mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-10 16:40:46 +02:00
* master: answer with the leader raft already knows Topo.Leader() backs off for up to 20 seconds waiting for an election. Callers that a health probe or a client is blocked on cannot afford that: /cluster/status, /cluster/healthz and /readyz all sit past the probe timeout of both the helm chart and the operator, so a master that is still joining looks dead rather than joining, and the kubelet restarts it. informNewLeader and SendHeartbeat hold the client on a master that cannot serve it, exactly when it should move on to find the one that can. Answer these from MaybeLeader instead, which reports what raft knows right now. MaybeLeader takes over the "am I the leader myself" fallback that Leader() used to apply on top of it, so one non-blocking call is still correct; Leader() keeps the backoff for callers that must wait. * master: let the leader admit a master that starts with no raft state Neither raft implementation lets a server outside the configuration campaign: goraft's promotable() requires a non-empty log, and hashicorp rejects vote requests from a candidate that is not in its configuration. A master that comes up with fresh state therefore cannot elect itself in — the leader has to pull it in. Nothing did. The peer list is static, rendered from the replica count, so scaling it up leaves the sitting leader running the old list with no idea the new masters exist. Under goraft they wait forever. Under hashicorp they are worse off: each bootstraps a cluster of its own from the new list, and two of them form a quorum next to the live leader, with their own TopologyId. That is the split brain SetTopologyId kills a master over. Admit the peer where it registers instead. Only the leader gets past the IsLeader check in KeepConnected, and a joining master's client lands there, so that is the moment it joins. The broadcast OnPeerUpdate rides on is not enough on its own: it only reaches masters already connected, which is why a leader that came up first missed both newcomers. RaftAddServer grew a goraft branch on the way, so cluster.raft.add stops silently doing nothing on the default raft, and RaftRemoveServer with it. Bootstrapping is now one call for both implementations, made only after the peers confirm nobody has a leader, and retried until this master is in rather than checked once and dropped. * master: do not evict a peer that is still in -peers The hashicorp leader drops a master from the raft configuration as soon as it stops answering pings. A master that is merely restarting answers nothing, so an ordinary bounce shrinks the quorum behind the operator's back — and then races its own return: the master comes back, registers, gets re-admitted, and the eviction lands after it. A randomized start/stop walk lands on it. Two of three masters running, the leader evicts the one that just went down, the restart re-adds it, the removal commits late and takes the leader's own leadership with it. What is left is a two-server configuration whose other half is down, and a running master that nobody will ask for a vote — no quorum, no way back until the third master returns. -peers is what declares membership. updatePeers already reconciles the configuration against it on every leadership change, and an operator who really means to drop a master can say so with cluster.raft.remove, so keep the eviction for masters that are no longer listed at all. * test: bounce masters at random and hold the election to it Twelve rounds of stopping or starting a random master, on both raft implementations, checking the two things an election must never get wrong: two masters claiming leadership at once, and a quorum that comes back without agreeing on one. The cluster's identity has to survive the whole walk, since a master that re-mints a TopologyId is the split brain SetTopologyId kills its peers over. The seed is random and logged, so a failure names the walk that reproduces it. Below a quorum the walk moves straight on. A master that has lost its quorum cannot commit anything, and goraft only checks whether it still has one on an election-timeout ticker, after its peers have been quiet for a full timeout — measured taking over 30 seconds to step down. That direction belongs to TestTwoMastersDownAndRestart, which was giving it ten seconds and would have started failing on a slower machine; it now waits on that behaviour explicitly rather than sleeping twice and hoping. WaitForTopologyId returns the id it waited for. Reading it separately raced the leader applying the raft entry that carries it, which shows up as an empty id right after an election rather than as a wrong one.
241 lines
8.1 KiB
Go
241 lines
8.1 KiB
Go
package weed_server
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net"
|
|
|
|
"github.com/hashicorp/raft"
|
|
goraft "github.com/seaweedfs/raft"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/peer"
|
|
"google.golang.org/grpc/status"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/cluster"
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
)
|
|
|
|
// checkGrpcAdminAuth authorizes the raft membership RPCs that mutate cluster
|
|
// quorum. It mirrors the volume server's gate: the caller's peer IP is matched
|
|
// against the master's -whiteList. With no whitelist configured IsWhiteListed
|
|
// allows everyone, so default and single-master deployments are unaffected;
|
|
// operators who set a whitelist get these RPCs locked down to it. The cluster's
|
|
// own dead-peer eviction no longer dials these RPCs (it uses the local raft
|
|
// handle), so the only remaining callers are operator tooling.
|
|
func (ms *MasterServer) checkGrpcAdminAuth(ctx context.Context) error {
|
|
if ms.guard == nil {
|
|
return nil
|
|
}
|
|
pr, ok := peer.FromContext(ctx)
|
|
if !ok {
|
|
glog.V(0).Infof("gRPC raft admin auth failed: no peer info")
|
|
return status.Error(codes.PermissionDenied, "no peer info")
|
|
}
|
|
addr := pr.Addr.String()
|
|
var host string
|
|
if tcpAddr, ok := pr.Addr.(*net.TCPAddr); ok {
|
|
host = tcpAddr.IP.String()
|
|
} else if h, _, splitErr := net.SplitHostPort(addr); splitErr == nil {
|
|
host = h
|
|
} else {
|
|
host = addr
|
|
}
|
|
if !ms.guard.IsWhiteListed(host) {
|
|
glog.V(0).Infof("gRPC raft admin auth failed: %s is not whitelisted (remote: %s)", host, addr)
|
|
return status.Errorf(codes.PermissionDenied, "not authorized: %s", host)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (ms *MasterServer) RaftListClusterServers(ctx context.Context, req *master_pb.RaftListClusterServersRequest) (*master_pb.RaftListClusterServersResponse, error) {
|
|
resp := &master_pb.RaftListClusterServersResponse{}
|
|
|
|
ms.Topo.RaftServerAccessLock.RLock()
|
|
if ms.Topo.HashicorpRaft == nil && ms.Topo.RaftServer == nil {
|
|
ms.Topo.RaftServerAccessLock.RUnlock()
|
|
return resp, nil
|
|
}
|
|
|
|
if ms.Topo.HashicorpRaft != nil {
|
|
servers := ms.Topo.HashicorpRaft.GetConfiguration().Configuration().Servers
|
|
_, leaderId := ms.Topo.HashicorpRaft.LeaderWithID()
|
|
ms.Topo.RaftServerAccessLock.RUnlock()
|
|
|
|
for _, server := range servers {
|
|
resp.ClusterServers = append(resp.ClusterServers, &master_pb.RaftListClusterServersResponse_ClusterServers{
|
|
Id: string(server.ID),
|
|
Address: string(server.Address),
|
|
Suffrage: server.Suffrage.String(),
|
|
IsLeader: server.ID == leaderId,
|
|
})
|
|
}
|
|
} else if ms.Topo.RaftServer != nil {
|
|
peers := ms.Topo.RaftServer.Peers()
|
|
leader := ms.Topo.RaftServer.Leader()
|
|
currentServerName := ms.Topo.RaftServer.Name()
|
|
ms.Topo.RaftServerAccessLock.RUnlock()
|
|
|
|
// Add the current server itself (Peers() only returns other peers)
|
|
resp.ClusterServers = append(resp.ClusterServers, &master_pb.RaftListClusterServersResponse_ClusterServers{
|
|
Id: currentServerName,
|
|
Address: ms.option.Master.ToGrpcAddress(),
|
|
Suffrage: "Voter",
|
|
IsLeader: currentServerName == leader,
|
|
})
|
|
|
|
// Add all other peers
|
|
for _, peer := range peers {
|
|
resp.ClusterServers = append(resp.ClusterServers, &master_pb.RaftListClusterServersResponse_ClusterServers{
|
|
Id: peer.Name,
|
|
Address: peer.ConnectionString,
|
|
Suffrage: "Voter",
|
|
IsLeader: peer.Name == leader,
|
|
})
|
|
}
|
|
}
|
|
return resp, nil
|
|
}
|
|
|
|
// raftAddServer admits a master into the quorum. A master that starts with no
|
|
// raft state cannot elect on its own, so the leader has to pull it in; this is
|
|
// the one place that knows how to do that for either raft implementation.
|
|
// goraft has no non-voting members, so an admitted peer always votes there.
|
|
func (ms *MasterServer) raftAddServer(id string, grpcAddress string, voter bool) error {
|
|
ms.Topo.RaftServerAccessLock.RLock()
|
|
defer ms.Topo.RaftServerAccessLock.RUnlock()
|
|
|
|
if ms.Topo.HashicorpRaft != nil {
|
|
if ms.Topo.HashicorpRaft.State() != raft.Leader {
|
|
return fmt.Errorf("raft add server %s failed: %s is no current leader", id, ms.Topo.HashicorpRaft.String())
|
|
}
|
|
var idxFuture raft.IndexFuture
|
|
if voter {
|
|
idxFuture = ms.Topo.HashicorpRaft.AddVoter(raft.ServerID(id), raft.ServerAddress(grpcAddress), 0, 0)
|
|
} else {
|
|
idxFuture = ms.Topo.HashicorpRaft.AddNonvoter(raft.ServerID(id), raft.ServerAddress(grpcAddress), 0, 0)
|
|
}
|
|
return idxFuture.Error()
|
|
}
|
|
|
|
if ms.Topo.RaftServer == nil {
|
|
return nil
|
|
}
|
|
if ms.Topo.RaftServer.State() != goraft.Leader {
|
|
return fmt.Errorf("raft add server %s failed: %s is no current leader", id, ms.Topo.RaftServer.Name())
|
|
}
|
|
_, err := ms.Topo.RaftServer.Do(&goraft.DefaultJoinCommand{
|
|
Name: id,
|
|
ConnectionString: grpcAddress,
|
|
})
|
|
return err
|
|
}
|
|
|
|
// raftRemoveServer drops a master from the quorum.
|
|
func (ms *MasterServer) raftRemoveServer(id string) error {
|
|
ms.Topo.RaftServerAccessLock.RLock()
|
|
defer ms.Topo.RaftServerAccessLock.RUnlock()
|
|
|
|
if ms.Topo.HashicorpRaft != nil {
|
|
if ms.Topo.HashicorpRaft.State() != raft.Leader {
|
|
return fmt.Errorf("raft remove server %s failed: %s is no current leader", id, ms.Topo.HashicorpRaft.String())
|
|
}
|
|
return ms.Topo.HashicorpRaft.RemoveServer(raft.ServerID(id), 0, 0).Error()
|
|
}
|
|
|
|
if ms.Topo.RaftServer == nil {
|
|
return nil
|
|
}
|
|
if ms.Topo.RaftServer.State() != goraft.Leader {
|
|
return fmt.Errorf("raft remove server %s failed: %s is no current leader", id, ms.Topo.RaftServer.Name())
|
|
}
|
|
_, err := ms.Topo.RaftServer.Do(&goraft.DefaultLeaveCommand{Name: id})
|
|
return err
|
|
}
|
|
|
|
func (ms *MasterServer) RaftAddServer(ctx context.Context, req *master_pb.RaftAddServerRequest) (*master_pb.RaftAddServerResponse, error) {
|
|
resp := &master_pb.RaftAddServerResponse{}
|
|
|
|
if err := ms.checkGrpcAdminAuth(ctx); err != nil {
|
|
return resp, err
|
|
}
|
|
|
|
if err := ms.raftAddServer(req.Id, req.Address, req.Voter); err != nil {
|
|
return nil, err
|
|
}
|
|
return resp, nil
|
|
}
|
|
|
|
func (ms *MasterServer) RaftRemoveServer(ctx context.Context, req *master_pb.RaftRemoveServerRequest) (*master_pb.RaftRemoveServerResponse, error) {
|
|
resp := &master_pb.RaftRemoveServerResponse{}
|
|
|
|
if err := ms.checkGrpcAdminAuth(ctx); err != nil {
|
|
return resp, err
|
|
}
|
|
|
|
if !req.Force {
|
|
ms.clientChansLock.RLock()
|
|
_, ok := ms.clientChans[fmt.Sprintf("%s@%s", cluster.MasterType, req.Id)]
|
|
ms.clientChansLock.RUnlock()
|
|
if ok {
|
|
return resp, fmt.Errorf("raft remove server %s failed: client connection to master exists", req.Id)
|
|
}
|
|
}
|
|
|
|
if err := ms.raftRemoveServer(req.Id); err != nil {
|
|
return nil, err
|
|
}
|
|
return resp, nil
|
|
}
|
|
|
|
func (ms *MasterServer) RaftLeadershipTransfer(ctx context.Context, req *master_pb.RaftLeadershipTransferRequest) (*master_pb.RaftLeadershipTransferResponse, error) {
|
|
resp := &master_pb.RaftLeadershipTransferResponse{}
|
|
|
|
if err := ms.checkGrpcAdminAuth(ctx); err != nil {
|
|
return resp, err
|
|
}
|
|
|
|
ms.Topo.RaftServerAccessLock.RLock()
|
|
defer ms.Topo.RaftServerAccessLock.RUnlock()
|
|
|
|
// Leadership transfer is only supported with hashicorp raft (-raftHashicorp=true)
|
|
// The default seaweedfs/raft (goraft) implementation does not support this feature
|
|
if ms.Topo.HashicorpRaft == nil {
|
|
if ms.Topo.RaftServer != nil {
|
|
return nil, fmt.Errorf("leadership transfer requires -raftHashicorp=true; the default raft implementation does not support this feature")
|
|
}
|
|
return nil, fmt.Errorf("raft not initialized (single master mode)")
|
|
}
|
|
|
|
if ms.Topo.HashicorpRaft.State() != raft.Leader {
|
|
leaderAddr, _ := ms.Topo.HashicorpRaft.LeaderWithID()
|
|
return nil, fmt.Errorf("this server is not the leader; current leader is %s", leaderAddr)
|
|
}
|
|
|
|
// Record previous leader
|
|
_, previousLeaderId := ms.Topo.HashicorpRaft.LeaderWithID()
|
|
resp.PreviousLeader = string(previousLeaderId)
|
|
|
|
var future raft.Future
|
|
if req.TargetId != "" && req.TargetAddress != "" {
|
|
// Transfer to specific server
|
|
future = ms.Topo.HashicorpRaft.LeadershipTransferToServer(
|
|
raft.ServerID(req.TargetId),
|
|
raft.ServerAddress(req.TargetAddress),
|
|
)
|
|
} else {
|
|
// Transfer to any eligible follower
|
|
future = ms.Topo.HashicorpRaft.LeadershipTransfer()
|
|
}
|
|
|
|
if err := future.Error(); err != nil {
|
|
return nil, fmt.Errorf("leadership transfer failed: %v", err)
|
|
}
|
|
|
|
// Get new leader info
|
|
_, newLeaderId := ms.Topo.HashicorpRaft.LeaderWithID()
|
|
resp.NewLeader = string(newLeaderId)
|
|
|
|
return resp, nil
|
|
}
|