mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-14 10:30:45 +02:00
Chris Lu
b63610cf8f
Volumes written by versions before 3.09 (commit 056c480eb) store the
needle checksum using the deprecated CRC.Value() transform. When the
read path moved into readNeedleTail, the fallback that accepts both
encodings was dropped, so .dat files copied from old installs now fail
verification with "invalid CRC ... data on disk corrupted" even though
the data is intact. Restore the dual check, matching the surviving
fallback in volume_read.go.
54 lines
1.6 KiB
Go
54 lines
1.6 KiB
Go
package needle
|
|
|
|
import (
|
|
"testing"
|
|
|
|
. "github.com/seaweedfs/seaweedfs/weed/storage/types"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
)
|
|
|
|
// .dat files written by volume server versions prior to 3.09 (before commit
|
|
// 056c480eb) store the needle checksum using the legacy CRC.Value() transform.
|
|
// Reads of such needles must still verify after an upgrade.
|
|
func TestReadNeedleTailLegacyChecksum(t *testing.T) {
|
|
data := []byte("hello seaweed")
|
|
rawChecksum := NewCRC(data)
|
|
legacyChecksum := rawChecksum.Value()
|
|
|
|
tail := make([]byte, NeedleChecksumSize+TimestampSize)
|
|
util.Uint32toBytes(tail[0:NeedleChecksumSize], legacyChecksum)
|
|
|
|
n := &Needle{Data: data}
|
|
if err := n.readNeedleTail(tail, Version3); err != nil {
|
|
t.Fatalf("legacy checksum should verify, got %v", err)
|
|
}
|
|
if n.Checksum != rawChecksum {
|
|
t.Fatalf("expected raw checksum stored, got %x want %x", uint32(n.Checksum), uint32(rawChecksum))
|
|
}
|
|
}
|
|
|
|
func TestReadNeedleTailRawChecksum(t *testing.T) {
|
|
data := []byte("hello seaweed")
|
|
rawChecksum := NewCRC(data)
|
|
|
|
tail := make([]byte, NeedleChecksumSize+TimestampSize)
|
|
util.Uint32toBytes(tail[0:NeedleChecksumSize], uint32(rawChecksum))
|
|
|
|
n := &Needle{Data: data}
|
|
if err := n.readNeedleTail(tail, Version3); err != nil {
|
|
t.Fatalf("raw checksum should verify, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestReadNeedleTailCorrupted(t *testing.T) {
|
|
data := []byte("hello seaweed")
|
|
|
|
tail := make([]byte, NeedleChecksumSize+TimestampSize)
|
|
util.Uint32toBytes(tail[0:NeedleChecksumSize], 0xdeadbeef)
|
|
|
|
n := &Needle{Data: data}
|
|
if err := n.readNeedleTail(tail, Version3); err == nil {
|
|
t.Fatal("expected CRC mismatch error, got nil")
|
|
}
|
|
}
|