mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-11 00:50:43 +02:00
Chris Lu
16ba8af0b7
util/http: lazily init the global HTTP client GetGlobalHttpClient returned a nil client until InitGlobalHttpClient ran, which only happens in weed.go's main. Anything that starts a command in-process bypasses that: the admin server's metrics goroutine seeds a dashboard sample on startup, reaching fetchPublicUrlMap -> GetGlobalHttpClient().Do, and nil-derefs the receiver in GetHttpScheme. Init the client on first Get via sync.Once so it is never nil regardless of the startup path. InitGlobalHttpClient keeps its eager-init role through the same Once.
38 lines
1.0 KiB
Go
38 lines
1.0 KiB
Go
package http
|
|
|
|
import (
|
|
"sync"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
util_http_client "github.com/seaweedfs/seaweedfs/weed/util/http/client"
|
|
)
|
|
|
|
var (
|
|
globalHttpClient *util_http_client.HTTPClient
|
|
globalHttpClientOnce sync.Once
|
|
)
|
|
|
|
func NewGlobalHttpClient(opt ...util_http_client.HttpClientOpt) (*util_http_client.HTTPClient, error) {
|
|
return util_http_client.NewHttpClient(util_http_client.Client, opt...)
|
|
}
|
|
|
|
// GetGlobalHttpClient returns the process-wide HTTP client, initializing it on
|
|
// first use. Lazy init keeps callers that bypass weed.go's main (in-process
|
|
// test harnesses, libraries) from dereferencing a nil client.
|
|
func GetGlobalHttpClient() *util_http_client.HTTPClient {
|
|
globalHttpClientOnce.Do(initGlobalHttpClient)
|
|
return globalHttpClient
|
|
}
|
|
|
|
func InitGlobalHttpClient() {
|
|
globalHttpClientOnce.Do(initGlobalHttpClient)
|
|
}
|
|
|
|
func initGlobalHttpClient() {
|
|
client, err := NewGlobalHttpClient()
|
|
if err != nil {
|
|
glog.Fatalf("error init global http client: %v", err)
|
|
}
|
|
globalHttpClient = client
|
|
}
|