mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-10 16:40:46 +02:00
* expose whether a volume replica is backed by remote storage
Volume locations returned by lookups do not indicate whether a replica
has been tiered to remote storage. Readers cannot distinguish a local
replica from a remote-backed one, so they may hit a remote-backed
replica first even when a local replica is available.
Add DataInRemote to the lookup location message, populate it from the
master's volume info, and carry it through the wdclient vid map so
clients can prefer local replicas when resolving chunk locations.
* wdclient: prefer local volume replicas over remote-tier replicas on lookup
LookupFileIdWithFallback (and the publicUrl variant in FilerClient)
didn't honor the DataInRemote flag when shuffling URLs, so the
DataInRemote patch only took effect in LookupVolumeServerUrl. Apply
the same ReorderToFront(localUrls) to sameDcUrls/otherDcUrls so
non-remote replicas stay at the front, matching the existing vidMap
convention.
* wdclient: propagate DataInRemote across tier transitions on existing replicas
When a volume is tiered to remote storage or a remote-backed replica is
restored locally, the cached DataInRemote on the same volume-server URL
stayed at its old value because two pieces of state never updated:
* master_grpc_server.go only split newVolumes and (already-tracked) volumes
into NewVids vs RemoteVids. ChangedVolumes went straight to NewVids, so
the broadcast announced the re-classified volume as a fresh arrival and
the client had no way to tell whether its existing cache was stale.
* vid_map.addLocationToMap early-returned when an entry already had the
same URL. A tier transition reports the same URL with DataInRemote
flipped, so the cached entry stayed at the old classification.
Wire both sides together: ChangedVolumes now go through the same IsRemote
split as newVolumes, and addLocationToMap replaces the existing entry in
place when the URL matches but DataInRemote has changed. The server
reference key only depends on URL/grpc port, so the refcount does not
move across the flip.
Adds vid_map_remote_transition_test.go covering the local->remote and
remote->local paths so the in-place update and the cache-key stability
are pinned by tests.
* wdclient: prefer local replicas across data-center boundaries
The previous local-first ordering hoisted local URLs to the front of each
data-center bucket separately, then concatenated same-DC before other-DC.
That meant a same-DC remote replica could still be tried before an
other-DC local replica even though the local one would answer cheaply.
Reorder once across the full candidate list: concatenate same-DC and
other-DC first, then ReorderToFront pulls every local replica to the very
front while preserving the DC preference inside each tier. Apply the same
ordering in all four lookup paths so the cached vidMap, the
LookupFileIdWithFallback provider path, FilerClient.GetLookupFileIdFunction
(PublicUrl-preferred variant), and the deprecated filer.LookupFn all agree:
- weed/wdclient/vid_map.go (LookupVolumeServerUrl)
- weed/wdclient/vidmap_client.go (LookupFileIdWithFallback)
- weed/wdclient/filer_client.go (LookupFileId)
- weed/filer/reader_at.go (LookupFn)
Strengthen the existing local-first tests: vidmap_client_localfirst_test
now asserts both endpoints are present (not just the local one is first),
and slice_test asserts an exact match instead of accepting two orderings.
Add TestLookupFileIdWithFallbackGlobalLocalFirst to pin the cross-DC
ordering invariant: any local replica (same or other DC) precedes every
remote-tier replica; within each tier DC1 precedes DC2.
Add docstrings to ToVolumeLocations, ReorderToFront, LookupVolumeServerUrl,
LookupFileId, GetVidLocations, GetLocations, LookupFileIdWithFallback, and
updateVidMap so the touched lookup paths are described in one place.
* topology: broadcast tier transitions on existing replicas
When a volume replica is tiered to remote storage or restored locally, the
wdclient's cached DataInRemote went stale: every connected client kept
preferring a remote-backed replica over a freshly restored local one, or
demoted a freshly tiered remote replica. The fix in commit 116982595 routed
ChangedVolumes to NewVids/RemoteVids on the master, but ApplyVolumeChanges
returned only fresh arrivals and previously servable replicas. An existing
replica whose IsRemote() classification flipped was neither, so it never
reached the broadcast loop and the wdclient never learned.
Make Disk.doAddOrUpdateVolume return a third signal -- tierTransition --
true exactly when an existing replica's IsRemote() flips. ApplyVolumeChanges
treats that as an arrival so the existing SendHeartbeat routing loop now
sees it. Add a master-side end-to-end test covering local->remote,
remote->local, no-op re-reports, and a mixed heartbeat that only announces
the tier transition.
Also add docstrings to LookupFileId, wdclientLocationsToPb, and
LookupVolume where the prior change touched their bodies.
* topology: broadcast tier transitions received through full reconciliation
The previous commit added tier-transition routing on the ChangedVolumes
delta path, but that is not the only way a re-tiered replica reaches the
master. After a digest mismatch the volume server resends a full Volumes
list, and SyncDataNodeRegistration applies the new IsRemote() classification
silently -- the changedVolumes return value was being thrown away. The
master therefore never broadcast NewVids/RemoteVids, and a wdclient connected
during the recovery kept the stale DataInRemote until it lost contact with
the master.
Surface the changed set through UpdateVolumes.changedVolumes (now covering
both ReadOnly flips and tier flips) and SyncDataNodeRegistration, then route
it through NewVids/RemoteVids in SendHeartbeat the same way the delta path
already does. Add an end-to-end test for the full reconciliation path.
* master: keep an EC volume's locations in the volume lookup
The nodes that answer for an EC volume hold shards, not a volume record,
so asking them for one fails. Dropping the location on that failure
emptied the result and turned every EC read through the master's HTTP
lookup and fid redirect into a 404.
Treat an absent volume record as a local read and keep the node in the
answer. The per-node conversion moves into topologyLocation so the EC
case is covered by a test.
Claude-Session: https://claude.ai/code/session_01FcSp6quCaxQ1cb3Vx7o9fW
* wdclient: replace a tier-flipped location without writing under a reader
GetLocations hands back the entry's own slice and the caller walks it
after the read lock is dropped, which is why every other mutation here
builds a new slice. Writing the flipped replica into the array in place
raced LookupVolumeServerUrl, reported by -race.
Copy the slice, swap the one element, and publish it.
Claude-Session: https://claude.ai/code/session_01FcSp6quCaxQ1cb3Vx7o9fW
* master: keep a remote volume on NewVids for older clients
Moving remote-tier volumes out of NewVids and into RemoteVids alone is a
wire break in the wrong direction. A master upgraded ahead of its filers
and mounts -- the usual order -- announces a tiered volume only on a
field the older client ignores, so the volume drops out of that client's
vid map entirely and reads for it fail.
Announce every volume on NewVids and repeat the remote-tier subset on
RemoteVids, so a new client still learns the tier and an old one keeps
the location. The routing moves into announceVolume, which the heartbeat
paths and their tests now share instead of each restating it.
On the client, RemoteVids no longer needs a second write per volume: the
tier is settled before anything is added.
Claude-Session: https://claude.ai/code/session_01FcSp6quCaxQ1cb3Vx7o9fW
* topology: split the volume snapshot by tier without copying the records
ToVolumeLocations runs on every KeepConnected, so a filer or mount
connecting made the master allocate a full VolumeInfo per volume per node
just to read four bytes of id off each one. AppendVolumeIds exists to
avoid exactly that.
Extend it to fill the remote-tier list alongside the full one, and use it
again in the snapshot.
Claude-Session: https://claude.ai/code/session_01FcSp6quCaxQ1cb3Vx7o9fW
* wdclient: keep the data-center preference ahead of the local-first ordering
Hoisting every local replica to the very front puts an other-DC local
read ahead of a same-DC remote one. When the remote tier sits in the same
region as the replicas -- the common arrangement -- that trades an
in-region GET for a WAN round trip and costs more than the remote read it
avoids.
Reorder inside each data-center bucket instead, so local still wins among
equals and the data-center preference still wins overall.
Claude-Session: https://claude.ai/code/session_01FcSp6quCaxQ1cb3Vx7o9fW
* operation: pick the read replica from one list
The local-preferring lookup built a list of local URLs and then branched
on whether it was empty, duplicating the random pick. Fall back by
filling the same list with every replica instead.
Claude-Session: https://claude.ai/code/session_01FcSp6quCaxQ1cb3Vx7o9fW
---------
Co-authored-by: Bruce Zou <gift_secondst@msn.com>
Co-authored-by: bruce-zzz <bruce.zou@hhy-data.com>
430 lines
14 KiB
Go
430 lines
14 KiB
Go
package wdclient
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"math/rand"
|
|
"strconv"
|
|
"strings"
|
|
"sync"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
)
|
|
|
|
type HasLookupFileIdFunction interface {
|
|
GetLookupFileIdFunction() LookupFileIdFunctionType
|
|
}
|
|
|
|
type LookupFileIdFunctionType func(ctx context.Context, fileId string) (targetUrls []string, err error)
|
|
|
|
type Location struct {
|
|
Url string `json:"url,omitempty"`
|
|
PublicUrl string `json:"publicUrl,omitempty"`
|
|
DataCenter string `json:"dataCenter,omitempty"`
|
|
GrpcPort int `json:"grpcPort,omitempty"`
|
|
DataInRemote bool `json:"dataInRemote,omitempty"`
|
|
}
|
|
|
|
func (l Location) ServerAddress() pb.ServerAddress {
|
|
return pb.NewServerAddressWithGrpcPort(l.Url, l.GrpcPort)
|
|
}
|
|
|
|
// locationsEntry is what a volume id maps to: the locations themselves plus the
|
|
// generation they were learned in. An entry is immutable once stored; every
|
|
// update installs a new one, so locations handed to a reader are never
|
|
// rewritten underneath it.
|
|
type locationsEntry struct {
|
|
locations []Location
|
|
generation uint64
|
|
}
|
|
|
|
type vidMap struct {
|
|
sync.RWMutex
|
|
vid2Locations map[uint32]*locationsEntry
|
|
ecVid2Locations map[uint32]*locationsEntry
|
|
// serverRefCount tracks how many vid locations (regular + EC) currently
|
|
// reference each volume server address. Maintaining it incrementally lets
|
|
// hasVolumeServer answer in O(1) instead of walking every volume entry.
|
|
// Keys are the canonical http form of pb.ServerAddress, so callers that
|
|
// pass either "host:port" or "host:port.grpc" find the same entry.
|
|
serverRefCount map[string]int
|
|
DataCenter string
|
|
// generation counts resets. Each entry remembers the generation it was
|
|
// learned in, so history expires per volume rather than by keeping
|
|
// snapshot copies of the whole map.
|
|
generation uint64
|
|
// retainGenerations is how many resets an entry survives without being
|
|
// refreshed before reset drops it.
|
|
retainGenerations uint64
|
|
}
|
|
|
|
func newVidMap(dataCenter string, retainGenerations int) *vidMap {
|
|
if retainGenerations <= 0 {
|
|
retainGenerations = DefaultVidMapCacheSize
|
|
}
|
|
return &vidMap{
|
|
vid2Locations: make(map[uint32]*locationsEntry),
|
|
ecVid2Locations: make(map[uint32]*locationsEntry),
|
|
serverRefCount: make(map[string]int),
|
|
DataCenter: dataCenter,
|
|
retainGenerations: uint64(retainGenerations),
|
|
}
|
|
}
|
|
|
|
// locationServerKey returns the index key used by serverRefCount for a
|
|
// Location. The key normalises away the optional grpc-port suffix so the
|
|
// counter stays consistent with hasVolumeServer's lookup.
|
|
func locationServerKey(loc Location) string {
|
|
return loc.ServerAddress().ToHttpAddress()
|
|
}
|
|
|
|
func (vc *vidMap) isSameDataCenter(loc *Location) bool {
|
|
if vc.DataCenter == "" || loc.DataCenter == "" || vc.DataCenter != loc.DataCenter {
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
// LookupVolumeServerUrl returns the cached volume-server URLs for vid in
|
|
// preference order: same-DC local, same-DC remote-tier, then the other data
|
|
// centers on the same footing. Within each group the order is randomized so
|
|
// load spreads across equivalent servers.
|
|
func (vc *vidMap) LookupVolumeServerUrl(vid string) (serverUrls []string, err error) {
|
|
id, err := strconv.Atoi(vid)
|
|
if err != nil {
|
|
glog.V(1).Infof("Unknown volume id %s", vid)
|
|
return nil, err
|
|
}
|
|
|
|
locations, found := vc.GetLocations(uint32(id))
|
|
if !found {
|
|
return nil, fmt.Errorf("volume %d not found", id)
|
|
}
|
|
var sameDcServers, otherDcServers []string
|
|
localUrls := make(map[string]bool)
|
|
|
|
for _, loc := range locations {
|
|
glog.V(4).Infof("lookup %s => %s, data in remote storage tier: %v", vid, loc.Url, loc.DataInRemote)
|
|
|
|
if !loc.DataInRemote {
|
|
localUrls[loc.Url] = true
|
|
}
|
|
|
|
if vc.isSameDataCenter(&loc) {
|
|
sameDcServers = append(sameDcServers, loc.Url)
|
|
} else {
|
|
otherDcServers = append(otherDcServers, loc.Url)
|
|
}
|
|
}
|
|
rand.Shuffle(len(sameDcServers), func(i, j int) {
|
|
sameDcServers[i], sameDcServers[j] = sameDcServers[j], sameDcServers[i]
|
|
})
|
|
rand.Shuffle(len(otherDcServers), func(i, j int) {
|
|
otherDcServers[i], otherDcServers[j] = otherDcServers[j], otherDcServers[i]
|
|
})
|
|
// Local replicas go first inside each data center, but never ahead of the
|
|
// data-center preference itself: a remote tier is often in the same region
|
|
// as the local replicas, so crossing a DC boundary to avoid it can cost
|
|
// more than the remote read it saves.
|
|
if len(localUrls) > 0 {
|
|
sameDcServers = util.ReorderToFront(localUrls, sameDcServers)
|
|
otherDcServers = util.ReorderToFront(localUrls, otherDcServers)
|
|
}
|
|
serverUrls = append(sameDcServers, otherDcServers...)
|
|
return
|
|
}
|
|
|
|
// LookupFileId resolves a "<vid>,<cookie>" file id to a list of HTTP read
|
|
// URLs using the same DC-then-local ordering as LookupVolumeServerUrl.
|
|
func (vc *vidMap) LookupFileId(ctx context.Context, fileId string) (fullUrls []string, err error) {
|
|
parts := strings.Split(fileId, ",")
|
|
if len(parts) != 2 {
|
|
return nil, errors.New("Invalid fileId " + fileId)
|
|
}
|
|
serverUrls, lookupError := vc.LookupVolumeServerUrl(parts[0])
|
|
if lookupError != nil {
|
|
return nil, lookupError
|
|
}
|
|
for _, serverUrl := range serverUrls {
|
|
fullUrls = append(fullUrls, "http://"+serverUrl+"/"+fileId)
|
|
}
|
|
return
|
|
}
|
|
|
|
// GetVidLocations returns the cached Location entries for vid as a string,
|
|
// for callers that need richer per-server fields than raw URLs (e.g.
|
|
// DataInRemote, PublicUrl).
|
|
func (vc *vidMap) GetVidLocations(vid string) (locations []Location, err error) {
|
|
id, err := strconv.Atoi(vid)
|
|
if err != nil {
|
|
glog.V(1).Infof("Unknown volume id %s", vid)
|
|
return nil, fmt.Errorf("Unknown volume id %s", vid)
|
|
}
|
|
foundLocations, found := vc.GetLocations(uint32(id))
|
|
if found {
|
|
return foundLocations, nil
|
|
}
|
|
return nil, fmt.Errorf("volume id %s not found", vid)
|
|
}
|
|
|
|
// GetLocations returns the cached Location entries for vid as a uint32.
|
|
// When both regular and EC entries are present, whichever was learned last
|
|
// wins so a volume that switched between regular and EC encoding stops
|
|
// answering from the stale copy. Returns found=false when nothing remains,
|
|
// including when only an older-generation entry would otherwise apply.
|
|
func (vc *vidMap) GetLocations(vid uint32) (locations []Location, found bool) {
|
|
vc.RLock()
|
|
defer vc.RUnlock()
|
|
|
|
regular, hasRegular := lookupEntry(vc.vid2Locations, vid)
|
|
ec, hasEc := lookupEntry(vc.ecVid2Locations, vid)
|
|
|
|
switch {
|
|
case hasRegular && hasEc:
|
|
// Whichever was learned last wins: once a volume is EC encoded, the
|
|
// regular copies a previous generation knew must stop answering for
|
|
// it, and a decoded volume must stop answering with its shards. A tie
|
|
// means one generation reported both, where the regular copies serve.
|
|
if ec.generation > regular.generation {
|
|
return ec.locations, true
|
|
}
|
|
return regular.locations, true
|
|
case hasRegular:
|
|
return regular.locations, true
|
|
case hasEc:
|
|
return ec.locations, true
|
|
}
|
|
|
|
// Nothing older to fall back to: a volume's history lives in its own entry,
|
|
// so a volume whose locations are all gone (a pod restarting, say) is a
|
|
// miss rather than a reason to serve what it used to have.
|
|
return nil, false
|
|
}
|
|
|
|
// lookupEntry returns vid's entry when it still holds locations. Callers must
|
|
// hold the lock.
|
|
func lookupEntry(vid2Locations map[uint32]*locationsEntry, vid uint32) (*locationsEntry, bool) {
|
|
entry, found := vid2Locations[vid]
|
|
if !found || len(entry.locations) == 0 {
|
|
return nil, false
|
|
}
|
|
return entry, true
|
|
}
|
|
|
|
func (vc *vidMap) GetLocationsClone(vid uint32) (locations []Location, found bool) {
|
|
locations, found = vc.GetLocations(vid)
|
|
|
|
if found {
|
|
// clone the locations in case the volume locations are changed below
|
|
existingLocations := make([]Location, len(locations))
|
|
copy(existingLocations, locations)
|
|
return existingLocations, found
|
|
}
|
|
|
|
return nil, false
|
|
}
|
|
|
|
// hasVolumeServer reports whether any tracked volume (regular or EC) is hosted
|
|
// on addr, including volumes still held from earlier generations. Used to gate
|
|
// admission of operations targeting a volume server.
|
|
func (vc *vidMap) hasVolumeServer(addr pb.ServerAddress) bool {
|
|
key := addr.ToHttpAddress()
|
|
if key == "" {
|
|
return false
|
|
}
|
|
vc.RLock()
|
|
defer vc.RUnlock()
|
|
return vc.serverRefCount[key] > 0
|
|
}
|
|
|
|
func (vc *vidMap) addLocation(vid uint32, location Location) {
|
|
vc.Lock()
|
|
defer vc.Unlock()
|
|
|
|
glog.V(4).Infof("+ volume id %d: %+v", vid, location)
|
|
|
|
vc.addLocationToMap(vc.vid2Locations, vid, location)
|
|
}
|
|
|
|
func (vc *vidMap) addEcLocation(vid uint32, location Location) {
|
|
vc.Lock()
|
|
defer vc.Unlock()
|
|
|
|
glog.V(4).Infof("+ ec volume id %d: %+v", vid, location)
|
|
|
|
vc.addLocationToMap(vc.ecVid2Locations, vid, location)
|
|
}
|
|
|
|
// addLocationToMap records location for vid. The first write of a generation
|
|
// replaces what an earlier one held instead of merging with it: after a reset
|
|
// the new master is the authority, so a volume that moved must not keep
|
|
// answering with the server it moved off. Callers must hold the write lock.
|
|
//
|
|
// If the URL is already present and the remote/local classification matches,
|
|
// the entry is left untouched (same replica, same view). When the
|
|
// classification flips -- e.g. a volume tiered to remote storage, or a
|
|
// remote-backed replica restored locally -- the entry is rebuilt so
|
|
// subsequent lookups pick up the new DataInRemote. The server reference key
|
|
// only depends on the URL/grpc port, so it stays stable across the flip and
|
|
// the refcount does not need to move.
|
|
func (vc *vidMap) addLocationToMap(vid2Locations map[uint32]*locationsEntry, vid uint32, location Location) {
|
|
entry, found := vid2Locations[vid]
|
|
if !found || entry.generation != vc.generation {
|
|
if found {
|
|
vc.releaseEntry(entry)
|
|
}
|
|
vid2Locations[vid] = &locationsEntry{
|
|
locations: []Location{location},
|
|
generation: vc.generation,
|
|
}
|
|
vc.incrementServerRef(locationServerKey(location))
|
|
return
|
|
}
|
|
|
|
for i, loc := range entry.locations {
|
|
if loc.Url == location.Url {
|
|
if loc.DataInRemote == location.DataInRemote {
|
|
return
|
|
}
|
|
// A reader holds the slice GetLocations handed it after the lock
|
|
// was dropped, so the replacement is copied rather than written
|
|
// into the array underneath it.
|
|
updated := make([]Location, len(entry.locations))
|
|
copy(updated, entry.locations)
|
|
updated[i] = location
|
|
entry.locations = updated
|
|
return
|
|
}
|
|
}
|
|
|
|
locations := make([]Location, 0, len(entry.locations)+1)
|
|
locations = append(locations, entry.locations...)
|
|
locations = append(locations, location)
|
|
vid2Locations[vid] = &locationsEntry{locations: locations, generation: entry.generation}
|
|
vc.incrementServerRef(locationServerKey(location))
|
|
}
|
|
|
|
func (vc *vidMap) deleteLocation(vid uint32, location Location) {
|
|
vc.Lock()
|
|
defer vc.Unlock()
|
|
|
|
glog.V(4).Infof("- volume id %d: %+v", vid, location)
|
|
|
|
vc.deleteLocationFromMap(vc.vid2Locations, vid, location)
|
|
}
|
|
|
|
func (vc *vidMap) deleteEcLocation(vid uint32, location Location) {
|
|
vc.Lock()
|
|
defer vc.Unlock()
|
|
|
|
glog.V(4).Infof("- ec volume id %d: %+v", vid, location)
|
|
|
|
vc.deleteLocationFromMap(vc.ecVid2Locations, vid, location)
|
|
}
|
|
|
|
// deleteLocationFromMap drops one location from vid's entry, and the entry
|
|
// itself once its last location is gone. The generation is untouched: a delete
|
|
// only speaks about the location it names, it does not make the rest of the
|
|
// entry any fresher. Callers must hold the write lock.
|
|
func (vc *vidMap) deleteLocationFromMap(vid2Locations map[uint32]*locationsEntry, vid uint32, location Location) {
|
|
entry, found := vid2Locations[vid]
|
|
if !found {
|
|
return
|
|
}
|
|
|
|
for i, loc := range entry.locations {
|
|
if loc.Url != location.Url {
|
|
continue
|
|
}
|
|
vc.decrementServerRef(locationServerKey(loc))
|
|
if len(entry.locations) == 1 {
|
|
delete(vid2Locations, vid)
|
|
return
|
|
}
|
|
remaining := make([]Location, 0, len(entry.locations)-1)
|
|
remaining = append(remaining, entry.locations[:i]...)
|
|
remaining = append(remaining, entry.locations[i+1:]...)
|
|
vid2Locations[vid] = &locationsEntry{locations: remaining, generation: entry.generation}
|
|
return
|
|
}
|
|
}
|
|
|
|
func (vc *vidMap) deleteVid(vid uint32) {
|
|
vc.Lock()
|
|
defer vc.Unlock()
|
|
|
|
if entry, found := vc.vid2Locations[vid]; found {
|
|
vc.releaseEntry(entry)
|
|
delete(vc.vid2Locations, vid)
|
|
}
|
|
if entry, found := vc.ecVid2Locations[vid]; found {
|
|
vc.releaseEntry(entry)
|
|
delete(vc.ecVid2Locations, vid)
|
|
}
|
|
}
|
|
|
|
// reset starts a new generation, as when the master changes and everything it
|
|
// told us has to be relearned. Entries stay readable while they are relearned
|
|
// and are dropped once they fall out of the retained window.
|
|
func (vc *vidMap) reset() {
|
|
vc.Lock()
|
|
defer vc.Unlock()
|
|
|
|
vc.generation++
|
|
if vc.generation <= vc.retainGenerations {
|
|
return
|
|
}
|
|
oldest := vc.generation - vc.retainGenerations
|
|
vc.expire(vc.vid2Locations, oldest)
|
|
vc.expire(vc.ecVid2Locations, oldest)
|
|
}
|
|
|
|
// expire drops entries last refreshed before oldest. Callers must hold the
|
|
// write lock.
|
|
func (vc *vidMap) expire(vid2Locations map[uint32]*locationsEntry, oldest uint64) {
|
|
for vid, entry := range vid2Locations {
|
|
if entry.generation >= oldest {
|
|
continue
|
|
}
|
|
vc.releaseEntry(entry)
|
|
delete(vid2Locations, vid)
|
|
}
|
|
}
|
|
|
|
// releaseEntry drops the server references an entry holds. Callers must hold
|
|
// the write lock.
|
|
func (vc *vidMap) releaseEntry(entry *locationsEntry) {
|
|
for _, loc := range entry.locations {
|
|
vc.decrementServerRef(locationServerKey(loc))
|
|
}
|
|
}
|
|
|
|
// incrementServerRef increases the refcount for key. Empty keys are skipped
|
|
// so a zero-value Location (which serialises to "") does not leak a permanent
|
|
// bucket that hasVolumeServer and decrementServerRef both ignore. Callers
|
|
// must hold vc's write lock.
|
|
func (vc *vidMap) incrementServerRef(key string) {
|
|
if key == "" {
|
|
return
|
|
}
|
|
vc.serverRefCount[key]++
|
|
}
|
|
|
|
// decrementServerRef decreases the refcount for key and removes the entry
|
|
// once it falls to zero. Callers must hold vc's write lock.
|
|
func (vc *vidMap) decrementServerRef(key string) {
|
|
if key == "" {
|
|
return
|
|
}
|
|
if n, ok := vc.serverRefCount[key]; ok {
|
|
if n <= 1 {
|
|
delete(vc.serverRefCount, key)
|
|
} else {
|
|
vc.serverRefCount[key] = n - 1
|
|
}
|
|
}
|
|
}
|