mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-20 05:20:49 +02:00
Chris Lu
d02ee6d5df
The replica-placement rule (data-center/rack/same-node limits plus host anti-affinity) existed three times: the shell's satisfyReplicaPlacement/isGoodMove used by volume.balance, fix.replication, and tier.move, and a line-for-line port in the maintenance balance worker. Move the canonical logic into weed/topology/balancer on a shared Location type; the shell and worker keep thin adapters that convert their own location representation and call it. Behavior is unchanged (the shared IsGoodMove keeps the shell's reject-move-to-self guard, and all four replica test suites pass).
38 lines
1.4 KiB
Go
38 lines
1.4 KiB
Go
package balance
|
|
|
|
import (
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
|
|
"github.com/seaweedfs/seaweedfs/weed/topology/balancer"
|
|
"github.com/seaweedfs/seaweedfs/weed/worker/types"
|
|
)
|
|
|
|
// hostFromAddress returns the physical machine (host/IP) of a server address,
|
|
// falling back to the node id when no address is known.
|
|
func hostFromAddress(address, nodeID string) string {
|
|
return balancer.HostFromAddress(address, nodeID)
|
|
}
|
|
|
|
// IsGoodMove checks whether moving a volume from sourceNodeID to target would
|
|
// satisfy the volume's replica placement policy. It is a thin adapter over the
|
|
// shared placement logic in weed/topology/balancer so the shell command and this
|
|
// worker cannot drift.
|
|
func IsGoodMove(rp *super_block.ReplicaPlacement, existingReplicas []types.ReplicaLocation, sourceNodeID string, target types.ReplicaLocation) bool {
|
|
locs := make([]balancer.Location, len(existingReplicas))
|
|
for i, r := range existingReplicas {
|
|
locs[i] = toBalancerLocation(r)
|
|
}
|
|
return balancer.IsGoodMove(rp, locs, sourceNodeID, toBalancerLocation(target))
|
|
}
|
|
|
|
// toBalancerLocation copies a worker replica location to the shared placement
|
|
// type field-by-field, so a future change to either struct is a compile error
|
|
// here rather than a silent mismatch.
|
|
func toBalancerLocation(r types.ReplicaLocation) balancer.Location {
|
|
return balancer.Location{
|
|
DataCenter: r.DataCenter,
|
|
Rack: r.Rack,
|
|
NodeID: r.NodeID,
|
|
Host: r.Host,
|
|
}
|
|
}
|