mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-05 19:47:47 +01:00
* fix(s3): accept fresh admin tokens when context carries stale authorization (#12390) Signed-off-by: Mohd Quamar Tyagi <104281681+Tyagiquamar@users.noreply.github.com> * security: share the admin Bearer check between S3 and admin-plane peers Move the authorization scan into security.CheckGrpcAdminToken, built on IsFilerAdminToken, and call it from CheckGrpcAdminPeer and the S3 IAM cache check. Both now accept a valid admin token in any authorization value instead of S3 re-implementing the decode and claim checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * filer: accept a fresh admin token after a stale one on IAM gRPC The S3 IAM cache check is meant to mirror the filer's, so route the filer's checkAdminAuth through security.CheckGrpcAdminToken too. IamGrpcStore appends its token to the caller's context, so a forwarded older token would otherwise still shadow it here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * security: parse at most four authorization values per admin call Scanning every value let one request repeat a junk Bearer token (cheap over HPACK) tens of thousands of times and burn about half a second of JWT parsing on an unauthenticated port. Real callers send their own token plus at most one forwarded from their context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * credential: match the other WithS3InternalAdminAuth replace fix The plugin worker fix makes the same set-instead-of-append change to WithS3InternalAdminAuth with different code and a different test at the same spot, so whichever lands second would conflict. Use the identical code and test so the two merge cleanly in either order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * security: test an expired admin token ahead of a fresh one Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * security: test that a same-key session token is not an admin token Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * filer: test IAM gRPC with only invalid authorization values Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Signed-off-by: Mohd Quamar Tyagi <104281681+Tyagiquamar@users.noreply.github.com> Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
119 lines
4.6 KiB
Go
119 lines
4.6 KiB
Go
package security
|
|
|
|
import (
|
|
"context"
|
|
"crypto/tls"
|
|
"crypto/x509"
|
|
"net"
|
|
"slices"
|
|
"testing"
|
|
"time"
|
|
|
|
jwt "github.com/golang-jwt/jwt/v5"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/credentials"
|
|
"google.golang.org/grpc/metadata"
|
|
"google.golang.org/grpc/peer"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
func peerCtx(addr net.Addr) context.Context {
|
|
return peer.NewContext(context.Background(), &peer.Peer{Addr: addr})
|
|
}
|
|
|
|
func bearerCtx(addr net.Addr, signingKey SigningKey) context.Context {
|
|
ctx := peerCtx(addr)
|
|
token := GenJwtForFilerAdmin(signingKey, 0)
|
|
return metadata.NewIncomingContext(ctx, metadata.Pairs("authorization", "Bearer "+string(token)))
|
|
}
|
|
|
|
func TestCheckGrpcAdminPeer(t *testing.T) {
|
|
key := SigningKey("test-signing-key-0123456789abcdef")
|
|
loopback := &net.TCPAddr{IP: net.ParseIP("127.0.0.1"), Port: 5000}
|
|
remote := &net.TCPAddr{IP: net.ParseIP("203.0.113.9"), Port: 5000}
|
|
|
|
for name, tc := range map[string]struct {
|
|
ctx context.Context
|
|
signingKey SigningKey
|
|
wantCode codes.Code
|
|
}{
|
|
"no peer info, no key": {context.Background(), nil, codes.Unauthenticated},
|
|
"loopback, no key": {peerCtx(loopback), nil, codes.OK},
|
|
"remote, no key": {peerCtx(remote), nil, codes.Unauthenticated},
|
|
"remote + valid token": {bearerCtx(remote, key), key, codes.OK},
|
|
"remote + no metadata, key set": {peerCtx(remote), key, codes.Unauthenticated},
|
|
"remote + bad token": {metadata.NewIncomingContext(peerCtx(remote), metadata.Pairs("authorization", "Bearer wrong")), key, codes.Unauthenticated},
|
|
"unix socket, no key": {peerCtx(&net.UnixAddr{Name: "/tmp/s.sock"}), nil, codes.OK},
|
|
"mtls verified peer": {peer.NewContext(context.Background(), &peer.Peer{
|
|
Addr: remote,
|
|
AuthInfo: credentials.TLSInfo{State: tls.ConnectionState{VerifiedChains: [][]*x509.Certificate{{}}}},
|
|
}), nil, codes.OK},
|
|
} {
|
|
err := CheckGrpcAdminPeer(tc.ctx, tc.signingKey)
|
|
got := codes.OK
|
|
if err != nil {
|
|
got = status.Code(err)
|
|
}
|
|
if got != tc.wantCode {
|
|
t.Errorf("%s: got %v want %v (err=%v)", name, got, tc.wantCode, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGrpcAdminPeerCredentials(t *testing.T) {
|
|
if md := GrpcAdminPeerCredentials(nil, 0); len(md) != 0 {
|
|
t.Errorf("expected nil metadata without signing key, got %v", md)
|
|
}
|
|
md := GrpcAdminPeerCredentials(SigningKey("key"), 60)
|
|
if len(md.Get("authorization")) != 1 {
|
|
t.Fatalf("expected one authorization entry, got %v", md)
|
|
}
|
|
}
|
|
|
|
func TestCheckGrpcAdminToken(t *testing.T) {
|
|
key := SigningKey("test-signing-key-0123456789abcdef")
|
|
fresh := "Bearer " + string(GenJwtForFilerAdmin(key, 60))
|
|
stale := "Bearer " + string(GenJwtForFilerAdmin(SigningKey("another-key"), 60))
|
|
expired, signErr := jwt.NewWithClaims(jwt.SigningMethodHS256, SeaweedFilerAdminClaims{
|
|
RegisteredClaims: jwt.RegisteredClaims{ExpiresAt: jwt.NewNumericDate(time.Now().Add(-time.Hour))},
|
|
}).SignedString([]byte(key))
|
|
if signErr != nil {
|
|
t.Fatalf("sign expired token: %v", signErr)
|
|
}
|
|
session, signErr := jwt.NewWithClaims(jwt.SigningMethodHS256, SeaweedFilerAdminClaims{
|
|
SessionId: "session",
|
|
RegisteredClaims: jwt.RegisteredClaims{ExpiresAt: jwt.NewNumericDate(time.Now().Add(time.Hour))},
|
|
}).SignedString([]byte(key))
|
|
if signErr != nil {
|
|
t.Fatalf("sign session token: %v", signErr)
|
|
}
|
|
|
|
for name, tc := range map[string]struct {
|
|
values []string
|
|
wantErr string
|
|
}{
|
|
"stale then fresh": {[]string{stale, fresh}, ""},
|
|
"fresh then garbage": {[]string{fresh, "garbage"}, ""},
|
|
"expired then fresh": {[]string{"Bearer " + expired, fresh}, ""},
|
|
"only expired": {[]string{"Bearer " + expired}, "invalid admin token"},
|
|
"only stale": {[]string{stale}, "invalid admin token"},
|
|
"same-key session": {[]string{"Bearer " + session}, "invalid admin token"},
|
|
"basic then stale": {[]string{"Basic dXNlcjpwYXNz", stale}, "invalid admin token"},
|
|
"no bearer value": {[]string{"Basic dXNlcjpwYXNz", "garbage"}, "authorization header must use Bearer scheme"},
|
|
"lowercase scheme ok": {[]string{"bearer " + fresh[len("Bearer "):]}, ""},
|
|
"fresh past the cap": {append(slices.Repeat([]string{stale}, maxGrpcAdminAuthValues), fresh), "invalid admin token"},
|
|
} {
|
|
ctx := metadata.NewIncomingContext(context.Background(), metadata.MD{"authorization": tc.values})
|
|
err := CheckGrpcAdminToken(ctx, key)
|
|
if tc.wantErr == "" {
|
|
if err != nil {
|
|
t.Errorf("%s: unexpected error %v", name, err)
|
|
}
|
|
continue
|
|
}
|
|
if status.Code(err) != codes.Unauthenticated || status.Convert(err).Message() != tc.wantErr {
|
|
t.Errorf("%s: got %v, want Unauthenticated %q", name, err, tc.wantErr)
|
|
}
|
|
}
|
|
}
|