mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-02 18:22:40 +01:00
* filer.redis3: prefix every key via getKey, honoring keyPrefix Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * filer.redis3: read username and keyPrefix options into client config Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * filer.redis3: reject a username configured without a password go-redis only sends AUTH when a password is set, so a configured username with an empty password silently connects as the default user instead of the intended ACL user. Fail loudly at initialize instead. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * filer.redis3: cover keyPrefix scoping in the store tests Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * filer.redis3: derive the test prefix and kv key from the per-run directory --------- Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
230 lines
6.8 KiB
Go
230 lines
6.8 KiB
Go
package redis3
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/redis/go-redis/v9"
|
|
|
|
redsync "github.com/go-redsync/redsync/v4"
|
|
"github.com/seaweedfs/seaweedfs/weed/filer"
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
)
|
|
|
|
const (
|
|
DIR_LIST_MARKER = "\x00"
|
|
)
|
|
|
|
type UniversalRedis3Store struct {
|
|
Client redis.UniversalClient
|
|
redsync *redsync.Redsync
|
|
keyPrefix string
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) getKey(key string) string {
|
|
if store.keyPrefix == "" {
|
|
return key
|
|
}
|
|
return store.keyPrefix + key
|
|
}
|
|
|
|
// checkUserPassword rejects a username with an empty password: go-redis only
|
|
// sends AUTH when a password is set, so the connection would silently run as
|
|
// the default user instead of the configured ACL user.
|
|
func checkUserPassword(username, password string) error {
|
|
if username != "" && password == "" {
|
|
return fmt.Errorf("username %q requires a password: with an empty password no AUTH is sent and the connection uses the default user", username)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) BeginTransaction(ctx context.Context) (context.Context, error) {
|
|
return ctx, nil
|
|
}
|
|
func (store *UniversalRedis3Store) CommitTransaction(ctx context.Context) error {
|
|
return nil
|
|
}
|
|
func (store *UniversalRedis3Store) RollbackTransaction(ctx context.Context) error {
|
|
return nil
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) InsertEntry(ctx context.Context, entry *filer.Entry) (err error) {
|
|
|
|
if err = store.doInsertEntry(ctx, entry); err != nil {
|
|
return err
|
|
}
|
|
|
|
dir, name := entry.FullPath.DirAndName()
|
|
|
|
if name != "" {
|
|
if err = insertChild(ctx, store, store.getKey(genDirectoryListKey(dir)), name); err != nil {
|
|
return fmt.Errorf("persisting %s in parent dir: %v", entry.FullPath, err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) doInsertEntry(ctx context.Context, entry *filer.Entry) error {
|
|
value, err := entry.EncodeAttributesAndChunks()
|
|
if err != nil {
|
|
return fmt.Errorf("encoding %s %+v: %v", entry.FullPath, entry.Attr, err)
|
|
}
|
|
|
|
if len(entry.GetChunks()) > filer.CountEntryChunksForGzip {
|
|
value = util.MaybeGzipData(value)
|
|
}
|
|
|
|
if err = store.Client.Set(ctx, store.getKey(string(entry.FullPath)), value, time.Duration(entry.TtlSec)*time.Second).Err(); err != nil {
|
|
return fmt.Errorf("persisting %s : %v", entry.FullPath, err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) UpdateEntry(ctx context.Context, entry *filer.Entry) (err error) {
|
|
|
|
return store.doInsertEntry(ctx, entry)
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) FindEntry(ctx context.Context, fullpath util.FullPath) (entry *filer.Entry, err error) {
|
|
|
|
data, err := store.Client.Get(ctx, store.getKey(string(fullpath))).Result()
|
|
if err == redis.Nil {
|
|
return nil, filer_pb.ErrNotFound
|
|
}
|
|
|
|
if err != nil {
|
|
return nil, fmt.Errorf("get %s : %v", fullpath, err)
|
|
}
|
|
|
|
entry = &filer.Entry{
|
|
FullPath: fullpath,
|
|
}
|
|
err = entry.DecodeAttributesAndChunks(util.MaybeDecompressData([]byte(data)))
|
|
if err != nil {
|
|
return entry, fmt.Errorf("decode %s : %v", entry.FullPath, err)
|
|
}
|
|
|
|
return entry, nil
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) DeleteEntry(ctx context.Context, fullpath util.FullPath) (err error) {
|
|
|
|
// The child listing is dropped by DeleteFolderChildren, together with the
|
|
// children it describes. Dropping it here would also discard an entry that
|
|
// arrived after the caller judged this directory empty, and nothing else
|
|
// records that the entry is there.
|
|
_, err = store.Client.Del(ctx, store.getKey(string(fullpath))).Result()
|
|
if err != nil {
|
|
return fmt.Errorf("delete %s : %v", fullpath, err)
|
|
}
|
|
|
|
dir, name := fullpath.DirAndName()
|
|
|
|
if name != "" {
|
|
if err = removeChild(ctx, store, store.getKey(genDirectoryListKey(dir)), name); err != nil {
|
|
return fmt.Errorf("DeleteEntry %s in parent dir: %v", fullpath, err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) DeleteFolderChildren(ctx context.Context, fullpath util.FullPath) (err error) {
|
|
|
|
dirListKey := store.getKey(genDirectoryListKey(string(fullpath)))
|
|
if err = removeChildren(ctx, store, dirListKey, func(name string) error {
|
|
path := util.NewFullPath(string(fullpath), name)
|
|
_, err = store.Client.Del(ctx, store.getKey(string(path))).Result()
|
|
if err != nil {
|
|
return fmt.Errorf("DeleteFolderChildren %s in parent dir: %v", fullpath, err)
|
|
}
|
|
// not efficient, but need to remove if it is a directory
|
|
store.Client.Del(ctx, store.getKey(genDirectoryListKey(string(path))))
|
|
return nil
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
|
|
// removeChildren clears the skip list nodes but leaves the list itself behind
|
|
if _, err = store.Client.Del(ctx, dirListKey).Result(); err != nil {
|
|
return fmt.Errorf("DeleteFolderChildren %s list: %v", fullpath, err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) ListDirectoryPrefixedEntries(ctx context.Context, dirPath util.FullPath, startFileName string, includeStartFile bool, limit int64, prefix string, eachEntryFunc filer.ListEachEntryFunc) (lastFileName string, err error) {
|
|
return lastFileName, filer.ErrUnsupportedListDirectoryPrefixed
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) ListDirectoryEntries(ctx context.Context, dirPath util.FullPath, startFileName string, includeStartFile bool, limit int64, eachEntryFunc filer.ListEachEntryFunc) (lastFileName string, err error) {
|
|
|
|
dirListKey := store.getKey(genDirectoryListKey(string(dirPath)))
|
|
counter := int64(0)
|
|
|
|
var callbackErr error
|
|
err = listChildren(ctx, store, dirListKey, startFileName, func(fileName string) bool {
|
|
if startFileName != "" {
|
|
if !includeStartFile && startFileName == fileName {
|
|
return true
|
|
}
|
|
}
|
|
|
|
path := util.NewFullPath(string(dirPath), fileName)
|
|
entry, err := store.FindEntry(ctx, path)
|
|
lastFileName = fileName
|
|
if err != nil {
|
|
glog.V(0).InfofCtx(ctx, "list %s : %v", path, err)
|
|
if err == filer_pb.ErrNotFound {
|
|
return true
|
|
}
|
|
} else {
|
|
if entry.TtlSec > 0 {
|
|
if entry.Attr.Crtime.Add(time.Duration(entry.TtlSec) * time.Second).Before(time.Now()) {
|
|
store.Client.Del(ctx, store.getKey(string(path))).Result()
|
|
store.Client.ZRem(ctx, dirListKey, fileName).Result()
|
|
return true
|
|
}
|
|
}
|
|
counter++
|
|
|
|
resEachEntryFunc, resEachEntryFuncErr := eachEntryFunc(entry)
|
|
if resEachEntryFuncErr != nil {
|
|
glog.V(0).InfofCtx(ctx, "failed to process eachEntryFunc for entry %q: %v", fileName, resEachEntryFuncErr)
|
|
callbackErr = resEachEntryFuncErr
|
|
return false
|
|
}
|
|
|
|
if !resEachEntryFunc {
|
|
return false
|
|
}
|
|
|
|
if counter >= limit {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
})
|
|
|
|
if callbackErr != nil {
|
|
return lastFileName, fmt.Errorf(
|
|
"failed to process eachEntryFunc for dir %q, entry %q: %w",
|
|
dirPath, lastFileName, callbackErr,
|
|
)
|
|
}
|
|
|
|
return lastFileName, err
|
|
}
|
|
|
|
func genDirectoryListKey(dir string) (dirList string) {
|
|
return dir + DIR_LIST_MARKER
|
|
}
|
|
|
|
func (store *UniversalRedis3Store) Shutdown() {
|
|
store.Client.Close()
|
|
}
|