mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-20 13:30:46 +02:00
Chris Lu
194dce27bf
* fix(mount): preserve user-set mtime through async/periodic flush (#9363) flushMetadataToFiler and flushFileMetadata both stamped time.Now() onto the entry before sending it to the filer, clobbering any mtime SetAttr had stored from utimes()/touch -m -d. The reproducer hit this ~1s after touch because the writebackCache deferred close from the prior write ran flushMetadataToFiler after the user's utimes call. Flush has no business inventing timestamps. Move the write-time stamp into Write (where it always belonged for POSIX correctness) and let flush persist whatever Write or SetAttr already put on the entry. * test(mount): tighten mtime regression test, drop tautological one - userMtime now has non-zero nanoseconds, so the *Ns assertions catch a regression that would zero the field. - Add CtimeNs assertion (was missing). - Drop TestWriteStampsEntryMtime: it duplicated the implementation it was supposed to test, so a regression in Write would not have failed it. Driving the real Write path needs a full PageWriter, which is out of scope for this fix; TestFlushFileMetadataPreservesUserMtime is the meaningful regression for #9363.
71 lines
2.4 KiB
Go
71 lines
2.4 KiB
Go
package mount
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
)
|
|
|
|
// TestFlushFileMetadataPreservesUserMtime is a regression test for issue #9363.
|
|
//
|
|
// Before the fix, flushFileMetadata stamped entry.Attributes.Mtime/Ctime with
|
|
// time.Now() on every flush, clobbering the value SetAttr stored on the entry
|
|
// when the user ran utimes()/touch -m -d while a file handle was still open.
|
|
//
|
|
// The flush has no business inventing timestamps: Write and SetAttr already
|
|
// maintain mtime/ctime on the entry, and the flush should just persist them.
|
|
//
|
|
// The test sets a user-chosen mtime far in the past, runs flushFileMetadata
|
|
// with no chunks (so it returns before the streamCreateEntry RPC), and asserts
|
|
// the entry's mtime is unchanged.
|
|
func TestFlushFileMetadataPreservesUserMtime(t *testing.T) {
|
|
wfs := &WFS{
|
|
inodeToPath: NewInodeToPath(util.FullPath("/"), 0),
|
|
fhLockTable: util.NewLockTable[FileHandleId](),
|
|
option: &Option{},
|
|
}
|
|
|
|
const inode = uint64(42)
|
|
fullPath := util.FullPath("/dir/sample.txt")
|
|
wfs.inodeToPath.Lookup(fullPath, 1, false, false, inode, true)
|
|
|
|
// Use a non-zero nanosecond so the *Ns assertions below catch a regression
|
|
// that zeroes the field instead of preserving it.
|
|
userMtime := time.Date(2020, 1, 15, 12, 34, 56, 123456789, time.UTC)
|
|
entry := &filer_pb.Entry{
|
|
Name: "sample.txt",
|
|
Attributes: &filer_pb.FuseAttributes{
|
|
Mtime: userMtime.Unix(),
|
|
MtimeNs: int32(userMtime.Nanosecond()),
|
|
Ctime: userMtime.Unix(),
|
|
CtimeNs: int32(userMtime.Nanosecond()),
|
|
},
|
|
}
|
|
fh := &FileHandle{
|
|
fh: FileHandleId(1),
|
|
inode: inode,
|
|
wfs: wfs,
|
|
entry: &LockedEntry{Entry: entry},
|
|
dirtyMetadata: true,
|
|
}
|
|
|
|
if err := wfs.flushFileMetadata(fh); err != nil {
|
|
t.Fatalf("flushFileMetadata returned error: %v", err)
|
|
}
|
|
|
|
if got := entry.Attributes.Mtime; got != userMtime.Unix() {
|
|
t.Errorf("mtime sec changed: got %d, want %d", got, userMtime.Unix())
|
|
}
|
|
if got := entry.Attributes.MtimeNs; got != int32(userMtime.Nanosecond()) {
|
|
t.Errorf("mtime ns changed: got %d, want %d", got, userMtime.Nanosecond())
|
|
}
|
|
if got := entry.Attributes.Ctime; got != userMtime.Unix() {
|
|
t.Errorf("ctime sec changed: got %d, want %d", got, userMtime.Unix())
|
|
}
|
|
if got := entry.Attributes.CtimeNs; got != int32(userMtime.Nanosecond()) {
|
|
t.Errorf("ctime ns changed: got %d, want %d", got, userMtime.Nanosecond())
|
|
}
|
|
}
|