mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-17 19:48:35 +02:00
* mount: propagate request context through metadata lookups The FUSE interrupt channel never reached the filer RPC: lookupEntry ran its LookupEntry under context.Background(), so a stalled filer parked ops like ListXAttr forever even after the kernel gave up on them. Thread a context from each op's cancel channel through maybeReadEntry, maybeLoadEntry, lookupEntry, ensureDirectoryVisited and waitForPendingAsyncFlush; the existing withFilerClient attempt bound turns it into both an interrupt and a deadline. A caller cancellation now surfaces as EINTR instead of waiting out the RPC. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mount: reuse ctxFromCancel for the read path's interrupt bridge Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mount: regression tests for canceled and stalled filer lookups Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mount: thread ctx through AcquireHandle Open, Create and Mknod all carry the request's cancel channel; let it bound the pending-flush wait and metadata load inside AcquireHandle too. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mount: keep flush waits and write sequences uninterruptible The cancel-derived context must only cover metadata reads: an interrupted Unlink or Rename that skips the pending-flush wait can race the async write back into existence, and Link/Rename mutations that run under a canceled context abort mid-sequence, strand the rollback, and leave wrong hard-link counts. Restore the blocking flush wait and run each op's write phase on context.Background(). Rmdir and Unlink also propagate EINTR from the parent lookup instead of proceeding past a permission check the interrupt prevented. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mount: interrupt shared directory builds and directory reads Waiters behind another request's singleflight directory build blocked until it finished even when interrupted; switch the wait to DoChan so the request context can abandon it. ReadDir paths now carry the request context through EnsureListingFresh, cache listings and direct reads, and map its cancellation to EINTR rather than EIO. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mount: assert exact statuses in filer-stall regression tests Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mount: let read-side flush waits release on interrupt waitForPendingAsyncFlush reports whether the flush actually finished: lookupEntry and AcquireHandle return EINTR when the request is abandoned mid-wait, while Unlink and Rename keep waiting on context.Background() so the delete/rename still sees the flushed state. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mount: propagate interrupt through remaining lookup checks Rename's source and destination permission lookups now return EINTR on interrupt instead of skipping checkStickyBit or masking an existing target, and the readdir preload visit maps cancellation to EINTR like the other branches. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * mount: fail closed on errored rename prerequisite lookups * mount: stop rmdir on interrupted target lookup, fail closed on dir lookup errors --------- Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
243 lines
5.6 KiB
Go
243 lines
5.6 KiB
Go
//go:build !freebsd
|
|
|
|
package mount
|
|
|
|
import (
|
|
"runtime"
|
|
"strings"
|
|
"syscall"
|
|
|
|
"github.com/seaweedfs/go-fuse/v2/fuse"
|
|
)
|
|
|
|
const (
|
|
// https://man7.org/linux/man-pages/man7/xattr.7.html#:~:text=The%20VFS%20imposes%20limitations%20that,in%20listxattr(2)).
|
|
MAX_XATTR_NAME_SIZE = 255
|
|
MAX_XATTR_VALUE_SIZE = 65536
|
|
XATTR_PREFIX = "xattr-" // same as filer
|
|
)
|
|
|
|
// GetXAttr reads an extended attribute, and should return the
|
|
// number of bytes. If the buffer is too small, return ERANGE,
|
|
// with the required buffer size.
|
|
func (wfs *WFS) GetXAttr(cancel <-chan struct{}, header *fuse.InHeader, attr string, dest []byte) (size uint32, code fuse.Status) {
|
|
|
|
if wfs.option.DisableXAttr {
|
|
return 0, fuse.Status(syscall.ENOTSUP)
|
|
}
|
|
|
|
//validate attr name
|
|
if len(attr) > MAX_XATTR_NAME_SIZE {
|
|
if runtime.GOOS == "darwin" {
|
|
return 0, fuse.EPERM
|
|
} else {
|
|
return 0, fuse.ERANGE
|
|
}
|
|
}
|
|
if len(attr) == 0 {
|
|
return 0, fuse.EINVAL
|
|
}
|
|
|
|
ctx, cancelFunc := ctxFromCancel(cancel)
|
|
defer cancelFunc()
|
|
_, _, entry, status := wfs.maybeReadEntry(ctx, header.NodeId)
|
|
if status != fuse.OK {
|
|
return 0, status
|
|
}
|
|
if entry == nil {
|
|
return 0, fuse.ENOENT
|
|
}
|
|
if entry.Extended == nil {
|
|
return 0, fuse.ENOATTR
|
|
}
|
|
data, found := entry.Extended[XATTR_PREFIX+attr]
|
|
if !found {
|
|
return 0, fuse.ENOATTR
|
|
}
|
|
if len(dest) < len(data) {
|
|
return uint32(len(data)), fuse.ERANGE
|
|
}
|
|
copy(dest, data)
|
|
|
|
return uint32(len(data)), fuse.OK
|
|
}
|
|
|
|
// SetXAttr writes an extended attribute.
|
|
// https://man7.org/linux/man-pages/man2/setxattr.2.html
|
|
//
|
|
// By default (i.e., flags is zero), the extended attribute will be
|
|
// created if it does not exist, or the value will be replaced if
|
|
// the attribute already exists. To modify these semantics, one of
|
|
// the following values can be specified in flags:
|
|
//
|
|
// XATTR_CREATE
|
|
// Perform a pure create, which fails if the named attribute
|
|
// exists already.
|
|
//
|
|
// XATTR_REPLACE
|
|
// Perform a pure replace operation, which fails if the named
|
|
// attribute does not already exist.
|
|
func (wfs *WFS) SetXAttr(cancel <-chan struct{}, input *fuse.SetXAttrIn, attr string, data []byte) fuse.Status {
|
|
|
|
if wfs.option.DisableXAttr {
|
|
return fuse.Status(syscall.ENOTSUP)
|
|
}
|
|
|
|
if wfs.IsOverQuotaWithUncommitted() {
|
|
return fuse.Status(syscall.ENOSPC)
|
|
}
|
|
|
|
//validate attr name
|
|
if len(attr) > MAX_XATTR_NAME_SIZE {
|
|
if runtime.GOOS == "darwin" {
|
|
return fuse.EPERM
|
|
} else {
|
|
return fuse.ERANGE
|
|
}
|
|
}
|
|
if len(attr) == 0 {
|
|
return fuse.EINVAL
|
|
}
|
|
//validate attr value
|
|
if len(data) > MAX_XATTR_VALUE_SIZE {
|
|
if runtime.GOOS == "darwin" {
|
|
return fuse.Status(syscall.E2BIG)
|
|
} else {
|
|
return fuse.ERANGE
|
|
}
|
|
}
|
|
|
|
ctx, cancelFunc := ctxFromCancel(cancel)
|
|
defer cancelFunc()
|
|
path, fh, entry, status := wfs.maybeReadEntry(ctx, input.NodeId)
|
|
if status != fuse.OK {
|
|
return status
|
|
}
|
|
if entry == nil {
|
|
return fuse.ENOENT
|
|
}
|
|
if fh != nil {
|
|
fh.entryLock.Lock()
|
|
defer fh.entryLock.Unlock()
|
|
}
|
|
|
|
if entry.Extended == nil {
|
|
entry.Extended = make(map[string][]byte)
|
|
}
|
|
_, exists := entry.Extended[XATTR_PREFIX+attr]
|
|
switch input.Flags {
|
|
case xattr_CREATE:
|
|
if exists {
|
|
return fuse.Status(syscall.EEXIST)
|
|
}
|
|
case xattr_REPLACE:
|
|
if !exists {
|
|
return fuse.ENODATA
|
|
}
|
|
}
|
|
|
|
// data aliases the FUSE request's pooled input buffer, which is
|
|
// recycled once this handler returns. Copy before storing so a
|
|
// later request reusing the buffer cannot corrupt the value.
|
|
entry.Extended[XATTR_PREFIX+attr] = append([]byte(nil), data...)
|
|
|
|
if fh != nil {
|
|
fh.dirtyMetadata = true
|
|
return fuse.OK
|
|
}
|
|
if path == "" {
|
|
// removed while open: the remembered entry is all there is to update
|
|
wfs.rememberRemovedDir(input.NodeId, entry)
|
|
return fuse.OK
|
|
}
|
|
|
|
return wfs.saveEntry(path, entry)
|
|
|
|
}
|
|
|
|
// ListXAttr lists extended attributes as '\0' delimited byte
|
|
// slice, and return the number of bytes. If the buffer is too
|
|
// small, return ERANGE, with the required buffer size.
|
|
func (wfs *WFS) ListXAttr(cancel <-chan struct{}, header *fuse.InHeader, dest []byte) (n uint32, code fuse.Status) {
|
|
|
|
if wfs.option.DisableXAttr {
|
|
return 0, fuse.Status(syscall.ENOTSUP)
|
|
}
|
|
|
|
ctx, cancelFunc := ctxFromCancel(cancel)
|
|
defer cancelFunc()
|
|
_, _, entry, status := wfs.maybeReadEntry(ctx, header.NodeId)
|
|
if status != fuse.OK {
|
|
return 0, status
|
|
}
|
|
if entry == nil {
|
|
return 0, fuse.ENOENT
|
|
}
|
|
if entry.Extended == nil {
|
|
return 0, fuse.OK
|
|
}
|
|
|
|
var data []byte
|
|
for k := range entry.Extended {
|
|
if strings.HasPrefix(k, XATTR_PREFIX) {
|
|
data = append(data, k[len(XATTR_PREFIX):]...)
|
|
data = append(data, 0)
|
|
}
|
|
}
|
|
if len(dest) < len(data) {
|
|
return uint32(len(data)), fuse.ERANGE
|
|
}
|
|
|
|
copy(dest, data)
|
|
|
|
return uint32(len(data)), fuse.OK
|
|
}
|
|
|
|
// RemoveXAttr removes an extended attribute.
|
|
func (wfs *WFS) RemoveXAttr(cancel <-chan struct{}, header *fuse.InHeader, attr string) fuse.Status {
|
|
|
|
if wfs.option.DisableXAttr {
|
|
return fuse.Status(syscall.ENOTSUP)
|
|
}
|
|
|
|
if len(attr) == 0 {
|
|
return fuse.EINVAL
|
|
}
|
|
ctx, cancelFunc := ctxFromCancel(cancel)
|
|
defer cancelFunc()
|
|
path, fh, entry, status := wfs.maybeReadEntry(ctx, header.NodeId)
|
|
if status != fuse.OK {
|
|
return status
|
|
}
|
|
if entry == nil {
|
|
return fuse.OK
|
|
}
|
|
if fh != nil {
|
|
fh.entryLock.Lock()
|
|
defer fh.entryLock.Unlock()
|
|
}
|
|
|
|
if entry.Extended == nil {
|
|
return fuse.ENOATTR
|
|
}
|
|
_, found := entry.Extended[XATTR_PREFIX+attr]
|
|
|
|
if !found {
|
|
return fuse.ENOATTR
|
|
}
|
|
|
|
delete(entry.Extended, XATTR_PREFIX+attr)
|
|
|
|
if fh != nil {
|
|
fh.dirtyMetadata = true
|
|
return fuse.OK
|
|
}
|
|
if path == "" {
|
|
// removed while open: the remembered entry is all there is to update
|
|
wfs.rememberRemovedDir(header.NodeId, entry)
|
|
return fuse.OK
|
|
}
|
|
|
|
return wfs.saveEntry(path, entry)
|
|
}
|