mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-19 04:50:54 +02:00
The collection filter was parsed twice with two syntaxes: the master-side volume listing compiled the whole string as one regex, while EC encode and EC balance detection split it on commas and matched each entry as a wildcard. A volume had to pass both, so "collection-a,collection-b" matched nothing (no collection is named that), and the ALL_COLLECTIONS sentinel, which the master side skips, dropped every volume at the task side. Parse it once, in one place: a comma-separated list where an entry is a name with optional * and ? wildcards, or a regex when it carries regex syntax. A regex entry now has to match the whole name unless it anchors itself, so listing a collection no longer picks up its longer namesakes.
130 lines
3.9 KiB
Go
130 lines
3.9 KiB
Go
package pluginworker
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
)
|
|
|
|
func makeTestVolumeListResponse(volumes ...*master_pb.VolumeInformationMessage) *master_pb.VolumeListResponse {
|
|
return &master_pb.VolumeListResponse{
|
|
VolumeSizeLimitMb: 30000,
|
|
TopologyInfo: &master_pb.TopologyInfo{
|
|
DataCenterInfos: []*master_pb.DataCenterInfo{
|
|
{
|
|
Id: "dc1",
|
|
RackInfos: []*master_pb.RackInfo{
|
|
{
|
|
Id: "rack1",
|
|
DataNodeInfos: []*master_pb.DataNodeInfo{
|
|
{
|
|
Id: "server1:8080",
|
|
DiskInfos: map[string]*master_pb.DiskInfo{
|
|
"hdd": {
|
|
VolumeInfos: volumes,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsEmptyFilter(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
&master_pb.VolumeInformationMessage{Id: 2, Collection: "videos", Size: 200},
|
|
)
|
|
metrics, _, _, err := buildVolumeMetrics(resp, "")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(metrics) != 2 {
|
|
t.Fatalf("expected 2 metrics, got %d", len(metrics))
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsAllCollections(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
&master_pb.VolumeInformationMessage{Id: 2, Collection: "videos", Size: 200},
|
|
)
|
|
metrics, _, _, err := buildVolumeMetrics(resp, string(CollectionFilterAll))
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(metrics) != 2 {
|
|
t.Fatalf("expected 2 metrics, got %d", len(metrics))
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsEachCollection(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
&master_pb.VolumeInformationMessage{Id: 2, Collection: "videos", Size: 200},
|
|
)
|
|
// EACH_COLLECTION passes all volumes through; filtering happens in the handler
|
|
metrics, _, _, err := buildVolumeMetrics(resp, string(CollectionFilterEach))
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(metrics) != 2 {
|
|
t.Fatalf("expected 2 metrics, got %d", len(metrics))
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsRegexFilter(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
&master_pb.VolumeInformationMessage{Id: 2, Collection: "videos", Size: 200},
|
|
&master_pb.VolumeInformationMessage{Id: 3, Collection: "photos-backup", Size: 300},
|
|
)
|
|
metrics, _, _, err := buildVolumeMetrics(resp, "^photos$")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(metrics) != 1 {
|
|
t.Fatalf("expected 1 metric, got %d", len(metrics))
|
|
}
|
|
if metrics[0].Collection != "photos" {
|
|
t.Fatalf("expected collection 'photos', got %q", metrics[0].Collection)
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsCollectionList(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
&master_pb.VolumeInformationMessage{Id: 2, Collection: "videos", Size: 200},
|
|
&master_pb.VolumeInformationMessage{Id: 3, Collection: "clips", Size: 300},
|
|
)
|
|
metrics, _, _, err := buildVolumeMetrics(resp, "photos,videos")
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if len(metrics) != 2 {
|
|
t.Fatalf("expected 2 metrics, got %d", len(metrics))
|
|
}
|
|
for _, metric := range metrics {
|
|
if metric.Collection != "photos" && metric.Collection != "videos" {
|
|
t.Fatalf("unexpected collection %q", metric.Collection)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBuildVolumeMetricsInvalidRegex(t *testing.T) {
|
|
resp := makeTestVolumeListResponse(
|
|
&master_pb.VolumeInformationMessage{Id: 1, Collection: "photos", Size: 100},
|
|
)
|
|
_, _, _, err := buildVolumeMetrics(resp, "[invalid")
|
|
if err == nil {
|
|
t.Fatal("expected error for invalid regex")
|
|
}
|
|
if !isConfigError(err) {
|
|
t.Fatalf("expected config error for invalid regex, got: %v", err)
|
|
}
|
|
}
|