mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-19 20:44:28 +02:00
* sts: recognize issuer-scoped parent user ids
ComputeParentUser output has a fixed shape (base64url SHA-256); let
callers distinguish it from bare subject strings.
* s3tables: keep legacy owner re-anchoring off local and scoped account ids
Re-anchoring a stored bare subject under the single trusted issuer must
only apply to strings that could actually be a legacy OIDC subject. A
stored owner naming the reserved or a configured local account, or an
already issuer-scoped id, can otherwise be claimed by any caller whose
token asserts that string as sub.
* s3tables: re-anchor legacy policy principals in map and array forms
A stored bare subject can appear as {"AWS": sub} or inside a principal
list, not only as a top-level string; re-anchoring only the string form
left legacy Deny statements unable to match the caller.
* s3tables: keep built-in legacy exclusions independent of the account checker
A missing local-account predicate must not disable re-anchoring entirely:
the reserved accounts, ARN-shaped values, and scoped-id shapes are never
OIDC subjects regardless, while legacy Deny statements for plain subjects
still need to resolve so a denied caller cannot fall through to an
identity grant.
* s3tables: exercise legacy Deny against an owner grant
The previous case denied the caller regardless of whether the statement
principal matched; make the caller the owner so a missed match shows.
Cover the array Deny form alongside the AWS map.
144 lines
4.8 KiB
Go
144 lines
4.8 KiB
Go
package sts
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestComputeParentUserStability(t *testing.T) {
|
|
// Same (sub, iss) must produce the same hash, regardless of order or
|
|
// whitespace mutations callers should never apply.
|
|
a := ComputeParentUser("alice", "https://idp.example/")
|
|
b := ComputeParentUser("alice", "https://idp.example/")
|
|
if a == "" {
|
|
t.Fatal("parent user should not be empty for non-empty sub")
|
|
}
|
|
if a != b {
|
|
t.Fatalf("expected stable hash, got %q vs %q", a, b)
|
|
}
|
|
}
|
|
|
|
func TestComputeParentUserDistinguishesIssuer(t *testing.T) {
|
|
// The point of incorporating iss is that the same `sub` from two providers
|
|
// must not collide. If this assertion ever fails, the hash input is wrong.
|
|
a := ComputeParentUser("alice", "https://idp-a.example/")
|
|
b := ComputeParentUser("alice", "https://idp-b.example/")
|
|
if a == b {
|
|
t.Fatalf("hashes for different issuers must differ, both = %q", a)
|
|
}
|
|
}
|
|
|
|
func TestComputeParentUserDistinguishesSubject(t *testing.T) {
|
|
a := ComputeParentUser("alice", "https://idp.example/")
|
|
b := ComputeParentUser("bob", "https://idp.example/")
|
|
if a == b {
|
|
t.Fatalf("hashes for different subjects must differ, both = %q", a)
|
|
}
|
|
}
|
|
|
|
func TestComputeParentUserEmptySub(t *testing.T) {
|
|
if got := ComputeParentUser("", "https://idp.example/"); got != "" {
|
|
t.Fatalf("empty sub should produce empty parent user, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestComputeParentUserEmptyIss(t *testing.T) {
|
|
// Without an issuer, two different IDPs that both name a user "alice"
|
|
// would collide on the same parent_user. Refuse rather than hash.
|
|
if got := ComputeParentUser("alice", ""); got != "" {
|
|
t.Fatalf("empty iss should produce empty parent user, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestComputeParentUserEncoding(t *testing.T) {
|
|
got := ComputeParentUser("alice", "https://idp.example/")
|
|
// Base64 RawURL has no padding and uses URL-safe alphabet — important
|
|
// because parent_user shows up in filer paths and audit log fields.
|
|
if strings.ContainsAny(got, "=+/") {
|
|
t.Fatalf("parent user should be base64 raw url, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestIsParentUserID(t *testing.T) {
|
|
if !IsParentUserID(ComputeParentUser("alice", "https://idp.example/")) {
|
|
t.Fatal("a ComputeParentUser result must be recognized")
|
|
}
|
|
for _, s := range []string{"", "alice", "admin", "arn:aws:iam::123:user/admin", "dGVzdA=="} {
|
|
if IsParentUserID(s) {
|
|
t.Fatalf("%q is not a scoped parent user id", s)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSessionClaimsRoundTripParentUser(t *testing.T) {
|
|
parent := ComputeParentUser("alice", "https://idp.example/")
|
|
claims := NewSTSSessionClaims("sid-1", "issuer", time.Now().Add(time.Hour)).
|
|
WithRoleInfo("arn:aws:iam::123:role/r", "arn:aws:sts::123:assumed-role/r/s", "arn:aws:sts::123:assumed-role/r/s").
|
|
WithParentUser(parent)
|
|
|
|
info := claims.ToSessionInfo(testCredGen)
|
|
if info.ParentUser != parent {
|
|
t.Fatalf("ParentUser lost on round-trip: got %q want %q", info.ParentUser, parent)
|
|
}
|
|
}
|
|
|
|
func TestResolveIdentityClaimPrefersPreferredUsername(t *testing.T) {
|
|
ctx := map[string]interface{}{
|
|
"preferred_username": "grant.west",
|
|
"email": "grant.west@example.com",
|
|
"sub": "alice-sub",
|
|
}
|
|
if got := ResolveIdentityClaim(ctx); got != "grant.west" {
|
|
t.Fatalf("expected preferred_username, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestResolveIdentityClaimFallsBackThroughPriority(t *testing.T) {
|
|
if got := ResolveIdentityClaim(map[string]interface{}{"email": "g@example.com", "sub": "s"}); got != "g@example.com" {
|
|
t.Fatalf("expected email fallback, got %q", got)
|
|
}
|
|
if got := ResolveIdentityClaim(map[string]interface{}{"sub": "s"}); got != "s" {
|
|
t.Fatalf("expected sub fallback, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestResolveIdentityClaimEmpty(t *testing.T) {
|
|
if got := ResolveIdentityClaim(nil); got != "" {
|
|
t.Fatalf("expected empty for nil ctx, got %q", got)
|
|
}
|
|
if got := ResolveIdentityClaim(map[string]interface{}{}); got != "" {
|
|
t.Fatalf("expected empty for empty ctx, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestResolveIdentityClaimSkipsNonString(t *testing.T) {
|
|
ctx := map[string]interface{}{
|
|
"preferred_username": []string{"no"},
|
|
"sub": "real-sub",
|
|
}
|
|
if got := ResolveIdentityClaim(ctx); got != "real-sub" {
|
|
t.Fatalf("expected sub after skipping non-string claim, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestResolveIdentityClaimTrimsWhitespace(t *testing.T) {
|
|
ctx := map[string]interface{}{
|
|
"preferred_username": " grant.west ",
|
|
"email": "grant.west@example.com",
|
|
}
|
|
if got := ResolveIdentityClaim(ctx); got != "grant.west" {
|
|
t.Fatalf("expected trimmed preferred_username, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestResolveIdentityClaimSkipsWhitespaceOnly(t *testing.T) {
|
|
ctx := map[string]interface{}{
|
|
"preferred_username": " ",
|
|
"email": "grant.west@example.com",
|
|
}
|
|
if got := ResolveIdentityClaim(ctx); got != "grant.west@example.com" {
|
|
t.Fatalf("expected email after skipping whitespace-only preferred_username, got %q", got)
|
|
}
|
|
}
|