mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-13 15:29:12 +01:00
user.emailandDevin
f7684c4478
A renewal rotates the token server-side before the response is sent. When that response is lost the client only knows the superseded token: retries mismatched, the token was cleared, and the holder conflicted with its own lease until it expired. The lock now remembers the superseded token, so a retry from the same owner replays the current token, and a superseded token can still release its own lock. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
123 lines
3.9 KiB
Go
123 lines
3.9 KiB
Go
package lock_manager
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestLockManager_GetLockOwnerIgnoresExpiredLock(t *testing.T) {
|
|
lm := NewLockManager()
|
|
|
|
lm.InsertLock("key1", time.Now().Add(-time.Second).UnixNano(), "token1", "owner1", 7, 3)
|
|
|
|
owner, err := lm.GetLockOwner("key1")
|
|
assert.Empty(t, owner)
|
|
assert.ErrorIs(t, err, LockNotFound)
|
|
}
|
|
|
|
func TestLockManager_InsertLockRejectsStaleTransfer(t *testing.T) {
|
|
lm := NewLockManager()
|
|
|
|
lm.InsertLock("key1", time.Now().Add(30*time.Second).UnixNano(), "token-new", "owner1", 8, 4)
|
|
lm.InsertLock("key1", time.Now().Add(30*time.Second).UnixNano(), "token-old", "owner1", 7, 3)
|
|
|
|
lock, found := lm.GetLock("key1")
|
|
assert.True(t, found)
|
|
assert.Equal(t, "token-new", lock.Token)
|
|
assert.Equal(t, int64(8), lock.Generation)
|
|
assert.Equal(t, int64(4), lock.Seq)
|
|
}
|
|
|
|
func TestLockManager_InsertLockAdvancesGenerationCounter(t *testing.T) {
|
|
lm := NewLockManager()
|
|
|
|
lm.InsertLock("key1", time.Now().Add(30*time.Second).UnixNano(), "token1", "owner1", 12, 1)
|
|
|
|
_, renewToken, generation, _, err := lm.Lock("key2", time.Now().Add(30*time.Second).UnixNano(), "", "owner2")
|
|
assert.NoError(t, err)
|
|
assert.NotEmpty(t, renewToken)
|
|
assert.Greater(t, generation, int64(12))
|
|
}
|
|
|
|
func TestLockManager_InsertBackupLockRejectsOlderGeneration(t *testing.T) {
|
|
lm := NewLockManager()
|
|
|
|
lm.InsertBackupLock("key1", time.Now().Add(30*time.Second).UnixNano(), "token-new", "owner1", 8, 1)
|
|
lm.InsertBackupLock("key1", time.Now().Add(30*time.Second).UnixNano(), "token-old", "owner1", 7, 9)
|
|
|
|
lock, found := lm.GetLock("key1")
|
|
assert.True(t, found)
|
|
assert.Equal(t, "token-new", lock.Token)
|
|
assert.Equal(t, int64(8), lock.Generation)
|
|
assert.Equal(t, int64(1), lock.Seq)
|
|
}
|
|
|
|
func TestLockManager_InsertBackupLockKeepsPrimaryRole(t *testing.T) {
|
|
lm := NewLockManager()
|
|
|
|
ok := lm.InsertLock("key1", time.Now().Add(30*time.Second).UnixNano(), "token-old", "owner1", 8, 1)
|
|
assert.True(t, ok)
|
|
|
|
lm.InsertBackupLock("key1", time.Now().Add(30*time.Second).UnixNano(), "token-new", "owner1", 8, 2)
|
|
|
|
lock, found := lm.GetLock("key1")
|
|
assert.True(t, found)
|
|
assert.False(t, lock.IsBackup)
|
|
assert.Equal(t, "token-new", lock.Token)
|
|
assert.Equal(t, int64(8), lock.Generation)
|
|
assert.Equal(t, int64(2), lock.Seq)
|
|
}
|
|
|
|
func TestLockManager_RemoveBackupLockRejectsOlderGeneration(t *testing.T) {
|
|
lm := NewLockManager()
|
|
|
|
lm.InsertBackupLock("key1", time.Now().Add(30*time.Second).UnixNano(), "token-new", "owner1", 8, 1)
|
|
|
|
removed := lm.RemoveBackupLockIfSeq("key1", 7, 9)
|
|
assert.False(t, removed)
|
|
|
|
lock, found := lm.GetLock("key1")
|
|
assert.True(t, found)
|
|
assert.Equal(t, "token-new", lock.Token)
|
|
assert.Equal(t, int64(8), lock.Generation)
|
|
assert.Equal(t, int64(1), lock.Seq)
|
|
}
|
|
|
|
func TestLockManager_LostRenewalResponseReplaysToken(t *testing.T) {
|
|
lm := NewLockManager()
|
|
expires := time.Now().Add(30 * time.Second).UnixNano()
|
|
|
|
_, token1, _, _, err := lm.Lock("key1", expires, "", "owner1")
|
|
assert.NoError(t, err)
|
|
|
|
// The renewal rotated token1 to token2; the client never learned it.
|
|
_, token2, _, _, err := lm.Lock("key1", expires, token1, "owner1")
|
|
assert.NoError(t, err)
|
|
assert.NotEqual(t, token1, token2)
|
|
|
|
// Retrying with the superseded token replays the current one instead of
|
|
// conflicting with its own lease until it expires.
|
|
owner, replayed, _, _, err := lm.Lock("key1", expires, token1, "owner1")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "owner1", owner)
|
|
assert.Equal(t, token2, replayed)
|
|
|
|
// A replay from a different owner still mismatches.
|
|
_, _, _, _, err = lm.Lock("key1", expires, token1, "intruder")
|
|
assert.Error(t, err)
|
|
|
|
// The next rotation retires the superseded token for good.
|
|
_, token3, _, _, err := lm.Lock("key1", expires, token2, "owner1")
|
|
assert.NoError(t, err)
|
|
assert.NotEqual(t, token2, token3)
|
|
_, _, _, _, err = lm.Lock("key1", expires, token1, "owner1")
|
|
assert.Error(t, err)
|
|
|
|
// A superseded token still releases its own lock.
|
|
unlocked, _, _, err := lm.Unlock("key1", token2)
|
|
assert.NoError(t, err)
|
|
assert.True(t, unlocked)
|
|
}
|