mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-18 20:18:27 +02:00
pingqiuandClaude Opus 4.7
4127e5136c
Closure report (v3-phase-15-t3-closure-report.md): - §E rewritten as FINAL A–F m01 verification table with per-impl status + G4 pass criterion = smartwal (production default) full A–F green; walstore non-default fallback with Matrix D failure tracked via BUG-007 - §E sign table: QA re-sign 2026-04-22 with evidence basis (seaweed_block@313dd52 + BUG-005 fix 42b045a); prior RETRACTED row superseded - §D INV-DURABLE-001: conditional "Path B pending" wording removed; scoped to smartwal; canonical row name stands - §B non-claims: stale _TBD_ perf wording replaced with first-light scope statement; new non-claim "G4 pass = smartwal only; walstore deferred via BUG-007" added - §G.3 finalized: FINAL resolution with smartwal A–F PASS; walstore deferred - §H Phase 2 narrative updated to match final matrix outcome (Matrix E smartwal-only; walstore E skipped pending BUG-007) - §H Phase 4: T3-DEF-6 test wording downgraded from "pins cleanup contract" to "smoke + goroutine-leak guard" per PM feedback (no test-only introspection of Target.ctrls/ AER/KATO internals; follow-up deferred) - §H Phase 5: BUG-007 filed and scoped; non-blocking basis spelled out Contract Bridge Catalogue (v2-v3-contract-bridge-catalogue.md): - §2.2.14 C1-NVME-SESSION-KATO reclassified PRESERVE-partial → VIOLATED with BUG-006 anchor + m01 Matrix D evidence - §2.2.14 C5-NVME-SESSION-STATE-CLEANUP-ON-CLOSE added (T3-DEF-6 retrofit, pinned by QA L1 addendum) - §2.3 drift-event audit table expanded with BUG-006, BUG-007, T3-DEF-5, T3-DEF-6 BUG-006 (006_nvme_kato_timer_not_enforced.md): - Unified contract ID to catalogue name C1-NVME-SESSION-KATO-STORED-NOT-ENFORCED (was drifting as C3-NVME-KATO-ENFORCEMENT, PM Low catch) - §7 reframed as "existing row reclassified VIOLATED" rather than "add new row" BUG-007 (007_walstore_umount_remount_data_loss.md): filed as pre-existing walstore-specific durability bug surfaced by Matrix D re-verify; explicitly non-blocking for T3 since smartwal is production default. BUG-005 (005_backend_close_cross_session.md): committed for HEAD-reproducibility (referenced by closure §H Phase 3). Inventory (bugs/inventory/nvme-test-coverage-deferred.md): T3-DEF-5/6/7 struck through with per-row resolution pointers; zero open T3-scope inventory rows remaining. Evidence artifacts committed in seaweed_block@313dd52 (scripts/iterate-m01-nvme.sh Matrix F robustness + t3_qa_session_cleanup_addendum_test.go). Awaiting architect + PM three-sign. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7.0 KiB
7.0 KiB
NVMe Test Coverage — Deferred Inventory (B-tier)
Date: 2026-04-22 Status: LIVING — items move OUT when landed, marked CLOSED when fully in ACTIVE tracks Purpose: enumerate NVMe test coverage deliberately deferred past T2 closed, so nothing rots silently. Each item has (a) V2 correspondent where applicable, (b) assigned downstream track, (c) activation trigger.
Governance: adding to this file does NOT require Discovery Bridge — it's a downgrade (from "should do" to "will do later"). Removing an item (i.e., landing it) is governed by the track it's assigned to.
L1-B — Go subprocess component tests deferred
| ID | Test | V2 correspondent | Track | Activation trigger |
|---|---|---|---|---|
TestT2Process_NVMe_ReconnectLoop — attach/write/disconnect × 50 cycles on one workstation |
LANDED 2026-04-22 as TestT2V2Port_NVMe_Process_ReconnectLoop50 (QA parallel capacity, 14.9s PASS, goroutine-leak guard included). Ledger row PCDD-NVME-SESSION-RECONNECT-LOOP-001 queued ACTIVE. |
|||
| L1B-2 | TestT2Process_NVMe_FailoverMidWrite — kill primary mid-in-flight-write, verify replica takeover |
TestComponent_FailoverPromote | G8/T6 Failover Data Continuity | master-side "kill + promote" RPC exposed |
| L1B-3 | TestT2Process_NVMe_CrashRecovery — write/sync/crash/restart/read-consistent |
TestCP13_SyncAll_ReplicaRestart_Rejoin | T3 durability or T5 | durable backend (beyond memback) available |
TestT2Process_NVMe_DisconnectMidR2T — kernel-realistic cancel path |
LANDED 2026-04-22 as TestT2V2Port_NVMe_IO_DisconnectMidH2CDataStream (unit-scope, 0.6s PASS). Pins recvH2CData mid-loop EOF unwind. Ledger row PCDD-NVME-SESSION-DISCONNECT-MID-R2T-001 queued ACTIVE. |
T3 deferred scenarios (post-sw-commit additions; G4 canonical not blocked)
| ID | Scenario | V2 parity | Defer target |
|---|---|---|---|
| T3-DEF-1 | t3c-durable-crash-during-sync — kill mid-Sync (before Sync returns); pre-Sync acked all present, post-Sync-initiation may vanish |
V2 CP13 crash variants | Post-G4 hardening (G21 or follow-up batch) |
| T3-DEF-2 | t3c-durable-restart-loop — 10-cycle attach/write-distinct-pattern/crash/restart/verify with pattern integrity |
V2 t0-hosting-smoke 20-cycle | Post-G4 hardening (same) |
Latent-gap findings (from Tier A V2/V3 Contract Bridge Catalogue retrofill 2026-04-22)
| ID | Statement | Surfaced by | Defer target |
|---|---|---|---|
v2-v3-contract-bridge-catalogue.md §2.2.13 Tier A retrofill |
CATALOGUED 2026-04-22 as row C4-ISCSI-VPD-STATIC-FIELDS-HARDCODED (PORT-AS-IS LOCKED explicit). Closes T3-DEF-5 as discipline row; no regression needed | ||
| same | LANDED 2026-04-22 as t3_qa_session_cleanup_addendum_test.go (TestT3_NVMe_Session_CleanupOnClose_NoLeaksAcrossCycles + _CNTLIDAllocator, both PASS 0.78s). Pins C5-NVME-SESSION-STATE-CLEANUP-ON-CLOSE. |
||
| same | FILED 2026-04-22 as bugs/006_nvme_kato_timer_not_enforced.md (Medium, target G21 / post-T3). C1-NVME-SESSION-KATO reclassified VIOLATED with BUG-006 anchor. Closes T3-DEF-7 as inventory row → BUG queue |
Rationale: proposed post-sw-commit; shipped 4-scenario set covers canonical G4 pass-gate (INV-DURABLE-001) + 3 adjacent invariants. Not regressions; V2-parity hardening adjuncts.
| L1B-5 | TestT2Process_NVMe_MultiVolumeConcurrent — 3 volumes × 4 queues each | TestComponent_MultiReplica (adapted) | T3 perf | n/a |
L2-B — Scenario YAML + Go replay deferred
| ID | Scenario | V2 correspondent | Track | Activation trigger |
|---|---|---|---|---|
| L2B-1 | t2-nvme-crash-recovery.yaml |
crash (1 of 11) | T3 durability | L1B-3 lands first |
| L2B-2 | t2-nvme-ha-failover.yaml |
HA (4 of 11, collapsed) | G8/T6 | L1B-2 lands first |
| L2B-3 | t2-nvme-fault-disk-fill.yaml |
fault (1 of 3) | T3 | backend exposes "fail next N writes" hook |
| L2B-4 | t2-nvme-fault-network-drop.yaml |
fault (1 of 3) | T3 | fault-injection infrastructure |
| L2B-5 | t2-nvme-consistency-fsync.yaml |
consistency (1 of 2) | T3 or G22 final gate | L1B-3 or durable backend |
L3-B — m01 real-kernel runs deferred
| ID | Run | Track | Activation trigger |
|---|---|---|---|
| L3B-1 | iterate-m01-nvme-reconnect.sh — attach/detach loop 1 hr, watch for connection leak |
T3 perf | after L3-A proven green in CI |
| L3B-2 | iterate-m01-nvme-fio.sh — mixed read/write IOPS/throughput/latency measurement via fio |
T3 perf | perf baseline established for iSCSI side first |
| L3B-3 | iterate-m01-nvme-24h-soak.sh — 24 hr continuous mkfs/mount/I/O/umount loop |
post-T2 closed (monitoring) | T2B-NVMe-product-ready signed |
L4-B — Long-duration / endurance
| ID | Run | Track | Activation trigger |
|---|---|---|---|
| L4B-1 | 7-day endurance soak (bonnie++ style) | G22 Final Gate | all prior tracks green |
| L4B-2 | Chaos mesh — network partition + process crash + disk fill random mix | G22 Final Gate | fault-injection infra available |
Activation checklist (when item moves from B to ACTIVE)
Filing a new entry from B to implementation requires:
- Assigned owner (not "TBD")
- Concrete activation trigger satisfied (not "when convenient")
- Acceptance criteria copied from the B-row or expanded inline
- Ledger row provisional → queued for ACTIVE
- Updated here: row marked
→ [link to impl commit or test file], strike-through the text
Items that never satisfy their trigger during the V3 P15 lifecycle carry forward to the next phase's inventory (P16 or beyond).
Rotation audit (quarterly)
Once per quarter (or per phase gate), reviewer walks this file and asks for each row:
- Is the track still alive?
- Is the activation trigger still relevant?
- Has V3 architecture drifted such that the test is no longer meaningful?
Drop rows that fail any of the three; add rationale line in §Change log.
Change log
| Date | Change | Author |
|---|---|---|
| 2026-04-22 | Initial file with 5 L1-B + 5 L2-B + 3 L3-B + 2 L4-B | QA Owner (Batch 11c sign prep) |
| 2026-04-22 | L1B-1 ReconnectLoop landed early: file t2_v2port_nvme_reconnect_loop_test.go, 50 cycles PASS 14.9s, no goroutine leak |
QA Owner |
| 2026-04-22 | L1B-4 DisconnectMidH2CDataStream landed early: file t2_v2port_nvme_disconnect_mid_r2t_test.go, unit-scope 0.6s PASS; server log confirms recvH2CData EOF unwind path exercised |
QA Owner |
| 2026-04-22 | T3-DEF-5/6/7 processed during T3-end retrospective: DEF-5 catalogued (C4-ISCSI-VPD-STATIC-FIELDS-HARDCODED), DEF-6 test landed (t3_qa_session_cleanup_addendum_test.go), DEF-7 filed as BUG-006 (006_nvme_kato_timer_not_enforced.md). All three struck through above |
QA Owner |