Plugins: create the settings collection instead of waiting for it forever
01a8fecfixed the advice that led operators into this, but advice is not a guard: a stack still running PB_BOOTSTRAP=false gets no app_settings collection on upgrade, and the plugin panel sits at 503 while the retry loop reads a collection that does not exist. The fix is not to soften the reading. A missing collection stays "not ready" rather than "no plugins configured", because the alternative lets the first save write a fresh document over settings the server merely failed to find - the failure this whole line of work exists to prevent. Instead the server now fixes the cause: on a missing collection it creates that collection and reads again. Three pieces: bootstrap.EnsureCollection creates one named collection from the desired schema if absent, and nothing else. Deliberately narrower than Run - no field reconcile elsewhere, no super-admin - so it is safe to call on a deployment that turned the full bootstrap off. It creates the collection the server cannot start without, not the schema the operator declined. The store tells a missing collection apart from an outage. A 404 from a list means the collection itself is gone: an existing but empty one answers 200 with no items. That is tagged errNoCollection, which wraps errNotReady so every write is still refused, and IsMissingCollection narrows it. The distinction matters because the remedies are opposites - creating collections against a flaky database is exactly the wrong reflex, and a test pins that an outage does not trigger it. loadPlugins acts on the tag once, then re-reads. Failing to create is reported as the original read error rather than the repair's, so the log names the real problem. Six tests: the tag and its negative in internal/plugins, and three in internal/api against a fake PocketBase covering the collection being created exactly once, an existing collection not being recreated, and an outage creating nothing. Docs from01a8fecare corrected in the same pass - they said the panel would answer 503 forever, which is no longer true. They now say what still depends on the bootstrap (every other collection and field) and what does not (app_settings alone). go build, go vet and go test ./... pass; compose files still parse. Not verified: no Docker CLI here, so the repair has not been exercised against a real PocketBase, only the fake. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
01a8fecf40
commit
660af5736a
18 files changed
+331
-61
No files matched your search
@@ -192,17 +192,35 @@ func TestPBStoreUnreachableStaysUnloaded(t *testing.T) {
|
||||
}
|
||||
|
||||
// A missing collection (bootstrap has not run) is "not ready", never "empty" —
|
||||
// otherwise the first save would write a fresh document over nothing.
|
||||
// otherwise the first save would write a fresh document over nothing. It is also
|
||||
// tagged separately, because retrying alone can never resolve it.
|
||||
func TestPBStoreMissingCollectionIsNotReady(t *testing.T) {
|
||||
m := NewManager(newPBStore(t, &fakePB{missingCol: true}))
|
||||
if err := m.Load(context.Background()); !IsNotReady(err) {
|
||||
err := m.Load(context.Background())
|
||||
if !IsNotReady(err) {
|
||||
t.Fatalf("expected not-ready for a missing collection, got %v", err)
|
||||
}
|
||||
if !IsMissingCollection(err) {
|
||||
t.Fatalf("a missing collection must be distinguishable, got %v", err)
|
||||
}
|
||||
if m.Ready() {
|
||||
t.Fatal("manager must not be ready without its collection")
|
||||
}
|
||||
}
|
||||
|
||||
// A plain outage must NOT look like a missing collection: creating the
|
||||
// collection is not the remedy for a database that is merely unreachable.
|
||||
func TestPBStoreOutageIsNotAMissingCollection(t *testing.T) {
|
||||
m := NewManager(newPBStore(t, &fakePB{listErr: true}))
|
||||
err := m.Load(context.Background())
|
||||
if !IsNotReady(err) {
|
||||
t.Fatalf("expected not-ready, got %v", err)
|
||||
}
|
||||
if IsMissingCollection(err) {
|
||||
t.Fatalf("an outage must not be reported as a missing collection: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
// The legacy file is imported into PocketBase exactly once.
|
||||
func TestPBStoreLegacyImport(t *testing.T) {
|
||||
f := &fakePB{}
|
||||
|
||||
Reference in new issue
Block a user