Plugins: the global layer moves into the database, beside the other two
The integration cascade stored its top layer differently from the two below it: org (L2) and user (L3) plugin config lived in PocketBase, in a pluginSettings field, while the global (L1) layer sat in a plugins.json next to the binary. That split was accretion rather than design - the file was the whole store in the v1 MVP, and the per-tenant layers were later built on PocketBase and layered on top of it instead of replacing it. It also cost something real. plugins.json was a second state store with different durability from pb_data: its own volume, its own ownership, its own backup. Losing pb_data is unmissable; losing api_data was silent, which is how "every plugin comes back disabled after a redeploy" happened. L1 now lives in the app_settings collection - one record keyed "global", holding its settings in a pluginSettings field, the same mechanism and the same field name the layers below use. The documents still differ in shape, because only L1 carries enable state and the registration of external plugins, but the storage is no longer a special case. The Manager grows a Store seam (PocketBase in production, file for the import, memory for tests) and, more importantly, a loaded gate. Settings in a database mean the store can be unreachable at boot - a cold stack, or a service account still to be set from the panel. That must not read as "no plugins configured", or the first save would write emptiness over real settings. So until a read succeeds the Manager stays unloaded, every mutation is refused, /api/admin/plugins* answers 503, and a background retry backs off to two minutes. The same gate covers a document that will not parse: it is never replaced by one built from an empty map, which is a stronger guarantee than the .corrupt backup it replaces. Writing to a store also revealed a hole in the previous fix. Classifying a save failure as errPersist was left to each Store, and a store that returned a plain error would fall through to the "saved, but the plugin failed to start" branch and be reported as a 200 - the same silent-success bug through a different door. The Manager now classifies, whatever the Store returns; a test pins it. Upgrades are automatic: on the first boot that finds no settings in the database, an existing plugins.json is imported and renamed to plugins.json.migrated. The import is refused if the store is merely unreachable, or if the file does not parse, so a stale or broken file can never overwrite live settings. /data is still needed - the panel rewrites .env there when it retargets PocketBase - but plugin settings no longer depend on it. 21 tests in internal/plugins cover both stores, including the production path against a fake PocketBase: create-then-update of the singleton, round-trip across a restart, an outage that leaves settings intact, a missing collection reading as not-ready rather than empty, and the import running exactly once. go build, go vet and go test ./... pass. Schema changes are mirrored into scripts/setup-pocketbase.mjs as that file requires. Not verified: no Docker CLI here, so no image was built and the bootstrap of app_settings against a real PocketBase is untested outside the fake. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
d2803bbd93
commit
9bd5c523c4
@@ -173,6 +173,16 @@ var collectionsSchema = map[string][]fieldDef{
|
||||
fJSON("params", 10000),
|
||||
fAutodate("created", true, false),
|
||||
},
|
||||
// Server-wide settings as a single record, keyed "global". Today it holds
|
||||
// pluginSettings: the top (L1) layer of the integration cascade — every
|
||||
// plugin's enable state, its global config, and the registration of any
|
||||
// external HTTP plugin. The org (L2) and user (L3) layers keep their own
|
||||
// plugin config in a field of the same name below, so the global layer is
|
||||
// stored the way they are instead of in a file beside the binary.
|
||||
"app_settings": {
|
||||
fText("key", true),
|
||||
fJSON("pluginSettings", 200000),
|
||||
},
|
||||
// Tenants that users belong to.
|
||||
"organizations": {
|
||||
fText("name", true),
|
||||
@@ -213,6 +223,7 @@ var collectionsSchema = map[string][]fieldDef{
|
||||
// createOrder is the dependency order for creating missing collections.
|
||||
// "users" is PocketBase's built-in auth collection and is never created here.
|
||||
var createOrder = []string{
|
||||
"app_settings",
|
||||
"organizations",
|
||||
"cars",
|
||||
"service_records",
|
||||
@@ -230,6 +241,7 @@ var createOrder = []string{
|
||||
// reconcileOrder additionally includes "users" so its custom fields (role,
|
||||
// organization, preferences) are added to the built-in collection.
|
||||
var reconcileOrder = []string{
|
||||
"app_settings",
|
||||
"organizations",
|
||||
"users",
|
||||
"cars",
|
||||
@@ -247,6 +259,8 @@ var reconcileOrder = []string{
|
||||
|
||||
// indexes are extra SQL indexes applied at collection-create time.
|
||||
var indexes = map[string][]string{
|
||||
// One settings record per key, so the global singleton cannot be duplicated.
|
||||
"app_settings": {"CREATE UNIQUE INDEX `idx_app_settings_key` ON `app_settings` (`key`)"},
|
||||
"organizations": {"CREATE UNIQUE INDEX `idx_organizations_name` ON `organizations` (`name`)"},
|
||||
"fuel_entries": {"CREATE INDEX `idx_fuel_entries_car_km` ON `fuel_entries` (`car`, `km`)"},
|
||||
"charging_sessions": {"CREATE INDEX `idx_charging_sessions_car_km` ON `charging_sessions` (`car`, `km`)"},
|
||||
|
||||
Reference in New Issue
Block a user