tajniak81andClaude Opus 5
d4033dbcef
Two changes, both about showing what is actually known rather than a tidier version of it. The build date asked for a day. A car's build date is often only a year, or a month and a year - the VIN plate is stamped with a month, the papers carry a day, a grey import neither - so a field insisting on all three is answered either with an invented day or with nothing, and both throw away what the owner did know. The field now picks its own precision: a full date, a month and year, or a year, each with the control that suits it. A year is typed rather than picked, because a date picker that makes you walk back to 1998 is worse than four keystrokes. Stored as the ISO prefix - "2015", "2015-03", "2015-03-10" - which is ISO 8601 reduced precision, and printed back at exactly that precision. The three shapes sort and compare as strings in date order, which is why the prefix is stored rather than a date with a precision field beside it. The formatter takes the string apart rather than parsing it: "2015-03" read as a UTC instant and printed in local time hands back February west of Greenwich. Narrowing the precision keeps what is still true, so a day dropped from "2015-03-10" leaves "2015-03". Widening clears the field. That is the awkward half of the control and it is deliberate: there is nothing to widen a year with, and leaving "2015" behind an empty month box would store a date the screen is not showing. The column was free text with no validation at all, which was tolerable while only a date picker could write it and is not now that three shapes are legal. normalizeBuildDate parses rather than pattern-matches, so "2015-13" and "2015-02-31" are refused instead of stored as something no reader can print. The phone needed changing to avoid destroying this. It parsed buildDate with DateTime.tryParse, which returns null for "2015" - so a half-known date would have shown as a dash, and saving the car from the phone would have written "" back over it. It holds both date fields as the string they arrived as now, prints them at their own precision, and hands back anything it cannot set. Its picker still only makes full dates; a precision control there is a separate job. Separately: an empty cell of the service table had three different looks in one row. The dash under Notes was body-coloured, as though it were content; the one under File was 12px, having borrowed the size of the Download button that would otherwise be there; the one under Changed parts was muted at 14px. They are one constant now, muted at the row's own size, which is what Next date and Next km already did for a missing value. The Download link keeps its own styling - it is an action, not a value. Verified in a browser: a stored "2015-03" loads as month precision in a month picker, month to year narrows to "2015", year to day clears, "19x98abc" typed into the year box sanitises to "1998", saving sends buildDate:"1998" and the Information tab then reads "1998" - while a full first-registration date beside it still reads 06-08-2026. All five empty cells across the three columns now compute to the same size, colour and weight, with the filled ones unchanged. go vet and go test ./... pass with a new test over the three valid shapes and six rejects; flutter analyze is clean and 22 tests pass, one new, covering a half-known date in two date formats and the time zone that could shift it; npm run build is clean. Not verified: First registration still demands a full date. The same argument applies to it and the field is now a reusable component, but it was not asked for and is one line away. The web formatter's month-name paths - the DMY and MDY formats, which spell the month out - are covered only by the phone's mirror of the logic, the web app still having no test runner. A car created through the Toyota import bypasses the new validation; it only ever produces full dates, so nothing invalid gets in that way, but it is not guarded. Both apps need redeploying before any of this is visible. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
46 lines
1.5 KiB
Go
46 lines
1.5 KiB
Go
package api
|
|
|
|
import "testing"
|
|
|
|
// A build date is stored as an ISO 8601 reduced-precision date, because it is
|
|
// often only half known: the VIN plate carries a month, the papers a day, a grey
|
|
// import neither. The column is free text, so the shapes have to be checked here
|
|
// or a value no reader can print gets stored.
|
|
func TestNormalizeBuildDate(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
in string
|
|
want string
|
|
}{
|
|
{"", ""}, // not set at all
|
|
{"2015", "2015"}, // the year off the plate
|
|
{"2015-03", "2015-03"}, // year and month
|
|
{"2015-03-10", "2015-03-10"}, // the papers' own date
|
|
{" 2015-03 ", "2015-03"}, // trimmed, like every other text field
|
|
{"2024-02-29", "2024-02-29"}, // a leap day is a day
|
|
} {
|
|
got, err := normalizeBuildDate(tc.in)
|
|
if err != nil {
|
|
t.Errorf("normalizeBuildDate(%q): %v", tc.in, err)
|
|
continue
|
|
}
|
|
if got != tc.want {
|
|
t.Errorf("normalizeBuildDate(%q) = %q, want %q", tc.in, got, tc.want)
|
|
}
|
|
}
|
|
|
|
// Rejected rather than stored and puzzled over later. The last two are the
|
|
// ones a plain length check would have let through.
|
|
for _, bad := range []string{
|
|
"15", // two-digit year
|
|
"2015-3", // unpadded month
|
|
"2015/03/10", // not ISO
|
|
"March 2015", // words
|
|
"2015-13", // there is no thirteenth month
|
|
"2015-02-31", // there is no such day
|
|
} {
|
|
if got, err := normalizeBuildDate(bad); err == nil {
|
|
t.Errorf("normalizeBuildDate(%q) = %q, want an error", bad, got)
|
|
}
|
|
}
|
|
}
|