Mirror PilotVault's API Server layout and add the superadmin console,
plugin system, runtime PocketBase settings, and user/organization
management. The car domain (cars, service records, parts, sharing) is
carried over unchanged apart from the auth switch.
Layout: main.go -> cmd/server/main.go; module carcontrol/api ->
drivervault/apiserver. internal/api is split by concern (auth, users,
orgs, settings, plugins, status, health, respond).
Auth: replace the server-minted HS256 JWT and the sessions collection
with a PocketBase token proxy. /api/auth/login relays PocketBase's
{token, record}, and every protected request re-resolves that token
against PocketBase, so a role change or deletion takes effect at once
instead of waiting out a token. AUTH_SECRET is obsolete and internal/auth
is gone. Per-device session listing/revocation goes with it: PocketBase
tokens are stateless. Changing a password rotates the user's token key,
which invalidates every token already issued.
Roles: add superadmin alongside user/admin, plus an organizations
collection and users.organization. Admins are scoped to their own
organization; superadmins span all of them. Guards prevent changing your
own role, deleting your own account, an admin touching a superadmin, and
deleting an organization that still has members.
Plugins: new internal/plugins package with one contract over two kinds --
builtin (compiled in) and external (any HTTP service, registered at
runtime with no rebuild). State persists to plugins.json; secrets are
masked on read and preserved when saved back at the mask.
PocketBase settings: /api/admin/pb-config applies a new connection at
runtime and persists it to .env. It deliberately does not require a
working service account, so a wrong or unreachable connection can still
be fixed from the panel.
Panel: rebuilt as the superadmin console -- login gate, status, users,
organizations, PocketBase, plugins, and the endpoint reference.
Clients: update the Web App and Phone App for the PocketBase token shape,
the move of user management to /api/users ({users}/{user} envelopes, with
password resets folded into PATCH), and the removal of sessions. Both now
mirror the server's real guards rather than the old last-admin rule, and
parse PocketBase's field-level error shape.
Config: modern POCKETBASE_*/API_ADDR names with legacy PB_*/PORT
fallbacks, so existing .env files keep working. Also fixes /api/status
probing the Web App on 8090 instead of DriverVault's 5173.
Run scripts/setup-pocketbase.mjs to add the organizations collection and
grow users.role; every client must log in once more.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
189 lines
4.9 KiB
Go
189 lines
4.9 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"net/url"
|
|
|
|
"drivervault/apiserver/internal/models"
|
|
)
|
|
|
|
func (s *Server) listServiceRecords(w http.ResponseWriter, r *http.Request) {
|
|
// Records are always scoped to a single car so access can be enforced; a
|
|
// cross-car listing would leak other users' data.
|
|
carID := r.URL.Query().Get("car")
|
|
if !s.requireCarAccess(w, r, carID, accessRead) {
|
|
return
|
|
}
|
|
q := url.Values{}
|
|
q.Set("sort", "-date") // most-recent service first
|
|
q.Set("perPage", "500")
|
|
q.Set("filter", fmt.Sprintf("car='%s'", carID))
|
|
s.respondServiceList(w, r, q)
|
|
}
|
|
|
|
// listCarServiceRecords serves GET /api/cars/{id}/service-records.
|
|
func (s *Server) listCarServiceRecords(w http.ResponseWriter, r *http.Request) {
|
|
carID := r.PathValue("id")
|
|
if !s.requireCarAccess(w, r, carID, accessRead) {
|
|
return
|
|
}
|
|
q := url.Values{}
|
|
q.Set("sort", "-date")
|
|
q.Set("perPage", "500")
|
|
q.Set("filter", fmt.Sprintf("car='%s'", carID))
|
|
s.respondServiceList(w, r, q)
|
|
}
|
|
|
|
func (s *Server) respondServiceList(w http.ResponseWriter, r *http.Request, q url.Values) {
|
|
res, err := s.pb.List(r.Context(), colServices, q)
|
|
if err != nil {
|
|
writePBError(w, err)
|
|
return
|
|
}
|
|
var recs []serviceRecord
|
|
if err := json.Unmarshal(res.Items, &recs); err != nil {
|
|
writeError(w, http.StatusInternalServerError, err.Error())
|
|
return
|
|
}
|
|
|
|
cars := newCarCache(s)
|
|
out := make([]models.ServiceRecord, 0, len(recs))
|
|
for _, rec := range recs {
|
|
m := rec.toModel()
|
|
if car, err := cars.get(r.Context(), m.Car); err == nil {
|
|
m.ComputeDerived(car)
|
|
}
|
|
out = append(out, m)
|
|
}
|
|
writeJSON(w, http.StatusOK, out)
|
|
}
|
|
|
|
func (s *Server) getServiceRecord(w http.ResponseWriter, r *http.Request) {
|
|
var rec serviceRecord
|
|
if err := s.pb.GetOne(r.Context(), colServices, r.PathValue("id"), &rec); err != nil {
|
|
writePBError(w, err)
|
|
return
|
|
}
|
|
m := rec.toModel()
|
|
if !s.requireCarAccess(w, r, m.Car, accessRead) {
|
|
return
|
|
}
|
|
if car, err := s.carModel(r.Context(), m.Car); err == nil {
|
|
m.ComputeDerived(car)
|
|
}
|
|
writeJSON(w, http.StatusOK, m)
|
|
}
|
|
|
|
func (s *Server) createServiceRecord(w http.ResponseWriter, r *http.Request) {
|
|
var in models.ServiceRecord
|
|
if err := decodeJSON(r, &in); err != nil {
|
|
writeError(w, http.StatusBadRequest, err.Error())
|
|
return
|
|
}
|
|
if in.Car == "" {
|
|
writeError(w, http.StatusBadRequest, "car is required")
|
|
return
|
|
}
|
|
if in.Date.IsZero() {
|
|
writeError(w, http.StatusBadRequest, "date is required")
|
|
return
|
|
}
|
|
if !s.requireCarAccess(w, r, in.Car, accessWrite) {
|
|
return
|
|
}
|
|
|
|
var rec serviceRecord
|
|
if err := s.pb.Create(r.Context(), colServices, servicePayload(in), &rec); err != nil {
|
|
writePBError(w, err)
|
|
return
|
|
}
|
|
m := rec.toModel()
|
|
if car, err := s.carModel(r.Context(), m.Car); err == nil {
|
|
m.ComputeDerived(car)
|
|
}
|
|
writeJSON(w, http.StatusCreated, m)
|
|
}
|
|
|
|
func (s *Server) updateServiceRecord(w http.ResponseWriter, r *http.Request) {
|
|
var in models.ServiceRecord
|
|
if err := decodeJSON(r, &in); err != nil {
|
|
writeError(w, http.StatusBadRequest, err.Error())
|
|
return
|
|
}
|
|
// Enforce write access via the record's existing parent car (the body's
|
|
// car field, if any, can't be used to escape into another user's car).
|
|
var existing serviceRecord
|
|
if err := s.pb.GetOne(r.Context(), colServices, r.PathValue("id"), &existing); err != nil {
|
|
writePBError(w, err)
|
|
return
|
|
}
|
|
if !s.requireCarAccess(w, r, existing.Car, accessWrite) {
|
|
return
|
|
}
|
|
var rec serviceRecord
|
|
if err := s.pb.Update(r.Context(), colServices, r.PathValue("id"), servicePayload(in), &rec); err != nil {
|
|
writePBError(w, err)
|
|
return
|
|
}
|
|
m := rec.toModel()
|
|
if car, err := s.carModel(r.Context(), m.Car); err == nil {
|
|
m.ComputeDerived(car)
|
|
}
|
|
writeJSON(w, http.StatusOK, m)
|
|
}
|
|
|
|
func (s *Server) deleteServiceRecord(w http.ResponseWriter, r *http.Request) {
|
|
var existing serviceRecord
|
|
if err := s.pb.GetOne(r.Context(), colServices, r.PathValue("id"), &existing); err != nil {
|
|
writePBError(w, err)
|
|
return
|
|
}
|
|
if !s.requireCarAccess(w, r, existing.Car, accessWrite) {
|
|
return
|
|
}
|
|
if err := s.pb.Delete(r.Context(), colServices, r.PathValue("id")); err != nil {
|
|
writePBError(w, err)
|
|
return
|
|
}
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|
|
|
|
// carModel fetches a single car as a domain model.
|
|
func (s *Server) carModel(ctx context.Context, id string) (*models.Car, error) {
|
|
if id == "" {
|
|
return nil, fmt.Errorf("empty car id")
|
|
}
|
|
var rec carRecord
|
|
if err := s.pb.GetOne(ctx, colCars, id, &rec); err != nil {
|
|
return nil, err
|
|
}
|
|
m := rec.toModel()
|
|
return &m, nil
|
|
}
|
|
|
|
// carCache memoizes car lookups within a single list request to avoid N+1
|
|
// fetches when many service records share the same car.
|
|
type carCache struct {
|
|
s *Server
|
|
cache map[string]*models.Car
|
|
}
|
|
|
|
func newCarCache(s *Server) *carCache {
|
|
return &carCache{s: s, cache: map[string]*models.Car{}}
|
|
}
|
|
|
|
func (c *carCache) get(ctx context.Context, id string) (*models.Car, error) {
|
|
if car, ok := c.cache[id]; ok {
|
|
return car, nil
|
|
}
|
|
car, err := c.s.carModel(ctx, id)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
c.cache[id] = car
|
|
return car, nil
|
|
}
|