Phase 1: accounts and sessions
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s

Implements PLAN.md Phase 1. A client can now register, log in, manage its
devices and set its profile; an operator can create accounts and flip the
runtime switches. There are still no rooms and no real /sync.

userapi: accounts, argon2id passwords in PHC format, devices, access and
refresh tokens stored as SHA-256 hashes, account data and the admin flag.
Its storage interface is storage.UserStore, implemented once in sqlstore
with `?` placeholders; the postgres driver supplies a rebind function and
unique-violation recognition rather than keeping a second copy of thirty
statements. Timestamps in these tables are int64 milliseconds, the unit the
Client-Server API uses on the wire.

Client-Server API: register (user-interactive auth with m.login.dummy and
optional registration tokens), register/available, token validity, login
with m.login.password, logout, logout/all, refresh, account/whoami,
capabilities, devices/* with password-gated deletion, profile/*, global and
per-room account data.

GET /sync is a deliberate placeholder: it answers a valid token with an
empty but well-formed response and refuses a revoked one. Phase 1 has no
rooms, so that is the whole truth, and it is what makes session revocation
observable. Phase 4 replaces it with the syncapi.

Auth middleware resolves a bearer token (header or the legacy query
parameter) to a device and user, answering an expired token with the soft
logout the spec asks for. Rate limiting is a token bucket per endpoint class
keyed on the client address, returning M_LIMIT_EXCEEDED with retry_after_ms.

adminapi v1 under /_warp/admin/v1: admin-only auth via a normal Matrix
token, GET/PUT /federation and /registration driving internal/settings and
reporting a config-pinned switch as a 409, GET/POST /users, GET /stats.

warp create-account [--admin] creates the first account straight in the
database, so a new install with registration off has a way in.

Complement is wired up for the federation=off profile: an image meeting its
contract, an entrypoint that configures Warp entirely from WARP_*
variables, and a runner that builds, clones and executes the target set
(TestRegistration, TestLogin, TestDeviceManagement). It has not been run
yet -- there is no container runtime on the development machine -- so the
three tests' assertions were read from the Complement sources and pinned as
httptest tests instead, and CI gained a job that runs the real thing.

Also fixes a .gitignore bug from Phase 0: the unanchored `warp` pattern,
meant for the built binary, also matched the directory server/cmd/warp and
silently excluded the entire command package from the repository. The
binary patterns are now anchored to the repository root, and cmd/warp is
committed for the first time.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
tajniak81andClaude Opus 5 committed 2026-10-15 18:18:37 +02:00
1 parent b4fb60a8ab
commit 6004bb01de
68 files changed
+9729 -66

No files matched your search

@@ -0,0 +1,167 @@
package clientapi_test
import (
"net/http"
"strings"
"testing"
)
// accountDataPath builds the global account data path for a user.
func accountDataPath(userID, dataType string) string {
return "/_matrix/client/v3/user/" + userID + "/account_data/" + dataType
}
// roomAccountDataPath builds the per-room variant.
func roomAccountDataPath(userID, roomID, dataType string) string {
return "/_matrix/client/v3/user/" + userID + "/rooms/" + roomID + "/account_data/" + dataType
}
func TestAccountDataRoundTrip(t *testing.T) {
ts := newTestServer(t, nil)
acc := ts.register("alice", "superuser")
path := accountDataPath(acc.UserID, "test.key")
expectError(t, ts.get(path, acc.AccessToken), http.StatusNotFound, "M_NOT_FOUND")
rec := ts.do(request{method: http.MethodPut, path: path, token: acc.AccessToken,
body: map[string]any{"value": "first"}})
expectStatus(t, rec, http.StatusOK)
rec = ts.get(path, acc.AccessToken)
expectStatus(t, rec, http.StatusOK)
if got := jsonBody(t, rec)["value"]; got != "first" {
t.Errorf("value = %v, want first", got)
}
rec = ts.do(request{method: http.MethodPut, path: path, token: acc.AccessToken,
body: map[string]any{"value": "second"}})
expectStatus(t, rec, http.StatusOK)
rec = ts.get(path, acc.AccessToken)
if got := jsonBody(t, rec)["value"]; got != "second" {
t.Errorf("value after overwriting = %v, want second", got)
}
}
func TestRoomAccountDataRoundTrip(t *testing.T) {
ts := newTestServer(t, nil)
acc := ts.register("alice", "superuser")
const roomID = "!room:warp.example"
path := roomAccountDataPath(acc.UserID, roomID, "test.key")
rec := ts.do(request{method: http.MethodPut, path: path, token: acc.AccessToken,
body: map[string]any{"value": "room first"}})
expectStatus(t, rec, http.StatusOK)
rec = ts.get(path, acc.AccessToken)
expectStatus(t, rec, http.StatusOK)
if got := jsonBody(t, rec)["value"]; got != "room first" {
t.Errorf("value = %v, want %q", got, "room first")
}
// Room account data is its own key space: the global entry of the same
// type is untouched.
expectError(t, ts.get(accountDataPath(acc.UserID, "test.key"), acc.AccessToken),
http.StatusNotFound, "M_NOT_FOUND")
}
func TestAccountDataIsPrivate(t *testing.T) {
ts := newTestServer(t, nil)
alice := ts.register("alice", "superuser")
bob := ts.register("bob", "bobspassword")
rec := ts.do(request{method: http.MethodPut, path: accountDataPath(alice.UserID, "test.key"),
token: alice.AccessToken, body: map[string]any{"value": "secret"}})
expectStatus(t, rec, http.StatusOK)
// Not even an admin: this is the user's own client configuration, not
// something the server operator has business reading.
ts.makeAdmin(bob)
for _, method := range []string{http.MethodGet, http.MethodPut} {
rec := ts.do(request{method: method, path: accountDataPath(alice.UserID, "test.key"),
token: bob.AccessToken, body: map[string]any{"value": "nosy"}})
expectError(t, rec, http.StatusForbidden, "M_FORBIDDEN")
}
}
func TestAccountDataRequiresAToken(t *testing.T) {
ts := newTestServer(t, nil)
acc := ts.register("alice", "superuser")
expectError(t, ts.get(accountDataPath(acc.UserID, "test.key"), ""),
http.StatusUnauthorized, "M_MISSING_TOKEN")
}
// TestAccountDataRejectsFullyRead covers the one type the spec reserves: it
// has to travel with a read receipt, so writing it directly is refused.
func TestAccountDataRejectsFullyRead(t *testing.T) {
ts := newTestServer(t, nil)
acc := ts.register("alice", "superuser")
rec := ts.do(request{method: http.MethodPut,
path: roomAccountDataPath(acc.UserID, "!room:warp.example", "m.fully_read"),
token: acc.AccessToken, body: map[string]any{"event_id": "$x"}})
expectError(t, rec, http.StatusBadRequest, "M_BAD_JSON")
}
func TestAccountDataRejectsNonObjects(t *testing.T) {
ts := newTestServer(t, nil)
acc := ts.register("alice", "superuser")
path := accountDataPath(acc.UserID, "test.key")
for name, body := range map[string]any{
"an array": []any{1, 2, 3},
"a string": "just a string",
"a number": 42,
"a boolean": true,
} {
t.Run(name, func(t *testing.T) {
rec := ts.do(request{method: http.MethodPut, path: path, token: acc.AccessToken, body: body})
expectError(t, rec, http.StatusBadRequest, "M_BAD_JSON")
})
}
}
func TestAccountDataRejectsOversizedContent(t *testing.T) {
ts := newTestServer(t, nil)
acc := ts.register("alice", "superuser")
rec := ts.do(request{method: http.MethodPut, path: accountDataPath(acc.UserID, "test.key"),
token: acc.AccessToken, body: map[string]any{"value": strings.Repeat("x", 70*1024)}})
expectError(t, rec, http.StatusBadRequest, "M_TOO_LARGE")
}
func TestRoomAccountDataRejectsMalformedRoomID(t *testing.T) {
ts := newTestServer(t, nil)
acc := ts.register("alice", "superuser")
rec := ts.do(request{method: http.MethodPut,
path: roomAccountDataPath(acc.UserID, "not-a-room-id", "test.key"),
token: acc.AccessToken, body: map[string]any{"value": "x"}})
expectError(t, rec, http.StatusBadRequest, "M_INVALID_PARAM")
}
// TestAccountDataIsReturnedVerbatim matters because account data is the
// client's own JSON: a server that re-serialises it can reorder keys or
// change number formatting under a client that is comparing bytes.
func TestAccountDataIsReturnedVerbatim(t *testing.T) {
ts := newTestServer(t, nil)
acc := ts.register("alice", "superuser")
path := accountDataPath(acc.UserID, "test.key")
const content = `{"b":1,"a":{"nested":[1,2,3]},"big":10000000000000001}`
rec := ts.do(request{method: http.MethodPut, path: path, token: acc.AccessToken,
body: rawJSON(content)})
expectStatus(t, rec, http.StatusOK)
rec = ts.get(path, acc.AccessToken)
expectStatus(t, rec, http.StatusOK)
if got := rec.Body.String(); got != content {
t.Errorf("account data came back as %s, want %s", got, content)
}
}
// rawJSON is marshalled as-is, so a test can send bytes of its choosing.
type rawJSON string
func (r rawJSON) MarshalJSON() ([]byte, error) { return []byte(r), nil }