Files
Warp/server/internal/storage/media_test.go
T
tajniak81andClaude Opus 5.5 92836f8dcd
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Phase 6: media
Implements PLAN.md Phase 6: the media repository. Clients upload files,
reserve an mxc:// URI and upload to it later, download and ask for
thumbnails, all through the authenticated media endpoints of Matrix 1.11;
other servers download this server's media through the federation media
endpoints, and media uploaded elsewhere is fetched over federation on
first use and kept.

internal/mediaapi is the component. Content goes into a BlobStore named
by its SHA-256, so the same file uploaded twice is stored once and the
hash doubles as the ETag; the metadata that maps an mxc:// URI onto a
blob is in media_repository and media_thumbnails. The local-filesystem
store writes to a temporary file and renames it into place once hashed,
so nothing ever refers to half a file. A storage driver can bring its own
store through storage.BlobProvider, which is where PocketBase's
filesystem abstraction (local or S3) plugs in with Phase 10.

Reserved uploads belong to the user who made them, take one upload,
lapse after a day, and are capped per user; a download of one waits for
its content, woken in memory the moment it arrives, for as long as
timeout_ms allows.

Thumbnails come from a fixed set of configured sizes, so a thousand
requested sizes cannot mean a thousand resizes. They are made on first
request and kept, never enlarge, honour a JPEG's EXIF orientation, and
point at the original when it already fits. The pixel count is checked
from the header before anything is decoded, at most four resizes run at
once, and concurrent requests for the same thumbnail share one.

Remote media is fetched through the signed client: the multipart/mixed
answer of Matrix 1.11, with a fallback to the legacy download endpoint
for servers that answer M_UNRECOGNIZED, and Location redirects followed
by a dialer that refuses loopback, private and link-local addresses.
Concurrent requests share one fetch, detached from the request that
started it. With federation off nothing is fetched, and what was cached
before is still served.

Downloads carry a sandboxing CSP, nosniff, inline Content-Disposition
only for the types the spec lists as safe, and private immutable caching.
The unauthenticated legacy download endpoints are off by default behind
media.legacy_unauthenticated_downloads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 21:26:49 +02:00

226 lines
7.2 KiB
Go

package storage_test
import (
"bytes"
"crypto/sha256"
"database/sql"
"encoding/hex"
"errors"
"io"
"os"
"strings"
"testing"
"github.com/dariuszjaniak/warp/server/internal/storage"
"github.com/dariuszjaniak/warp/server/internal/storage/filestore"
)
// migratedMediaDB opens a driver with the media tables empty.
func migratedMediaDB(t *testing.T, driver string) storage.Database {
t.Helper()
db := openTestDB(t, driver)
if err := db.Migrate(t.Context()); err != nil {
t.Fatalf("Migrate: %v", err)
}
if driver == storage.DriverPostgres {
pool, err := sql.Open("pgx", os.Getenv("WARP_TEST_POSTGRES_DSN"))
if err != nil {
t.Fatalf("open postgres to reset the media tables: %v", err)
}
defer func() { _ = pool.Close() }()
if _, err := pool.ExecContext(t.Context(), `TRUNCATE media_repository, media_thumbnails`); err != nil {
t.Fatalf("reset the media tables: %v", err)
}
}
return db
}
func TestMediaUploadAndRead(t *testing.T) {
for _, driver := range testDrivers {
t.Run(driver, func(t *testing.T) {
ctx := t.Context()
media := migratedMediaDB(t, driver).Media()
m := storage.Media{
Origin: "warp.example", MediaID: "abc", ContentType: "image/png",
UploadName: "cat.png", Size: 42, SHA256: strings.Repeat("a", 64),
UserID: "@alice:warp.example", CreatedAtMS: 1000,
}
if err := media.CreateMedia(ctx, m); err != nil {
t.Fatalf("CreateMedia: %v", err)
}
if err := media.CreateMedia(ctx, m); !errors.Is(err, storage.ErrMediaExists) {
t.Fatalf("CreateMedia twice = %v, want ErrMediaExists", err)
}
got, err := media.Media(ctx, "warp.example", "abc")
if err != nil {
t.Fatalf("Media: %v", err)
}
if got != m {
t.Errorf("Media = %+v, want %+v", got, m)
}
if _, err := media.Media(ctx, "other.example", "abc"); !errors.Is(err, storage.ErrNoSuchMedia) {
t.Errorf("Media of another origin = %v, want ErrNoSuchMedia", err)
}
// Content, once stored, does not change.
err = media.CompleteUpload(ctx, "warp.example", "abc", storage.MediaContent{SHA256: strings.Repeat("b", 64)})
if !errors.Is(err, storage.ErrMediaUploaded) {
t.Errorf("CompleteUpload of uploaded media = %v, want ErrMediaUploaded", err)
}
err = media.CompleteUpload(ctx, "warp.example", "nope", storage.MediaContent{})
if !errors.Is(err, storage.ErrNoSuchMedia) {
t.Errorf("CompleteUpload of unknown media = %v, want ErrNoSuchMedia", err)
}
})
}
}
func TestMediaPendingUploads(t *testing.T) {
for _, driver := range testDrivers {
t.Run(driver, func(t *testing.T) {
ctx := t.Context()
media := migratedMediaDB(t, driver).Media()
const alice = "@alice:warp.example"
for _, p := range []struct {
id string
expires int64
}{{"p1", 5000}, {"p2", 5000}, {"old", 1500}} {
if err := media.CreateMedia(ctx, storage.Media{
Origin: "warp.example", MediaID: p.id, UserID: alice,
CreatedAtMS: 1000, Pending: true, ExpiresAtMS: p.expires,
}); err != nil {
t.Fatalf("CreateMedia(%s): %v", p.id, err)
}
}
n, err := media.PendingUploads(ctx, alice, 2000)
if err != nil {
t.Fatalf("PendingUploads: %v", err)
}
if n != 2 {
t.Errorf("PendingUploads = %d, want 2 (one has expired)", n)
}
content := storage.MediaContent{
ContentType: "text/plain", UploadName: "a.txt", Size: 3, SHA256: strings.Repeat("c", 64),
}
if err := media.CompleteUpload(ctx, "warp.example", "p1", content); err != nil {
t.Fatalf("CompleteUpload: %v", err)
}
got, err := media.Media(ctx, "warp.example", "p1")
if err != nil {
t.Fatalf("Media: %v", err)
}
if got.Pending || got.ExpiresAtMS != 0 || got.SHA256 != content.SHA256 || got.Size != 3 {
t.Errorf("completed media = %+v", got)
}
if err := media.CompleteUpload(ctx, "warp.example", "p1", content); !errors.Is(err, storage.ErrMediaUploaded) {
t.Errorf("second CompleteUpload = %v, want ErrMediaUploaded", err)
}
deleted, err := media.DeleteExpiredUploads(ctx, 2000)
if err != nil {
t.Fatalf("DeleteExpiredUploads: %v", err)
}
if deleted != 1 {
t.Errorf("DeleteExpiredUploads = %d, want 1", deleted)
}
if _, err := media.Media(ctx, "warp.example", "old"); !errors.Is(err, storage.ErrNoSuchMedia) {
t.Errorf("expired upload still there: %v", err)
}
if _, err := media.Media(ctx, "warp.example", "p1"); err != nil {
t.Errorf("a completed upload was swept: %v", err)
}
})
}
}
func TestMediaThumbnails(t *testing.T) {
for _, driver := range testDrivers {
t.Run(driver, func(t *testing.T) {
ctx := t.Context()
media := migratedMediaDB(t, driver).Media()
th := storage.Thumbnail{
Origin: "remote.example", MediaID: "xyz", Width: 96, Height: 96, Method: "crop",
ContentType: "image/jpeg", Size: 10, SHA256: strings.Repeat("d", 64), CreatedAtMS: 7,
}
if _, err := media.Thumbnail(ctx, "remote.example", "xyz", 96, 96, "crop"); !errors.Is(err, storage.ErrNoSuchMedia) {
t.Fatalf("Thumbnail before storing = %v, want ErrNoSuchMedia", err)
}
if err := media.StoreThumbnail(ctx, th); err != nil {
t.Fatalf("StoreThumbnail: %v", err)
}
th.SHA256, th.Size = strings.Repeat("e", 64), 11
if err := media.StoreThumbnail(ctx, th); err != nil {
t.Fatalf("StoreThumbnail again: %v", err)
}
got, err := media.Thumbnail(ctx, "remote.example", "xyz", 96, 96, "crop")
if err != nil {
t.Fatalf("Thumbnail: %v", err)
}
if got != th {
t.Errorf("Thumbnail = %+v, want %+v", got, th)
}
if _, err := media.Thumbnail(ctx, "remote.example", "xyz", 96, 96, "scale"); !errors.Is(err, storage.ErrNoSuchMedia) {
t.Errorf("Thumbnail of another method = %v, want ErrNoSuchMedia", err)
}
})
}
}
func TestFileStore(t *testing.T) {
ctx := t.Context()
store, err := filestore.New(t.TempDir())
if err != nil {
t.Fatal(err)
}
content := []byte("hello, media")
sum := sha256.Sum256(content)
info, err := store.Put(ctx, bytes.NewReader(content), 100)
if err != nil {
t.Fatalf("Put: %v", err)
}
if info.SHA256 != hex.EncodeToString(sum[:]) || info.Size != int64(len(content)) {
t.Fatalf("Put = %+v", info)
}
// The same content again is the same blob.
again, err := store.Put(ctx, bytes.NewReader(content), 100)
if err != nil || again != info {
t.Fatalf("Put twice = %+v, %v", again, err)
}
f, err := store.Open(ctx, info.SHA256)
if err != nil {
t.Fatalf("Open: %v", err)
}
got, _ := io.ReadAll(f)
_ = f.Close()
if !bytes.Equal(got, content) {
t.Errorf("Open read %q", got)
}
if _, err := store.Put(ctx, bytes.NewReader(content), 5); !errors.Is(err, storage.ErrBlobTooLarge) {
t.Errorf("Put past the limit = %v, want ErrBlobTooLarge", err)
}
// A hash that is not one cannot name a file, inside the store or out.
for _, bad := range []string{"../../etc/passwd", strings.Repeat("G", 64), ""} {
if _, err := store.Open(ctx, bad); !errors.Is(err, storage.ErrNoSuchBlob) {
t.Errorf("Open(%q) = %v, want ErrNoSuchBlob", bad, err)
}
}
if err := store.Delete(ctx, info.SHA256); err != nil {
t.Fatalf("Delete: %v", err)
}
if _, err := store.Open(ctx, info.SHA256); !errors.Is(err, storage.ErrNoSuchBlob) {
t.Errorf("Open after Delete = %v, want ErrNoSuchBlob", err)
}
if err := store.Delete(ctx, info.SHA256); err != nil {
t.Errorf("Delete twice = %v", err)
}
}