Files
Warp/server/internal/clientapi/profile.go
T
tajniak81andClaude Opus 5 6004bb01de
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Phase 1: accounts and sessions
Implements PLAN.md Phase 1. A client can now register, log in, manage its
devices and set its profile; an operator can create accounts and flip the
runtime switches. There are still no rooms and no real /sync.

userapi: accounts, argon2id passwords in PHC format, devices, access and
refresh tokens stored as SHA-256 hashes, account data and the admin flag.
Its storage interface is storage.UserStore, implemented once in sqlstore
with `?` placeholders; the postgres driver supplies a rebind function and
unique-violation recognition rather than keeping a second copy of thirty
statements. Timestamps in these tables are int64 milliseconds, the unit the
Client-Server API uses on the wire.

Client-Server API: register (user-interactive auth with m.login.dummy and
optional registration tokens), register/available, token validity, login
with m.login.password, logout, logout/all, refresh, account/whoami,
capabilities, devices/* with password-gated deletion, profile/*, global and
per-room account data.

GET /sync is a deliberate placeholder: it answers a valid token with an
empty but well-formed response and refuses a revoked one. Phase 1 has no
rooms, so that is the whole truth, and it is what makes session revocation
observable. Phase 4 replaces it with the syncapi.

Auth middleware resolves a bearer token (header or the legacy query
parameter) to a device and user, answering an expired token with the soft
logout the spec asks for. Rate limiting is a token bucket per endpoint class
keyed on the client address, returning M_LIMIT_EXCEEDED with retry_after_ms.

adminapi v1 under /_warp/admin/v1: admin-only auth via a normal Matrix
token, GET/PUT /federation and /registration driving internal/settings and
reporting a config-pinned switch as a 409, GET/POST /users, GET /stats.

warp create-account [--admin] creates the first account straight in the
database, so a new install with registration off has a way in.

Complement is wired up for the federation=off profile: an image meeting its
contract, an entrypoint that configures Warp entirely from WARP_*
variables, and a runner that builds, clones and executes the target set
(TestRegistration, TestLogin, TestDeviceManagement). It has not been run
yet -- there is no container runtime on the development machine -- so the
three tests' assertions were read from the Complement sources and pinned as
httptest tests instead, and CI gained a job that runs the real thing.

Also fixes a .gitignore bug from Phase 0: the unanchored `warp` pattern,
meant for the built binary, also matched the directory server/cmd/warp and
silently excluded the entire command package from the repository. The
binary patterns are now anchored to the repository root, and cmd/warp is
committed for the first time.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-10-15 18:18:37 +02:00

158 lines
5.3 KiB
Go

package clientapi
import (
"errors"
"net/http"
"github.com/dariuszjaniak/warp/server/internal/federation"
"github.com/dariuszjaniak/warp/server/internal/httputil"
"github.com/dariuszjaniak/warp/server/internal/storage"
"github.com/dariuszjaniak/warp/server/internal/userapi"
)
// profileResponse is the body of GET /profile/{userId}. Both fields are
// omitted when unset: the spec distinguishes "no display name" from an empty
// one, and clients fall back to the localpart for the former.
type profileResponse struct {
DisplayName string `json:"displayname,omitempty"`
AvatarURL string `json:"avatar_url,omitempty"`
}
// MaxDisplayNameLength and MaxAvatarURLLength bound the profile fields.
// The spec sets no limit; these are what keeps a member list from carrying a
// megabyte of display name per user once rooms exist.
const (
MaxDisplayNameLength = 256
MaxAvatarURLLength = 1024
)
// handleGetProfile implements GET /_matrix/client/v3/profile/{userId}.
func (c *ClientAPI) handleGetProfile(w http.ResponseWriter, r *http.Request) error {
account, err := c.lookupProfile(r)
if err != nil {
return err
}
httputil.WriteJSON(w, http.StatusOK, profileResponse{
DisplayName: account.DisplayName,
AvatarURL: account.AvatarURL,
})
return nil
}
// handleGetDisplayName implements GET /profile/{userId}/displayname.
func (c *ClientAPI) handleGetDisplayName(w http.ResponseWriter, r *http.Request) error {
account, err := c.lookupProfile(r)
if err != nil {
return err
}
httputil.WriteJSON(w, http.StatusOK, profileResponse{DisplayName: account.DisplayName})
return nil
}
// handleGetAvatarURL implements GET /profile/{userId}/avatar_url.
func (c *ClientAPI) handleGetAvatarURL(w http.ResponseWriter, r *http.Request) error {
account, err := c.lookupProfile(r)
if err != nil {
return err
}
httputil.WriteJSON(w, http.StatusOK, profileResponse{AvatarURL: account.AvatarURL})
return nil
}
// lookupProfile resolves the user ID in the path to a local account.
//
// A user ID on another server is where the federation switch shows up in the
// Client-Server API: with federation off there is no way to answer and the
// spec's M_FORBIDDEN is the honest reply, as PLAN.md section 3 requires.
// With federation on, the lookup itself is Phase 5 work.
func (c *ClientAPI) lookupProfile(r *http.Request) (storage.Account, error) {
userID := r.PathValue("userID")
localpart, err := c.users.ParseLocalUserID(userID)
switch {
case errors.Is(err, userapi.ErrForeignServer):
if !c.federation.Enabled() {
return storage.Account{}, federation.RejectClientRequest(
"looking up the profile of a user on another server")
}
return storage.Account{}, httputil.NotFound(
"Profiles of users on other servers cannot be fetched yet")
case err != nil:
return storage.Account{}, httputil.InvalidParam("%s is not a valid user ID", userID)
}
account, err := c.users.Account(r.Context(), localpart)
switch {
case errors.Is(err, userapi.ErrNoSuchUser):
return storage.Account{}, httputil.NotFound("Profile not found")
case err != nil:
return storage.Account{}, err
}
return account, nil
}
// putDisplayNameRequest is the body of PUT /profile/{userId}/displayname.
type putDisplayNameRequest struct {
DisplayName string `json:"displayname"`
}
// putAvatarURLRequest is the body of PUT /profile/{userId}/avatar_url.
type putAvatarURLRequest struct {
AvatarURL string `json:"avatar_url"`
}
// handlePutDisplayName implements PUT /profile/{userId}/displayname.
func (c *ClientAPI) handlePutDisplayName(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
localpart, err := c.requireSelf(auth, r.PathValue("userID"))
if err != nil {
return err
}
var req putDisplayNameRequest
if err := httputil.DecodeJSON(w, r, &req); err != nil {
return err
}
if len(req.DisplayName) > MaxDisplayNameLength {
return httputil.NewError(http.StatusBadRequest, httputil.ErrCodeTooLarge,
"Display names must be at most %d bytes", MaxDisplayNameLength)
}
if err := c.users.SetDisplayName(r.Context(), localpart, req.DisplayName); err != nil {
return profileWriteError(err)
}
// Once rooms exist this also has to rewrite the m.room.member event in
// every room the user is in; that belongs to the roomserver in Phase 3.
httputil.WriteJSON(w, http.StatusOK, struct{}{})
return nil
}
// handlePutAvatarURL implements PUT /profile/{userId}/avatar_url.
func (c *ClientAPI) handlePutAvatarURL(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
localpart, err := c.requireSelf(auth, r.PathValue("userID"))
if err != nil {
return err
}
var req putAvatarURLRequest
if err := httputil.DecodeJSON(w, r, &req); err != nil {
return err
}
if len(req.AvatarURL) > MaxAvatarURLLength {
return httputil.NewError(http.StatusBadRequest, httputil.ErrCodeTooLarge,
"Avatar URLs must be at most %d bytes", MaxAvatarURLLength)
}
if err := c.users.SetAvatarURL(r.Context(), localpart, req.AvatarURL); err != nil {
return profileWriteError(err)
}
httputil.WriteJSON(w, http.StatusOK, struct{}{})
return nil
}
// profileWriteError maps a failed profile update. An admin may write to
// another user's profile, so "no such user" is reachable here.
func profileWriteError(err error) error {
if errors.Is(err, userapi.ErrNoSuchUser) {
return httputil.NotFound("Profile not found")
}
return err
}