Files
Warp/server/internal/clientapi/rooms.go
T
tajniak81andClaude Opus 5 c96f88e994
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Phase 3: rooms, local only
Implements PLAN.md Phase 3: the roomserver, the room half of storage, the
Client-Server room endpoints and the admin room endpoints. A client can now
create a room, invite, join, leave, kick, ban, send messages and state,
redact, name a room with an alias and find one in the public directory.
Nothing talks to another server; every operation that would need to is
refused with a message that says so rather than a bare M_FORBIDDEN.

roomserver: one input pipeline every event goes through, whatever sent it —
validate, authorise, resolve, persist, emit. The rules are not
reimplemented here; internal/matrix is pure library code and this is what
connects it to a database and to a room's history. The Client-Server
handlers do no authorisation of their own, deliberately: whether Alice may
kick Bob is a question about the room's power levels, and the one place
that is answered correctly is the authorisation rules inside the pipeline.

A mutex per room serialises writers. Two events racing into one room would
each read the same forward extremities, both become one, and fork the room
for no reason — which would then need state resolution to put back
together. State resolution is wired in anyway for the multi-extremity
case. It is unreachable from outside in this phase, and the alternative is
a pipeline that authorises against one arbitrary branch of a fork without
saying so.

Room versions 3 to 12 all work and are each tested end to end. Version 12
earns that coverage: its room ID is the create event's own ID, its create
event carries no room_id, and the create event is excluded from every other
event's auth_events — so the state auth.Check is given is the event's
auth_events plus the create event, which that version identifies by room ID
rather than citing.

createRoom sends the spec's events in the spec's order, each authorised
against what the ones before it produced. A failure part-way leaves an
incomplete room, which is the lesser evil: the alternative is holding every
event of a new room in memory and writing them in one transaction, making
the pipeline that authorises them a special case. The one failure a second
client can cause at any time, an alias clash, takes the room row back out.

Redactions stay two decisions, as the spec keeps them. The rules let almost
any redaction into the room; whether it applies to its target is a separate
test, run inside the same transaction as the redaction itself so that a
client holding an event ID can always read the stripped event.

storage: events keyed by event ID rather than by a surrogate, since an
event ID appears in prev_events, auth_events, state snapshots and client
requests alike. Stream ordering comes from a counter row bumped inside the
write transaction, because a PostgreSQL sequence is explicitly not
transactional and a rolled-back write would leave a hole in the stream that
/sync would have to be taught to skip. State snapshots are stored per event
and deduplicated by content hash, so the table grows with state changes
rather than with traffic — and that is what makes "the state after a
forward extremity" answerable at all. The room's listing columns are
denormalised onto its row because the public directory orders every
published room by member count and pages the result, which cannot be done
by reading each room's state in turn.

Federation-disabled behaviour from PLAN.md section 3 is enforced here.
Restricted joins are the exception that works: the rule needs a signature
from the authorising user's server verified, and while federation is off
that server is always this one.

adminapi: room list and detail, purge, force-leave, and room and event
counters on the dashboard. clientapi gains its own rate-limit buckets for
createRoom and for joining, both of which write events rather than read
them.

Tested against the real event core and a real database rather than fakes:
what is under test is whether an event this server signs is one the
authorisation rules accept, and a fake of either would only prove that the
pipeline calls what the fake expects. The storage tests run against both
SQL drivers. docs/rooms.md describes the pipeline, the storage decisions
and the known gaps — chief among them that history visibility is
room-level rather than per-event, and that /sync still reports no rooms,
both of which belong with the event stream in Phase 4.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-10-16 10:34:57 +02:00

418 lines
14 KiB
Go

package clientapi
import (
"encoding/json"
"errors"
"net/http"
"strings"
"github.com/dariuszjaniak/warp/server/internal/httputil"
"github.com/dariuszjaniak/warp/server/internal/matrix/id"
"github.com/dariuszjaniak/warp/server/internal/roomserver"
"github.com/dariuszjaniak/warp/server/internal/storage"
"github.com/dariuszjaniak/warp/server/internal/userapi"
)
// roomError maps a roomserver error onto the Matrix error the spec answers
// it with.
//
// The roomserver's refusals carry their reason in the message — which rule
// said no, which membership was missing — and the message is passed through
// to the client. That is deliberate: "M_FORBIDDEN" on its own sends a user
// to their operator and the operator to the logs, and nothing in these
// messages is anything the caller could not work out by reading the room's
// state, which they are entitled to do.
func roomError(err error) error {
var matrixErr *httputil.MatrixError
switch {
case err == nil:
return nil
case errors.As(err, &matrixErr):
return err
case errors.Is(err, roomserver.ErrNoSuchRoom):
return httputil.NotFound("Unknown room")
case errors.Is(err, roomserver.ErrNoSuchEvent):
return httputil.NotFound("Unknown event")
case errors.Is(err, roomserver.ErrNoSuchAlias):
return httputil.NotFound("Unknown room alias")
case errors.Is(err, roomserver.ErrAliasExists):
return httputil.NewError(http.StatusConflict, httputil.ErrCodeRoomInUse,
"That room alias is already taken")
case errors.Is(err, roomserver.ErrUnknownRoomVersion),
errors.Is(err, roomserver.ErrUnsupportedRoomVersion):
return httputil.NewError(http.StatusBadRequest, httputil.ErrCodeUnsupportedVer, "%s", err.Error())
case errors.Is(err, roomserver.ErrFederationDisabled):
return httputil.Forbidden("%s", err.Error())
case errors.Is(err, roomserver.ErrRejected), errors.Is(err, roomserver.ErrForbidden):
return httputil.Forbidden("%s", err.Error())
case errors.Is(err, roomserver.ErrInvalidContent):
return httputil.BadJSON("%s", err.Error())
default:
return err
}
}
// createRoomRequest is the POST /createRoom body.
type createRoomRequest struct {
RoomVersion string `json:"room_version"`
Preset string `json:"preset"`
Visibility string `json:"visibility"`
RoomAliasName string `json:"room_alias_name"`
Name string `json:"name"`
Topic string `json:"topic"`
Invite []string `json:"invite"`
CreationContent json.RawMessage `json:"creation_content"`
InitialState []roomserver.StateEvent `json:"initial_state"`
PowerLevelContentOverride json.RawMessage `json:"power_level_content_override"`
IsDirect bool `json:"is_direct"`
Invite3PID []map[string]json.RawMessage `json:"invite_3pid"`
}
type createRoomResponse struct {
RoomID string `json:"room_id"`
RoomAlias string `json:"room_alias,omitempty"`
}
// handleCreateRoom implements POST /_matrix/client/v3/createRoom.
func (c *ClientAPI) handleCreateRoom(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
var req createRoomRequest
if _, err := httputil.DecodeOptionalJSON(w, r, &req); err != nil {
return err
}
// Third-party invites go through an identity server, which Warp does
// not talk to (PLAN.md phase 9). Saying so is better than creating the
// room and quietly dropping the invites.
if len(req.Invite3PID) > 0 {
return httputil.Unknown(http.StatusBadRequest,
"Third-party invites are not supported by this server")
}
resp, err := c.rooms.CreateRoom(r.Context(), roomserver.CreateRoomRequest{
Creator: auth.UserID,
Version: req.RoomVersion,
Preset: req.Preset,
Visibility: req.Visibility,
RoomAliasName: req.RoomAliasName,
Name: req.Name,
Topic: req.Topic,
Invite: req.Invite,
CreationContent: req.CreationContent,
InitialState: req.InitialState,
PowerLevelContentOverride: req.PowerLevelContentOverride,
IsDirect: req.IsDirect,
})
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, createRoomResponse{
RoomID: resp.RoomID,
RoomAlias: resp.Alias,
})
return nil
}
// eventIDResponse is what every endpoint that sends an event returns.
type eventIDResponse struct {
EventID string `json:"event_id"`
}
// sendEventRequest is the body of a send or state PUT: any JSON object.
type sendEventRequest = json.RawMessage
// handleSendEvent implements
// PUT /_matrix/client/v3/rooms/{roomID}/send/{eventType}/{txnID}.
func (c *ClientAPI) handleSendEvent(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
eventType := r.PathValue("eventType")
if eventType == "" {
return httputil.MissingParam("An event type is required")
}
txnID := r.PathValue("txnID")
if txnID == "" {
return httputil.MissingParam("A transaction ID is required")
}
var content sendEventRequest
if err := httputil.DecodeJSON(w, r, &content); err != nil {
return err
}
eventID, err := c.rooms.SendEvent(r.Context(), roomserver.SendEventRequest{
RoomID: roomID,
Sender: auth.UserID,
Type: eventType,
Content: content,
Transaction: transactionRef(auth, txnID),
})
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, eventIDResponse{EventID: eventID})
return nil
}
// handlePutState implements
// PUT /_matrix/client/v3/rooms/{roomID}/state/{eventType}[/{stateKey}].
//
// State events carry no transaction ID: the spec gives none, because a
// state event is idempotent in a way a message is not — sending the same
// state twice leaves the room in the state you asked for either way.
func (c *ClientAPI) handlePutState(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
eventType := r.PathValue("eventType")
if eventType == "" {
return httputil.MissingParam("An event type is required")
}
stateKey := r.PathValue("stateKey")
var content sendEventRequest
if err := httputil.DecodeJSON(w, r, &content); err != nil {
return err
}
eventID, err := c.rooms.SendEvent(r.Context(), roomserver.SendEventRequest{
RoomID: roomID,
Sender: auth.UserID,
Type: eventType,
StateKey: &stateKey,
Content: content,
})
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, eventIDResponse{EventID: eventID})
return nil
}
// redactRequest is the PUT /rooms/{roomID}/redact/{eventID}/{txnID} body.
type redactRequest struct {
Reason string `json:"reason"`
}
// handleRedact implements
// PUT /_matrix/client/v3/rooms/{roomID}/redact/{eventID}/{txnID}.
func (c *ClientAPI) handleRedact(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
eventID := r.PathValue("eventID")
if err := id.ValidateEventID(eventID); err != nil {
return httputil.InvalidParam("%s is not a valid event ID", eventID)
}
txnID := r.PathValue("txnID")
if txnID == "" {
return httputil.MissingParam("A transaction ID is required")
}
var req redactRequest
if _, err := httputil.DecodeOptionalJSON(w, r, &req); err != nil {
return err
}
redactionID, err := c.rooms.Redact(r.Context(), roomserver.RedactRequest{
RoomID: roomID,
Sender: auth.UserID,
EventID: eventID,
Reason: req.Reason,
Transaction: transactionRef(auth, txnID),
})
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, eventIDResponse{EventID: redactionID})
return nil
}
// handleGetEvent implements
// GET /_matrix/client/v3/rooms/{roomID}/event/{eventID}.
func (c *ClientAPI) handleGetEvent(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
eventID := r.PathValue("eventID")
if err := id.ValidateEventID(eventID); err != nil {
return httputil.InvalidParam("%s is not a valid event ID", eventID)
}
clientEvent, err := c.rooms.Event(r.Context(), roomID, auth.UserID, eventID)
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, clientEvent)
return nil
}
// handleGetState implements GET /_matrix/client/v3/rooms/{roomID}/state,
// which returns the room's whole current state as an array.
func (c *ClientAPI) handleGetState(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
state, err := c.rooms.RoomState(r.Context(), roomID, auth.UserID)
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, state)
return nil
}
// handleGetStateEvent implements
// GET /_matrix/client/v3/rooms/{roomID}/state/{eventType}[/{stateKey}].
//
// It returns the event's content rather than the event: an inconsistency in
// the Client-Server API that predates most of it, and one every client
// relies on. The ?format=event query parameter asks for the whole event
// instead, which is how a client that wants the sender gets it.
func (c *ClientAPI) handleGetStateEvent(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
eventType := r.PathValue("eventType")
if eventType == "" {
return httputil.MissingParam("An event type is required")
}
stateKey := r.PathValue("stateKey")
if r.URL.Query().Get("format") == "event" {
state, err := c.rooms.StateEvent(r.Context(), roomID, auth.UserID, eventType, stateKey)
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, state)
return nil
}
content, err := c.rooms.StateEventContent(r.Context(), roomID, auth.UserID, eventType, stateKey)
if err != nil {
return roomError(err)
}
httputil.WriteRawJSON(w, http.StatusOK, content)
return nil
}
// membersResponse is the GET /rooms/{roomID}/members body.
type membersResponse struct {
Chunk []roomserver.ClientEvent `json:"chunk"`
}
// handleGetMembers implements GET /_matrix/client/v3/rooms/{roomID}/members.
//
// The ?at= parameter asks for the membership as of a point in the event
// stream, and is accepted and ignored. That is not a shortcut: there is one
// stream position in this build, because /sync has no stream to be at until
// Phase 4, so the membership as of any token a client can hold *is* the
// current membership. Phase 4 replaces this endpoint's filtering along with
// /sync and has to honour it then — see docs/rooms.md.
func (c *ClientAPI) handleGetMembers(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
query := r.URL.Query()
membership, notMembership := query.Get("membership"), query.Get("not_membership")
for _, value := range []string{membership, notMembership} {
if err := roomserver.ValidateMembershipFilter(value); err != nil {
return roomError(err)
}
}
members, err := c.rooms.Members(r.Context(), roomserver.MembersRequest{
RoomID: roomID,
User: auth.UserID,
Membership: membership,
NotMembership: notMembership,
})
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, membersResponse{Chunk: members})
return nil
}
// joinedMembersResponse is the GET /rooms/{roomID}/joined_members body.
type joinedMembersResponse struct {
Joined map[string]roomserver.RoomMember `json:"joined"`
}
// handleGetJoinedMembers implements
// GET /_matrix/client/v3/rooms/{roomID}/joined_members.
func (c *ClientAPI) handleGetJoinedMembers(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
joined, err := c.rooms.JoinedMembers(r.Context(), roomID, auth.UserID)
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, joinedMembersResponse{Joined: joined})
return nil
}
// joinedRoomsResponse is the GET /joined_rooms body.
type joinedRoomsResponse struct {
JoinedRooms []string `json:"joined_rooms"`
}
// handleGetJoinedRooms implements GET /_matrix/client/v3/joined_rooms.
func (c *ClientAPI) handleGetJoinedRooms(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
rooms, err := c.rooms.JoinedRooms(r.Context(), auth.UserID)
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, joinedRoomsResponse{JoinedRooms: rooms})
return nil
}
// pathRoomID reads and validates the {roomID} path value.
func pathRoomID(r *http.Request) (string, error) {
roomID := r.PathValue("roomID")
if err := id.ValidateRoomID(roomID); err != nil {
return "", httputil.InvalidParam("%s is not a valid room ID", roomID)
}
return roomID, nil
}
// transactionRef builds the idempotency key for a send.
//
// It is keyed on the device rather than the user: the spec scopes a
// transaction ID to the access token, and two of a user's clients each
// counting from "m1" must not collide.
func transactionRef(auth userapi.Authenticated, txnID string) *storage.TransactionRef {
return &storage.TransactionRef{
Localpart: auth.Localpart,
DeviceID: auth.DeviceID,
TxnID: txnID,
}
}
// aliasFromPath reads the {roomAlias} path value, which arrives percent-
// encoded because it contains a '#' and a ':'.
func aliasFromPath(r *http.Request) (string, error) {
alias := r.PathValue("roomAlias")
if alias == "" {
return "", httputil.MissingParam("A room alias is required")
}
if !strings.HasPrefix(alias, "#") {
return "", httputil.InvalidParam("%s is not a valid room alias", alias)
}
return alias, nil
}