shell: return flag parse errors from s3.bucket.create (#12544)

weed/shell/command_s3_bucket_create.go

@@ -59,7 +59,7 @@ func (c *commandS3BucketCreate) Do(args []string, commandEnv *CommandEnv, writer
 	bucketOwner := bucketCommand.String("owner", "", "bucket owner identity name (for S3 IAM authentication)")
 	withLock := bucketCommand.Bool("withLock", false, "enable Object Lock on the bucket (requires and enables versioning)")
 	if err = bucketCommand.Parse(args); err != nil {
-		return nil
+		return err
 	}
 
 	if *bucketName == "" {

weed/shell/command_s3_bucket_create_test.go

@@ -62,6 +62,17 @@ func TestS3BucketCreateRequestsExclusiveCreate(t *testing.T) {
 	assert.Equal(t, "my-bucket", req.Entry.Name)
 }
 
+func TestS3BucketCreateReturnsFlagParseError(t *testing.T) {
+	filerServer := &bucketCreateTestFilerServer{}
+	commandEnv, cleanup := newBucketCreateTestCommandEnv(t, filerServer)
+	defer cleanup()
+
+	var output bytes.Buffer
+	err := (&commandS3BucketCreate{}).Do([]string{"-name", "my-bucket", "-withlock"}, commandEnv, &output)
+	require.EqualError(t, err, "flag provided but not defined: -withlock")
+	assert.Empty(t, filerServer.createRequests())
+}
+
 func newBucketCreateTestCommandEnv(t *testing.T, filerServer filer_pb.SeaweedFilerServer) (*CommandEnv, func()) {
 	t.Helper()