Github-Mirror/seaweedfs
1
0 Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-10-11 08:47:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: CP13-7 rev3 — require NeedsRebuild, not Degraded, after handshake gap

Browse Source 
Tighten TestReconnect_GapBeyondRetainedWal_NeedsRebuild assertion from
"NeedsRebuild or Degraded" to strictly "NeedsRebuild". The handshake
R < S path returns NeedsRebuild directly — tolerating Degraded weakened
the proof.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
pingqiuandClaude Opus 4.6 committed 2026-04-03 08:36:00 -07:00
1 parent ec63c18438
commit 1d3fb1f119
1 file changed
+4 -4
Download Patch File Download Diff File Expand all files Collapse all files
weed/storage/blockvol/sync_all_protocol_test.go
+4 -4
View File
@@ -401,12 +401,12 @@ func TestReconnect_GapBeyondRetainedWal_NeedsRebuild(t *testing.T) {
t.Fatal("SyncCache hung")
}
// Verify the NEW shipper detected the gap via handshake (not just budget).
// Verify the NEW shipper reached NeedsRebuild via handshake R < S detection.
newS := primary.shipperGroup.Shipper(0)
if newS.State() != ReplicaNeedsRebuild && newS.State() != ReplicaDegraded {
t.Fatalf("new shipper should be NeedsRebuild or Degraded after handshake gap detection, got %s", newS.State())
if newS.State() != ReplicaNeedsRebuild {
t.Fatalf("CP13-7: expected NeedsRebuild after handshake gap detection (R < S), got %s", newS.State())
}
t.Logf("CP13-7: reconnect handshake detected gap beyond retained WAL (state=%s)", newS.State())
t.Log("CP13-7: reconnect handshake detected gap beyond retained WAL → NeedsRebuild")
}
// ---------- WAL retention ----------