Github-Mirror/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-09-20 13:30:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: reject IOBackend=io_uring in Validate(), fix wal_admit_wait metric type

Browse Source 
Finding 1: IOBackend=io_uring was accepted and logged as resolved but
had no runtime effect. Now rejected by Validate() until actually wired,
preventing user confusion.

Finding 2: wal_admit_wait_seconds_total was exported as GaugeFunc but
is monotonically increasing. Changed to CounterFunc to match _total
naming convention.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Ping Qiu
2026-03-11 17:35:43 -07:00
co-authored by Claude Opus 4.6
parent e22e57a3f7
commit f698b1f154
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
weed/storage/blockvol/iscsi/cmd/iscsi-target/metrics.go
+1 -1
View File
@@ -155,7 +155,7 @@ func newMetricsAdapter(inner iscsi.BlockDevice, vol *blockvol.BlockVol, reg prom
Namespace: "seaweedfs", Subsystem: "blockvol",
Name: "wal_admit_timeout_total", Help: "WAL admission timeouts (ErrWALFull)",
}, func() float64 { return float64(em.WALAdmitTimeoutTotal.Load()) }))
reg.MustRegister(prometheus.NewGaugeFunc(prometheus.GaugeOpts{
reg.MustRegister(prometheus.NewCounterFunc(prometheus.CounterOpts{
Namespace: "seaweedfs", Subsystem: "blockvol",
Name: "wal_admit_wait_seconds_total", Help: "Total time spent waiting in WAL admission (seconds)",
}, func() float64 { _, s := em.WALAdmitWaitSnapshot(); return float64(s) / 1e9 }))