Files
seaweedfs/weed/s3api/s3api_iceberg_credentials.go
T
Chris Lu 8d2b417c69 iceberg, lance: vend read-only credentials to callers that may only read (#11859)
* s3tables: share the UpdateTable authorization gate

Extract the validation, load, and permission check from handleUpdateTable
into authorizeUpdateTable so the table an update was authorized against is
the same snapshot the mutation writes to. Manager gains
AuthorizeUpdateTable, mirroring AuthorizeCreateTable, so callers can ask the
question without updating anything.

* s3tables: share the UpdateView authorization gate

Extract the lookup, policy load, and permission check from handleUpdateView
into authorizeUpdateView, mirroring authorizeUpdateTable, and expose it as
Manager.AuthorizeUpdateView for callers that need the answer without the
update.

* s3api: scope vended table credentials to read-only on request

VendTableCredentials takes a readOnly flag and tablePrefixSessionPolicy
emits only s3:GetObject for the table prefix when it is set, keeping the
conditioned ListBucket and unconditioned GetBucketLocation statements that
reads still need.

* iceberg: vend read-only credentials when the caller may not write

LoadTable and friends vend storage credentials only for the authority the
caller holds: the vend now checks UpdateTable/UpdateView permission and a
caller that may only read the catalog entry gets a read-only session. Paths
that just passed a write gate (stage-create, view commit) keep the full
session.

* lance: vend read-only credentials when the caller may not write

storage_options vends the same read-only session as the Iceberg catalog
when the caller lacks UpdateTable on the table.

* lance: keep write credentials for callers authorized to declare

A Lance commit is a direct S3 write that never revisits the catalog, so a
caller that just passed CreateTable still gets a writable session; the
UpdateTable gate applies to describe, the read path.

* iceberg, lance: log a failed write check instead of only reading it as denied
2026-10-20 07:16:27 -07:00

185 lines
6.1 KiB
Go

package s3api
import (
"context"
"encoding/json"
"fmt"
"strings"
"time"
"github.com/seaweedfs/seaweedfs/weed/iam/sts"
)
// icebergVendedCredentialsProvider names the origin recorded on sessions the
// catalog mints, so audit trails can tell them apart from ordinary logins.
const icebergVendedCredentialsProvider = "iceberg-catalog"
// SetIcebergCredentialRole configures the role the Iceberg catalog assumes when
// a client asks for vended credentials. Vending stays off until it is set.
func (s3a *S3ApiServer) SetIcebergCredentialRole(roleArn string, durationSeconds int64) {
s3a.icebergCredentialRole = strings.TrimSpace(roleArn)
s3a.icebergCredentialDuration = durationSeconds
}
// VendedCredentials are short-lived S3 credentials scoped to one table.
type VendedCredentials struct {
AccessKeyID string
SecretAccessKey string
SessionToken string
Expiration time.Time
}
// VendTableCredentials mints credentials that can read exactly one table's
// prefix, and write it too unless readOnly, for a caller the Iceberg catalog
// has already authenticated and authorized. Returns nil when no role is
// configured, which leaves the catalog telling the client to keep using its
// own credentials.
func (s3a *S3ApiServer) VendTableCredentials(ctx context.Context, principal, bucket, prefix string, readOnly bool) (*VendedCredentials, error) {
if s3a.icebergCredentialRole == "" {
return nil, nil
}
if principal == "" {
return nil, fmt.Errorf("no principal to vend credentials for")
}
if bucket == "" {
return nil, fmt.Errorf("no bucket to scope credentials to")
}
stsService := s3a.stsService()
if stsService == nil {
return nil, fmt.Errorf("STS is not configured")
}
policy, err := tablePrefixSessionPolicy(bucket, prefix, readOnly)
if err != nil {
return nil, err
}
request := &sts.AssumeRoleForPrincipalRequest{
RoleArn: s3a.icebergCredentialRole,
Principal: principal,
RoleSessionName: icebergSessionName(principal, bucket, prefix),
ProviderName: icebergVendedCredentialsProvider,
Policy: &policy,
}
if s3a.icebergCredentialDuration > 0 {
duration := s3a.icebergCredentialDuration
request.DurationSeconds = &duration
}
resp, err := stsService.AssumeRoleForPrincipal(ctx, request)
if err != nil {
return nil, err
}
if resp == nil || resp.Credentials == nil {
return nil, fmt.Errorf("STS returned no credentials")
}
return &VendedCredentials{
AccessKeyID: resp.Credentials.AccessKeyId,
SecretAccessKey: resp.Credentials.SecretAccessKey,
SessionToken: resp.Credentials.SessionToken,
Expiration: resp.Credentials.Expiration,
}, nil
}
func (s3a *S3ApiServer) stsService() *sts.STSService {
if s3a.iam == nil || s3a.iam.iamIntegration == nil {
return nil
}
provider, ok := s3a.iam.iamIntegration.(IAMManagerProvider)
if !ok {
return nil
}
manager := provider.GetIAMManager()
if manager == nil {
return nil
}
return manager.GetSTSService()
}
// tablePrefixSessionPolicy narrows a session to one table's files plus the
// bucket listing that clients need to resolve them. A read-only session drops
// the write verbs: the catalog vends no more authority than the caller holds.
func tablePrefixSessionPolicy(bucket, prefix string, readOnly bool) (string, error) {
prefix = strings.Trim(prefix, "/")
// A resource pattern is matched with wildcards, so a location carrying one
// would widen the session to sibling tables. Refuse rather than escape it:
// nothing SeaweedFS generates contains these.
if strings.ContainsAny(bucket, "*?") || strings.ContainsAny(prefix, "*?") {
return "", fmt.Errorf("refusing to scope credentials to a location with wildcards: s3://%s/%s", bucket, prefix)
}
// Without a prefix there is nothing to scope to, and the session would carry
// read and write over every table in the bucket. A table registered at the
// bucket root is the only way to get here.
if prefix == "" {
return "", fmt.Errorf("refusing to scope credentials to a whole bucket: s3://%s", bucket)
}
objectActions := []string{"s3:GetObject", "s3:PutObject", "s3:DeleteObject", "s3:AbortMultipartUpload", "s3:ListMultipartUploadParts"}
if readOnly {
objectActions = []string{"s3:GetObject"}
}
policy := map[string]interface{}{
"Version": "2012-10-17",
"Statement": []map[string]interface{}{
{
"Effect": "Allow",
"Action": objectActions,
"Resource": []string{fmt.Sprintf("arn:aws:s3:::%s/%s/*", bucket, prefix)},
},
{
// Listing is granted on the bucket, so without the condition the
// session could enumerate every other table's object names.
"Effect": "Allow",
"Action": []string{"s3:ListBucket"},
"Resource": []string{fmt.Sprintf("arn:aws:s3:::%s", bucket)},
"Condition": map[string]interface{}{
"StringLike": map[string]interface{}{
"s3:prefix": []string{prefix, prefix + "/*"},
},
},
},
{
// GetBucketLocation carries no prefix to condition on, so it sits
// in its own statement rather than being denied by one.
// ListBucketMultipartUploads is deliberately absent: Iceberg
// writers complete and abort by upload id, and granting it either
// leaks in-flight keys bucket-wide or breaks on the same missing
// prefix.
"Effect": "Allow",
"Action": []string{"s3:GetBucketLocation"},
"Resource": []string{fmt.Sprintf("arn:aws:s3:::%s", bucket)},
},
},
}
encoded, err := json.Marshal(policy)
if err != nil {
return "", fmt.Errorf("build session policy: %w", err)
}
return string(encoded), nil
}
// icebergSessionName builds a session name that identifies the caller and the
// table in audit logs, within the 64-character AWS limit.
func icebergSessionName(principal, bucket, prefix string) string {
name := fmt.Sprintf("iceberg-%s-%s", principal, strings.ReplaceAll(strings.Trim(prefix, "/"), "/", "-"))
if strings.Trim(prefix, "/") == "" {
name = fmt.Sprintf("iceberg-%s-%s", principal, bucket)
}
name = strings.Map(func(r rune) rune {
switch {
case r >= 'a' && r <= 'z', r >= 'A' && r <= 'Z', r >= '0' && r <= '9', r == '-', r == '_':
return r
default:
return '-'
}
}, name)
if len(name) > 64 {
name = name[:64]
}
return name
}