mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-11-04 11:07:35 +01:00
* master: tell a warming-up Assign client when warm-up ends During warm-up the master refuses Assign with Unavailable and now attaches the remaining warm-up as a gRPC RetryInfo detail. RetryWithBackoff may shorten a backoff step to that hint plus 50 ms, never lengthen it, and only for a valid, positive hint, so a writer retries right after warm-up ends instead of up to one backoff step later. The warm-up itself is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * master: jitter the retry-hint slack and hint LookupVolume too Per review: the slack added to a server hint is now random in [50ms, 300ms], so clients refused at the same moment do not all retry in one instant. The warm-up refusal of LookupVolume carries the same RetryInfo hint as Assign; the masterclient's lookup retry already goes through RetryWithBackoff, so it lands at warm-up end too. Tests: the slow guard tests are replaced by one sleep-free table test of the step logic (zero, negative, huge, malformed, valid and wrapped hints, a hint longer than the step, none). One timing test of the shortened step stays, plus a jitter-bounds test and a LookupVolume hint test. The no-hint control test, which was timing-sensitive, is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * master: name the shared warm-up test and file the lookup test by topic Rename the no-remaining test to TestWarmingUpErrorWithoutRemainingHasNoHint, since the helper now serves Assign and LookupVolume, and move the LookupVolume hint test next to the other LookupVolume warm-up tests. Tests only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * util: read the retry hint through ServerStatus Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * master: bound the warm-up hint in tests by the remaining warm-up around the RPC Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: leave more scheduler margin in the retry-hint timing tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * util, master: trim retry-hint comments Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: widen the retry-hint timing bounds to just under the unhinted wait Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: require a refused warm-up call before the hinted assign retry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: check the hinted retry wait through a test timer, not the wall clock Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: move the assign warm-up end to 2.6s for more hinted-retry headroom Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: require the hinted retry to wait out its timer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
349 lines
13 KiB
Go
349 lines
13 KiB
Go
package weed_server
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/stats"
|
|
|
|
"github.com/seaweedfs/raft"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/security"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/types"
|
|
"github.com/seaweedfs/seaweedfs/weed/topology"
|
|
"google.golang.org/genproto/googleapis/rpc/errdetails"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
"google.golang.org/protobuf/types/known/durationpb"
|
|
)
|
|
|
|
func (ms *MasterServer) StreamAssign(server master_pb.Seaweed_StreamAssignServer) error {
|
|
for {
|
|
req, err := server.Recv()
|
|
if err != nil {
|
|
glog.Errorf("StreamAssign failed to receive: %v", err)
|
|
return err
|
|
}
|
|
resp, err := ms.Assign(server.Context(), req)
|
|
if err != nil {
|
|
// Return transient errors (warmup, growth-in-progress shed) as in-band
|
|
// error responses instead of killing the stream, so pooled connections
|
|
// survive.
|
|
if st, ok := status.FromError(err); ok && (st.Code() == codes.Unavailable || st.Code() == codes.ResourceExhausted) {
|
|
glog.V(1).Infof("StreamAssign transient error: %v", err)
|
|
resp = &master_pb.AssignResponse{Error: st.Message()}
|
|
} else {
|
|
glog.Errorf("StreamAssign failed to assign: %v", err)
|
|
return err
|
|
}
|
|
}
|
|
if err = server.Send(resp); err != nil {
|
|
glog.Errorf("StreamAssign failed to send: %v", err)
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
func (ms *MasterServer) Assign(ctx context.Context, req *master_pb.AssignRequest) (*master_pb.AssignResponse, error) {
|
|
|
|
if !ms.Topo.IsLeader() {
|
|
return nil, raft.NotLeaderError
|
|
}
|
|
|
|
if req.Count == 0 {
|
|
req.Count = 1
|
|
}
|
|
|
|
if req.Replication == "" {
|
|
req.Replication = ms.option.DefaultReplicaPlacement
|
|
}
|
|
replicaPlacement, err := super_block.NewReplicaPlacementFromString(req.Replication)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
ttl, err := needle.ReadTTL(req.Ttl)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if ms.Topo.IsWarmingUp() {
|
|
return nil, warmingUpError(ms.Topo.RemainingWarmupDuration())
|
|
}
|
|
diskType := types.ToDiskType(req.DiskType)
|
|
|
|
ver := needle.GetCurrentVersion()
|
|
option := &topology.VolumeGrowOption{
|
|
Collection: req.Collection,
|
|
ReplicaPlacement: replicaPlacement,
|
|
Ttl: ttl,
|
|
DiskType: diskType,
|
|
Preallocate: ms.preallocateSize,
|
|
DataCenter: req.DataCenter,
|
|
Rack: req.Rack,
|
|
DataNode: req.DataNode,
|
|
MemoryMapMaxSizeMb: req.MemoryMapMaxSizeMb,
|
|
Version: uint32(ver),
|
|
}
|
|
|
|
if !ms.Topo.DataCenterExists(option.DataCenter) {
|
|
return nil, fmt.Errorf("data center %v not found in topology", option.DataCenter)
|
|
}
|
|
if !ms.Topo.RackExists(option.DataCenter, option.Rack) {
|
|
return nil, fmt.Errorf("rack %v not found in topology", option.Rack)
|
|
}
|
|
if !ms.Topo.DataNodeExists(option.DataCenter, option.Rack, option.DataNode) {
|
|
return nil, fmt.Errorf("data node %v not found in topology", option.DataNode)
|
|
}
|
|
|
|
vl := ms.Topo.GetVolumeLayout(option.Collection, option.ReplicaPlacement, option.Ttl, option.DiskType)
|
|
if req.DiskType == "" {
|
|
if writable, _ := vl.GetWritableVolumeCount(); writable == 0 {
|
|
if hddVl := ms.Topo.GetVolumeLayout(option.Collection, option.ReplicaPlacement, option.Ttl, types.ToDiskType(types.HddType)); hddVl != nil {
|
|
if writable, _ := hddVl.GetWritableVolumeCount(); writable > 0 {
|
|
option.DiskType = types.ToDiskType(types.HddType)
|
|
vl = hddVl
|
|
}
|
|
}
|
|
}
|
|
}
|
|
vl.SetLastGrowCount(req.WritableVolumeCount)
|
|
|
|
var (
|
|
lastErr error
|
|
maxTimeout = time.Second * 10
|
|
startTime = time.Now()
|
|
initiatedGrow bool
|
|
repickedAfterGrow bool
|
|
recheckedBlocker bool
|
|
unservedLayoutLogged bool
|
|
)
|
|
|
|
for time.Now().Sub(startTime) < maxTimeout {
|
|
fid, count, dnList, shouldGrow, err := ms.Topo.PickForWrite(req.Count, option, vl, req.ExpectedDataSize)
|
|
if shouldGrow && !initiatedGrow && !ms.option.VolumeGrowthDisabled && vl.AddGrowRequestIfAbsent() {
|
|
initiatedGrow = true
|
|
if err != nil && ms.Topo.AvailableSpaceFor(option) <= 0 && ms.Topo.CapacityFor(option) > 0 {
|
|
err = fmt.Errorf("%s and no free volumes left for %s", err.Error(), option.String())
|
|
}
|
|
ms.volumeGrowthRequestChan <- &topology.VolumeGrowRequest{
|
|
Option: option,
|
|
Count: req.WritableVolumeCount,
|
|
Reason: "grpc assign",
|
|
}
|
|
}
|
|
if err != nil {
|
|
glog.V(1).Infof("assign %v %v: %v", req, option.String(), err)
|
|
stats.MasterPickForWriteErrorCounter.Inc()
|
|
lastErr = err
|
|
if (req.DataCenter != "" || req.Rack != "") && strings.Contains(err.Error(), topology.NoWritableVolumes) {
|
|
// Fail fast only when no growth can produce a writable volume in
|
|
// the requested location; a location with a pending or just-
|
|
// concluded grow gets the same wait/shed path as an
|
|
// unconstrained assign, so its client retry can re-trigger
|
|
// growth.
|
|
growBlocker := err
|
|
growthInFlight := !ms.option.VolumeGrowthDisabled && (initiatedGrow || vl.HasGrowRequest())
|
|
if growthInFlight {
|
|
growBlocker = ms.Topo.GrowthBlocker(option)
|
|
}
|
|
if growBlocker != nil {
|
|
// The blocker's slot counts can predate an in-flight grow's
|
|
// delivery by a heartbeat: a volume minted on the last slot
|
|
// still registers writable a moment later. Give a pending
|
|
// grow one repick before surfacing the placement error.
|
|
if growthInFlight && !recheckedBlocker {
|
|
recheckedBlocker = true
|
|
select {
|
|
case <-ctx.Done():
|
|
return nil, ctx.Err()
|
|
case <-time.After(200 * time.Millisecond):
|
|
}
|
|
continue
|
|
}
|
|
glog.V(0).Infof("assign %v %v: %v", req, option.String(), err)
|
|
return nil, growBlocker
|
|
}
|
|
}
|
|
if shouldGrow {
|
|
if ms.Topo.AvailableSpaceFor(option) <= 0 {
|
|
// Fail fast whenever any capacity is registered: full for
|
|
// this medium, or a medium no volume server serves — a
|
|
// state a heartbeat won't change, so a retryable shed
|
|
// would loop until the client's deadline. Shed retryably
|
|
// only while nothing at all has registered, a just-started
|
|
// cluster whose volume servers have not heartbeated, so
|
|
// the first write rides out the startup window instead of
|
|
// failing outright.
|
|
if ms.Topo.CapacityForAnyDisk() > 0 {
|
|
if ms.Topo.CapacityFor(option) <= 0 {
|
|
// Wrapped here, not beside the "no free volumes left"
|
|
// wrap above, so followers and growth-disabled
|
|
// masters name the unserved medium too — the
|
|
// initiator block is skipped for both.
|
|
// The empty disk type is the legacy unlabeled
|
|
// layout; naming it "hdd" here sends operators
|
|
// looking for servers that were never labeled.
|
|
lastErr = fmt.Errorf("%s and no volume server carries the %s disk layout for %s", err.Error(), describeDiskLayout(req.DiskType), option.String())
|
|
assignUnservedLayoutWarning.Do(option.String(), lastErr)
|
|
unservedLayoutLogged = true
|
|
}
|
|
break // surface the real error, not a retryable shed
|
|
}
|
|
return nil, status.Errorf(codes.ResourceExhausted, "no volume server capacity registered yet for %s", option.String())
|
|
}
|
|
// Only the initiator waits, and only while the growth it triggered
|
|
// is still pending: followers shed fast so a herd doesn't pin a
|
|
// goroutine each, and an initiator whose growth concluded without
|
|
// yielding a writable volume sheds so client retries re-trigger
|
|
// growth instead of looping it here. ResourceExhausted, not
|
|
// Unavailable: clients retry it (assign_file_id.go) without
|
|
// invalidating the shared master connection.
|
|
if initiatedGrow != vl.HasGrowRequest() {
|
|
// The failed pick above may predate the growth concluding, so
|
|
// re-pick once before shedding: growth registers its volumes
|
|
// before clearing the flag, and shedding here would bounce the
|
|
// client off a volume that just landed.
|
|
if initiatedGrow && !repickedAfterGrow {
|
|
repickedAfterGrow = true
|
|
continue
|
|
}
|
|
return nil, status.Errorf(codes.ResourceExhausted, "no writable volumes for %s, volume growth in progress", option.String())
|
|
}
|
|
}
|
|
select {
|
|
case <-ctx.Done():
|
|
return nil, ctx.Err()
|
|
case <-time.After(200 * time.Millisecond):
|
|
}
|
|
continue
|
|
}
|
|
dn := dnList.Head()
|
|
if dn == nil {
|
|
continue
|
|
}
|
|
return assignResponse(fid, count, dnList, ms.guard), nil
|
|
}
|
|
// The last in-loop pick can predate the growth it triggered concluding:
|
|
// growth registers its volumes before clearing the pending flag, so pick
|
|
// once more before shedding.
|
|
if fid, count, dnList, _, err := ms.Topo.PickForWrite(req.Count, option, vl, req.ExpectedDataSize); err == nil {
|
|
if dnList.Head() != nil {
|
|
return assignResponse(fid, count, dnList, ms.guard), nil
|
|
}
|
|
}
|
|
// The initiator timed out with its growth still pending: shed retryably
|
|
// rather than failing the write that growth is about to satisfy.
|
|
if initiatedGrow && vl.HasGrowRequest() && ms.Topo.AvailableSpaceFor(option) > 0 {
|
|
return nil, status.Errorf(codes.ResourceExhausted, "no writable volumes for %s, volume growth in progress", option.String())
|
|
}
|
|
if lastErr != nil && !unservedLayoutLogged {
|
|
// The unserved-layout branch already logged this once per option via
|
|
// assignUnservedLayoutWarning; repeating it here would flood the log
|
|
// on every retry of a state a retry cannot change.
|
|
glog.V(0).Infof("assign %v %v: %v", req, option.String(), lastErr)
|
|
}
|
|
return nil, lastErr
|
|
}
|
|
|
|
func assignResponse(fid string, count uint64, dnList *topology.VolumeLocationList, guard *security.Guard) *master_pb.AssignResponse {
|
|
var replicas []*master_pb.Location
|
|
for _, r := range dnList.Rest() {
|
|
replicas = append(replicas, &master_pb.Location{
|
|
Url: r.Url(),
|
|
PublicUrl: r.PublicUrl,
|
|
GrpcPort: uint32(r.GrpcPort),
|
|
DataCenter: r.GetDataCenterId(),
|
|
})
|
|
}
|
|
dn := dnList.Head()
|
|
return &master_pb.AssignResponse{
|
|
Fid: fid,
|
|
Location: &master_pb.Location{
|
|
Url: dn.Url(),
|
|
PublicUrl: dn.PublicUrl,
|
|
GrpcPort: uint32(dn.GrpcPort),
|
|
DataCenter: dn.GetDataCenterId(),
|
|
},
|
|
Count: count,
|
|
Auth: string(security.GenJwtForVolumeServer(guard.SigningKey(), guard.ExpiresAfterSec(), fid)),
|
|
Replicas: replicas,
|
|
}
|
|
}
|
|
|
|
// describeDiskLayout names the disk layout an assign targets. The empty disk
|
|
// type is the legacy unlabeled layout on servers that were never started with
|
|
// -disk; naming it "hdd" sends operators looking for servers that were never
|
|
// labeled.
|
|
//
|
|
// Pass the original request disk type, not the canonicalized option.DiskType:
|
|
// ToDiskType folds both "" and "hdd" into HardDriveType, so only the request
|
|
// string can tell an unlabeled request from an explicit hdd one.
|
|
func describeDiskLayout(reqDiskType string) string {
|
|
if reqDiskType == "" {
|
|
return "default (unlabeled)"
|
|
}
|
|
return fmt.Sprintf("%q", strings.ToLower(reqDiskType))
|
|
}
|
|
|
|
// assignUnservedLayoutWarning logs a repeated assign failure at most once per
|
|
// option per interval instead of once per write attempt: a layout no volume
|
|
// server serves is a state a retry cannot change, so repeating it only buries
|
|
// the actionable first warning.
|
|
//
|
|
// The remembered set is bounded and expires: option keys embed
|
|
// request-derived fields (collection, disk type), so an unbounded, permanent
|
|
// dedupe map would let a client grow master memory at will and would also
|
|
// suppress the warning if the same option goes unserved again after the
|
|
// topology recovers.
|
|
const (
|
|
unservedLayoutWarnInterval = time.Hour
|
|
unservedLayoutWarnMaxKeys = 1024
|
|
)
|
|
|
|
type unservedLayoutWarning struct {
|
|
mu sync.Mutex
|
|
now func() time.Time
|
|
last map[string]time.Time
|
|
}
|
|
|
|
var assignUnservedLayoutWarning = &unservedLayoutWarning{
|
|
now: time.Now,
|
|
last: make(map[string]time.Time),
|
|
}
|
|
|
|
func (w *unservedLayoutWarning) Do(optionKey string, lastErr error) {
|
|
w.mu.Lock()
|
|
defer w.mu.Unlock()
|
|
now := w.now()
|
|
if t, ok := w.last[optionKey]; ok && now.Sub(t) < unservedLayoutWarnInterval {
|
|
return
|
|
}
|
|
if len(w.last) >= unservedLayoutWarnMaxKeys {
|
|
// Client-driven keys must never grow the map without bound; a full
|
|
// reset trades a burst of repeated warnings for bounded memory.
|
|
w.last = make(map[string]time.Time)
|
|
}
|
|
w.last[optionKey] = now
|
|
glog.Warningf("assign requests for %s will keep failing until a volume server registers that disk layout or clients change their assignment disk type: %v", optionKey, lastErr)
|
|
}
|
|
|
|
// warmingUpError carries the remaining warm-up as a RetryInfo detail, the gRPC
|
|
// counterpart of the HTTP handlers' Retry-After.
|
|
func warmingUpError(remaining time.Duration) error {
|
|
st := status.New(codes.Unavailable, "master is warming up, topology is still loading")
|
|
if remaining <= 0 {
|
|
return st.Err()
|
|
}
|
|
withHint, err := st.WithDetails(&errdetails.RetryInfo{RetryDelay: durationpb.New(remaining)})
|
|
if err != nil {
|
|
return st.Err()
|
|
}
|
|
return withHint.Err()
|
|
}
|