mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-09-08 15:41:15 +02:00
* storage: make DeleteVolume errors inspectable with errors.Is An absent volume wraps ErrVolumeNotFound and an only-empty refusal now wraps ErrVolumeNotEmpty with %w instead of %v, so callers no longer have to match on the message. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * volume server: return NotFound and FailedPrecondition from VolumeDelete An absent volume maps to codes.NotFound and a non-empty volume under only_empty to codes.FailedPrecondition, so a caller retiring a volume can treat NotFound as already done. The store message is kept in the status description because the EC empty-replica sweep still matches on it. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * wdclient: add LookupVolumeIdsAuthoritative Bypasses the vid map and asks the provider directly, for callers where a stale positive location is unsafe. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: add LookupDirectoryEntries batch lookup RPC Up to 4096 exact-path lookups in one call, resolved concurrently with results in request order, plus one deduplicated location lookup for every volume the returned entries reference and per-fid read tokens when the filer signs reads. unavailable_volume_is_miss lets cache-style callers take an entry whose volume has no live location as a miss, resolved against the master rather than the filer's location cache. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: test that an expired file entry is deleted on read Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: test that AssignVolume and CreateEntry resolve the same TTL rule Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * master: refuse partial lookups while warming up LookupVolume returned Unavailable during warm-up only when every requested volume was missing. A batch mixing a reported volume with one whose server has not reconnected yet came back as a partial answer with a per-volume not-found, which a caller treating the master as authoritative reads as gone. Any not-found during warm-up is now Unavailable, which callers already retry. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: build batch test requests instead of copying a proto message Copying a generated message copies its internal mutex, which go vet's copylocks check rejects. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: match ErrNotFound with errors.Is and state the miss rule's contract A wrapped not-found from the store would otherwise be reported as an error rather than a miss. The comments now say why a nil location map is the only sign of an unanswered lookup: the provider returns nil when it got no answer and a populated map, with unserved volumes reported as errors, when the master did answer. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * volume server: map absent and non-empty VolumeDelete errors in the Rust server Matches the Go server: an absent volume is NotFound and an only_empty refusal is FailedPrecondition instead of Internal, with the messages the EC empty-replica sweep matches on. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm * filer: test that a malformed entry keeps its error outside cache mode Same test file as the enterprise tree, so the next sync sees one version. Claude-Session: https://claude.ai/code/session_01T4MEV3ETqFFKN46Uu2ZrUm
107 lines
3.6 KiB
Go
107 lines
3.6 KiB
Go
package filer
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// TestPromoteToPrefixObject covers a key written before the keys nested under it:
|
|
// the file becomes the directory they live in, and has to stay an object of its own.
|
|
func TestPromoteToPrefixObject(t *testing.T) {
|
|
f, store := newTestFilerWithStubStore()
|
|
ctx := context.Background()
|
|
|
|
object := &Entry{
|
|
FullPath: util.FullPath("/buckets/bkt/a/foo"),
|
|
Attr: Attr{
|
|
Mode: 0o644,
|
|
Mime: "text/plain",
|
|
TtlSec: 3600,
|
|
},
|
|
Chunks: []*filer_pb.FileChunk{{FileId: "1,01", Size: 4}},
|
|
Extended: map[string][]byte{s3_constants.SeaweedFSExpiresS3: []byte("true")},
|
|
}
|
|
require.NoError(t, f.CreateEntry(ctx, object, nil, false, false, nil, false, f.MaxFilenameLength))
|
|
|
|
nested := &Entry{FullPath: util.FullPath("/buckets/bkt/a/foo/bar"), Attr: Attr{Mode: 0o644}}
|
|
require.NoError(t, f.CreateEntry(ctx, nested, nil, false, false, nil, false, f.MaxFilenameLength))
|
|
|
|
promoted, err := store.FindEntry(ctx, object.FullPath)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, promoted)
|
|
|
|
assert.True(t, promoted.IsDirectory(), "the nested key needs a directory here")
|
|
assert.Equal(t, object.Chunks, promoted.Chunks, "the object's data stays on it")
|
|
assert.Contains(t, promoted.Extended, s3_constants.SeaweedFSPrefixObject)
|
|
// Expiring the entry deletes the directory row on its own and strands the keys
|
|
// under it, so the promotion gives up the lazy TTL.
|
|
assert.Zero(t, promoted.Attr.TtlSec)
|
|
}
|
|
|
|
// TestExpiredDirectoryIsNotDeletedOnRead pins the other half: a TTL an older build
|
|
// left on a promoted directory must not take the keys under it with it.
|
|
func TestExpiredDirectoryIsNotDeletedOnRead(t *testing.T) {
|
|
f, store := newTestFilerWithStubStore()
|
|
ctx := context.Background()
|
|
|
|
dirPath := util.FullPath("/buckets/bkt/a/foo")
|
|
expired := time.Now().Add(-2 * time.Hour)
|
|
require.NoError(t, store.InsertEntry(ctx, &Entry{
|
|
FullPath: dirPath,
|
|
Attr: Attr{
|
|
Mode: os.ModeDir | 0o755,
|
|
Crtime: expired,
|
|
Mtime: expired,
|
|
TtlSec: 60,
|
|
},
|
|
Extended: map[string][]byte{s3_constants.SeaweedFSExpiresS3: []byte("true")},
|
|
}))
|
|
nested := &Entry{FullPath: dirPath + "/bar", Attr: Attr{Mode: 0o644}}
|
|
require.NoError(t, store.InsertEntry(ctx, nested))
|
|
|
|
found, err := f.FindEntry(ctx, dirPath)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, found, "deleting it here would leave the nested key unreachable")
|
|
|
|
stillThere, err := store.FindEntry(ctx, nested.FullPath)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, stillThere)
|
|
}
|
|
|
|
// TestExpiredFileIsDeletedOnRead pins the native cache-TTL path: regular
|
|
// entries become invisible and their metadata row is removed without a
|
|
// cache-specific transaction or reverse Volume index.
|
|
func TestExpiredFileIsDeletedOnRead(t *testing.T) {
|
|
f, store := newTestFilerWithStubStore()
|
|
ctx := context.Background()
|
|
|
|
filePath := util.FullPath("/buckets/lmcache/expired")
|
|
expired := time.Now().Add(-2 * time.Hour)
|
|
require.NoError(t, store.InsertEntry(ctx, &Entry{
|
|
FullPath: filePath,
|
|
Attr: Attr{
|
|
Mode: 0o644,
|
|
Crtime: expired,
|
|
Mtime: expired,
|
|
TtlSec: 60,
|
|
},
|
|
Chunks: []*filer_pb.FileChunk{{FileId: "7,01", Size: 4}},
|
|
}))
|
|
|
|
found, err := f.FindEntry(ctx, filePath)
|
|
require.ErrorIs(t, err, filer_pb.ErrNotFound)
|
|
require.Nil(t, found)
|
|
|
|
_, err = store.FindEntry(ctx, filePath)
|
|
require.ErrorIs(t, err, filer_pb.ErrNotFound,
|
|
"native TTL lookup should remove the expired metadata row")
|
|
}
|