4 people df4995b894 volume server: VolumeMarkReadonly answers NotFound when the volume vanished under the lock (#11443) ...

* volume server: VolumeMarkReadonly answers NotFound when the volume vanished under the lock

make_volume_readonly looked the volume up, notified the master (step 1),
then took the store write lock (step 2) and marked the volume only `if
let Some(..)`. When the volume left the store during step 1 -- a master
round trip, during which an unmount or a heartbeat expiry can land --
the missing else meant the RPC reported success for a volume the server
no longer has, and step 3 told the master again that it is read-only.

Go's Store.MarkVolumeReadonly (weed/storage/store.go) returns
"volume %d not found" when findVolume comes back nil, and
makeVolumeReadonly (weed/server/volume_grpc_admin.go) returns that error
before the step-3 notification. The Rust step 2 now does the same:
find_volume_mut(vid) -> Status::not_found("volume {vid} not found"), and
the `?` skips step 3, as it already did for a set_read_only_persist
failure. The scrub caller already matches NotFound to skip such a
volume instead of failing the whole report; it now actually gets it.
volume_mark_writable already returns NotFound under its write lock.

The regression test opens the step-1 window deterministically: step 1
awaits the current_master_url read lock, so the test holds its write
guard, lets make_volume_readonly park there after its own lookup
succeeded, unmounts the volume, then releases the guard. With no master
configured the notification is a no-op, so the write lock in step 2 is
the only place left that can notice the volume is gone.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* volume server: trim comments on the vanished-volume mark-readonly path

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

2026-09-25 22:05:53 +08:00

..

debug.rs

rust: cargo fmt both crates, with a commented-out fmt --check CI step (#11329)

2026-09-15 09:29:22 -07:00

favicon.ico

adjust logo

2026-04-23 10:05:51 -07:00

grpc_client.rs

rust volume: build outgoing gRPC clients in one place and give every dial a connect timeout (#11354)

2026-09-20 19:41:37 -07:00

grpc_server.rs

volume server: VolumeMarkReadonly answers NotFound when the volume vanished under the lock (#11443)

2026-09-25 22:05:53 +08:00

handlers.rs

volume server: the write queue answers uploads with the needle's real ETag (#11414)

2026-09-24 07:08:36 +08:00

heartbeat.rs

volume: an EC volume needs an .ecx to mount, and a 0-byte stub never outranks a real index (#11415)

2026-09-24 07:08:56 +08:00

memory_status.rs

rust volume: document every unsafe block and stop mutating the process env in tests (#11352)

2026-09-20 13:29:07 -07:00

mod.rs

rust volume: share the I/O-error tracker between Volume and EcVolume (#11351)

2026-09-20 16:57:23 -07:00

profiling.rs

grpc: optional client_cert/client_key for outgoing mTLS connections (#10747)

2026-08-13 13:15:20 -07:00

request_id.rs

rust: tonic 0.14 / prost 0.14, drop the result_large_err allow (#11327)

2026-09-15 04:40:46 -07:00

server_stats.rs

Rust volume server implementation with CI (#8539)

2026-03-26 17:24:35 -07:00

store_ec.rs

volume server: HTTP DELETE on a distributed EC volume (#11405)

2026-09-20 23:26:31 -07:00

ui.rs

rust volume: share the I/O-error tracker between Volume and EcVolume (#11351)

2026-09-20 16:57:23 -07:00

volume_server.rs

rust volume: one S3 tier registry instead of two kept in sync by hand (#11357)

2026-09-20 13:30:40 -07:00

write_queue.rs

rust volume: one S3 tier registry instead of two kept in sync by hand (#11357)

2026-09-20 13:30:40 -07:00