Phase 4: sync
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Implements PLAN.md Phase 4: the read model. /sync, /messages and /context, the filters that narrow them, and the streams a response carries that are not room events — typing, receipts, presence and to-device messages. With this a client can be used against Warp, which is milestone M1. The one architectural choice is that the syncapi has no copy of the rooms: it reads them through the roomserver. Dendrite gives its syncapi its own tables and feeds them from the output stream, which is right for a design where the two can be separate processes, and Dendrite's could be. Warp is one process by decision, and there the copy buys nothing and costs the hardest class of bug a homeserver has — a read model that disagrees with the room, where a client is shown a message that was rejected and the only way to find out is to compare two tables. So the roomserver grew a read model (stream.go, roomsync.go, visibility.go) rather than exporting its store: reading an event means parsing it under its room's version, and a second copy of the version registry, the parser and the client projection would be a second place for them to disagree. syncapi: stream tokens naming a position in each of five independent streams, so a client that has seen receipt 7 but only event 4 can say so in one opaque string. A token with fewer positions than this build writes is accepted and the rest read as zero, which is what lets a token stored before a stream existed go on working. The PDU position comes from MAX(stream_ordering) and not from the counter row the other four use: the counter is advanced inside the writing transaction, so a token taken from it would name a position whose event no reader can see yet, and the event would be skipped for good once that transaction committed. Long polling goes through a notifier that wakes by room and by user rather than globally — an event wakes the listeners of its room, a membership event also wakes the user it names, so an invite reaches a client that is not in the room yet. A wake-up is only ever a hint: the listener re-reads the streams and decides for itself what changed, which is what makes it safe for the notifier to hold no state about what each client has seen. The listener registers before the read, so an event landing in between leaves the channel signalled and the sync reads again rather than blocking on a change it just missed. EventPersisted must not block, because it is called with the room's write lock still held. "Something happened" is not "a token moved". A stream can move without this user being concerned by it, and returning on every such move would turn a long poll back into a busy loop. The same trap caught presence twice over: a client says it is still online by syncing, so ?set_presence= makes every sync a presence write, and a stream that moved each time would wake every peer, which would sync, which would move it again. SetPresence therefore reports whether anything a peer would notice actually changed, and a write that only refreshes the last-active timestamp leaves the stream alone. Timeline windows are named by their two ends and a direction, Low exclusive and High inclusive in both directions, rather than by "from" and "to" as the wire format spells them. Each of those would otherwise be the low bound in one direction and the high bound in the other, which is exactly the off-by-one every pagination bug is made of; the handlers translate once and nothing below them thinks about it again. A sync's timeline is read backwards and reported forwards, because a client wants the newest events of the window it missed — a forward read with a limit hands it the oldest and then calls the rest a gap. visibility: history visibility is now a span rather than a yes or no, which is what Phase 3 deferred here. A user who has left a room is served the room as it was when they left — their state reads, their members and their timeline — instead of being refused, and is bounded above at their own membership event so a kicked client cannot go on streaming. Their span is found from their own member events, so a user who joined, left and rejoined sees their latest span. ?at= on /members is honoured for the same reason. What is left is that the span is computed from the room's current history_visibility where the spec judges each event by the one in force when it was sent; that is a state read per event and belongs with open question 1. Typing is held in memory and nowhere else: notifications expire in seconds, are worthless across a restart, and arrive one per keystroke-burst per room, so persisting them would be the busiest table in the database holding the least valuable data in it. Receipts only ever advance, compared on the position of the event acknowledged rather than on arrival, because two of a user's clients read at different speeds and the slower one must not drag the marker backwards. To-device queues are per device and drained by the next sync rather than by the one that delivered them, so a client that crashes in between gets the batch again — the right way round, since a lost key share leaves a message permanently undecryptable and a duplicate is ignored. A wildcard addressee is expanded when sent, not stored, because "every device" means the ones that existed then. Presence is off by default, which answers PLAN.md open question 3. It is the noisiest thing in Matrix and the one genuinely fan-out notification here; a private homeserver gains little from it. With it off the endpoints refuse rather than disappearing, because a client that gets a 404 from /presence concludes the server is too old to have it and stops asking. storage: one migration per driver adding the receipt, to-device, presence and filter tables with a counter row each, and a stream position on the existing account data table rather than a parallel one — there is exactly one current value per (user, room, type), and a second table would be a second thing to keep in step. Account data is reported in an event list but is not an event, so it gets its own response type: a room event with an empty sender and no timestamp would make a client decide what that meant. Deliberately missing, each named in docs/sync.md: notification counts (they need push rules, Phase 8), device lists (the keyserver, Phase 7), anything remote (Phase 5), threads (Phase 10). device_lists is sent as two empty lists because a client reads a missing one as malformed; the notification counts are left out entirely, because a zero there is a claim and an absent field is not. Tested through HTTP rather than against the builder, because what is worth pinning down is the response a client sees — which section a room lands in, whether a token handed back can be handed in again, whether paging terminates and loses nothing. The storage tests run against both SQL drivers; the notifier has its own tests for the concurrent case. A live server was driven end to end, which is what caught the two bugs the unit tests had missed: a backwards /messages page must be in reverse chronological order, and `start` must name where the page began rather than position zero when ?from= was omitted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
c96f88e994
commit
d187ad0d17
60 files changed
+10196
-264
No files matched your search
@@ -0,0 +1,100 @@
|
||||
-- The sync read model: the streams /sync reports that are not room events,
|
||||
-- and the filters a client uploads.
|
||||
--
|
||||
-- A room event's position in the event stream is its stream_ordering in
|
||||
-- roomserver_events, and nothing here duplicates it. What is here is
|
||||
-- everything else a sync response carries, each with a stream of its own:
|
||||
-- read receipts, to-device messages, presence and account data all change
|
||||
-- without any event being sent, and a client that has seen receipt 7 but
|
||||
-- only event 4 has to be able to say so in one token.
|
||||
--
|
||||
-- Typing notifications are deliberately absent. They expire after seconds,
|
||||
-- they are worthless after a restart, and writing them to disk would mean a
|
||||
-- row per keystroke-burst per room; they live in memory in the syncapi.
|
||||
|
||||
-- One counter row per stream, incremented inside the writing transaction.
|
||||
-- Same reasoning as roomserver_sequences: an UPDATE takes a row lock in
|
||||
-- both engines and hands out gapless positions, which a sequence does not.
|
||||
CREATE TABLE IF NOT EXISTS sync_sequences (
|
||||
name TEXT NOT NULL PRIMARY KEY,
|
||||
value BIGINT NOT NULL
|
||||
);
|
||||
|
||||
INSERT INTO sync_sequences (name, value) VALUES ('receipt', 0) ON CONFLICT (name) DO NOTHING;
|
||||
INSERT INTO sync_sequences (name, value) VALUES ('to_device', 0) ON CONFLICT (name) DO NOTHING;
|
||||
INSERT INTO sync_sequences (name, value) VALUES ('account_data', 0) ON CONFLICT (name) DO NOTHING;
|
||||
INSERT INTO sync_sequences (name, value) VALUES ('presence', 0) ON CONFLICT (name) DO NOTHING;
|
||||
|
||||
-- Account data gets a stream position so that an incremental sync can ask
|
||||
-- for the blobs that changed rather than re-sending every one of them. The
|
||||
-- column goes on the existing table rather than into a parallel one: there
|
||||
-- is exactly one current value per (user, room, type), and a second table
|
||||
-- would be a second thing to keep in step with it.
|
||||
ALTER TABLE user_account_data ADD COLUMN stream_pos BIGINT NOT NULL DEFAULT 0;
|
||||
|
||||
CREATE INDEX IF NOT EXISTS user_account_data_stream_idx
|
||||
ON user_account_data (localpart, stream_pos);
|
||||
|
||||
-- Read receipts. Only the latest receipt of each (user, type, thread) in a
|
||||
-- room is kept: a receipt supersedes the one before it, and /sync reports
|
||||
-- the current one rather than a history.
|
||||
CREATE TABLE IF NOT EXISTS sync_receipts (
|
||||
room_id TEXT NOT NULL,
|
||||
user_id TEXT NOT NULL,
|
||||
-- m.read or m.read.private.
|
||||
receipt_type TEXT NOT NULL,
|
||||
-- The thread the receipt is for, or '' for the room's main timeline.
|
||||
-- Threads are Phase 10; the column is here because the key would
|
||||
-- otherwise have to change when they arrive, and a receipt table is
|
||||
-- not something to migrate twice.
|
||||
thread_id TEXT NOT NULL DEFAULT '',
|
||||
event_id TEXT NOT NULL,
|
||||
-- When the receipt was sent, which clients show as "read at".
|
||||
ts_ms BIGINT NOT NULL,
|
||||
stream_pos BIGINT NOT NULL,
|
||||
PRIMARY KEY (room_id, user_id, receipt_type, thread_id)
|
||||
);
|
||||
|
||||
CREATE INDEX IF NOT EXISTS sync_receipts_stream_idx
|
||||
ON sync_receipts (stream_pos);
|
||||
|
||||
CREATE INDEX IF NOT EXISTS sync_receipts_room_stream_idx
|
||||
ON sync_receipts (room_id, stream_pos);
|
||||
|
||||
-- To-device messages: a queue per device, drained by the device
|
||||
-- acknowledging a later sync token rather than by reading it.
|
||||
CREATE TABLE IF NOT EXISTS sync_to_device (
|
||||
stream_pos BIGINT NOT NULL PRIMARY KEY,
|
||||
localpart TEXT NOT NULL,
|
||||
device_id TEXT NOT NULL,
|
||||
sender TEXT NOT NULL,
|
||||
event_type TEXT NOT NULL,
|
||||
content TEXT NOT NULL,
|
||||
sent_at_ms BIGINT NOT NULL
|
||||
);
|
||||
|
||||
CREATE INDEX IF NOT EXISTS sync_to_device_device_idx
|
||||
ON sync_to_device (localpart, device_id, stream_pos);
|
||||
|
||||
-- Presence. One row per user, the current state and nothing historical.
|
||||
CREATE TABLE IF NOT EXISTS sync_presence (
|
||||
user_id TEXT NOT NULL PRIMARY KEY,
|
||||
presence TEXT NOT NULL,
|
||||
status_msg TEXT NOT NULL DEFAULT '',
|
||||
last_active_ms BIGINT NOT NULL,
|
||||
stream_pos BIGINT NOT NULL
|
||||
);
|
||||
|
||||
CREATE INDEX IF NOT EXISTS sync_presence_stream_idx
|
||||
ON sync_presence (stream_pos);
|
||||
|
||||
-- Uploaded filters. The JSON is stored as the client sent it: a filter is
|
||||
-- returned verbatim by GET /user/{userID}/filter/{filterID}, and clients
|
||||
-- compare what they get back with what they uploaded.
|
||||
CREATE TABLE IF NOT EXISTS sync_filters (
|
||||
localpart TEXT NOT NULL,
|
||||
filter_id TEXT NOT NULL,
|
||||
filter_json TEXT NOT NULL,
|
||||
created_at_ms BIGINT NOT NULL,
|
||||
PRIMARY KEY (localpart, filter_id)
|
||||
);
|
||||
Reference in new issue
Block a user