Files
Warp/server/internal/roomserver/verify.go
T
tajniak81andClaude Opus 5.5 6aaf554336
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Phase 5: federation
Implements PLAN.md Phase 5: the Server-Server API. Warp joins rooms on
other servers and lets their users join its rooms, invites across servers
with the invitee's server countersigning, rejects remote invites (locally
if the inviter is unreachable), and exchanges events, typing, receipts and
to-device messages with other homeservers — all behind the runtime switch,
which now starts and stops real outbound traffic.

The protocol lives in internal/federation with no knowledge of rooms:
X-Matrix signing (fuzzed parser), the spec's discovery algorithm keeping
the dial address and the TLS name apart, a signed client that refuses
every request while the switch is off or the policy denies the
destination, and a key ring that caches other servers' keys for at most a
week, with optional notaries.

The roomserver takes events from elsewhere through the spec's intake:
signatures and hashes (a hash mismatch keeps the redacted form), the rules
against the event's own auth events, against the state before it — with
/get_missing_events for small gaps and /state_ids for wide ones — and
against the current state, where a failure is a soft failure. Events held
without their state are outliers: a column on roomserver_events, because
the current state of a room joined over federation is almost all
outliers, and excluded from every timeline query. Forks are resolved at
the room's head. Membership across servers is make_join/send_join,
make_leave/send_leave and countersigned invites, in both directions;
m.room.server_acl is enforced on everything another server sends.
History before a remote join is backfilled when /messages pages past it,
stored at negative stream positions.

internal/federationapi is the running component: the inbound endpoints,
and an outbound queue that persists what it owes each destination, sends
it in transactions of 50 PDUs and 100 EDUs, backs off from ten seconds to
six hours, survives restarts, and drops events persisted while federation
is off rather than delivering a backlog in one burst. Its Module is what
the switch starts and stops.

Also: a TLS listener for port 8448, trusted key servers, key validity and
an outbound CA bundle in the config; per-destination health and backoff
reset in the admin API; remote profiles, aliases and directories in the
Client-Server API; a Complement federation profile. See
docs/federation.md, including its known gaps (no partial-state joins, no
key rotation).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 17:14:20 +02:00

77 lines
2.8 KiB
Go

package roomserver
import (
"context"
"fmt"
"github.com/dariuszjaniak/warp/server/internal/matrix/auth"
"github.com/dariuszjaniak/warp/server/internal/matrix/event"
"github.com/dariuszjaniak/warp/server/internal/matrix/signing"
)
// eventVerifier checks an event's signature from a named server.
//
// This server's own signatures are checked against the key in hand, which
// is what keeps every rule that needs a signature — a restricted join
// authorised by a local user, chiefly — working with federation off.
// Anybody else's go to the key ring, and only while federation is on: with
// it off there is no way to fetch a key, and a signature that cannot be
// checked is refused rather than waved through, the same answer the switch
// gives everywhere else.
type eventVerifier struct {
serverName string
key *signing.KeyPair
remote auth.Verifier
enabled func() bool
}
// verifier returns the Verifier the authorisation rules are given.
func (r *API) verifier() *eventVerifier {
return &eventVerifier{
serverName: r.serverName,
key: r.signingKey,
remote: r.keys,
enabled: r.federationEnabled,
}
}
// VerifyEventSignature implements auth.Verifier.
func (v *eventVerifier) VerifyEventSignature(ctx context.Context, serverName string, e *event.Event) error {
if serverName == v.serverName {
return e.VerifySignature(v.serverName, v.key.KeyID(), v.key.Public)
}
if v.remote == nil || !v.enabled() {
return fmt.Errorf("%w: cannot verify a signature from %s", ErrFederationDisabled, serverName)
}
return v.remote.VerifyEventSignature(ctx, serverName, e)
}
// verifyIncoming checks an event from another server before anything else
// looks at it: it must be signed by its sender's server, and its content
// must match its hash.
//
// A content hash mismatch is not a rejection. The signature covers only
// what a redaction keeps, so an event whose signature verifies and whose
// hash does not is an event somebody has redacted — legitimately, or by
// tampering with the parts the signature does not cover — and the spec's
// answer to both is the same: keep the redacted form.
func (r *API) verifyIncoming(ctx context.Context, e *event.Event) (*event.Event, error) {
sender, err := e.SenderServer()
if err != nil {
return nil, fmt.Errorf("%w: %s: %v", ErrBadEvent, e.EventID(), err)
}
if err := r.verifier().VerifyEventSignature(ctx, sender, e); err != nil {
return nil, fmt.Errorf("%w: %s is not signed by %s: %v", ErrBadEvent, e.EventID(), sender, err)
}
if err := e.VerifyContentHash(); err != nil {
redacted, rerr := e.Redact()
if rerr != nil {
return nil, fmt.Errorf("%w: %s: %v", ErrBadEvent, e.EventID(), rerr)
}
r.log.Info("event failed its content hash; using its redacted form",
"event_id", e.EventID(), "sender", e.Sender())
return redacted, nil
}
return e, nil
}