Files
Warp/server/internal/httputil/errors.go
T
tajniak81andClaude Opus 5 c96f88e994
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Phase 3: rooms, local only
Implements PLAN.md Phase 3: the roomserver, the room half of storage, the
Client-Server room endpoints and the admin room endpoints. A client can now
create a room, invite, join, leave, kick, ban, send messages and state,
redact, name a room with an alias and find one in the public directory.
Nothing talks to another server; every operation that would need to is
refused with a message that says so rather than a bare M_FORBIDDEN.

roomserver: one input pipeline every event goes through, whatever sent it —
validate, authorise, resolve, persist, emit. The rules are not
reimplemented here; internal/matrix is pure library code and this is what
connects it to a database and to a room's history. The Client-Server
handlers do no authorisation of their own, deliberately: whether Alice may
kick Bob is a question about the room's power levels, and the one place
that is answered correctly is the authorisation rules inside the pipeline.

A mutex per room serialises writers. Two events racing into one room would
each read the same forward extremities, both become one, and fork the room
for no reason — which would then need state resolution to put back
together. State resolution is wired in anyway for the multi-extremity
case. It is unreachable from outside in this phase, and the alternative is
a pipeline that authorises against one arbitrary branch of a fork without
saying so.

Room versions 3 to 12 all work and are each tested end to end. Version 12
earns that coverage: its room ID is the create event's own ID, its create
event carries no room_id, and the create event is excluded from every other
event's auth_events — so the state auth.Check is given is the event's
auth_events plus the create event, which that version identifies by room ID
rather than citing.

createRoom sends the spec's events in the spec's order, each authorised
against what the ones before it produced. A failure part-way leaves an
incomplete room, which is the lesser evil: the alternative is holding every
event of a new room in memory and writing them in one transaction, making
the pipeline that authorises them a special case. The one failure a second
client can cause at any time, an alias clash, takes the room row back out.

Redactions stay two decisions, as the spec keeps them. The rules let almost
any redaction into the room; whether it applies to its target is a separate
test, run inside the same transaction as the redaction itself so that a
client holding an event ID can always read the stripped event.

storage: events keyed by event ID rather than by a surrogate, since an
event ID appears in prev_events, auth_events, state snapshots and client
requests alike. Stream ordering comes from a counter row bumped inside the
write transaction, because a PostgreSQL sequence is explicitly not
transactional and a rolled-back write would leave a hole in the stream that
/sync would have to be taught to skip. State snapshots are stored per event
and deduplicated by content hash, so the table grows with state changes
rather than with traffic — and that is what makes "the state after a
forward extremity" answerable at all. The room's listing columns are
denormalised onto its row because the public directory orders every
published room by member count and pages the result, which cannot be done
by reading each room's state in turn.

Federation-disabled behaviour from PLAN.md section 3 is enforced here.
Restricted joins are the exception that works: the rule needs a signature
from the authorising user's server verified, and while federation is off
that server is always this one.

adminapi: room list and detail, purge, force-leave, and room and event
counters on the dashboard. clientapi gains its own rate-limit buckets for
createRoom and for joining, both of which write events rather than read
them.

Tested against the real event core and a real database rather than fakes:
what is under test is whether an event this server signs is one the
authorisation rules accept, and a fake of either would only prove that the
pipeline calls what the fake expects. The storage tests run against both
SQL drivers. docs/rooms.md describes the pipeline, the storage decisions
and the known gaps — chief among them that history visibility is
room-level rather than per-event, and that /sync still reports no rooms,
both of which belong with the event stream in Phase 4.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-10-16 10:34:57 +02:00

166 lines
5.8 KiB
Go

// Package httputil holds the HTTP plumbing shared by every Warp API: the
// Matrix error envelope, JSON helpers, CORS and middleware.
package httputil
import (
"fmt"
"net/http"
)
// Matrix error codes used so far. The full list lives in the Client-Server
// API spec, section "Standard error response"; codes are added as the
// endpoints that return them are implemented.
const (
ErrCodeForbidden = "M_FORBIDDEN"
ErrCodeUnknownToken = "M_UNKNOWN_TOKEN"
ErrCodeMissingToken = "M_MISSING_TOKEN"
ErrCodeBadJSON = "M_BAD_JSON"
ErrCodeNotJSON = "M_NOT_JSON"
ErrCodeNotFound = "M_NOT_FOUND"
ErrCodeLimitExceeded = "M_LIMIT_EXCEEDED"
ErrCodeUnknown = "M_UNKNOWN"
ErrCodeUnrecognized = "M_UNRECOGNIZED"
ErrCodeUnauthorized = "M_UNAUTHORIZED"
ErrCodeMissingParam = "M_MISSING_PARAM"
ErrCodeInvalidParam = "M_INVALID_PARAM"
ErrCodeTooLarge = "M_TOO_LARGE"
ErrCodeUnsupportedVer = "M_UNSUPPORTED_ROOM_VERSION"
// Room codes, added with the roomserver in Phase 3.
ErrCodeRoomInUse = "M_ROOM_IN_USE"
// Account and session codes, added with the userapi in Phase 1.
ErrCodeUserInUse = "M_USER_IN_USE"
ErrCodeInvalidUsername = "M_INVALID_USERNAME"
ErrCodeUserDeactivated = "M_USER_DEACTIVATED"
ErrCodeExclusive = "M_EXCLUSIVE"
ErrCodeWeakPassword = "M_WEAK_PASSWORD"
)
// MatrixError is the standard Matrix error envelope. Every non-2xx response
// from a /_matrix endpoint is one of these, serialised as
//
// {"errcode": "M_FORBIDDEN", "error": "..."}
//
// It implements error so handlers can return it up the stack.
type MatrixError struct {
Code string `json:"errcode"`
Message string `json:"error"`
// RetryAfterMS accompanies M_LIMIT_EXCEEDED.
RetryAfterMS int64 `json:"retry_after_ms,omitempty"`
// SoftLogout accompanies M_UNKNOWN_TOKEN when the client may keep its
// encryption state and re-login.
SoftLogout bool `json:"soft_logout,omitempty"`
// status is the HTTP status to send; not part of the JSON body.
status int
}
func (e *MatrixError) Error() string {
return fmt.Sprintf("%s: %s", e.Code, e.Message)
}
// StatusCode is the HTTP status this error is sent with.
func (e *MatrixError) StatusCode() int {
if e.status == 0 {
return http.StatusInternalServerError
}
return e.status
}
// NewError builds an arbitrary Matrix error.
func NewError(status int, code, format string, args ...any) *MatrixError {
return &MatrixError{Code: code, Message: fmt.Sprintf(format, args...), status: status}
}
// Forbidden is M_FORBIDDEN (403). Federation-disabled rejections use it.
func Forbidden(format string, args ...any) *MatrixError {
return NewError(http.StatusForbidden, ErrCodeForbidden, format, args...)
}
// NotFound is M_NOT_FOUND (404) for a resource that could exist but does not.
func NotFound(format string, args ...any) *MatrixError {
return NewError(http.StatusNotFound, ErrCodeNotFound, format, args...)
}
// Unrecognized is M_UNRECOGNIZED (404), the spec's answer for an endpoint
// this server does not implement at all.
func Unrecognized() *MatrixError {
return NewError(http.StatusNotFound, ErrCodeUnrecognized, "Unrecognized request")
}
// MethodNotAllowed is M_UNRECOGNIZED (405) for a known path, wrong verb.
func MethodNotAllowed() *MatrixError {
return NewError(http.StatusMethodNotAllowed, ErrCodeUnrecognized, "Unrecognized request")
}
// NotJSON is M_NOT_JSON (400): the body was not valid JSON at all.
func NotJSON() *MatrixError {
return NewError(http.StatusBadRequest, ErrCodeNotJSON, "Content not JSON")
}
// BadJSON is M_BAD_JSON (400): valid JSON, wrong shape.
func BadJSON(format string, args ...any) *MatrixError {
return NewError(http.StatusBadRequest, ErrCodeBadJSON, format, args...)
}
// MissingParam is M_MISSING_PARAM (400).
func MissingParam(format string, args ...any) *MatrixError {
return NewError(http.StatusBadRequest, ErrCodeMissingParam, format, args...)
}
// InvalidParam is M_INVALID_PARAM (400).
func InvalidParam(format string, args ...any) *MatrixError {
return NewError(http.StatusBadRequest, ErrCodeInvalidParam, format, args...)
}
// MissingToken is M_MISSING_TOKEN (401).
func MissingToken() *MatrixError {
return NewError(http.StatusUnauthorized, ErrCodeMissingToken, "Missing access token")
}
// UnknownToken is M_UNKNOWN_TOKEN (401).
func UnknownToken(softLogout bool) *MatrixError {
err := NewError(http.StatusUnauthorized, ErrCodeUnknownToken, "Unrecognised access token")
err.SoftLogout = softLogout
return err
}
// LimitExceeded is M_LIMIT_EXCEEDED (429).
func LimitExceeded(retryAfterMS int64) *MatrixError {
err := NewError(http.StatusTooManyRequests, ErrCodeLimitExceeded, "Too many requests")
err.RetryAfterMS = retryAfterMS
return err
}
// InternalError is M_UNKNOWN (500). The message is deliberately vague: the
// detail belongs in the log, not in the response.
func InternalError() *MatrixError {
return NewError(http.StatusInternalServerError, ErrCodeUnknown, "Internal server error")
}
// UserInUse is M_USER_IN_USE (400): the requested user name is taken.
func UserInUse() *MatrixError {
return NewError(http.StatusBadRequest, ErrCodeUserInUse, "Desired user ID is already taken")
}
// InvalidUsername is M_INVALID_USERNAME (400): the user name is not usable,
// either because of its characters or its length.
func InvalidUsername(format string, args ...any) *MatrixError {
return NewError(http.StatusBadRequest, ErrCodeInvalidUsername, format, args...)
}
// UserDeactivated is M_USER_DEACTIVATED (403).
func UserDeactivated() *MatrixError {
return NewError(http.StatusForbidden, ErrCodeUserDeactivated, "This account has been deactivated")
}
// Unknown is M_UNKNOWN with an explicit status, for the handful of cases the
// spec answers with that code rather than a specific one — an unsupported
// login type, for instance.
func Unknown(status int, format string, args ...any) *MatrixError {
return NewError(status, ErrCodeUnknown, format, args...)
}