Files
Warp/server/internal/storage/sync.go
T
tajniak81andClaude Opus 5 d187ad0d17
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Phase 4: sync
Implements PLAN.md Phase 4: the read model. /sync, /messages and /context,
the filters that narrow them, and the streams a response carries that are
not room events — typing, receipts, presence and to-device messages. With
this a client can be used against Warp, which is milestone M1.

The one architectural choice is that the syncapi has no copy of the rooms:
it reads them through the roomserver. Dendrite gives its syncapi its own
tables and feeds them from the output stream, which is right for a design
where the two can be separate processes, and Dendrite's could be. Warp is
one process by decision, and there the copy buys nothing and costs the
hardest class of bug a homeserver has — a read model that disagrees with
the room, where a client is shown a message that was rejected and the only
way to find out is to compare two tables. So the roomserver grew a read
model (stream.go, roomsync.go, visibility.go) rather than exporting its
store: reading an event means parsing it under its room's version, and a
second copy of the version registry, the parser and the client projection
would be a second place for them to disagree.

syncapi: stream tokens naming a position in each of five independent
streams, so a client that has seen receipt 7 but only event 4 can say so in
one opaque string. A token with fewer positions than this build writes is
accepted and the rest read as zero, which is what lets a token stored
before a stream existed go on working. The PDU position comes from
MAX(stream_ordering) and not from the counter row the other four use: the
counter is advanced inside the writing transaction, so a token taken from
it would name a position whose event no reader can see yet, and the event
would be skipped for good once that transaction committed.

Long polling goes through a notifier that wakes by room and by user rather
than globally — an event wakes the listeners of its room, a membership
event also wakes the user it names, so an invite reaches a client that is
not in the room yet. A wake-up is only ever a hint: the listener re-reads
the streams and decides for itself what changed, which is what makes it
safe for the notifier to hold no state about what each client has seen. The
listener registers before the read, so an event landing in between leaves
the channel signalled and the sync reads again rather than blocking on a
change it just missed. EventPersisted must not block, because it is called
with the room's write lock still held.

"Something happened" is not "a token moved". A stream can move without this
user being concerned by it, and returning on every such move would turn a
long poll back into a busy loop. The same trap caught presence twice over:
a client says it is still online by syncing, so ?set_presence= makes every
sync a presence write, and a stream that moved each time would wake every
peer, which would sync, which would move it again. SetPresence therefore
reports whether anything a peer would notice actually changed, and a write
that only refreshes the last-active timestamp leaves the stream alone.

Timeline windows are named by their two ends and a direction, Low exclusive
and High inclusive in both directions, rather than by "from" and "to" as
the wire format spells them. Each of those would otherwise be the low bound
in one direction and the high bound in the other, which is exactly the
off-by-one every pagination bug is made of; the handlers translate once and
nothing below them thinks about it again. A sync's timeline is read
backwards and reported forwards, because a client wants the newest events
of the window it missed — a forward read with a limit hands it the oldest
and then calls the rest a gap.

visibility: history visibility is now a span rather than a yes or no, which
is what Phase 3 deferred here. A user who has left a room is served the
room as it was when they left — their state reads, their members and their
timeline — instead of being refused, and is bounded above at their own
membership event so a kicked client cannot go on streaming. Their span is
found from their own member events, so a user who joined, left and rejoined
sees their latest span. ?at= on /members is honoured for the same reason.
What is left is that the span is computed from the room's current
history_visibility where the spec judges each event by the one in force
when it was sent; that is a state read per event and belongs with open
question 1.

Typing is held in memory and nowhere else: notifications expire in seconds,
are worthless across a restart, and arrive one per keystroke-burst per
room, so persisting them would be the busiest table in the database holding
the least valuable data in it. Receipts only ever advance, compared on the
position of the event acknowledged rather than on arrival, because two of a
user's clients read at different speeds and the slower one must not drag
the marker backwards. To-device queues are per device and drained by the
next sync rather than by the one that delivered them, so a client that
crashes in between gets the batch again — the right way round, since a lost
key share leaves a message permanently undecryptable and a duplicate is
ignored. A wildcard addressee is expanded when sent, not stored, because
"every device" means the ones that existed then.

Presence is off by default, which answers PLAN.md open question 3. It is
the noisiest thing in Matrix and the one genuinely fan-out notification
here; a private homeserver gains little from it. With it off the endpoints
refuse rather than disappearing, because a client that gets a 404 from
/presence concludes the server is too old to have it and stops asking.

storage: one migration per driver adding the receipt, to-device, presence
and filter tables with a counter row each, and a stream position on the
existing account data table rather than a parallel one — there is exactly
one current value per (user, room, type), and a second table would be a
second thing to keep in step. Account data is reported in an event list but
is not an event, so it gets its own response type: a room event with an
empty sender and no timestamp would make a client decide what that meant.

Deliberately missing, each named in docs/sync.md: notification counts (they
need push rules, Phase 8), device lists (the keyserver, Phase 7), anything
remote (Phase 5), threads (Phase 10). device_lists is sent as two empty
lists because a client reads a missing one as malformed; the notification
counts are left out entirely, because a zero there is a claim and an absent
field is not.

Tested through HTTP rather than against the builder, because what is worth
pinning down is the response a client sees — which section a room lands in,
whether a token handed back can be handed in again, whether paging
terminates and loses nothing. The storage tests run against both SQL
drivers; the notifier has its own tests for the concurrent case. A live
server was driven end to end, which is what caught the two bugs the unit
tests had missed: a backwards /messages page must be in reverse
chronological order, and `start` must name where the page began rather than
position zero when ?from= was omitted.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-10-16 11:55:27 +02:00

297 lines
10 KiB
Go

package storage
import (
"context"
"errors"
)
// Errors the sync store returns for cases a caller has to tell apart.
var (
// ErrNoSuchFilter is returned for a filter ID the user has not
// uploaded.
ErrNoSuchFilter = errors.New("no such filter")
)
// StreamPositions is the top of every stream a sync token points into, read
// in one call.
//
// A sync response is assembled from several independent streams, and the
// token it returns has to name a position in each. Reading them one at a
// time would let a stream move between two of the reads, and the client
// would then be handed a token that skips whatever landed in the gap.
type StreamPositions struct {
// PDU is the room event stream: the highest stream ordering in
// roomserver_events.
PDU int64
Receipt int64
ToDevice int64
AccountData int64
Presence int64
}
// TimelineDirection is which way a timeline read walks the stream.
type TimelineDirection string
// The two directions, spelled as the Client-Server API spells them in
// /messages' `dir` parameter.
const (
// DirectionForward reads oldest first, which is the order /sync hands
// events to a client.
DirectionForward TimelineDirection = "f"
// DirectionBackward reads newest first, which is how /messages pages
// back through a room's history.
DirectionBackward TimelineDirection = "b"
)
// TimelineRequest is one window of a room's event stream.
//
// The window is named by its two ends rather than by a direction and a
// starting point, because the two are independent: which end the limit
// trims, and which order the rows come back in, is Direction's business,
// and nothing else about the request changes with it. Spelling the bounds
// as "from" and "to" instead would mean each of them being the low bound in
// one direction and the high bound in the other, which is exactly the
// off-by-one every pagination bug is made of.
//
// Low is exclusive and High inclusive, in both directions. That is what
// lets a token a client was handed be passed straight back without
// re-reading the event it names: a position is somewhere a client has got
// to, not an event it still wants.
type TimelineRequest struct {
RoomID string
// Low is an exclusive lower bound. Zero means the start of the room.
Low int64
// High is an inclusive upper bound. Zero means the top of the stream,
// and goes on meaning that as the stream grows.
High int64
// Direction decides which end of the window the limit trims — the
// bottom when reading backwards, the top when reading forwards — and
// the order the rows come back in.
Direction TimelineDirection
// Limit caps the rows returned. It is required: an unbounded timeline
// read is a way to ask the server to serialise a whole room.
Limit int
// Filter narrows which events come back. The store applies it in SQL
// because a filter applied after the limit would return fewer events
// than the client asked for and then look like the end of the room.
Filter TimelineFilter
}
// TimelineFilter is the part of a Client-Server API event filter that the
// store can apply itself.
//
// Only the fields that are a plain comparison on an indexed or stored
// column are here. The rest of a filter — `contains_url`, lazy-loading,
// `include_redundant_members` — is about what an event means or about how a
// response is assembled, and is applied by the syncapi.
type TimelineFilter struct {
// Types, when non-empty, admits only these event types. A trailing '*'
// is a wildcard, as the spec defines for filter patterns.
Types []string
// NotTypes excludes types, and wins over Types for an event matching
// both, which is what the spec requires.
NotTypes []string
// Senders, when non-empty, admits only these senders.
Senders []string
// NotSenders excludes senders, and likewise wins.
NotSenders []string
}
// IsEmpty reports whether the filter admits everything.
func (f TimelineFilter) IsEmpty() bool {
return len(f.Types) == 0 && len(f.NotTypes) == 0 &&
len(f.Senders) == 0 && len(f.NotSenders) == 0
}
// SyncMembership is a user's current membership in one room, with the
// position of the event that set it.
//
// The position is what bounds what a user who has left may see: their view
// of the room ends at their own leave event, and a room they were kicked
// out of must not keep streaming to them.
type SyncMembership struct {
RoomID string
Membership string
EventID string
// StreamOrdering is the position of the membership event.
StreamOrdering int64
}
// Receipt is one read receipt.
type Receipt struct {
RoomID string
UserID string
ReceiptType string
// ThreadID is the thread the receipt is for, or empty for the room's
// main timeline.
ThreadID string
EventID string
// TimestampMS is when the receipt was sent, which is what a client
// shows as "read at".
TimestampMS int64
// StreamPos is the receipt's position in the receipt stream.
StreamPos int64
}
// ToDeviceMessage is one message addressed to a single device.
type ToDeviceMessage struct {
// StreamPos is the message's position in the to-device stream.
StreamPos int64
Localpart string
DeviceID string
Sender string
Type string
// Content is the message body as the sender wrote it.
Content []byte
SentAtMS int64
}
// NewToDeviceMessage is one message to enqueue.
type NewToDeviceMessage struct {
Localpart string
// DeviceID is the device to deliver to. The caller has already expanded
// a wildcard addressee into one of these per device: which devices a
// user has is the userapi's business, not the store's.
DeviceID string
Sender string
Type string
Content []byte
SentAtMS int64
}
// PresenceState is a user's presence as the store holds it.
type PresenceState struct {
UserID string
// Presence is "online", "offline" or "unavailable".
Presence string
StatusMsg string
// LastActiveMS is when the user was last seen doing something.
LastActiveMS int64
// StreamPos is the position of the last change to this row.
StreamPos int64
}
// AccountDataEntry locates one account data blob that has changed. The
// content is not carried: a sync response needs to know which blobs to
// re-read, and reading them is a separate, cacheable call.
type AccountDataEntry struct {
// RoomID is empty for global account data.
RoomID string
DataType string
StreamPos int64
}
// StoredFilter is an uploaded filter.
type StoredFilter struct {
Localpart string
FilterID string
// JSON is the filter exactly as the client uploaded it.
JSON []byte
CreatedAtMS int64
}
// SyncStore persists the streams a sync response carries that are not room
// events, plus the filters clients upload: the storage half of the syncapi
// component.
//
// Typing notifications are not here on purpose. They expire in seconds and
// are worthless across a restart, so the syncapi keeps them in memory.
type SyncStore interface {
// StreamPositions reads the top of every stream in one call.
StreamPositions(ctx context.Context) (StreamPositions, error)
// SetReceipt records a read receipt, replacing any earlier one from the
// same user for the same type and thread, and returns its stream
// position.
//
// A receipt that would move backwards is not written and reports the
// current position with moved false: receipts only ever advance, and a
// client syncing on two devices would otherwise flap.
SetReceipt(ctx context.Context, r Receipt) (pos int64, moved bool, err error)
// Receipts returns the current receipts of the given rooms whose
// position is after from and at or before to. A from of 0 returns every
// current receipt, which is what an initial sync needs.
Receipts(ctx context.Context, roomIDs []string, from, to int64) ([]Receipt, error)
// ReceiptsForUser returns one user's own current receipts in the given
// rooms, whatever their position. A client needs its own read markers
// on an initial sync even when it set them long ago.
ReceiptsForUser(ctx context.Context, userID string, roomIDs []string) ([]Receipt, error)
// SendToDevice enqueues messages for delivery and returns the highest
// position it wrote. An empty batch is not an error and returns the
// current position.
SendToDevice(ctx context.Context, msgs []NewToDeviceMessage) (int64, error)
// ToDeviceMessages returns the messages queued for one device whose
// position is after from and at or before to, oldest first.
ToDeviceMessages(ctx context.Context, localpart, deviceID string, from, to int64, limit int) ([]ToDeviceMessage, error)
// DeleteToDeviceMessages removes the messages for a device at or before
// pos. A device acknowledges a batch by syncing past it, so this is
// what the next sync does with the batch before it.
DeleteToDeviceMessages(ctx context.Context, localpart, deviceID string, pos int64) error
// SetPresence records a user's presence and returns its stream
// position, reporting whether anything a peer would care about
// changed.
//
// A write that only refreshes LastActiveMS does not move the stream.
// A client says it is still online by syncing, so every sync is one of
// these — and a stream that moved each time would wake every peer's
// long poll, which would sync, which would move it again.
SetPresence(ctx context.Context, p PresenceState) (pos int64, moved bool, err error)
// Presence reads one user's presence, returning ErrNoSuchUser when
// nothing has ever been recorded for them.
Presence(ctx context.Context, userID string) (PresenceState, error)
// PresenceForUsers returns the presence of the given users whose
// position is after from and at or before to. A from of 0 returns every
// current state.
PresenceForUsers(ctx context.Context, userIDs []string, from, to int64) ([]PresenceState, error)
// AccountDataChanges lists the account data of a user that changed
// after from and at or before to.
AccountDataChanges(ctx context.Context, localpart string, from, to int64) ([]AccountDataEntry, error)
// AccountDataAt lists every account data blob a user has, as an initial
// sync needs.
AccountDataAt(ctx context.Context, localpart string, to int64) ([]AccountDataEntry, error)
// SaveFilter stores a filter under a new ID and returns it.
SaveFilter(ctx context.Context, localpart string, filter []byte, createdAtMS int64) (string, error)
// Filter reads an uploaded filter, returning ErrNoSuchFilter when the
// ID is unknown.
Filter(ctx context.Context, localpart, filterID string) ([]byte, error)
}