Files
Warp/server/internal/clientapi/directory.go
T
tajniak81andClaude Opus 5 c96f88e994
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Phase 3: rooms, local only
Implements PLAN.md Phase 3: the roomserver, the room half of storage, the
Client-Server room endpoints and the admin room endpoints. A client can now
create a room, invite, join, leave, kick, ban, send messages and state,
redact, name a room with an alias and find one in the public directory.
Nothing talks to another server; every operation that would need to is
refused with a message that says so rather than a bare M_FORBIDDEN.

roomserver: one input pipeline every event goes through, whatever sent it —
validate, authorise, resolve, persist, emit. The rules are not
reimplemented here; internal/matrix is pure library code and this is what
connects it to a database and to a room's history. The Client-Server
handlers do no authorisation of their own, deliberately: whether Alice may
kick Bob is a question about the room's power levels, and the one place
that is answered correctly is the authorisation rules inside the pipeline.

A mutex per room serialises writers. Two events racing into one room would
each read the same forward extremities, both become one, and fork the room
for no reason — which would then need state resolution to put back
together. State resolution is wired in anyway for the multi-extremity
case. It is unreachable from outside in this phase, and the alternative is
a pipeline that authorises against one arbitrary branch of a fork without
saying so.

Room versions 3 to 12 all work and are each tested end to end. Version 12
earns that coverage: its room ID is the create event's own ID, its create
event carries no room_id, and the create event is excluded from every other
event's auth_events — so the state auth.Check is given is the event's
auth_events plus the create event, which that version identifies by room ID
rather than citing.

createRoom sends the spec's events in the spec's order, each authorised
against what the ones before it produced. A failure part-way leaves an
incomplete room, which is the lesser evil: the alternative is holding every
event of a new room in memory and writing them in one transaction, making
the pipeline that authorises them a special case. The one failure a second
client can cause at any time, an alias clash, takes the room row back out.

Redactions stay two decisions, as the spec keeps them. The rules let almost
any redaction into the room; whether it applies to its target is a separate
test, run inside the same transaction as the redaction itself so that a
client holding an event ID can always read the stripped event.

storage: events keyed by event ID rather than by a surrogate, since an
event ID appears in prev_events, auth_events, state snapshots and client
requests alike. Stream ordering comes from a counter row bumped inside the
write transaction, because a PostgreSQL sequence is explicitly not
transactional and a rolled-back write would leave a hole in the stream that
/sync would have to be taught to skip. State snapshots are stored per event
and deduplicated by content hash, so the table grows with state changes
rather than with traffic — and that is what makes "the state after a
forward extremity" answerable at all. The room's listing columns are
denormalised onto its row because the public directory orders every
published room by member count and pages the result, which cannot be done
by reading each room's state in turn.

Federation-disabled behaviour from PLAN.md section 3 is enforced here.
Restricted joins are the exception that works: the rule needs a signature
from the authorising user's server verified, and while federation is off
that server is always this one.

adminapi: room list and detail, purge, force-leave, and room and event
counters on the dashboard. clientapi gains its own rate-limit buckets for
createRoom and for joining, both of which write events rather than read
them.

Tested against the real event core and a real database rather than fakes:
what is under test is whether an event this server signs is one the
authorisation rules accept, and a fake of either would only prove that the
pipeline calls what the fake expects. The storage tests run against both
SQL drivers. docs/rooms.md describes the pipeline, the storage decisions
and the known gaps — chief among them that history visibility is
room-level rather than per-event, and that /sync still reports no rooms,
both of which belong with the event stream in Phase 4.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-10-16 10:34:57 +02:00

212 lines
6.4 KiB
Go

package clientapi
import (
"net/http"
"strconv"
"github.com/dariuszjaniak/warp/server/internal/httputil"
"github.com/dariuszjaniak/warp/server/internal/roomserver"
"github.com/dariuszjaniak/warp/server/internal/userapi"
)
// aliasResponse is the GET /directory/room/{roomAlias} body.
type aliasResponse struct {
RoomID string `json:"room_id"`
Servers []string `json:"servers"`
}
// handleGetAlias implements GET /_matrix/client/v3/directory/room/{roomAlias}.
//
// The endpoint needs no token: a client that has been handed a link has to
// be able to turn it into a room ID before it can decide whether to log in,
// and the spec makes it unauthenticated for that reason.
func (c *ClientAPI) handleGetAlias(w http.ResponseWriter, r *http.Request) error {
alias, err := aliasFromPath(r)
if err != nil {
return err
}
resolved, err := c.rooms.ResolveAlias(r.Context(), alias)
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, aliasResponse{
RoomID: resolved.RoomID,
Servers: resolved.Servers,
})
return nil
}
// putAliasRequest is the PUT /directory/room/{roomAlias} body.
type putAliasRequest struct {
RoomID string `json:"room_id"`
}
// handlePutAlias implements PUT /_matrix/client/v3/directory/room/{roomAlias}.
func (c *ClientAPI) handlePutAlias(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
alias, err := aliasFromPath(r)
if err != nil {
return err
}
var req putAliasRequest
if err := httputil.DecodeJSON(w, r, &req); err != nil {
return err
}
if req.RoomID == "" {
return httputil.MissingParam("A room ID is required")
}
if err := c.rooms.CreateAlias(r.Context(), alias, req.RoomID, auth.UserID); err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, struct{}{})
return nil
}
// handleDeleteAlias implements
// DELETE /_matrix/client/v3/directory/room/{roomAlias}.
func (c *ClientAPI) handleDeleteAlias(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
alias, err := aliasFromPath(r)
if err != nil {
return err
}
if err := c.rooms.DeleteAlias(r.Context(), alias, auth.UserID, auth.Admin); err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, struct{}{})
return nil
}
// roomAliasesResponse is the GET /rooms/{roomID}/aliases body.
type roomAliasesResponse struct {
Aliases []string `json:"aliases"`
}
// handleGetRoomAliases implements
// GET /_matrix/client/v3/rooms/{roomID}/aliases.
func (c *ClientAPI) handleGetRoomAliases(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
aliases, err := c.rooms.RoomAliases(r.Context(), roomID, auth.UserID)
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, roomAliasesResponse{Aliases: aliases})
return nil
}
// visibilityResponse is the GET /directory/list/room/{roomID} body.
type visibilityResponse struct {
Visibility string `json:"visibility"`
}
// handleGetRoomVisibility implements
// GET /_matrix/client/v3/directory/list/room/{roomID}.
//
// Whether a room is in the public directory is itself public: the directory
// can be read without a token, so hiding the flag behind one would protect
// nothing.
func (c *ClientAPI) handleGetRoomVisibility(w http.ResponseWriter, r *http.Request) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
visibility, err := c.rooms.RoomVisibility(r.Context(), roomID)
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, visibilityResponse{Visibility: visibility})
return nil
}
// handlePutRoomVisibility implements
// PUT /_matrix/client/v3/directory/list/room/{roomID}.
func (c *ClientAPI) handlePutRoomVisibility(w http.ResponseWriter, r *http.Request, auth userapi.Authenticated) error {
roomID, err := pathRoomID(r)
if err != nil {
return err
}
var req visibilityResponse
if err := httputil.DecodeJSON(w, r, &req); err != nil {
return err
}
if err := c.rooms.SetRoomVisibility(r.Context(), roomID, auth.UserID, req.Visibility, auth.Admin); err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, struct{}{})
return nil
}
// publicRoomsFilter is the filter in a POST /publicRooms body.
type publicRoomsFilter struct {
GenericSearchTerm string `json:"generic_search_term"`
RoomTypes []string `json:"room_types"`
}
// publicRoomsRequest is the POST /publicRooms body.
type publicRoomsRequest struct {
Limit int `json:"limit"`
Since string `json:"since"`
Filter publicRoomsFilter `json:"filter"`
// IncludeAllNetworks and ThirdPartyInstanceID select an application
// service's own directory, which arrives with application service
// support in Phase 9.
IncludeAllNetworks bool `json:"include_all_networks"`
ThirdPartyInstanceID string `json:"third_party_instance_id"`
}
// handleGetPublicRooms implements GET /_matrix/client/v3/publicRooms.
func (c *ClientAPI) handleGetPublicRooms(w http.ResponseWriter, r *http.Request) error {
query := r.URL.Query()
limit := 0
if raw := query.Get("limit"); raw != "" {
parsed, err := strconv.Atoi(raw)
if err != nil || parsed < 0 {
return httputil.InvalidParam("limit must be a non-negative integer")
}
limit = parsed
}
return c.publicRooms(w, r, roomserver.PublicRoomsRequest{
Limit: limit,
Since: query.Get("since"),
Server: query.Get("server"),
})
}
// handlePostPublicRooms implements POST /_matrix/client/v3/publicRooms,
// which is the same listing with a filter.
func (c *ClientAPI) handlePostPublicRooms(w http.ResponseWriter, r *http.Request, _ userapi.Authenticated) error {
var req publicRoomsRequest
if _, err := httputil.DecodeOptionalJSON(w, r, &req); err != nil {
return err
}
if req.ThirdPartyInstanceID != "" {
return httputil.Unknown(http.StatusBadRequest,
"Application service room directories are not supported by this server")
}
if req.Limit < 0 {
return httputil.InvalidParam("limit must be a non-negative integer")
}
return c.publicRooms(w, r, roomserver.PublicRoomsRequest{
Limit: req.Limit,
Since: req.Since,
Search: req.Filter.GenericSearchTerm,
Server: r.URL.Query().Get("server"),
})
}
// publicRooms is the body of both directory endpoints.
func (c *ClientAPI) publicRooms(w http.ResponseWriter, r *http.Request, req roomserver.PublicRoomsRequest) error {
resp, err := c.rooms.PublicRooms(r.Context(), req)
if err != nil {
return roomError(err)
}
httputil.WriteJSON(w, http.StatusOK, resp)
return nil
}