mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-10-11 16:57:45 +02:00
s3api: register the azurekms KMS provider under its build tag (#11691)
* s3api: register the azurekms KMS provider under its build tag weed/kms/azure registers itself with weed/kms from an init(), but the blank import that triggers it was commented out in auth_credentials.go (TODO: Fix Azure SDK compatibility issues). Nothing else imports the package, so building with -tags azurekms still ends with "KMS provider 'azure' not registered" at startup for any config using "type": "azure". Move the import into weed/s3api/kms_azure.go behind //go:build azurekms so default builds stay free of the Azure SDK, and drop the dead comment. Closes #11686 * ci: compile and test azurekms-gated code weed/kms/azure is excluded from every default build, so nothing in CI compiled it; that is how the provider shipped unregistered. Build the tree and run the kms tests with -tags azurekms on every Go change. --------- Co-authored-by: Yi-111-a <> Co-authored-by: Chris Lu <chris.lu@gmail.com>
This commit is contained in:
2 files changed
+8
-1
No files matched your search
@@ -32,7 +32,6 @@ import (
|
||||
|
||||
// Import KMS providers to register them
|
||||
_ "github.com/seaweedfs/seaweedfs/weed/kms/aws"
|
||||
// _ "github.com/seaweedfs/seaweedfs/weed/kms/azure" // TODO: Fix Azure SDK compatibility issues
|
||||
_ "github.com/seaweedfs/seaweedfs/weed/kms/gcp"
|
||||
_ "github.com/seaweedfs/seaweedfs/weed/kms/local"
|
||||
_ "github.com/seaweedfs/seaweedfs/weed/kms/openbao"
|
||||
|
||||
@@ -0,0 +1,8 @@
|
||||
//go:build azurekms
|
||||
|
||||
package s3api
|
||||
|
||||
// Import the Azure KMS provider so its init() registers it with
|
||||
// weed/kms. The provider is gated behind the `azurekms` build tag so that
|
||||
// default builds do not pull in the Azure SDK.
|
||||
import _ "github.com/seaweedfs/seaweedfs/weed/kms/azure"
|
||||
Reference in new issue
Block a user