With jwt.signing.read set, volume servers refuse unsigned reads, so
cp.from of a chunked file failed with "source returned status 401".
Mint a read token for the chunk on each source attempt, the same way the
filer's own reads do.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A follower took the scheme from [https.client], so with HTTPS clients
toward volume servers and plain-HTTP masters every forwarded request
(/dir/assign, /dir/status, the UI) failed with 502 "first record does not
look like a TLS handshake". Masters share one [https.master] setting, so
use HTTPS exactly when this master serves it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
security.toml is mounted with subPath and read once at startup, so on an
upgrade that turns volume HTTPS on, the volume servers restarted with TLS
while filer, S3 and the other clients kept speaking plain HTTP. A
checksum/volume-https pod annotation, rendered only while the option is
on, rolls them all.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The copy built a bare client and plain http:// chunk URLs, so with
[https.client] on it could not read from or write to HTTPS volume servers
("source returned status 400"). Use the global client's transport and
redirect policy, and normalize the source and destination URLs to its
scheme.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its volume server registers by pod IP, so HTTPS clients could not verify
the volume certificate.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Volume servers register as <pod>.<volume service>.<namespace>, and HTTPS
clients verify that name, which none of the certificate's wildcards cover.
With volume HTTPS on, the certificate also lists every volume group's
service.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
global.seaweedfs.volumeHttps.enabled sets [https.volume] to the volume
certificate and turns on [https.client] with the client certificate and the
chart CA, so the volume data port is no longer plaintext under
enableSecurity. The option fails without enableSecurity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A scheduled run whose jobs no executor can take gives them up at once,
leaving them to the next detection. For a job type with a long detection
interval that is a whole interval later: a daily job whose only worker
was briefly full lost a day.
Bring the job type's next detection forward to within 10 minutes when
its jobs are given up for capacity, never pushing back an earlier one.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* filer: renew AppendToEntry's cluster lock while the append runs
AppendToEntry took a 5 s short-lived lock and never renewed it, so an
append slower than that (slow store, slow volume, GC pause) lost the
lock while still running, and another filer could take it and append
to the same entry concurrently, dropping one append's chunks. Use the
auto-renewing lock the HTTP append path already uses.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: refuse an AppendToEntry commit once its cluster lock was lost
A renewal can still fail, or the lock can be lost and granted again
under a new generation, while the append runs; another filer may have
appended in between. Check the lock and its generation right before
the entry is written, fail the append so the caller retries, and drop
the manifest chunks this attempt created.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* cluster: IsLocked reports a lock whose lease ran out as not held
isLocked only flipped when a renewal came back rejected, a second after
the reply, so a holder whose renewal stalled past the lease (a long GC
pause) still read as locked while the server could hand the key to
someone else. Track the lease from each grant's send time and require
it in IsLocked, which the filer append paths check before committing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: hold the slow-append test past the renewing lock's first lease
The renewing lock grants a 7 s lease, so a 6 s hold passed even with
renewal off; wait past LiveLockTTL so only a renewal keeps the lock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: say the AppendToEntry lock check is best effort
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3vectors: render filter string control characters as serde_json does
json_extract serializes the stored value with serde_json: \b, \f, \n,
\r, \t, \u00XX for the rest of U+0000-U+001F, and U+007F-U+009F raw.
The scalar comparison text used Rust debug escapes (\0, \u{1}, \u{7f}),
so $eq/$in on such strings missed scalar values and $ne/$nin kept them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* test(s3vectors): filter on every control character, quote and backslash
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* vector: derive the indexed metadata key columns
An indexed metadata key is a hidden `_mk_<n>` column of List<Utf8>: the
strings an S3 `$eq` on a string matches, that is the value when it is a
string or the string elements of an array, and nothing for any other type
or a missing key. The field metadata names the key and its state
(`building` or `ready`).
The module derives the column from metadata given as JSON (the write
path) or as stored (jsonb or JSON text, for a backfill), and reads the
indexed keys from a schema. It lives in the worker crate so the engine and
the worker share it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* vector: fill the indexed metadata key columns on PutVectors
PutVectors builds its batch against the table's current schema. Once a
table has indexed metadata key columns, the three-column batch no longer
matches that schema and the write fails. Fill each `_mk_*` column the
schema has from the row's metadata, whatever the key's state; a column
the engine does not know still fails the request.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* vector: answer string $eq and $in on a ready indexed key from its column
The gateway renders a string `$eq` or `$in` on a key as an OR of
`json_extract(metadata, P) = '"v"'` (or IN) and
`json_array_contains(metadata, P, '"v"')` over the same values. On the
parsed filter, a top-level conjunct of that shape on a key whose column is
`ready` becomes `array_has` / `array_has_any` on the column, which its
LABEL_LIST index answers. The two halves must name the same key and the
same strings, the scalar half in the text json_extract returns for them;
anything else, including `$ne`, `$nin`, `$exists`, numbers and booleans,
stays on the JSON path, and the other conjuncts still apply.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* vector: score few indexed matches exactly, per scope
With a ready indexed key in the filter, `ann` first counts the rows of its
scope that the key's conjuncts match, through the scalar index. When they
are at most the limit it scores them exactly over that scope, the way
the short-result fallback does; above it, the vector index searches with
the indexed prefilter, and the fallback still applies. The scope is the
one `exact_in_scope` scores, so per-scope exact answers merge into the
global exact top-k.
The limit is `Query::exact_match_limit` (None takes 256; 0 never counts),
set by the engine's --exact-match-limit (WEED_VECTOR_EXACT_MATCH_LIMIT).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* vector: count filtered queries by metadata key
For each index, the engine counts its QueryVectors calls by the metadata
keys of the parsed filter, with their total latency and the operand types
each key was compared with, over the last hour in 5-minute buckets. At most
512 indexes and 32 keys per index are kept (an idle key makes room;
otherwise the index is marked truncated), and the stats are not exported
as metrics labels.
The new FilterStats RPC returns an index's stats; the gateway's discovery
client forwards it like the other calls.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* vector: report the metadata columns capability in gRPC health
An engine whose writes fill the indexed metadata key columns reports the
gRPC health service `weed.vector.capability.metadata_columns` as serving,
so an operator action can refuse to index a key while an older engine
could still write the table.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* vector: expire filter stats' operand kinds and truncation with the window
The operand kinds a key was compared with, and the mark that a key went
uncounted, outlived the queries that set them. Keep the kinds per
5-minute bucket and the truncation as the bucket it last happened in, so
both leave the hour window with the counts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* vector: fill indexed key columns a write left empty racing their add
A PutVectors that opened the table before an indexed key's column was
added, and commits after the add, is rebased by Lance onto the wider
schema: it commits, and the rows it wrote hold NULL in the new column, so
the column's index misses them (reproduced in the test: 100 of 150 rows).
After its commit, PutVectors now looks for indexed-key columns the batch
did not carry, reads those of its keys whose column is still NULL, derives
the values from their stored metadata and patches just those columns with
a partial-schema merge that updates only rows still NULL.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* vector: keep filter stats' truncation mark at the later bucket
record() reads the clock before it takes the lock, so a call that waited
on the lock across a bucket boundary could move the truncation mark (and
the index's last-used bucket) back to its earlier bucket, and the mark
then left the window one bucket early.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* vector: derive a raced write's indexed key columns from current metadata
A PutVectors that opened the table before an indexed key's column was
added is retried by Lance against the wider schema: rows it inserts hold
NULL there, and rows it updates keep the value derived from their old
metadata, which the NULL-only heal never looked at. The heal now derives
the columns for all of the write's keys.
Its merge also ran with Lance's retry, which joins the values derived
before the conflict onto the rows a later write of the same keys left.
It now fails on a conflict and is redone from the latest version.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* vector: check the raced write's keys keep the later write's rows
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* volume: apply a tailed size-0 record as a delete when the key exists
A delete and an empty write both reach the tail receiver as a size-0
.dat record. Writing every one as a live needle turned each delete
caught by volume.move's tail into a 200-empty object. Treat the record
as a delete when the key already has a record on the receiver, and as
an empty write otherwise.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* rust volume: apply a tailed size-0 record as a delete when the key exists
Mirrors the Go tail receiver: a size-0 record for a key that already
has a record here is a delete, otherwise an empty write.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: volume.merge applies a size-0 record as a delete when the key exists
The tail stream carries deletes as size-0 records, and volume.merge
wrote each one to the merged copy as a live empty needle, so every
delete in the volume came back as a 200-empty object on all replicas.
A size-0 record for a key already written in the merged stream is now
a delete on the target; for a new key it stays an empty write.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: volume.merge reads a size-0 record as a delete only after its own replica's record
Replicas append the same write at their own times, so a fresh empty write
can reach the merge twice when the copies are further apart than the
dedup window. Tracking keys across all replicas made the second copy a
delete. Track, per source replica, the keys it has returned (duplicates
the merge skips included): a size-0 record is a delete only when its own
replica wrote the key before, which is the only way a replica appends a
delete. A delete for a key the merged copy already deleted sends nothing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: volume.merge verification counts the deletes the merge applied
Applying deletes lets a correct merge hold fewer live needles than a
replica that missed a delete, and the live-count check then refused it
and kept the divergent replicas. Every key live on a replica is either
live or deleted in the merged copy, so compare that replica's live count
with the merged live count plus the keys the merge deleted. An empty
merged copy is still refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: tail receiver looks a size-0 record's key up in the needle map
The receiver read the needle to decide whether a size-0 record deletes
an existing key. A read reports a needle past its TTL as not found, so
a delete for it was written as a live empty needle, which reads ignore
TTL for. Look the key up in the needle map instead (Volume.LookupNeedle).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* rust volume: tail receiver looks a size-0 record's key up in the needle map
Mirror Go: write_tailed_needle read the needle to decide whether a size-0
record deletes an existing key, and a read reports a needle past its TTL
as not found, so the delete became a live empty needle. Look the key up
in the needle map instead (Volume::lookup_needle).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: volume.merge keeps a merged delete when a late empty copy follows
A replica that missed a delete can hold its copy of the empty write
stamped after the other replica's delete. As that replica's first record
for the key it was written, reviving the deleted key. A size-0 record now
never revives a key the merged copy already deleted.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: volume.merge refuses more replicas than its key history has bits
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: keep a volume's live replicas readable while another volume cannot be found
A filer's "volume not found" answer counted as a filer failure, so three
of them opened the circuit breaker on a healthy filer. With its only filer
in the cool-down, every lookup then failed without asking, as "all 1
filer(s) failed with non-retryable error: %!w(<nil>)". And a refresh whose
lookup failed left the cache without the volume's live replicas, since
InvalidateCache had already dropped them with the dead one.
The breaker now counts only failures to reach the filer, and asks the
filers anyway when all of them are in their cool-down. InvalidateCache keeps
what it removed; a lookup that errors puts it back unless the volume was
learned again, the epoch moved, or a reset would have expired it, and
leaves out locations fenced by a pushed removal.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: set invalidated locations aside in the map instead of copying them out
The first commit kept what InvalidateCache removed in a side map and put it
back when the lookup failed. The copy left the map's lock, so a removal the
master pushed between the take and the put-back was undone: the removed
server came back into the cache.
The entry now stays in the map with a state. entryStale hides it from readers
and releases its server references, as a delete did. A pushed removal edits
it like any other entry. When the lookup after the invalidation returns an
error, the entry becomes entryRevived and is served again.
A stale or revived entry holds only what was known before the read failed,
so the next thing learned replaces it: a lookup answer drops it before the
answer is cached, including an answer with no locations and an answer to a
lookup that was in flight when another one failed, and a pushed add replaces
it instead of merging.
LookupVolumeIdsWithFallback returns no error when every volume it was asked
for has locations after the revive, so the filer's LookupVolume handler sends
its response instead of an error status.
The not-found breaker test now checks the failure count itself. Without
that, a regression of the classification passed, because a lone filer in its
cool-down is asked anyway.
On the first commit, TestPushedRemovalRacingFailedRefreshes failed in 8 of 8
runs under -race: four with "got [live:8080 old:8080], want [live:8080]",
four with "got [], want [live:8080]".
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* wdclient: retry a filer lookup pass that asked no filer
The pass decides once whether to skip unhealthy filers. A filer whose
breaker trips after that decision, as when a concurrent lookup records
its failure, is still skipped. With every filer skipped the pass ended
with no error and failed the lookup as non-retryable with
"%!w(<nil>)". Such a pass now counts as Unavailable, so the lookup
retries and the next pass asks the filers anyway.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: believe a provider answer that reports errors for some volumes
The master provider answers a batch with a map of the volumes it knows
and an error naming the ones it does not. The failed-lookup branch took
that as no answer and revived what InvalidateCache had set aside, so a
volume the master reported as absent came back with its old locations,
and the batch could return them with a nil error. Only a nil map now
means no answer. Otherwise the answer replaces what was set aside, and
the provider's error is still returned.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: keep set-aside locations learned after a lookup was asked
A successful lookup dropped every stale or revived entry of the volumes
it asked for, however old the answer was. A lookup asked before the
master confirmed new locations could, on finishing, delete those
locations after a read had set them aside and a failed refresh had
revived them, and its own answer was not cached because the epoch had
moved. Entries now record when their locations were learned, and an
answer drops only what was learned before it was asked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: keep an older answer from replacing locations set aside after it was asked
fdcde25 keeps dropSetAside from deleting set-aside locations that were
learned after a lookup was asked. The answer's insertion still replaced
them: fillLocations adds each location with vidMap.addLocation, and
addLocationToMap replaces a stale or revived entry whatever its learnedAt.
The epoch does not stop this when the newer locations came from another
lookup's answer or, on the master client, from a pushed add, since neither
moves it. The master client's provider also caches its answer itself,
before LookupVolumeIdsWithFallback reaches dropSetAside.
vidMap.addAnswer adds an answer's locations under one lock, and adds none
of them while vid has a stale or revived entry learned after the lookup was
asked. fillLocations uses it, and the master client's provider passes the
learned mark it takes next to its epoch. An answer with nothing newer in the
way still replaces what was set aside, with every location it reports.
On fdcde25, TestOlderAnswerDoesNotReplaceNewerRevivedLocations and the
"newer location revived during the lookup" case of
TestMasterAnswerAgainstSetAsideLocations fail with
"got [old:8080], want [new:8080]".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: move addAnswer next to dropSetAside
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* admin/plugin: fail a restored job its worker no longer lists
An admin restart reloads the jobs that were running from the persisted
state, but the workers drop those jobs when the old admin stream closes.
No pending execution covers a restored job, so only the 24h stale sweep
ended it, and until then it blocked dedupe and scheduling of its job type.
Track the active jobs loaded at startup by worker and fail one after two
itemized heartbeats from its worker leave it out, as is already done for
a dispatch whose worker restarted. A listed job is left to adoption.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin/plugin: keep tracking a listed restored job; skip queued ones
- A restored job its worker lists only resets its miss count, so one it
drops later is still failed.
- Track only jobs that were sent to a worker (request id set, not pending).
- Match restored ids against the trimmed heartbeat ids.
- Fail the restored attempt under the jobs lock that applies the expiry
(handleJobCompletedIf / expireActiveJobIf), so a newer attempt of the
same job is neither failed nor canceled.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin/plugin: keep a newer attempt's detail from a restored-job expiry
- The conditional completion writes the job detail through
persistJobDetailSnapshotIf and skips it when the stored detail already
names another request; the check runs under jobDetailsMu with the write.
- mergeTerminalDetailIntoTracked ignores a terminal detail of another
request, so a restart does not end the loaded attempt with it.
- Tests wait for the restored-job expiries instead of sleeping.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin/plugin: restore a finished retry from its detail
The job detail is saved as each attempt changes and the job list only
periodically, so a terminal detail naming another request is the newer
attempt. Apply it with its request id instead of ignoring it; the
expiry's own detail write already refuses to overwrite another request.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin/plugin: restore whichever attempt is newer
The job list and a job's detail can name different attempts either way
round: the list is saved periodically, and a detail write can fail. When
their request ids differ, apply the terminal detail only if it is the
newer attempt (higher attempt number, else later update).
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin/plugin: fill a restored job's empty request id from its detail
A job the list saved while still queued has no request id; take the
finished detail's, as the merge did before the newer-attempt check.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin/plugin: take the worker and attempt of a newer restored detail
When the restore takes a finished retry's detail over the job list's
attempt, the record kept the older attempt's worker and attempt number
next to the retry's request id and state.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin/plugin: fold the conditional completion into the existing functions
handleJobCompleted, expireActiveJob, trackExecutionCompletion and
persistJobDetailSnapshot take the accept check themselves instead of
gaining *If twins.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin/plugin: ignore a late earlier-attempt completion; replace an older detail
- A completion whose request id differs from the tracked attempt's is a
late report of an earlier attempt and no longer ends a retry.
- A conditional completion skips the detail write only when the stored
detail is a newer attempt (detailIsNewerAttempt), so an older finished
attempt's detail left behind by a failed write is replaced.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin/plugin: take only the dispatched attempt's reports
A late progress report of a timed-out attempt replaced the retry's request
id, after which the retry's own completion was rejected as foreign. One
rule now gates both: a record the admin dispatched (attempt > 0) takes
progress and completion only for its own request (reportFromOtherAttempt).
When an expiry replaces an older attempt's detail it also takes the
closing attempt's worker, attempt number and times.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin/plugin: restore a newer running attempt's identity from its detail
The job list can name attempt A while the detail shows retry B running
when the admin stopped. The restore now takes B's request id, worker and
attempt number from such a newer running detail, so B's own reports are
accepted. Test helper keeps a given attempt number.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin/plugin: keep attemptEnded's doc comment on attemptEnded
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin/plugin: dispatch an attempt-less job as attempt 1
The late-report guard only covers records with a positive attempt, and
ExecuteJob passed a zero attempt through, so a direct caller's dispatch
could be closed by another request's completion. The HTTP API already
raised zero to one; the dispatch path now does the same for every caller.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep a hard-linked file's chunks when one of its names is replaced
Replacing one name of a hard-linked file deleted the file's chunks while
its other names still pointed at them. Reads through those names then
return EIO once the volumes are vacuumed; until then they only work
through readDeleted.
Two everyday ways to get there through a mount:
- conda links an environment's files to its package cache with hard
links. Python saves a __pycache__/*.pyc by writing a temporary file and
renaming it over the old name, so the cache's copy loses its data.
- A training script saves model.pt, hard-links it into an epoch directory
and saves the next epoch by renaming a new file over model.pt. Each
archived epoch loses its data.
Three write paths deleted the chunks of the entry they replaced without
asking whether that entry was one of several hard links:
- a rename over a file: moveSelfEntry drops the target's link, then
queues all of the target's chunks for deletion;
- CreateEntry over an existing path (an S3 PUT, for one): the update
drops the old entry's link, then deleteChunksIfNotNew deletes its chunks,
and the CreateEntry handler deletes chunks its own list covers;
- UpdateEntry with an entry that no longer carries the old one's link.
A plain delete already keeps the chunks while HardLinkCounter > 1, and a
folder delete asks hardLinkIsOrphaned. The three paths now go through
Filer.KeepHardLinkedChunks, which asks after the write, once the replaced
name's link is gone: the chunks stay unless the file's shared record went
with it, that is, unless the replaced name was the last link. Writing the
file through one of its names (an entry with the same hard link id) still
deletes the chunks the write replaced, since every name reads the new
content.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep hard-linked chunks from the shared record, not the replaced row
A lookup that cannot read the hard link record returns the name's own row,
which can lag the file. Read the record when filtering the garbage, and keep
everything when it cannot be read.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test the manifest reads behind KeepHardLinkedChunks
The manifest resolution moves into withoutChunksOf, which takes the lookup
function, so tests can serve manifests. Chunks behind nested manifests and
the manifests themselves stay, unrelated garbage is still deleted, and an
unreadable manifest returns an error, on which KeepHardLinkedChunks deletes
nothing. Behavior is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* volume: count needles vacuum drops as unreadable and log each at error level
Vacuum drops a live needle whose record fails to read back intact (CRC
mismatch, malformed fields, short or dangling record). The key leaves the
compacted index with no tombstone, so repair tools later treat it as a
vacuumed delete. Log every dropped key at error level and count the drops
in SeaweedFS_volumeServer_vacuuming_dropped_needles per collection, once
the compacted index is written.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* grafana: add a panel for needles dropped by vacuum
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* seaweed-volume: count needles vacuum drops as unreadable and log each at error level
Mirror the Go volume server: log every dropped key at error level and add
SeaweedFS_volumeServer_vacuuming_dropped_needles per collection once the
compacted index is written.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: count dropped needles only after the compacted dat is flushed
The final .cpd fsync runs in the deferred close and loadTmpNeedleMap can
still fail after the index is saved; a copy failing there is retried and
would count the same needles again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: lock the path for plain HTTP overwrites
CreateEntry looks up the entry it replaces and queues that entry's chunks
for deletion. Two plain PUT/POST writes of one path could both read the
same old entry, so the chunks of whichever write lost were never queued.
Take the exclusive path lock around CreateEntry, as the gRPC CreateEntry
already does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test concurrent HTTP overwrites queue every replaced chunk
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: resolve deleted manifests through the master on a volume cache miss
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep a manifest needle until its sub-chunks are queued for deletion
When a manifest could not be read during chunk deletion, the manifest
needle was deleted anyway and the data chunks it listed were orphaned.
Retry the resolve with the deletion retry backoff and delete the
manifest alone only after MaxRetryAttempts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep a durable delete that joins a pending manifest retry
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: bound each manifest retry read with a deadline
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: requeue resolved manifest ids on an fsync upgrade instead of rereading
A durable delete that joins a manifest retry in flight used to resolve
the manifest a second time, but the first pass had already queued the
manifest needle, so the reread could fail and the sub-chunks never got
the durable mark. Resolve nested manifests up front and queue the same
ids again with fsync.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: bound each manifest retry pass and stop it on shutdown
A pass takes ready manifests one at a time and stops after
manifestRetryTimeout, leaving the rest queued for the next tick, so a run
of stalled reads cannot keep the shared retry loop from ordinary deletion
retries or from noticing shutdown.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* http: report the status of a failed delete that has no body
A replica that answers a DELETE with a bare 500 left the forwarding
server reporting "[<replica>]: " with an empty reason.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: forward a delete retry that finds nothing here to the replicas
A delete is applied locally before it is sent to the other replicas, so
when the fan-out fails the client is told to retry while this replica
already dropped the needle. The retry then read nothing here and answered
404 without asking the replicas, so the replica that missed the delete
kept the needle for good.
On a replicated volume, a plain delete that finds the needle missing or
deleted now cancels a write still queued for it, as a replica delete
does, and sends the delete on to the other replicas. A failed fan-out is
reported as before, so the client retries until every replica agrees.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): take a replica's 404 to a forwarded delete as done
A replica that no longer holds the needle answers a forwarded delete with
404. The Go server folds that into success, but the Rust server reported
it as a replication failure, so a delete that only had to catch up one
replica failed on the replica that was already in step.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): forward a delete retry that finds nothing here to the replicas
Mirrors the Go server: on a replicated volume, a plain delete that finds
the needle missing or deleted cancels a write still queued for it and
sends the delete on to the other replicas, so a retry after a failed
fan-out reaches the replica that kept the needle.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: answer a delete whose needle read fails with 500, not 404
A replica's 404 to a forwarded delete is taken as the needle being gone
there. DeleteHandler answered 404 for any failed pre-read, so a replica
whose disk could not read the needle let the primary acknowledge a delete
that replica never applied. Only a missing or deleted needle (or a volume
this server does not hold) answers 404 now; other read errors are a 500,
so the client retries.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): answer a delete whose needle read fails with 500, not 404
Mirrors the Go server: a replica's 404 to a forwarded delete is taken as
the needle being gone there, so only a missing or deleted needle answers
404; other read errors are a 500 and the client retries.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): corrupt the needle with portable file writes in the delete read test
FileExt::write_all_at is Unix-only, so the test did not build on Windows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* volume: serve decoded bytes for a range over a compressed needle
A Range with Accept-Encoding: gzip got Content-Encoding: gzip and a slice
of the compressed bytes, which a decoding client cannot read. The range
is over the stored file's decoded bytes, so pass gzip through only for a
whole read.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* seaweed-volume: serve decoded bytes for a range over a compressed needle
Mirrors the Go volume server: a Range with Accept-Encoding: gzip got
Content-Encoding: gzip and a slice of the compressed bytes. Pass gzip
through only for a whole read.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* seaweed-volume: HEAD of a compressed needle reports the served length
HEAD answered a compressed needle from its meta: the stored gzip length
with no Content-Encoding, whatever the request accepted. Go reads the
payload and reports what the GET would send: the decoded length, or the
gzip length with Content-Encoding: gzip for a whole read that accepts
gzip. Read a compressed needle in full on HEAD too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* test/volume_server: range and HEAD over a compressed needle
Both volume servers serve a gzip-accepted range decoded, and HEAD reports
the length the matching GET would send.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* seaweed-volume: decode every gzip member of a compressed needle
Go's gzip reader reads concatenated members; GzDecoder stopped after the
first, so a range over such a needle saw a shorter body and length.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* vector: answer a short filtered ANN query by an exact scan
A prefiltered query through the IVF index sees only the partitions it
probes. When those hold fewer than k eligible rows the answer is short
(400 matches, topK 500, 63 partitions: about 208 returned), and when at
most k rows match Lance appends the ones its probes missed with an
infinite distance. Either case is now answered again by an exact scan of
the same scope: the listed fragments plus the live coverage of the listed
index segments, or the whole table.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* vector: count an explicit probe count as indexed only with an index
With nprobes set on a table that has no vector index, the scan was marked
indexed, so a filtered query matching fewer than k rows ran the same exact
scan a second time.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: retry TiKV store writes on a write conflict
TiKV transactions are optimistic. A commit fails with a write conflict
when another transaction committed one of its keys after it began, even
for a blind Set or Delete. Outside a filer transaction the TiKV store
runs each save and delete in a transaction of its own and returned that
error to the caller, so of two requests writing the same entry at the
same moment one failed, and a mount reported EIO.
A write the store commits itself (InsertEntry, UpdateEntry, DeleteEntry,
one batch of DeleteFolderChildren, KvPut, KvDelete) now runs again in a
new transaction after a write conflict, up to 5 times, waiting 1-2ms,
2-4ms, ... 16-32ms in between. The failed transaction stored nothing,
and the retry lands after the other writer, as if the two had not
overlapped. The retries stop when the context is done.
A write inside a transaction from BeginTransaction is not retried: the
conflict is reported when the caller commits, as before.
deleteBatch now goes through RunInTxn like the other writes.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* filer: stop TiKV write retries once the context is done
When the context was cancelled while the retry wait was running, the
timer case could still win the select and start one more transaction.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep a TiKV entry that is no longer expired when listing deletes it
The listing decides an entry has expired from its own read, and the
delete ran later as a blind delete. Once the delete retries after a
write conflict, a live replacement committed in between was removed.
Read the entry again in the deleting transaction and delete it only if
it is still expired.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: MapleWhiteZZZ <18653045+MapleWhiteZZZ@users.noreply.github.com>
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* storage: reject a streamed read whose record id or size differs
The header probe before a streamed read returned not-found only when both
the record's id and its size differed from the index entry, so a record of
another needle with the same size passed and its data was streamed under
the requested key until the final checksum check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: refuse a needle blob whose header names another needle
WriteNeedleBlob compared only the blob header's size with the size it was
asked to index. A blob read from an offset that has since moved to another
record of the same size was appended and indexed under the wrong key.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): refuse a needle blob whose header names another needle
Mirror of the Go check: write_needle_blob_and_index compared only the blob
header's size, so a blob of another needle with the same size was appended
and indexed under the requested key.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): report not-found when a streamed read's record is another needle
The meta read ahead of a streamed reply took the id from the record header
without comparing it with the requested key. Return not-found when the
index entry resolves to another needle, as the Go header probe does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: check the requested id after a meta-only read
ReadNeedleMeta overwrites n.Id with the record's header id, so a meta-only
read through an index entry that resolves to another needle returned that
needle's metadata, and the streamed-read probe that follows compared the
record with itself. Return not-found when the header names another needle,
as the Rust meta read does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: copy a needle blob to another volume, not under another key
WriteNeedleBlob now refuses a blob whose header names another needle,
so the round trip writes the blob under its own id into a second volume
and checks that storing it under another key is refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: compare the streamed header with a deleted entry's record size
A deleted index entry stores the negated size, so a read-deleted stream
compared the positive header size with a negative one and missed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* storage: copy an empty needle written during compaction in makeupDiff
A size-0 index row is a live empty needle, not a delete. makeupDiff
grouped it with tombstones and appended a made-up delete marker, so
the compacted .dat lost the record's cookie and held a delete.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): copy an empty needle written during compaction in makeup_diff
A size-0 index row is a live empty needle. makeup_diff wrote a made-up
delete marker and a tombstone row for it, so the needle read as not
found after the commit. Copy the record like any other live row.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: fail makeupDiff when the replayed needle write fails
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): check the compacted empty needle's id and cookie in the test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* admin: show a pruned job's detail from its run record
Tracking keeps the newest 1000 jobs across all job types and deletes
the details of older finished ones, while each job type's run history
keeps its last 10 successful and 10 failed runs. A job listed in the
run history could therefore open as "job detail not found". Fall back
to the run record when the job is no longer tracked.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* admin: show 100% progress for a pruned successful run
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: use the newest run record for a job across both outcomes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: keep the run record a pruned job's detail was built from
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: keep looking for a run record past an unreadable history
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: pick a pruned job's newest run record across job types
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* storage: red test for CommitCompact after CompactByVolumeData with a concurrent write or delete
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: build the temporary needle map in CompactByVolumeData
Fixes#12783
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: require a successful commit in the CompactByVolumeData commit test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
BinarySearchByAppendAtNs, its left/right probes and ResumeByLastEntry read
every probed record through readNeedleAt, which parsed the whole body and
verified the data checksum, although they use only the id, cookie, size and
append time. One record with damaged data on the search path, even a needle
deleted long ago, failed the search and with it the tail sender, a
timestamp-based incremental copy and the volume.move catch-up.
readNeedleAt now reads the header and the trailer and skips the data. The
data checksum is still verified where the data is read, including the tail
receiver for every record it gets. The Rust volume server already parses
only the metadata on this path and does not verify the data checksum.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* storage: red test for the append-time search racing a vacuum commit
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: hold the data-file read lock across the append-time search
Fixes#12785
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: Version() writes the superblock version only when it changes
Version() stored the .vif version into SuperBlock.Version on every call, so
each call was a write that raced with readers of the superblock that do not
take superBlockAccessLock, such as the append-time search and the
compaction setup.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: harden the append-time search race test; add a lock-hold budget test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: Linux-only lock budget; stop before reading search failures
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* security: add a constant-time HTTP Basic Auth check
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: require HTTP Basic Auth on the HTTP ports when configured
With filer.basic_auth.password set in security.toml (or
WEED_FILER_BASIC_AUTH_PASSWORD), a request on the filer HTTP ports, TUS
included, must carry those credentials or a valid filer JWT, and an
access level with no JWT signing key is no longer open. Valid Basic
credentials grant read and write. 401 responses then carry a Basic
challenge so browsers prompt. The credentials reload on SIGHUP with the
signing keys.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* scaffold: document filer.basic_auth in security.toml
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: enable reloaded Basic Auth before swapping the JWT keys
Reload cleared the old signing keys before storing the new Basic
credentials, so a switch from JWT to Basic Auth briefly left both off
and admitted anonymous requests. Store new credentials first and clear
old ones last.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: refuse Basic credentials on cross-origin browser requests
Browsers resend cached Basic credentials on requests other websites
trigger, such as a form POST with mv.from, and the default
cors.allowed_origins "*" lets them through. Accept Basic credentials
only on requests without an Origin, from the filer's own host, or from
an origin explicitly listed in cors.allowed_origins. A JWT is still
accepted from any origin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: recheck Basic Auth after reading an empty signing key
A request that loaded Basic Auth as off, then read the signing key after
a JWT-to-Basic Reload had cleared it, was let through anonymously. Open
access now also needs Basic Auth to be off after the key read; with
Reload enabling the new credential before disabling the old one, the
two loads cannot both miss a credential that was on throughout.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* security: compare Basic Auth credentials as MACs under a per-process key
A plain SHA-256 of the password is what password-hash scanners flag;
keying the digests with a random per-process HMAC key keeps the
length-independent constant-time compare without holding one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* util: read a configuration file without merging into the shared viper
LoadConfiguration merges each read into the shared viper, so a key
removed from the file keeps its old value after a reload.
ReadConfiguration reads the file into a fresh viper with the same search
path and WEED_ environment overrides.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: turn Basic Auth off when security.toml no longer sets it
The shared viper merges each SIGHUP reload into what it held, so
removing [filer.basic_auth] kept the old password valid. Read the
credentials from security.toml alone at startup and on reload; an
unreadable file keeps the current setting.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep Basic Auth when security.toml cannot be read
A malformed file at startup dropped a WEED_FILER_BASIC_AUTH_PASSWORD
from the environment, and viper reports an unsearchable config
directory as a missing file, which turned Basic Auth off on reload.
ReadConfiguration now always returns the environment overrides and
reports whether the file was read; a reload that could not read it
keeps the current credentials.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep reloading Basic Auth from the security.toml first read
A search directory that turned unsearchable made viper fall through to a
lower-priority security.toml, and a reload from a file without
[filer.basic_auth] turned Basic Auth off. ReadConfiguration now takes the
file to read, and the filer reads the file it first found on every reload.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: sort newly discovered filers and log every current-filer switch
Discovery appended new filers in map iteration order, so after the current
filer left, the fallback at index 0 was a random filer. Append them sorted.
Route every change of the current filer through one helper that logs it at
V(0) with its reason (failover, return_home, discovery), so an operator can
see which filer a gateway uses without new metrics.
* wdclient: prefer a home filer and return to it after failover with backoff
A FilerClient with FilerClientOption.HomeFiler set goes back to that filer
once its circuit breaker allows a re-check, instead of staying on whichever
peer it failed over to. Leaving home again soon after a return doubles the
wait before the next return, up to 5 minutes; a return that holds for 10
minutes resets it. Volume lookups and discovery follow the same preference.
* s3: embedded gateway uses its local filer as home filer
weed filer -s3, weed server -s3 and weed mini now build the gateway's filer
address in the form the filer registers in the master (ip:port.grpcPort),
with the gRPC port default applied, and pass it to the gateway as its home
filer, so the gateway returns to its local filer after any failover.
Standalone weed s3 has no home filer and behaves as before.
Refs #12768, follow-up to #12771
* wdclient: switch the current filer only from the filer a request started on
A volume lookup that started on a peer and finished after the client had
returned home moved it back to the peer and counted that as leaving home,
doubling the return backoff although home never failed. Concurrent
failovers could also each count as a separate departure.
Failovers now name the filer they started on and take effect only while it
is still current, via compare-and-swap, so only the winning switch logs and
feeds the backoff. S3's failover walk uses the same rule.
* wdclient: switch the current filer and record the return backoff in one step
The index moved by compare-and-swap before the switch was recorded, and
both ran under the shared read lock. A request reading the current filer
in that gap saw the peer with the old eligibility time and, with home's
breaker still closed after one failure, switched straight back home.
The eligibility check, the move and the bookkeeping now all run under
homeMu.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: discovery falls back past a home that is still backing off
When discovery removed the current filer and home was not yet eligible,
the client took index 0, which is home whenever it is listed first. With
home's breaker still closed after a single failure, requests went back to
the filer they had just left. Take the next filer instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: start return timing on every switch back to the home filer
Only a return_home switch stamped lastReturnHome. Discovery or a peer's
failover could also put the client back on home, and a failure soon
after such a return kept the backoff at its base value instead of
doubling it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Konstantin Lebedev <whitefox@mayflower.work>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: recover leveldb without rebuilding broken tables
leveldb.Recover rebuilds a table with damaged blocks using the user
comparer and filter on internal keys. The shortened index keys it writes
are not valid internal keys, so a Get on the rebuilt table panics, and
the bloom filter it writes misses every lookup. Recover with a comparer
that keeps full index keys (same name, so the manifest still matches)
and no filter.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: recover a leveldb store when a compaction finds a corrupted table
When a compaction reads a damaged table block, as a power loss can
leave one, goleveldb latches the corruption error and returns it for
every later write until the database is reopened. A plain reopen loads
the same table and the next compaction fails again, so the store kept
rejecting inserts even across restarts.
Treat a corruption error from a write like a storage error, and reopen
through leveldb.Recover, which rebuilds the table without the damaged
blocks, then retry the write.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: rebuild damaged leveldb tables before Recover
leveldb.Recover's own table rebuild orders internal keys with the user
comparer, so a damaged table holding several versions of one key fails
with "keys are not in increasing order" and the recovery gives up.
Overriding the comparer cannot fix that, because the same comparer
also serves the recovered database's user keys.
Rebuild every table that has corrupted blocks first, using an internal
key comparer and full index keys, then let Recover rebuild the manifest
from tables it no longer needs to rewrite. Seed the test tables from a
journal flush so they keep several versions of a key, and check keys
the write test does not rewrite.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: leave unreadable leveldb tables for Recover to drop
table.NewReader reports a truncated table or a damaged footer through
the reader, not its error, so rebuildDamagedTables never stopped on one,
but it rewrote it as an empty table first. Skip tables with nothing
readable and let Recover drop them, and test an unreadable table next
to a healthy one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: let StrictRecovery drop damaged leveldb tables
With StrictRecovery set, leveldb.Recover drops a table that has corrupted
blocks. Salvaging the readable blocks first would hide the damage from it,
so skip the rebuild under that option.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: hold the leveldb storage lock while rebuilding tables
The table rebuild ran after the failed open released the storage lock
and before Recover took it, so it could rewrite the tables of a database
another caller had open on the same storage. Take the lock for the
rebuild; Recover takes it again afterwards.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* master: reject an assign on a follower as Unavailable
Assign on a master that is not the raft leader returned
raft.NotLeaderError as a plain error, which reaches gRPC clients as
codes.Unknown. operation.Assign retries only Unavailable,
ResourceExhausted, Canceled and DeadlineExceeded, so every assign made
during a leader election failed at once instead of waiting for the new
leader.
Return it as codes.Unavailable, like the warming-up status in the same
file, so clients retry within their 30 s assign budget. The message is
unchanged, so callers that match "Not current leader" still work.
StreamAssign now answers such a request in-band with the error message
instead of ending the stream, as it already does for warm-up.
TestAssignOnFollowerIsUnavailable covers it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* pb: keep the cached channel when the peer answers Unavailable with details
gRPC's own Unavailable (dial failure, closing transport) never carries
details, so one that does came from the peer over a working channel.
Closing the shared ClientConn for it cancels every other in-flight RPC
on it with "the client connection is closing".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* master: tag the follower's assign rejection with a NOT_LEADER ErrorInfo
The detail marks it as the master's answer, so clients retry it
without tearing down their cached channel to that master.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* test: let the merge-read vacuum outlast the master's write drain
Before compacting a volume the master waits up to 30 s for writes it
assigned to that volume to drain. The test cut each /vol/vacuum call at
30 s and gave the vacuum 60 s, so one or two slow drains failed it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: retry the merge-read vacuum until the master runs one
A 409 means another vacuum holds the master's lock; check the chunks
only after a vacuum this test asked for has finished.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* util/http: probe an unanswering server in the background, not on a read
Once the retry interval passed, the first read put the dead server first
and waited out the full dial timeout before trying a live replica. Keep it
last and dial it from a background probe with a short timeout instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* util/http: try every server of a machine that does not answer last
Unreachability was kept per host:port, so a powered-off node running one
volume server per disk cost one stalled read per server before each was
known dead. A dial that times out or finds no route now marks the whole
machine; a refused connection still marks only that port and shows the
machine is up.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* util/http: probe an unanswering server with an HTTP request
A bare TCP connect cleared servers that accept connections but never send
response headers, and could not dial an address without an explicit port.
Probe with a HEAD request through the global client instead, and have the
tests wait for the probe to settle.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* util/http: keep a timed-out port last after a sibling port answers
A dial timeout stored only the machine verdict, so a success on another
port of that machine cleared it and the port that timed out went back to
the front. Record the port as well as the machine.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* util/http: classify refused and unroutable dials with Winsock errnos on Windows
Windows reports these as WSAECONNREFUSED, WSAEHOSTUNREACH and friends,
which errors.Is does not match against the syscall constants. Test the
refusal with a real dial to a closed port.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* util/http: wait for background probes through a WaitGroup in tests
A refused probe can finish before the test reads the claimed record, so
inferring completion from the record's timestamp could wait out the
deadline on a probe that already settled.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* util/http: key machine verdicts apart from hosts without a port
A host without an explicit port is also its machine name, so a sibling
port answering cleared the timed-out host along with the machine verdict.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* util/http: group a bracketed port-less IPv6 host with its machine
net.SplitHostPort rejects "[2001:db8::9]", so the machine key kept the
brackets and missed the verdict stored for "[2001:db8::9]:9501".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: metrics for metadata subscription delivery (lag, holds, ring fall-offs, claim and watermark ages)
* filer: measure subscribe delivery lag after the real send using the mutation stamp, and record a watermark hold once per hold
* filer: skip empty progress markers when sampling subscribe delivery lag
* filer: assert subscribe delivery lag is sampled only after the stream send succeeds
* grafana: panels for the metadata subscription delivery metrics
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: record a watermark hold when the read passes the held entry, not when the next hold starts
* filer: use a monotonic clock for the subscribe hold duration
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep an explicit gRPC port in the embedded gateways' filer address
runFiler handed the embedded S3/WebDAV/IAM/SFTP gateways
NewServerAddress(...).String(), and String() drops the .grpcPort part.
With a non-default -port.grpc the gateways then dialed port+10000 and
did not recognize their own filer in the master's list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: match discovered filers by gRPC address
A filer listed as host:port and the same filer discovered as
host:port.grpcPort were compared as raw strings, so a refresh pruned the
configured filer, added every discovered filer as new in map order, and
reset the current filer to whichever came first; a pushed join added it
a second time. Key filers by their gRPC address: a survivor keeps its
health and current position and takes the discovered address form, and
pushed joins and leaves match the same way.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* security: scoped read-only token for filer metadata subscriptions
A token signed with jwt.filer_signing.subscribe.key names the subscribe
methods and the path prefixes its holder may see. mTLS peers and admin
tokens stay unrestricted. Internal subscribers attach an admin token
when both keys are configured.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: enforce subscription token scope on metadata streams
With jwt.filer_signing.subscribe.key set, SubscribeMetadata and
SubscribeLocalMetadata authorize the caller first. A scoped caller gets
a stream that sends only events whose paths are all under its prefixes,
filters batches, and never carries log file refs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: send an admin token on internal metadata subscriptions
Peer filers, metadata followers and the lifecycle reader attach an
admin token when the subscribe key is configured, so they keep the full
stream without mTLS.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: add fs.meta.token to mint metadata subscription tokens
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: end scoped metadata subscriptions at token expiry
The scope now carries the token's exp. The scoped stream's context ends
at that time and the call returns Unauthenticated, so an open stream no
longer outlives its token.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer.sync: sign metadata subscriptions with the source cluster's key
MetadataFollowOption takes a FilerJwtProvider; filer.sync passes the
one loaded from -a.security or -b.security, so clusters with different
admin keys both accept the subscription.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: report fs.meta.token flag errors
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: give scoped metadata subscribers their own client id
A scoped caller could reuse another subscriber's ClientId with a higher
epoch and replace that registration, disconnecting it. Scoped streams now
register under a server-chosen id that no other subscriber holds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* security: accept only HS256 metadata subscription tokens
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* security: test HS384 metadata subscription token rejection
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: never let a scoped subscriber replace another registration
The server-chosen id can be taken by another subscriber between choosing
and registering it. Registering scoped streams with the lowest epoch makes
addClient refuse them rather than replace the other registration.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: send position markers for events a scoped token withholds
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test a scoped stream withholding a whole event batch
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: filter SendMsg on scoped metadata streams
The scoped wrappers only overrode Send, so a SendMsg on the embedded
stream would reach the client unfiltered. Route it through the same
filter and refuse any other message type. Ported from #12790.
Co-authored-by: mindaeon <30555587+mindaeon@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test a scoped subscription through the real subscribe loop
Run SubscribeLocalMetadata with a scoped token over a flushed backlog,
the in-memory tail and live events: only in-scope events arrive, sibling,
"..", encoded and cross-boundary rename paths are dropped, and no log
file references are sent although the client asks for them. Without the
subscribe key every event still arrives. Ported from #12790.
Co-authored-by: mindaeon <30555587+mindaeon@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test that the HTTP API refuses metadata subscription tokens
GET, HEAD, PUT, POST and DELETE all refuse a subscription token, also
when the subscribe key equals the read or write key. Ported from #12790.
Co-authored-by: mindaeon <30555587+mindaeon@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: mindaeon <30555587+mindaeon@users.noreply.github.com>
* s3: list each part number once, its latest attempt
Every UploadPart writes its own NNNN_<uuid>.part entry, so a part number
uploaded twice listed twice, superseded ETag included, and a max-parts page
could hold only the stale attempt. ListParts now groups the entries by part
number, reports the attempt sortEntriesByLatestChunk ranks first (the same
order completion uses), and pages over distinct part numbers, reading past a
page boundary that splits one part number's attempts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: test ListParts over repeated part attempts
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: rank an empty part attempt by commit stamp or mtime
An empty UploadPart body stores no chunks, so sortEntriesByLatestChunk gave
it time zero and an empty re-upload always lost to the attempt it replaced.
Attempts now rank by the filer's commit stamp when both carry one, else by
the later of the first chunk's write time and the entry mtime.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: keep only the newest attempt per part while listing parts
listPartAttempts held every attempt of a part number until the page was
built, so a heavily retried part grew one ListParts request's memory past
what max-parts bounds. It now compares each entry against the newest seen
for its part number with compareLatestPartAttempt, the comparator
sortEntriesByLatestChunk sorts with.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: order part attempts by commit stamp, then attempt time
Comparing commit stamps only when both attempts carried one made the order
non-transitive across stamped and unstamped attempts, so listing and
completion could pick different attempts depending on input order. The
commit stamp now leads (unstamped entries predate the field) and the
attempt time breaks ties.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: list part 10000 after the four-digit part numbers
Part names sort as text, so 10000_<uuid>.part lands between 1000.part and
1000_<uuid>.part. A page could end on part 10000 and the next marker then
skipped parts 1000-9999, and a legacy 1000.part could be reported before
the newer attempt of part 1000 was read. List the four-digit part numbers
first and part 10000 in its own prefix listing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: test ListParts paging across part 10000
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
test/s3: build s3-fast-list with its data map draining the last page
The data map task reads the channel and then the list-task state. When
the list task sends its last page and completes between the two reads,
the map is dumped without that page and the tool exits 0, so a one-page
prefix comes back empty. Read the state before the channel.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* telemetry: refresh the server module to the root module's dependency versions
The server module replaces seaweedfs with ../.., so root dependency
bumps raised prometheus/common, prometheus/procfs and x/sys past the
versions its go.mod listed, and go build refused to run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: run the telemetry integration test on root go.mod changes
The telemetry server module builds against the root module through a
replace directive, so a root dependency bump can leave its go.mod stale
without touching telemetry/.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The versions chart keeps the 8 versions with the most clusters on the last
day and folds the rest into "other". A new release starts small, so 4.54
(282 clusters) was folded in while 4.53 shrank as clusters upgraded,
which showed as a dip across the named versions. The newest plain release
now always keeps its own band.
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* mount: release the meta cache lock between batches of a rebuild wipe
deleteFolderChildrenForRebuild held mc's write lock while it listed every
cached child of the directory and deleted them. Every metadata read in the
mount (FindEntry, IsNameFresh, isOversized) takes the read lock, and a
waiting writer blocks new readers, so while a large directory was wiped,
lookups and getattrs in unrelated directories queued behind the scan. The
scan gets slower as leveldb accumulates the deletion markers of earlier
wipes of the same directory, which happens quickly once lookups rebuild
expired directories.
Wipe rebuildWipeBatchSize (1024) children per lock hold and drop the lock
between batches. A child is judged pinned under the same lock that deletes
it, so a local-only create is kept whether it was pinned before the wipe
started or between batches. The listing that refills the directory already
ran outside the lock, so batching adds no interleaving the build did not
allow.
Add LevelDBStore.BatchDeleteEntries, the counterpart of BatchInsertEntries.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* mount: bound how long a lookup waits on the directory rebuild it starts
Since #11268 a lookup whose parent's cache expired rebuilds the parent and
every expired ancestor up to the mount root before it answers, and every
lookup beneath them joins the same builds. With a slow listing (a large
directory, a busy filer, or the meta cache lock held by another rebuild) a
plain stat, an ls -l, or the parent touch after mkdir waited for all of it.
Wait at most lookupRebuildTimeout (2s), then fall back to one LookupEntry
RPC. Since #12206 the shared build does not run on the requester's context,
so it keeps going after the waiter gives up and later lookups find the
directory cached. A timed-out wait records a rebuild attempt, so lookups
during the cooldown do not queue on a build that is already known to be
slow.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* mount: wait for the rebuild's listing in TestLookupDoesNotWaitOutSlowRebuild
The build runs on its own goroutine, so the lookup that stopped waiting
for it can return before the build's ListEntries reaches the filer. The
test read `started` without waiting right after the lookup returned, which
relied on an ordering nothing guarantees, and the ListEntries count taken
afterwards assumed the same. Wait for the listing to arrive, bounded by
the test's deadline.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* mount: keep children inserted while a rebuild wipe runs
A deferred create inserts its placeholder before Create registers the
handle that pins it. The single-lock wipe made such an insert wait until
it finished, so the placeholder survived; a batch that runs in that gap
judged it unpinned and dropped it, and the rebuilt listing then omitted
the file until its flush.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: drop a cached path that an event vacates during a rebuild wipe
A build replays only the events later than its listing's snapshot and
leaves the earlier ones to the listing, which starts after the wipe. With
the wipe in batches a file's whole life fits inside it: created, flushed,
then unlinked or renamed away. Both events are earlier than the snapshot
and are skipped, the listing has no such file, and the placeholder the
wipe kept stays in the published directory until the next rebuild.
While a directory's wipe runs, an event buffered for it now takes the
path it vacates out of the store at once, fenced by versions like any
other event. After the wipe the store holds what the listing put there,
and a removal earlier than the snapshot may still arrive, so from then on
the event is left to the replay as before.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* mount: check which file a removal took away during a rebuild wipe
Two things the removal applied during a rebuild wipe got wrong.
A placeholder is unversioned, so the version gate lets every removal
through. One that arrived late, for an earlier file of the same name,
took out the placeholder of a file created since. The entry the event
took away is now compared with the cached one, by inode or, with no
inode to compare, by creation time. An event that only names the file
cannot tell and is taken at its word.
The entry was deleted without OP=MV, so taking one name of a hard-linked
file out of the cache also took one off the count its other names share.
A replayed event that vacates a path already deletes with OP=MV.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* mount: keep a removal the rebuild wipe declined out of the replay
The wipe declines a removal when what is cached there is newer than the
event or is another file than the one it took away. The event stayed
buffered anyway. An unversioned listing clears the children's version
records and replays every buffered event, so the declined removal then
deleted the entry the wipe kept and the directory was published without
it.
A declined removal now buffers only the name it puts in place, so a
rename still lands on replay.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: check a declined removal again when the build replays it
The previous commit dropped the removal half of an event the wipe
declined, judged by the file cached when the event arrived. Earlier
buffered events can replace that file during the replay: a listing
attempt that failed leaves its events buffered, so the retry's wipe may
see the first attempt's file while the replay puts a later one in place
first. The dropped delete then left that later file published.
The wipe now records which removals it declined, and the replay checks
each against the entry it finds at that point, replaying only the name
the event puts in place when that entry is still another file. A
removal declined by version is replayed as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: keep a declined removal's invalidation off the placeholder's handle
After the replay the build invalidates every buffered event again,
raised to the snapshot, and it still sent the original of a removal the
replay rejected. A late delete of an earlier file then reached the
handle of the placeholder at that name: the placeholder is unversioned,
so the raised timestamp got past it and the handle was marked deleted.
The replay's decision on a declined removal now replaces the event in
the buffer, and the invalidations use what was replayed. It is made
before the snapshot check, so a removal the listing covered is judged
the same way.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: keep an event's signatures on the halves a rename is split into
A declined removal replays as its rename's create half, and a rename across
a building directory is split in two. Both dropped the event's filer
signatures, so a handle stamped by that filer no longer fenced the replayed
invalidation by timestamp and could take older listed contents over newer
ones it had read.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: drain invalidations around the declined-removal build check
Invalidations run on a background worker, so the baseline could miss the
removal's own and the final read could run before the build's arrived.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: MapleWhiteZZZ <18653045+MapleWhiteZZZ@users.noreply.github.com>
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* volume: fsync a batch delete that asks for it
BatchDeleteRequest gets an fsync field, and the Go and Rust volume
servers pass it to the needle delete, which already orders the
tombstone, .dat sync, publish and .idx sync for a durable delete.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* operation: pass an fsync flag to batch deletes
DeleteFileIdsWithLookupVolumeId and DeleteFileIdsAtOneVolumeServer take
an fsync argument and send it in the BatchDeleteRequest. Every caller
passes false for now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: fsync chunk deletes under an fsync path rule
DeleteChunks passes the path rule's fsync flag to the deletion queue.
The flag is kept with the pending record until the delete is
confirmed, so retries and re-queues keep it, and the batch and retry
loops send marked ids in a durable BatchDelete.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep fsync marks in the deletion ledger
Marked ids go into the trailing parts of a manifest ledger, counted by
fsyncParts. Older filers read those parts as plain ids and still delete
them; a reload or a claimed foreign ledger restores the marks. A ledger
without marks keeps the single array form.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: record a queued deletion before the delete loop can see it
queueDeletions published the ids to the hot queue before taking the
ledger lock, so a concurrent flush could delete an id before its fsync
mark landed and then forget the mark with the record.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: fsync a folder delete's chunks by each child's path rule
A recursive delete collected its file children's chunks and resolved
the rule once for the folder, which misses a trailing-slash rule on
the folder itself and file-prefix rules. Each file child's own rule now
decides fsync; the folder rule still decides chunk deletion.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep a newer fsync request when a plain delete finishes
An id re-queued with fsync while a plain delete of it was in flight
lost its mark when that delete succeeded, so the queued copy also ran
without fsync. A plain attempt now leaves a marked record for its
queued copy; a durable delete of an already-deleted needle still syncs
the tombstone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: delete a folder's plain child chunks without fsync
Children whose own rule turns fsync off were still deleted durably when
the folder's rule asked for fsync. Only the children marked by their
own rule now go out with fsync.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: retry a durable chunk delete the volume server failed
A volume server rolls back a durable delete it cannot sync and answers
with a 5xx carrying the I/O error text, which the classifier took as
permanent, so the record and its fsync mark were dropped while the
needle stayed live. A 5xx answer to a durable delete is now retryable,
within the usual attempt limit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: build request condition keys in one helper
Split the keys ExtractConditionValuesFromRequest reads from the request
itself into RequestConditionValues, keeping aws:SourceIp and the
bucket-listing keys in the method.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: evaluate request condition keys for STS sessions
The IAM integration context for STS and OIDC sessions carried only the
source IP, legacy user agent/referer keys and claims, so role and session
policy conditions on s3:x-amz-*, aws:SecureTransport, aws:CurrentTime,
s3:RequestObjectTag/* and the other request keys never matched: a Deny
on them never fired, and a negated Deny always did. Add the same request
keys the static identity path evaluates.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: report SigV4 presigned requests as REST-QUERY-STRING
s3:authType recognized only SigV2 query authentication, so a policy
condition on REST-QUERY-STRING never matched a SigV4 presigned URL.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* ci: cache the Snowflake suite's Maven dependencies under their own key
setup-java's maven cache key hashes the repository pom.xml files, which
other Java workflows share. The Snowflake job restored that cache, which
lacks the suite's plugins and dependencies, and never saved its own because
the key already existed. Every run downloaded the whole suite dependency
tree from Maven Central and failed when Central answered 429.
Key the cache on run.sh, which pins the suite revision.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: fall back to Google's Maven Central mirror in the Snowflake job
A cold cache still resolves about 36 MB of plugins and dependencies, and
Maven gives up after three 429 retries within 30 s. Add the mirror as a
settings-profile repository; Maven tries it first and moves on to Central
for any artifact the mirror fails to serve.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: mint read_auth for the data chunks behind manifest chunks
* filer: cover every chunk behind manifests in read_auth (data + nested), minted after resolution, and skip when read signing is off
* filer: pass the master client as manifest cache invalidator, and move the read_auth helpers below populateBatchReadAuth for the enterprise merge
* testutil: fetch pinned Maven Central jars with a mirror fallback
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: mount pinned Iceberg jars into the Spark catalog containers
Each test started a new Spark container that resolved the Iceberg runtime
and AWS bundle through Ivy from Maven Central, so a run downloaded them six
times and a single refused request left Spark retrying until the package
timed out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: cache the Iceberg jars for the Spark catalog tests
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* testutil: test the verified jar download
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: bound Maven jar downloads by one deadline shared across retries
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: give each Maven mirror attempt its own timeout within the download budget
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: accept an empty ListObjectsV2 continuation-token
An empty continuation-token lists from the start and is echoed back
empty, as S3 does; rejecting it broke s3-tests
test_bucket_listv2_continuationtoken_empty.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: leave the ListObjects V1 Prefix unencoded under encoding-type=url
S3 encodes the V1 Delimiter, markers and keys but echoes Prefix as sent,
and botocore, which always asks for url encoding, decodes the V1 Prefix
only for V2. Encoding it broke s3-tests test_bucket_list_prefix_unreadable.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: use a codespell-clean key in the versions encoding test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: URL-encode a V1 Prefix that XML cannot carry
Leaving the V1 Prefix raw under encoding-type=url turned a control
character such as \x01 into U+FFFD in the response. Such a prefix is
URL-encoded again; prefixes that are valid XML text, including '\n',
stay as sent.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* master: export writable volumes per disk for each volume layout
The layout gauges only report how many volumes of a collection take
writes, not where they sit, so two writable volumes sharing one disk
cannot be seen or alerted on. The leader now exports
writable_volumes_per_disk with the layout labels plus data center, rack,
node and disk id, counting the replicas of the layout's writable volumes
on each disk (state=writable) and those of them that are crowded
(state=crowded). Series for disks that no longer hold a writable volume of
the layout, and for layouts that are gone, are deleted.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* master: reset the leader-only layout gauges on followers
The layout writable, crowded, under-replicated and per-disk gauges are only
set by the leader, so a master that lost leadership kept exporting the
values of its last term indefinitely, and dashboards that aggregate over
masters could show numbers days old. A master that is not the leader now
clears them on each periodic pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* grafana: chart disks holding several writable volumes of a collection
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* grafana: keep disks of different clusters apart in the per-disk panel
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: reject an empty ListObjectsV2 continuation-token
AWS answers continuation-token= with 400 InvalidArgument ("The continuation
token provided is incorrect"); SeaweedFS listed from the start of the bucket.
No token this server issues is empty, and raw-key and base64: tokens keep
resuming as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* s3api: reject an encoding-type other than url on listings
AWS answers any encoding-type other than url with 400 InvalidArgument
("Invalid Encoding Method specified in Request") on ListObjects,
ListObjectsV2, ListObjectVersions, ListMultipartUploads and ListParts;
SeaweedFS ignored the value and listed unencoded keys.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* s3api: apply encoding-type=url to ListObjectVersions
The handler accepted encoding-type=url but returned raw keys. It now
URL-encodes Key in Version and DeleteMarker entries, CommonPrefixes, Prefix,
Delimiter, KeyMarker and NextKeyMarker with the urlPathEscape form ListObjects
uses, and echoes EncodingType.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* s3api: URL-encode Prefix and Delimiter in ListObjects responses
Under encoding-type=url, ListObjects and ListObjectsV2 encoded keys,
CommonPrefixes, markers and StartAfter but echoed Prefix and Delimiter raw,
so a client decoding them once corrupted a prefix holding '%' or '+'.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* volume growth: spread writable volumes of a layout over servers and disks
Volume growth picked every server, and the volume server picked every disk,
independently: the server weighted by free slots, the disk by the lowest
total volume count. A grow request therefore stacks several writable volumes
of one collection on some disks while most disks get none (a Poisson spread:
with 160 replicas on 479 disks about 20 disks get two or three), and their
writes share those disks.
Data centers and racks are still picked weighted by free slots. Inside a
rack the server is now one of those holding the fewest writable volumes of
the layout per disk, weighted by free slots among them; this covers the main
server, same-rack replicas and replicas walked into other racks and data
centers. On the volume server the disk is the one with the fewest writable
volumes of the collection, then the lowest volume count as before.
A grow request registers each volume before placing the next, so a request
smaller than the number of disks lands on distinct disks.
Fixes#12746
* volume growth: scan the layout load once per grow request
Placing each volume rescanned all writable volumes of the layout under its
read lock. RecordAssign takes that lock exclusively on every assign, so with
thousands of writables (0.8 ms for 10000) every volume of a grow request
stalled assigns once more.
GrowByCountAndType now scans once and findAndGrow adds every volume it
creates to the counts. Per volume, placement costs about 130-160 us on 480
servers whatever the number of writables, against 120 us before the spread
change; the single scan is 0.17 ms for 2000 writables and 0.8 ms for 10000.
* volume growth: address review of the spread placement
- Count only disks that report volume slots in a server's load. An
unavailable disk, or one low on space with no volumes, is still listed in
DiskTags with no slots; counting it understated the load of a server with
failed disks and piled volumes onto its remaining ones.
- On the volume server, judge a volume full by its .dat size, which the
master compares with the limit, not by ContentSize.
- A server that refuses an allocation ranks last for the rest of the grow
request, and the request retries the volume up to 3 times. The least
loaded server is picked first deterministically, so without this one server
that cannot fit a preallocated volume stopped the layout from growing.
- Scan the layout load after warmup, so a grow request issued right after a
leader change sees the writable volumes the returning servers report.
* volume growth: keep the request-local placement load ahead of the request fields
The JSON request fields stay together at the end of VolumeGrowOption, and
the comment now says the load lives for the whole grow request.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): place a new volume on the disk with the fewest writable volumes of its collection
Store::add_volume picked the disk with the most free slots, so the Rust
volume server ignored the collection spread rule the Go server now applies.
find_free_location ranks disks by the writable volumes of the collection
first (not read-only, .dat below the volume size limit), then by free slots.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume growth: leave a refusing server out of every placement tier
A server that refused an allocation only ranked last among the servers of
its rack, so the weighted data center and rack picks could still choose its
rack on every retry while other racks had room. It now offers no free slots
for the rest of the grow request, which takes its slots out of the rack and
data center weights too. If only refusing servers are left, they are tried
again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume growth: require the full same-rack count only in the main rack
The data center check asked every rack for SameRackCount+1 free servers,
but only the main rack holds the same-rack copies; each other rack takes one.
With a refused server left out of its rack, the check rejected a feasible
placement, the retry put the refused server back, and it was picked again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Konstantin Lebedev <whitefox@mayflower.work>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* volume: fsync a needle delete that asks for it
A delete now takes fsync like a write: the tombstone is synced before the
needle map drops the needle, and the .idx row before the delete is
acknowledged. A failed .dat sync takes the tombstone back off the .dat.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: honor fsync=true on DELETE and forward it to replicas
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): fsync a needle delete that asks for it
Mirrors the Go volume server: DELETE with fsync=true flushes the tombstone
before the index drops the needle and the .idx before the ack, and a failed
.dat flush takes the tombstone back off the .dat.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: let a durable delete through on a full volume
A queued delete hit the batch worker's volume size check, which a
tombstone append is exempt from inline, so fsync=true deletes failed once
the volume reached its hard limit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: sync a durable delete of an already-deleted needle
An earlier delete without fsync may have dropped the needle with its
tombstone still unsynced, so the inline path syncs before acking anyway,
as the batch worker already does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: refuse a batch request that races the worker stopping
stopWorker can close the batch channel between startWorker handing it out
and the send, which panicked. The request now falls back to the inline path.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): sync a durable delete of an already-deleted needle
Mirrors the Go volume server: an earlier delete without fsync may have
dropped the needle with its tombstone still unsynced.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): run a durable delete on a blocking thread
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: keep syncDelete's signature for existing callers
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: refuse a write a delete cancelled before it appends
A write cancelled while still queued behind the volume locks used to
append, publish and then tombstone itself without a sync, after its
delete may already have been acknowledged as durable. A crash could
keep the row and lose the tombstone. Refuse it before the append.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): refuse a write a delete cancelled before it appends
Mirrors the Go change: a write cancelled while still queued behind the
volume locks no longer appends, publishes and tombstones itself without
a sync after its delete may already be durable.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): drop the write guards for a durable delete's flushes
The durable delete held the write lease and the io write guard across
both fsyncs, so reads of the volume waited on them. Append and publish
the tombstone under the guards and flush with only the io read side, as
write_synced_run and the Go path already do. do_delete_request keeps its
signature.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: stop taking writes when a durable delete fails to index
The needle map drops the needle before it appends the .idx row, so after
a failed append a durable retry found nothing to delete and acked, and a
later write could bury the unindexed tombstone so a reload brought the
needle back. Fence the volume the way a failed durable write does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): stop taking writes when a durable delete fails to index
Rust counterpart of the Go change: the needle map drops the needle
before it appends the .idx row, so a failed append left a durable retry
nothing to delete, and a later write could bury the unindexed tombstone.
publish_delete_request now fences the volume for a durable delete, as
publish_write does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: stop taking writes when any delete fails to index
A non-durable delete whose .idx append failed left the volume writable with
the needle already dropped from the map, so a later durable retry found
nothing to delete and acknowledged without the missing row.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): stop taking writes when any delete fails to index
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: take the fsync flag on the existing delete functions
DeleteVolumeNeedle, deleteNeedle2 and syncDelete take fsync instead of
gaining *WithFsync variants.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): take the fsync flag on the existing delete functions
delete_volume_needle and delete_needle take fsync instead of gaining
*_with_fsync variants; the durable path and the deletable checks fold
back into delete_needle, and the cancelled-write check mirrors Go's
isCancelledWrite.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* test(s3): s3-listing-study integration suite (WIP)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* test(s3): run the s3-listing-study tools against SeaweedFS (WIP)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* test(s3): s3-listing-study deleted-prefix probe, fresh data dir per run
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* test(s3): listing study ports keep clear of every gRPC companion
free_ports.py compared only base ports, so a base port could land on
another server's base+10000 gRPC listener.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(s3): listing study ports stay below the ephemeral range
Base ports of 20000-55000 put both them and their gRPC companions inside
32768-60999, so an outgoing connection made while weed server starts could
take a port before the server that was given it binds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(s3): listing study checks the order inside each listing page
parse_page sorted Contents and CommonPrefixes together before the probes
compared them, so keys returned out of order within one page passed. Check
each list's byte order first; the versions pager does the same.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(s3): listing study applies --only before running a probe
The filter was applied to the probe results, so a run limited to one tool
still sent every reference listing request and the deleted-prefix check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(s3): listing study requires CommonPrefixes from shallow modes
The CommonPrefixes comparison ran only when a tool returned at least one
prefix, so a delimiter listing of the canary root that came back empty
passed. Compare them for every shallow mode except the two whose
normalizer keeps keys only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: reject unknown elements in PutBucketNotificationConfiguration
xml.Unmarshal skips children that match no field, so a configuration
whose only child was an unmapped element parsed as empty and returned
success while nothing was stored.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: fail test-with-server when the server does not stop
A passing suite returned success even when stop-server gave up with the
server still running.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3: run tigrisdata-community s3-api-compat-tests in CI
Runs the suite, pinned to a commit, against weed mini through a small
provider patch, and fails on any test that is not in
expected_failures.txt or on a listed test that starts passing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* test/s3/tigris_compat: prepare the suite again when the patch changes
The checkout was reused whenever it sat at the pinned commit, so an
edited seaweedfs-provider.patch, or a checkout whose patch failed to
apply, kept being built as it was. Record the commit and the patch's
hash once the patch applies, and prepare the checkout again when either
differs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: keep the pid file of a server already running
start-server removed weed-server.pid before it found the port taken, so
a second start lost the pid of the server holding it and stop-server
could no longer stop that one. Remove the file only once the port is
free, and have test-with-server stop only a server it started.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: bound the S3 port probes
A listener that accepts but never answers held curl, and with it the
readiness loop and the cleanup after it, for good. Give each probe two
seconds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: expect a listed test to end with its listed status
A listed test passed the check with any non-pass status, so a setup error
that skipped the call under test (RestoreObject's PutObject, say) went
unnoticed. Entries now expect fail unless they name another status; only
GetBucketAccelerateConfiguration, whose setup PUT is unsupported, expects
error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: refuse to start while the recorded server still runs
A second start-server before the first server answered on the S3 port
passed the port probe and dropped the pid file of the live server, so
stop-server could no longer stop it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: recognize the test server by its command line
start-server and stop-server took any process named weed at the recorded
pid for the test server, so a weed process that reused the pid would be
reported as running and killed by stop-server. Match the command line
start-server launches instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: recognize the test server by its start time
A weed mini started from another checkout has the same command line, so
a pid it reused still matched. Record the process start time next to the
pid at launch and require both before treating the process as the test
server.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: PutObjectTagging_VersionId passes now
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: keep the server records until the server exits
stop-server waited a fixed two seconds after SIGTERM and then removed
weed-server.pid and weed-server.started even if weed was still shutting
down, so a later stop-server could not find it and clean could delete
data it still used. Wait up to 30 seconds for the recorded server to exit
and keep the records, failing, while it still runs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: start the server on an empty data directory
A data directory left by an earlier run on other ports made the master
freeze volume growth (topology id mismatch), and every PutObject failed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3: run tigrisdata-community s3-api-compat-tests in CI
Runs the suite, pinned to a commit, against weed mini through a small
provider patch, and fails on any test that is not in
expected_failures.txt or on a listed test that starts passing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* test/s3/tigris_compat: prepare the suite again when the patch changes
The checkout was reused whenever it sat at the pinned commit, so an
edited seaweedfs-provider.patch, or a checkout whose patch failed to
apply, kept being built as it was. Record the commit and the patch's
hash once the patch applies, and prepare the checkout again when either
differs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: keep the pid file of a server already running
start-server removed weed-server.pid before it found the port taken, so
a second start lost the pid of the server holding it and stop-server
could no longer stop that one. Remove the file only once the port is
free, and have test-with-server stop only a server it started.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: bound the S3 port probes
A listener that accepts but never answers held curl, and with it the
readiness loop and the cleanup after it, for good. Give each probe two
seconds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: accept PutBucketAccelerateConfiguration with Status=Suspended
GetBucketAccelerateConfiguration always reports Suspended, but the PUT
answered 501 for every request. Suspended is now accepted, Enabled
stays NotImplemented, and the accelerate subresource resolves to
s3:GetAccelerateConfiguration / s3:PutAccelerateConfiguration.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* s3api: accept an empty PutBucketNotificationConfiguration
GetBucketNotificationConfiguration always reports an empty
configuration, but the PUT answered 501, including for the empty
configuration clients send to clear notifications. An empty one is now
accepted; a topic, queue, Lambda or EventBridge destination stays
NotImplemented.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* s3api: reject accelerate and notification bodies with the wrong root
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* test/s3/tigris_compat: expect a listed test to end with its listed status
A listed test passed the check with any non-pass status, so a setup error
that skipped the call under test (RestoreObject's PutObject, say) went
unnoticed. Entries now expect fail unless they name another status; only
GetBucketAccelerateConfiguration, whose setup PUT is unsupported, expects
error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: refuse to start while the recorded server still runs
A second start-server before the first server answered on the S3 port
passed the port probe and dropped the pid file of the live server, so
stop-server could no longer stop it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: recognize the test server by its command line
start-server and stop-server took any process named weed at the recorded
pid for the test server, so a weed process that reused the pid would be
reported as running and killed by stop-server. Match the command line
start-server launches instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: recognize the test server by its start time
A weed mini started from another checkout has the same command line, so
a pid it reused still matched. Record the process start time next to the
pid at launch and require both before treating the process as the test
server.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: PutObjectTagging_VersionId passes now
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: keep the server records until the server exits
stop-server waited a fixed two seconds after SIGTERM and then removed
weed-server.pid and weed-server.started even if weed was still shutting
down, so a later stop-server could not find it and clean could delete
data it still used. Wait up to 30 seconds for the recorded server to exit
and keep the records, failing, while it still runs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3/tigris_compat: start the server on an empty data directory
A data directory left by an earlier run on other ports made the master
freeze volume growth (topology id mismatch), and every PutObject failed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: return x-amz-version-id from object tagging on versioned buckets
PutObjectTagging, GetObjectTagging and DeleteObjectTagging now report
the version they acted on, "null" for an object written before
versioning was enabled.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* s3api: set the tagging x-amz-version-id only on success
The header was set before the tag-conditioned policy recheck, so a
denied request carried the version id on its AccessDenied response.
Also test the "null" version and require distinct version ids.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* test/s3: run tigrisdata-community s3-api-compat-tests in CI
Runs the suite, pinned to a commit, against weed mini through a small
provider patch, and fails on any test that is not in
expected_failures.txt or on a listed test that starts passing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* s3api: report no ownership controls after DeleteBucketOwnershipControls
GetBucketOwnershipControls reports BucketOwnerEnforced for a bucket that
never stored a setting, so it kept reporting it after the setting was
deleted. The delete now records that it happened, and GET answers
OwnershipControlsNotFoundError until ownership is put again. How
objects are written after the delete is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* s3api: answer DeleteBucketOwnershipControls with 204 No Content
AWS answers a successful DeleteBucketOwnershipControls with 204 and no
body; this answered 200 with an empty OwnershipControls document.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* lance: per-table cleanup retention and on-demand purge of deleted rows
A vector deleted from an index stayed in storage until compaction
rewrote its fragment (only above 10% deletions) and the cleanup job's
168 h retention, set once per worker, aged out every version that
referenced it.
Let a table override retain_hours and min_versions in its Lance config
(seaweedfs.cleanup.retain_hours, seaweedfs.cleanup.min_versions), and
let it request a purge (seaweedfs.purge.requested). The cleanup job
proposes a table with a pending purge regardless of the version floor
and then rewrites every fragment with deletions, retrains the indices
(a remapped IVF_FLAT index still holds the deleted vector), keeps only
the latest version, and records the request as served. A version pinned
by a tag fails the purge and leaves the request pending.
The test scans every file of a local table for a deleted vector's key,
metadata and values, and finds none after the purge.
* lance: refuse to purge a sharded vector index
A retrain builds every index name over the whole table, so the purge
turned shards of one vector index (one name per fragment set) into
names that each covered every fragment, indexing every row once per
shard. Check before compacting and fail with the request left pending,
and retrain only the vector indices.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* lance: rebuild scalar indices in a purge
Compaction only remaps scalar indices, and a retrain leaves them alone,
so a purge reported success while a bitmap index still listed the
deleted row's value, and under stable row ids a BTree index still held
the deleted key. Build each scalar index again from the remaining rows
with the parameters it was built with.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* lance: purge through the cleanup job's retention policy
The purge built its own cleanup policy, so a deployment that has the
cleanup job keep more than the floor and the window (versions an
unleased reader may still be on) would have lost them to a purge. Clean
up through retention_policy, the one the job itself uses, with the
latest version kept.
Mark the request served only once the oldest version left is one the
rebuild wrote, and record the rebuild so a purge that has to wait for
its cleanup (a tag, or that policy) retries only the cleanup instead of
compacting and retraining the indices on every pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* vector: lease the version every list page reads
A list page read its version without a lease unless it was a segment
that read data and metadata twice. A purge removes every version but
the latest, and only a lease tag stops it, so a listing that opened the
version before the purge's compaction could lose its files mid-read.
Pin it as get_vectors and query_vectors do.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* lance: give the cleanup job a build's execution time
A purge compacts the table and retrains its indices inside a cleanup
job, but the job declared no runtime defaults, so the admin held it to
its 90 s default and could expire a purge mid-rebuild. Declare the same
budget the indices job uses for a retrain.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* mount: drop a peer-unlinked name only while its inode keeps another
Move the survivor check from followSurvivingLink into InodeToPath.RemoveAlias
so the check and the removal happen under one table lock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: follow a peer unlink to the surviving hard link for closed inodes
A peer deleting one name of a hard link only moved an open handle to the
surviving name. A closed inode kept the deleted name as its primary path, so
the next open by the kernel's nodeid failed with ENOENT.
Co-authored-by: skymazer <54621405+skymazer@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: share the cached-entry freshness check of peer invalidations
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: keep a name a local rename reclaimed before the peer unlink arrived
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: keep a name a local rename or link gave the inode after an older peer delete
The cached-entry check only covers a cached parent. InodeToPath now records,
per hard-linked inode, the newest name a local rename or link gave it with
the filer stamp, and the closed-inode peer-delete path keeps that name when
the delete is older. The record lives in a side map dropped on Forget, so
InodeEntry keeps its size class.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: sign rename stream responses with the filer signature
A rename response carries the stamp of the filer that applied it, so the mount
can tell which clock the stamp belongs to, as it does for create acks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: order a peer delete against a local rename or link only on one filer clock
The stamp of a local rename or link comes from the filer that applied it, and
a delete logged by another filer runs on a different clock. Keep the name only
when both carry the same nonzero filer signature; otherwise drop it as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: drop the local-name stamp fence for uncached parents
Ordering a delayed peer delete against a local rename by filer stamp needs a
record per alias, a shared filer clock, and the open-handle path to follow;
that is a larger change than this fix. Back to the cached-entry check, which
covers a cached parent.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: skymazer <54621405+skymazer@users.noreply.github.com>
* mount: report opens for reading with TouchAccessTime (-accessReport)
An open answered from the metadata cache never reaches the filer, so a
filer that tracks access cannot see that a cached file is still being
read. With -accessReport, the mount sends one TouchAccessTime per open
for reading, with the open time, whether the open was answered from the
cache or not. Write-only opens are not reported.
Reports go out in the background and never hold up the open: a report
that does not fit in the queue is dropped, and drops and failures are
logged once a minute. A filer that answers Unimplemented pauses
reporting for 10 minutes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: address review of the access report
- Drop reports still queued when reporting pauses; the filer that answered
Unimplemented would answer them the same way.
- Bound each filer attempt to 2s, so a filer that accepts the connection
but never answers leaves time for the next one, and keep using the filer
that answered.
- Fail over only when a filer cannot be reached. Any answer, Unimplemented
included, ends the walk.
- Report an O_CREAT open of an existing file with read access, which comes
through Create instead of Open. A new file has nothing to read and is not
reported.
- Stop the reporter on unmount: stop ends the workers and cancels the
report in flight.
- Say in the flag help that it has no effect unless the filer implements
TouchAccessTime.
- Tests no longer wait a fixed time to see that nothing else was sent; they
look at the queue of a reporter that is not started.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: fail an access report over only when the filer did not answer
A status the filer sent ends the walk even when its message contains a
word the transient classifier matches, so an Unimplemented answer still
pauses reporting and a rejected request is not resent elsewhere.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: keep a filer selection made while an access report failed over
A report that reached a later filer moves the mount there only if the
selection it started from is still current, so a slower report cannot
undo another call's failover.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: share an access report's time with the filers not yet tried
Each attempt is capped by an equal share of the report time left, so a
row of stalled filers cannot use up the report before a healthy one later
in the list is tried.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: report the path an open for reading came through
A create that opens an existing hard link reports the name it was
given rather than the inode's first known name. Open reads the inode's
path from the inode table rather than the handle's saved path, which
other handle operations may rewrite concurrently.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: check the access report stop and failover tests without races
The post-stop report is checked on a reporter without workers, so no
worker can take an accepted report before the check, and the failover
test asserts that the stalled filer was tried first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* pb: keep the shared channel when the peer answers with its own status
gRPC never raises InvalidArgument, NotFound, AlreadyExists,
FailedPrecondition, OutOfRange or DataLoss itself, so such a status is
the peer's answer. It fell through to the string matching, and a message
naming a path like /transport closed the cached channel and cancelled
every other call on it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: say which filer selection an access report keeps
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: bound the in-flight call in the rejected-report channel test
The call held in flight went through touchAccessTime, whose 2 s attempt
cap could expire on a slow runner and fail the test on a healthy channel.
It now uses callFiler with the test deadline. The wait for it to reach
the filer also ends if it returns early or the deadline passes, and the
blocked handler is released on every exit path.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: report each file at most once per -accessReport.interval
Every read open used to send a TouchAccessTime, adding a filer metadata
call per open. A path reported within the interval (default 1h) is now
skipped; the last report times live in a bounded LRU. 0 keeps reporting
every open.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: report an open again once the file was modified since its last report
Within -accessReport.interval a read open was skipped even after a write,
so the filer kept an atime older than the mtime until the interval ran
out. relatime records that first read after a write; do the same by
comparing the entry's mtime with the last report.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: keep the report time apart from the mtime it saw
Recording max(now, mtime) as the last report let a file dated a day ahead
suppress reports for a day plus the interval. Record when the report was
sent and the mtime the entry had, and treat any change of that mtime as a
modification, so neither clock can stretch or shorten the interval.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: MapleWhiteZZZ <18653045+MapleWhiteZZZ@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* shell: volume.check.disk skips replicas whose live counts match
FileCount counts every write and DeleteCount every delete or overwrite
until a vacuum drops them, so a replica vacuumed while its peer was not
keeps a different FileCount forever and was re-checked on every run
although both hold the same live needles. Only treat counts as differing
when the live counts (FileCount - DeleteCount) differ too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: volume.check.disk skips equal live counts only across compaction revisions
Equal live counts at the same compaction revision mean a missed write
and a missed delete, not a vacuum-state difference, so keep checking
those pairs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: volume.check.disk real-time recheck ignores heartbeat revisions
VolumeStatus counts are newer than the heartbeat's compaction revisions,
so a vacuum in between could make a pair at the same revision look
vacuum-skewed. Apply the old count rules there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: volume.check.disk skips on live counts only when no repair could follow
Equal live counts across compaction revisions can still hide a missed
write and a missed delete. Keep checking such pairs when -syncDeleted
could propagate the delete, or when -resurrectMissingNeedles could copy
a needle into a never-vacuumed replica.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3vectors: enforce AWS metadata, key and filter limits
PutVectors accepted vector metadata of any size and key count, bounded
only by the request body limit, and keys of any length; QueryVectors
accepted filters of any size. Apply the AWS S3 Vectors limits
(https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-vectors-limitations.html),
taking the ENHANCED index values where the modes differ, since this
implementation prefilters and takes no indexMode:
- 100 KB total metadata per vector, which also bounds a single
non-filterable field;
- 2 KB filterable metadata per vector;
- 50 metadata keys per vector;
- 1024-character vector keys;
- at most 10 nonFilterableMetadataKeys of 1 to 63 characters at
CreateIndex;
- 100 filter constraints per QueryVectors request.
A violation is a ValidationException before the engine is called.
* s3vectors: accept metadata whose JSON is exactly at the byte limits
metadataEntrySize counts a trailing comma for every member, so starting
from both braces overcounted by one and rejected metadata that encodes to
exactly 2 KB filterable or 100 KB total.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3vectors: rewrap the metadata limits header comment
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* kms/openbao: refresh the AppRole token before it expires
The provider logged in with AppRole once, when it was created, and
never renewed the token. After the token's TTL every SSE-KMS upload,
and every read of an SSE-KMS object whose data key was not cached,
failed with "permission denied" (HTTP 500 to the client) until the S3
server was restarted.
With AppRole authentication the provider now logs in again in the
background once two thirds of the token's TTL have passed, and retries
a failed login every 5 s. Each login is bounded by the client's
timeout, or by 30 s when request_timeout is not positive. Close stops
the refresh. A static token, or an AppRole token without a TTL, is left
as it is.
* kms: keep the OpenBao token refresh across configuration reloads
- AddKMSProvider and InitializeGlobalKMS create a provider instance of
their own with the new NewProvider instead of the registry's cached
one: a reload closed the cached instance and then got it back, which
now stopped its token refresh. The new instance is created before the
old one is closed, so a configuration that fails leaves the current
provider working
- openbao: time each refresh from the start of the login that issued
the token, since its TTL runs from then rather than from the response
- tests: a reload gives a new instance and closes the old one, a failed
reload keeps the old one; the refresh survives a reload; a slow login
response
* kms: create a replacement provider outside the manager lock
AddKMSProvider ran the provider factory, which for OpenBao is a login
that may wait for its timeout, while holding the manager lock, so every
lookup, also of unrelated providers, waited for it. The new provider is
now created before the lock is taken; the lock covers only the swap, and
the replaced provider is closed after it. Test: a lookup while another
provider is being created.
PutObject rejected a Cache-Control value it could not parse with
InvalidDigest, whose message is about Content-MD5, even when the request
sent no Content-MD5. CreateMultipartUpload already answers the same parse
error with InvalidRequest; PutObject now does too.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* operation: reassign an upload after a proven-expired volume JWT
* seaweed-volume: mark an expired write JWT refused before append
Mirror the Go volume server: a multipart POST whose write JWT is signed
with the current key, names this fid and fails only on exp gets
X-Seaweed-Write-Outcome: expired-jwt-before-append on its 401, so the
uploader reassigns instead of failing. Both checks use one guard
snapshot, so a key rotation between them cannot drop the marker.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* operation: keep same-FID retry for filer-proxy expiries, snapshot the write signing key, and make the RetryForever budget test fail fast
* operation: re-mint the filer credential before a proxy same-FID expiry retry
* operation: make a proxy marked-expiry terminal in the outer retry too, not only the inner same-FID loop
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* mount: compare permissions against local ids without mapping them again
Access, open and create (without -defaultPermissions) ran FilerToLocal on
entries that maybeReadEntry and maybeLoadEntry already return in local ids.
Under a uid/gid map where a local id is also a mapped filer id, the owner
was mapped twice and the check refused the file's own owner.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: cache a deferred create's placeholder in filer ids
The meta cache stores filer uid/gid and maps them to local ids on every
read, but createRegularFile cached the deferred or writeback placeholder
with the caller's local ids. The second mapping in the permission checks
used to cancel that out under a swapping id map; without it the owner of
a placeholder was refused. Cache a mapped clone and keep the handle's
entry in local ids.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: test that a deferred create returns its entry in local ids
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: stop following a peer that stays unreachable
* filer: re-track an answering peer only while it is still followed
A signature read that succeeds just before the master removes the peer
called initPeerWatermark after the removal, clearing its mark. The loop
then exits, so the watermark it re-tracked never advances or drops and
pins aggregated readers at the settled horizon.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: forget a peer's unreachable clock when the master removes it
Only a successful connection cleared the clock, so every departed address
that once failed stayed in the map for the filer's lifetime, and a re-added
peer inherited the old outage. The removal now drops it, and the clock is
guarded by peerChansLock so the removed peer's exiting loop cannot start a
new one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: report the unreachable mark only when it is set
Once peerResumeRetention forgets the mark of a peer that stays
unreachable, markPeerWatermarkRemoved no longer marks it (its watermarks
are gone), but notePeerUnreachable still saw no mark and logged
"treating it as removed" on every retry. markPeerWatermarkRemoved now
reports whether it set a new mark.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: fix the unreachable-peer subscriber's start before the baseline write
The subscriber goroutine picked its start time itself, so a baseline write
that finished first fell before the subscription and the test failed after
20 seconds with correct delivery.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* mount: answer an interrupted read with EINTR, not EIO
The kernel's FUSE contract (Documentation/filesystems/fuse/fuse.rst,
"Interrupting filesystem operations") lets a filesystem either ignore an
INTERRUPT or honor it by replying EINTR to the original request. Read did
neither: the FUSE cancel channel cancels the read's context, the chunk
fetch fails with "context canceled", and every error became EIO.
Interrupts come from any signal the reader handles. Go's runtime sends
SIGURG for goroutine preemption, so Go programs reading under load hit
this on healthy data: on a 128-thread 64 KiB random-read test about 250
of 5 million reads failed with EIO, and none with GODEBUG=asyncpreemptoff=1.
Read now returns EINTR when its own context was cancelled, the way
dirReadStatus already does for directory reads and lookups do since
#11717. Go's os.File retries EINTR, so those readers see no error. A
cancelled read also skips the entry refresh retry, and neither read log
line reports an interrupt as a warning or error. Failures without an
interrupt stay EIO.
Tests: TestReadInterruptedReturnsEINTR (fails on the old code with EIO),
TestReadFailureWithoutInterruptReturnsEIO; weed/mount/... passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: require the failed-read test to reach the filer
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: skip the read retry once the request is interrupted
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* mount: move an open file's read view to the chunks a merge wrote
When a flush finds that a file's chunks take more than twice its size,
maybeMergeChunks reads the file back and writes it again as new chunks.
The commit that publishes them makes the filer delete the chunks they
replaced. The flush put the new chunks into the handle's entry but left
its read view on the old ones, so every descriptor that kept the file
open went on reading the replaced chunks. Those read back until their
volume is vacuumed. After that a read first retries the fetch of the
missing needle for about 13 s; then refreshEntryForRead installs the
filer's entry and the read is retried. The refresh skips a handle with
writes it has not flushed, and such a read returns EIO instead.
Files that are kept open and rewritten in place, such as PostgreSQL
data files and SQLite databases, are the ones whose chunks bloat, so
they are the ones that hit this.
installRewrittenChunks puts the merge's chunks into the entry and the
read view together, under the entry lock. Chunks attached while the
merge ran were not part of it and stay. Flushes without a merge are
unchanged.
TestMergeMovesReadViewOffReplacedChunks covers the handle.
TestReadOpenHandleAfterChunkMerge runs it on a real mount, with and
without an unflushed write; for it, the fuse_integration framework
starts mini on a free master port and exposes the address.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: drain uploads before a merge replaces the chunks
Uploads attach their chunks without the handle lock, first to the entry
and then to the read view, and writes that landed after doFlush drained
the pages may still be uploading when the flush takes its lock. An
upload that attached during the merge could keep a chunk older than
data the merge already holds, or put a chunk the merge replaced back
into the read view. Either outranks the merge's zero-timestamp chunk.
When the chunks are bloated enough to merge, the flush now drains the
pages again while its lock holds writes off, and takes the chunks again.
FlushAll returns only after every upload has attached to both the entry
and the read view, so nothing attaches during the merge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: leave a pre-merge upload failure to the next flush
The drain before a merge returned an upload failure through the
metadata flush. doFlush then retried it as a filer error and answered
EIO, where the page flush answers a full disk with ENOSPC. The drain is
there only to wait for the uploads: a failure stays with the pages, and
the next flush reports it as a write error, as it would without a merge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: keep chunks attached while a flush installs its compacted list
A write that lands after doFlush drained the pages can still be uploading
when flushMetadataToFiler takes its chunk snapshot. Its upload attaches the
chunk without the handle lock, and the plain flush then replaced the
entry's chunks with the list compacted from the snapshot, dropping it from
the handle and from every later commit. Keep chunks attached after the
snapshot, as the merge path already does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: fail a merge's flush on a failed drain
A failed upload found by the drain before a merge was only logged, and
the flush went on to publish a size covering bytes that no chunk stores.
It now fails the flush as a pageUploadError before anything is
published; doFlush maps it with writeErrorToFuseStatus, as it does its
own FlushData failure, and does not retry it as a filer error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: clone a flush's request entry under the entry lock
The request snapshot cloned the live entry after GetEntry had released
its read lock. Uploads attach chunks without the handle lock, so an
AppendChunks that landed during the clone raced it on the Chunks field.
Clone inside UpdateEntry, as content flush recovery does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: leave a merge to a later flush while uploads are pending
Before a merge the flush drained the pages while it held the handle and
publication locks. A writeback upload retries a transient storage error
until it succeeds, so that drain could hold both locks for as long as
storage stayed down, stalling reads, writes and stat on the handle.
The flush now checks for pending uploads and, if any, publishes the
compacted chunks and leaves the merge to a later flush. With none
pending the lock still holds writes off, so nothing attaches during the
merge, and a failed upload still fails the flush as a write error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: keep room for pending uploads when a flush merges onto a moved entry
A flush that leaves the chunk merge to a later flush publishes while
uploads are still pending, and writes that landed after the drain can be
uploading on any flush. Merging a peer's inline content or a shrink into
such a publication lets the upload attach its chunk next to the inline
bytes, where reads never reach it. Tell createContentEntry when uploads
are pending so the merge keeps room for them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: test chunk merges through the filer's chunk proxy, also under load
The tests serve the filer's chunk proxy, and like the filer the fake
deletes the chunks each commit replaces, so a read view still naming
them fails:
- TestFlushMergeThroughChunkProxy/Quiet: the flush merges, and reads
through the open handle return the file from the merged chunk alone.
- TestFlushMergeThroughChunkProxy/UploadInFlight: an older page is still
uploading while a newer page of the same bytes has attached. The flush
leaves the merge, reads return the newer page, and the next flush
merges.
- TestFlushMergeRacesWithWritesAndReads: four writers, three flushers
and a reader on one handle, with uploads delayed at random. The
writers pause now and then, so 14 to 18 flushes a run merge and the
others leave the merge to a later one. Every read must succeed within
2 s, and at the end the handle and the filer must both hold exactly
what was written.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: let a held upload go when UploadInFlight fails
The subtest's proxy holds the older page's upload until the test
releases it, and only the passing path did. A failure in between left
the handler blocked, so the proxy's cleanup waited on it and the failure
surfaced as a suite timeout. Release it from a cleanup as well, once,
and bound the waits for the upload and the drains.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* mount: ask the filer again when a deferred create is published mid-lookup
A program that writes a file under a temporary name and renames it while
the file is still open (safetensors save_file does, through Rust
tempfile's persist) looks the temporary name up before the rename. When
the parent directory's listing is not cached, that lookup goes to the
filer. If a FLUSH publishes the deferred create while the lookup is in
flight (a forked child closing its inherited descriptor sends one), the
filer can answer not-found from a read taken before the create
committed. By the time the answer arrives the flush has cleared the
handle's dirty flag, so lookupEntry finds nothing local to explain the
answer, logs "possible coherence bug" and returns ENOENT, and the rename
fails although the file exists.
Note before sending the request whether the inode had unpublished
metadata (a dirty handle or an async flush in flight). On not-found, if
it had and has since been published, ask the filer once more: the filer
acknowledged the publish before the second request is sent. A second
not-found stands, so a file another mount removed is not brought back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: judge a placeholder's not-found by one look at its base
Review of the previous commit found two problems. The retry check and the
not-found fallback read the handle separately, so a flush that finished
between the two reads still turned the answer into ENOENT. And the
pre-request read of dirtyMetadata, a plain bool that Write and the flush
set under the handle lock, raced with them on every lookup that reached
the filer.
Note instead whether the handle is a local placeholder: a deferred create
has no filer base (baseEntry) until a flush publishes it. A not-found for
a placeholder is judged by one atomic look at that base. With none, the
filer cannot have the file yet and the handle answers. With a base, the
filer acknowledged the publish, so ask once more. dirtyMetadata is not
read for this, and the not-found fallback keeps the existing check, with
the placeholder decision added.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: answer a placeholder from its own handle; a second miss is final
Follow-ups from review of the previous commit:
- Pick the placeholder after the async-flush wait, from the path's
current mapping.
- A placeholder that still has no base answers from the observed handle
itself, instead of through the not-found fallback, which re-resolved
the path and could miss once the handle was released and the cache
entry evicted.
- A not-found from the second request is final. The flush installs the
base before it clears dirtyMetadata, and keeps it set when a write
landed meanwhile, so the fallback could return a file another mount had
removed.
- Test gates release on cleanup, so a failing test leaves no handler
blocked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: read a placeholder's entry the way GetAttr does
The previous commit answered a not-found for a placeholder from the
handle's live entry under entryLock. Neither of the entry's writers takes
that lock: Write and the metadata flush change size, times and chunks
under the handle lock, and async upload workers append chunks under the
LockedEntry lock, so the lookup could read an entry while it changed.
Answer with the copy the create cached when it is still this file's
(same inode), as the not-found fallback already prefers. Otherwise copy
the handle's entry under both writers' locks, in GetAttr's order (handle
lock shared, then the LockedEntry lock), and convert the copy. No caller
of lookupEntry holds a handle lock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: cache a deferred create's placeholder in filer ids
The meta cache stores filer uid/gid and maps them to local ids on every
read, but createRegularFile cached the placeholder with the caller's local
ids. Under a uid/gid map whose local id is also a mapped filer id, a lookup
or stat answered from the placeholder reported the wrong owner. Cache a
mapped clone and keep the handle's entry in local ids.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: assert the placeholder is cached before checking its owner
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: check the snapshot owner after evicting the cached placeholder
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* helm: set publishNotReadyAddresses on the volume headless service
* fix(helm): separate volume DNS discovery from ingress traffic
* test(helm): cover volume DNS discovery and ingress routing
* fix(helm): rename the volume routing Service so volumes.client cannot collide
* docs(helm): name the ready-only Service for explicit volume backendRefs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(helm): fail when the volume routing Service name collides after truncation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs(helm): point explicit volume backendRefs at the rendered client-volume name
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* volume: remove files a failed VolumeEcShardsCopy wrote
The shard files were copied before the .ecx, so a source holding a
0-byte index failed the request only after its shards had landed, and
nothing removed them: every retried move stranded another unmounted
shard on a new disk.
Copy the .ecx first, staged beside its target, so a bad index fails
before any shard lands; rename it into place only after the shards and
sidecars have copied, so a failed copy never truncates or replaces an
.ecx the destination already has. On any error, remove exactly the
files this call created; files already on the disk (an existing
holder's shards, index or journal) are left alone. Go and Rust volume
servers behave the same.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* ec_balance: skip EC volumes whose every holder reports an empty .ecx
A shard copy refuses a 0-byte .ecx, so detection proposed the same
failing move of such a volume every cycle. Leave volumes with no
holder reporting a needle out of planning; their shards still count
toward disk occupancy.
Claude-Session: https://claude.ai/code/session_011UpvafcfUuC2mLxNAXLQJi
* volume: serialize VolumeEcShardsCopy per volume
Overlapping copies of one vid shared the staged .ecx, and a failed copy's
cleanup removed shards that a concurrent copy had already committed and
mounted. Hold a per-vid EC lifecycle lock across the whole copy and its
cleanup, named as in the enterprise build (Store.EcLifecycleLock /
ec_lifecycle_lock).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: overwrite an existing .ecx in place when committing a copied index
A mounted EcVolume reads its index through an open handle, so renaming
the staged copy over it left the reader on the replaced inode: tombstones
the source had folded into its .ecx never reached the mounted holder.
An index already on the disk is now overwritten in place, as before the
staging change; a fresh destination still gets the rename. Go and Rust.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: stage replacements of shards a VolumeEcShardsCopy finds on disk
The shard transfer opened an existing destination shard with O_TRUNC and
removed it on a stream or write error, so a failed retry deleted a shard
this disk already held. A shard already present is now copied to
<shard>.copying and renamed into place only after every other file has
copied; a mounted copy is reopened so it serves the new file. Fresh
shards still write in place and are removed on failure. Go and Rust.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: stage the .vif and .ecsum a VolumeEcShardsCopy brings until commit
The sidecars landed as soon as they transferred, ahead of the deferred
.ecx commit, so a failure after them left a new .vif beside the index
the failed copy kept. They are now staged as .copying and renamed into
place with the shards and index once every transfer has succeeded; a
source without one still stages nothing. Go and Rust.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: run a Rust VolumeEcShardsCopy to completion when its caller goes away
tonic drops a cancelled handler future at its current await, which
released the EC lifecycle lock while file operations the copy had started
(a cleanup remove_file on the blocking pool, a create or rename) could
still land; a retry taking the lock could then lose its files to them.
The copy now runs in a spawned task that owns the lock, as Go's handler
runs to completion.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: fail the sidecar copy tests with an unreadable source .ecsum
A directory at the source path reads as "not found" on volume servers
that skip non-regular EC files, which turned the failure into a no-op.
A mode-000 file fails the transfer on every implementation; root and
Windows, which can read it, skip the test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: copy each shard a VolumeEcShardsCopy lists once
A shard listed twice and already held here was staged twice; the first
commit rename consumed the staged file, so the second failed the request
after the shard was replaced, and every retry failed the same way.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: wait out an in-flight VolumeEcShardsCopy before mounting its shards
A shard the copy had already landed could be mounted while the copy was
still running; the copy's failure cleanup then removed the file but left
the shard registered and announced. MountEcShards takes the per-volume
lifecycle lock, as the enterprise build already does, and the Rust mount
handler takes the same lock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: fail a VolumeEcShardsCopy whose replaced mounted shard cannot be reopened
The copy reported success while the mounted shard kept serving the
replaced file. The error lets the caller retry the copy instead of
treating the shard as delivered.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: check which transfer fails in the EC copy cleanup tests
An earlier failure, before any shard or sidecar landed, would leave the
destination unchanged and pass every assertion without exercising the
cleanup. The sidecar test also skips on Windows, where a mode-000 file
stays readable.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: fail the sidecar transfer in the EC copy test by injection
A mode-000 file is still readable to root and on Windows, so the test
skipped there. The source now returns an error for the .ecsum request
only, and the test checks that it served .vif before that failure.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: take the EC lifecycle lock for a blanket full teardown
A teardown acknowledged while a detached copy of the same volume was
still waiting on its source let that copy recreate the index and shards
afterwards. Go and Rust now wait for the copy, as the enterprise build
does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: keep the request id on a Rust EC shard copy
The copy now runs in a spawned task, outside the gRPC layer's request id
scope, so its CopyFile calls to the source went out with a new id. Carry
the caller's id into the task.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: unmount a replaced EC shard whose reopen fails
The failed copy left the mount reading the replaced file's inode, so the
destination kept serving the old shard. Unmount it, which also reports
the removal to the master, so a retry copies and mounts it again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: make the Rust EC copy tests fail for the right reason
The sidecar test now serves a directory as the source .ecsum, which root
cannot read either, so it no longer returns early there. The cancel test
holds the store until the handler's join reports the cancellation, so a
copy that finished before the abort can no longer pass it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: stage every shard a VolumeEcShardsCopy transfers
A shard missing here was written in place with a cleanup guard armed
before its transfer started, so a failed copy removed a shard that
ReceiveFile wrote meanwhile. Every shard is now staged, and only one
that did not exist when it is moved into place is removed on failure.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: take the EC lifecycle lock for VolumeEcShardsRebuild
A rebuild folds the deletion journal into .ecx. Run during a copy of the
same volume, the copy's index then replaced the folded tombstones. Go
and Rust take the lock the enterprise build already takes here.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: check the staged .vif bytes in the EC sidecar failure test
A source without the optional .vif also returns success, so the served
extension list could not prove the transfer. The test now reads the
staged .vif when the .ecsum request fails and compares it with the
source's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: unmount a failed reopen's shard on the copy's disk only
UnmountEcShards walks every disk, so a reopen failure on the destination
also unmounted a healthy copy of the same shard on a sibling disk. The
copy now unloads the shard from its own disk and reports that disk's
removal.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: take the EC lifecycle lock for an ordinary EC shard delete
Shards a copy has staged are invisible to the delete's last-shard check,
so deleting the only canonical shard removed the index the copy was
about to commit its shards against. Go and Rust deletes now wait for an
in-flight copy of the same volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: leave a mounted shard's copied file in place on copy failure
A shard mounted on the copy's disk whose file was missing got the copied
file reopened into its mount, then that file was unlinked by a later
failure's cleanup while the mount kept serving it. Only an unmounted
shard's new file is removed now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: skip repeated shard ids with a seen set
Scanning the request prefix for each id made a request with many
repeats quadratic while the copy held the volume's lifecycle lock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: make the Go EC copy and lock tests observe their effects
The fake source counts requests per extension, so the duplicate-id test
proves .ec05 is fetched once, and returns fixture errors instead of
failing the test from its handler goroutine. The staged .vif reaches
the test through a channel. The mount and teardown lock tests seed real
files and check that nothing happened while the lock was held and that
the operation took effect after it was released.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: poll the handler directly in the Rust EC lifecycle lock tests
A spawned handler that had not run when the 200 ms timer fired passed
the blocking check without ever reaching the lock. The tests now poll
the pinned handler future themselves, which guarantees it is waiting on
the lock, and cover the ordinary shard delete as well.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: observe the lifecycle-lock waiter in EC copy lock tests
The mount, teardown, shard-delete and rebuild tests slept 200 ms while
holding the lock, so a handler scheduled only after the unlock passed
without ever taking it. Wait until the handler's goroutine is blocked on
the mutex instead; each test now fails within its timeout if the handler
skips the lock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: check the shard is staged before the failure-path write in a copy test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: recover a missing EC index under the volume's lifecycle lock
Missing-index recovery fetched the index and then ran a store-wide mount
of every orphan shard, without the per-volume lifecycle lock. It could
mount shards an in-flight VolumeEcShardsCopy of another volume had just
renamed in, and that copy's failure cleanup then unlinked a mounted shard.
Each recovered volume now holds its lifecycle lock across a re-check, the
fetch and a mount restricted to that volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): recover a missing EC index under the volume's lifecycle lock
Mirror of the Go change: recover_missing_ec_indexes takes the volume's
ec_lifecycle_lock, re-checks that the index is still missing, fetches it,
and mounts only that volume's shards through mount_recovered_ec_shards_only,
so an in-flight VolumeEcShardsCopy of another volume never has its
renamed-in shards mounted from under it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: mount a volume whose index a copy installed during recovery
Recovery re-checks under the lifecycle lock that the index is still
missing. When a copy installed it in the meantime, the re-check skipped
the mount too, and the volume's other shards stayed unmounted because
later scans no longer list it. Skip only the fetch and still mount the
volume's orphan shards under the lock, in Go and Rust.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: fetch a recovered EC index into the disk the locked re-check found
The re-check under the lifecycle lock only kept a yes/no answer, so the
fetch still wrote to the destination from the first scan, which may be a
disk that has since gone away. Fetch into the record the re-check returned.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: mount a copy-installed EC index even when no peer is known
Recovery skipped the locked step when the master was unreachable, the
lookup failed or no peer was listed. A copy that installed the index after
discovery then left the volume's other shards unmounted, and later scans
no longer list it. Always run the locked re-check, and give up for lack of
peers only when the index is still missing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: grow the stack buffer before scanning for a lock waiter
A full buffer can cut off the handler goroutine's stack, so the test would
report a handler that is waiting as one that never waited.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): fetch a recovered EC index into the disk the locked re-check found
Mirror of the Go change: fetch into the record the re-check under the
lifecycle lock returned instead of the destination from the first scan.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): mount a copy-installed EC index even when no peer is known
Mirror of the Go change: a failed lookup or an empty peer list no longer
skips the locked re-check, so a volume whose index a copy installed after
discovery still gets its orphan shards mounted.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): run missing-index recovery to completion when the mount RPC is cancelled
Dropping the mount handler mid-recovery released the volume's lifecycle
lock while the .ecj merge it had started on a blocking thread was still
landing, so a teardown could remove the volume before that late write.
Run recovery on its own task, as the copy handler does, so the lock is
held until it finishes; Go's handler already runs it to completion.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: skip other volumes before stat in a single-volume EC scan
Recovery re-checks and mounts each volume with its own scans, so a
request with many orphans repeated whole-store discovery once per volume.
The index-owner and orphan-shard scans now take the same volume filter
and drop other volumes' files by name, before the per-file stat, and the
locked re-check scans only its own volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): skip other volumes before stat in a single-volume EC scan
Mirror of the Go change: the index-owner and orphan-shard scans take the
volume filter and drop other volumes' files by name before the per-file
stat, so recovery's per-volume re-check and mount no longer repeat
whole-store discovery under the store lock for every orphan.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): announce shards recovered after the mount RPC was cancelled
Recovery now outlives a cancelled mount RPC, but the heartbeat nudge
stayed in the handler, so shards it mounted after the caller left waited
for the next full EC heartbeat. Nudge it from the recovery task, as Go's
loads announce each recovered shard.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: match the collection as well as the volume id in the recovery re-check
Discovery keys orphans by (collection, vid), but the locked re-check
matched the vid only. Two collections with orphans of the same vid could
both resolve to the first record, so the other's index was never fetched.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): match the collection as well as the volume id in the recovery re-check
Mirror of the Go change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: answer NoSuchBucket from GetBucketRequestPayment for a missing bucket
The handler wrote the static BucketOwner answer without resolving the
bucket, so a bucket that does not exist looked like one that does.
Check the bucket first, as PutBucketRequestPayment and the other static
configuration getters already do.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: test GetBucketRequestPayment on existing and missing buckets
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: release the stamps of parent directories a rename creates
* filer: test that a suppressed create keeps the moved entry's stamp in flight
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* operation: prepare upload content before assigning the volume
* operation: keep the existing upload function names for prepared payloads
UploadData and doUpload prepare once and hand the prepared payload to
retriedUploadData, so the retry loop, doUploadData, uploadChunk and
uploadChunkToHolders take a preparedUpload directly instead of growing
a prepared twin of each and branching on nil.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* operation: send ciphertext whenever the prepared payload carries a cipher key
doUploadData chose the cipher branch from the option, so a payload
prepared under a different option could be sent as plaintext metadata
or lose its key. Decide from the prepared payload itself.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* operation: build a chunk's preparation and upload options in one place
The chunk loop prepared with a hand-written option while uploadChunk and
uploadChunkToHolders built their own, so a setting that shapes the bytes
could reach one and not the other. chunkUploadOption now feeds all three.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* operation: test that a reassigned chunk reuses its prepared payload
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The Go volume server fails the RPC when the remote read returns a
different length than req.Size; the Rust server cached whatever came
back as a full-size chunk.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: let master-pushed adds replace the gateway's lookup-fed locations
After a master leader change the S3 gateway clears its FilerClient cache and
refills it through filer lookups. The filer's own master client may still
answer from the previous leader's generation until the new leader has heard
from the volume servers, so a volume server lost together with the old leader
is cached again. The new leader never knew that server and never pushes its
removal, and the gateway keeps trying it until reads fail on it volume by
volume, one 30 s dial timeout at a time.
The gateway's master client relearns every volume from the new leader's
adds. On each add, cache the volume where the master client now knows it to
be, in place of what a lookup cached, and keep lookups already in flight from
caching their answer over it. A provider answer for a volume is now cached
whole or not at all.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: take a lookup's fill epoch before its second cache check
A master add that landed between the second cache check and the read of
the fill epoch was invisible to both: the check had already missed, and
the epoch the lookup then read already included the confirmation, so a
filer answer that still named the lost server was merged back into the
confirmed entry. Taking the epoch first means such an add either shows
up in the check or stops the answer from being cached. The same order
covers a reset or clear in that gap.
TestConfirmDuringLookupIsNotUndone fires a confirmation from a test hook
at that point and fails with the old order.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: gate the master lookup provider's cache writes on the map epoch
The provider wrote each answer straight into the vid map, so a lookup sent
before a master reset and answered after it landed in the new generation,
which a gateway's FilerClient now reads as the current master's view. The
answer now goes through fillLocations, which drops it once a reset passed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* wdclient: keep the vidMapClient doc comment on its type
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* s3: answer ClientDisconnected for a GET the client aborted before the first byte
Fixes#12706
* s3: tell a gone client on TLS and HTTP/2 too, and not on a connection the server closed
* filer: fail health check when absent from lock ring
If the master broadcasts a lock ring that does not include this filer
(e.g. the late-cleanup race in seaweedfs#11442), every lock acquisition
fails with "no lock server found" and locked writes, including S3 PUTs,
hang indefinitely while /healthz and /readyz still report OK.
Make the filer health handler return 503 once this filer has been
missing from its own lock ring for longer than a 30s grace period, so
Kubernetes liveness probes restart it and it re-registers with the
master. The grace period covers startup before the first ring update
and the master's ring-change batching delay.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: hold the lock-ring health clock until the filer announces
AnnounceOnceCaughtUp can hold the master registration for up to a minute
while HTTP already serves, so the filer cannot be in the ring yet. Report
healthy until the announce gate opens and start the grace period after it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep a probe racing a ring rejoin from reading a reset clock
A probe that loses the CompareAndSwap to a concurrent healthy probe could
load the reset zero and report the filer absent since the epoch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: trim the lock-ring health comments
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: restart the lock-ring health grace when a ring update brings the filer back
The clock only reset when a probe saw the filer in the ring, so a rejoin
and a second removal between two probes reused the first absence and
failed the next probe early. Reset it from the ring snapshot callback.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test the announce gate leaves the lock-ring health clock unset
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: re-read lock-ring membership after starting the health clock
A probe whose first read raced a rejoin could start the clock after the
snapshot callback reset it, leaving a stale start for the next removal.
The ring is installed before the callback runs, so a second read sees the
rejoin whenever the reset came first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: treat a health clock changed during the probe as a rejoin
A rejoin and a second removal can both land between the probe's two
membership reads. The second read then shows the filer absent again, and
the probe judged the new absence by the expired start it had read before
the rejoin's reset. The snapshot callback resets the clock before the next
ring update is installed, so a clock that no longer matches the probe's
start means a rejoin happened; report healthy and let the next probe use
the fresh clock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test ring updates that land during a lock-ring health probe
Move the absence clock into lockRingAbsence, which takes the membership
read as a function, so the test can install ring updates between the
probe's reads: a rejoin after the first read, and a rejoin plus removal
between the two reads.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: give every lock-ring health reset a new clock value
A probe that saw the filer absent started the clock with a CAS from 0,
so a rejoin that reset the clock to 0 again before that CAS was
invisible, and the probe could install a start time from before the
rejoin. Each reset now stores a new non-positive value and the probe
swaps from the value it loaded before the membership read, so any
rejoin during the probe makes the CAS fail. This drops the second
membership read and never waits on the LockRing mutex.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test lock-ring rejoins before and after the probe's membership read
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep the lock-ring version lookup out of the unhealthy health path
LockRing.Version takes the ring mutex, which SetSnapshot holds while
the snapshot callback transfers locks, so an expired-absence probe
could wait on those transfers and time out instead of answering 503.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test an expired-absence health probe while the ring mutex is held
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* test(fuse): two mounts staging the same files without -dlm
Two jobs that extract the same archive into one shared directory, each
through its own mount and without -dlm, both create many of the same
files: a file that exists is skipped, otherwise it is created, written
and closed, then chmod'ed and given its mtime. Before #12593, #12594 and
#12596 the attribute update and the content flush sent the mount's whole
cached entry. Sent after the other mount had rewritten the file, the
update put back chunks that the rewrite had dropped and the filer had
deleted, so the entry pointed at deleted needles and the file failed to
read once its volume was vacuumed. Nothing told the writers.
TestStageSameFilesWithoutDLM runs that on the fuse_dlm cluster with the
mounts started without -dlm (startTestCluster takes a dlm flag;
startDLMTestCluster is unchanged) and checks every staged file: each
chunk is still on the volume server (HEAD on the fid, without
readDeleted) and the filer serves the bytes written. What the losing
writer is told depends on the version and is only logged.
With a 4.53 weed binary the test fails: 66, 71 and 70 of the 400 files
were broken in three runs. With master it passes in about 48 s.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(fuse): bound the staging test's filer and volume checks
The checks used the default HTTP client and a background context, so a
server that accepts a request and stops answering held the test until the
package timeout instead of failing the check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(fuse): fail the staging test unless both mounts wrote the same files
A mount whose MkdirAll failed returned early, and a mount that started
late could skip every file, so the test passed with one writer. Start both
loops together, fail on setup errors, and require files both mounts wrote.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(fuse): bound the staging test's checks with one deadline
A per-call timeout still let 400 hung lookups and reads run for hours.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* s3: keep serving for -preStopSeconds after SIGTERM
On SIGTERM the gateway closed its listeners at once, so requests a load
balancer or Kubernetes Service still routed to it failed until the endpoint
was removed. With -preStopSeconds set, the gateway makes /status, /healthz
and /readyz return 503, keeps serving for that many seconds, then runs the
existing graceful shutdown. 0 (the default) keeps the old behavior.
The flag is registered for weed s3 and as -s3.preStopSeconds for weed
filer, weed server and weed mini. A cancelled weed mini cluster context
ends the wait early. The Helm chart passes s3.preStopSeconds and
filer.s3.preStopSeconds through.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: assert the preStopSeconds chart render under set -e, drop timing from the probe test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: wait before weed mini cancels its clients; size grace periods in the chart
weed mini's interrupt hook runs before the S3 one and cancels the S3
gateway's shutdownCtx, so the pre-stop wait never happened there. The wait
is now also registered with beforeMiniClientsShutdown, which runs before
that cancel, and a sync.OnceFunc keeps the interrupt hook from waiting a
second time. Outside weed mini the registration is a no-op.
Helm: the s3 deployment fails to render when terminationGracePeriodSeconds
is below preStopSeconds + 15. The filer statefulset and the all-in-one
deployment, whose grace period is fixed at 60s, add preStopSeconds to it.
allInOne.s3.preStopSeconds is passed through, inheriting s3.preStopSeconds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: keep 64-bit counters aligned on 386; let allInOne.s3.preStopSeconds=0 disable the wait
draining sat ahead of inFlightDataSize and inFlightUploads in S3ApiServer
and shifted them off 8-byte alignment on 32-bit builds, so the atomic
upload-limit counters panicked there. It now follows them.
Helm: allInOne.s3.preStopSeconds inherits s3.preStopSeconds only when null;
default treated an explicit 0 as unset. The s3 values and the grace period
error now say a lifecycle preStop hook's time comes on top.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* grace: add OnInterruptFirst for hooks that must run before any shutdown
Interrupt hooks run in reverse registration order, so a hook cannot run
ahead of a service that registers later, such as a volume server that is
still loading its volumes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: run the -preStopSeconds wait before every other interrupt hook
Under weed server the volume server registers its hook once its volumes
are loaded, often after the S3 gateway. Its hook then ran first and shut
the volume server down, so the gateway spent the whole wait serving
requests that could not read or write objects.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* s3: escape raw semicolons before the router matches a route
registerRouter applied EscapeSemicolonsInQuery with router.Use, but mux
runs router middleware only after it has picked the route. Queries()
matchers split pairs on ';', so GET /bucket?uploads;x=1 reached the
multipart listing handler while the handler and the IAM resolver read
uploads%3Bx=1 and saw no uploads subresource. Wrap the S3 router with the
escape so routing and authorization read the same query.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: report a listing without prefix as s3:prefix "" in policy conditions
The advanced IAM path already sets s3:prefix to "" when a bucket listing
names no prefix, as AWS does, but bucket policies and attached policies
read conditions from ExtractConditionValuesFromRequest, which leaves the
key out. The AWS home-directory policy that grants s3:prefix ["", "home/"]
then denied the root listing, and a Deny keyed on the empty prefix never
applied.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: test the served handler composition for the semicolon escape
Move the escape and the Vectors split into s3Handler so a command test can
send ';' queries through the handler the server actually serves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: keep the isVectorsRequest doc comment on its function
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(s3api): complete bucket-listing IAM condition handling
Populate s3:delimiter and s3:max-keys for bucket. Add regression tests for listing conditions and variants.
Assisted-by: gpt-6.1-sol, deepseek-v4.1-flash
* fix(s3api): ignore max-keys for multipart listing policies
Assisted-by: GPT-6.1 Terra
* s3api: drop max-keys from multipart-upload listing policy conditions
Bucket policies and embedded IAM policies read condition values through
ExtractConditionValuesFromRequest, which still exposed max-keys on ?uploads
listings. Those page by max-uploads, so an unused max-keys parameter could
satisfy an s3:max-keys condition. Match the advanced IAM path and leave the
key absent there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* topology: never report negative free volume slots
Free volume slots are computed as max + remote - volume - ecSlots. When phantom or over-registered volumes push the count past the configured max, the result is negative and rolls up into the cluster total, causing volume grow and assign to fail with a negative 'volumes left' count even while healthy servers have capacity. Clamp every free-volume count at zero so an over-committed server contributes no slots instead of subtracting from the cluster.
* topology: drop the issue reference from the free-slot test comment
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* topology: test free slots next to an over-committed server
A server with more volumes than slots must not hide the free slots of
the other servers in its rack, data center or topology.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* topology: sum free slots per data node in racks, data centers and topology
Clamping the rolled-up counters only clamped their sum, so one server with
more volumes than slots still hid the free slots of every other server in
its rack, data center and topology. Interior nodes now add up their
children's free slots, so each data node counts as zero at worst. A data
node in maintenance mode no longer adds slots to its parents either.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* topology: test that disk info keeps an over-committed deficit
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* topology: keep the signed free volume count in disk info
EC encode retries and the balance planners add refunds and planned moves
to the published FreeVolumeCount. Clamping it at zero dropped an
over-committed disk's deficit, so a refund could make a full disk look
free. Volume growth already reads the clamped AvailableSpaceFor.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* topology: test placement next to an over-committed server
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* topology: accept either data center order in the placement spread check
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* seaweed-volume: expect a fresh redb file to start at 72 KiB
The assertion fails on redb 4.2.0, whose empty database is about 1 MiB.
* seaweed-volume: bulk-load redb rebuilds with the stable cursor
redb 4.6.0 has no experimental_cursor feature. Full rebuilds insert
sorted needle ids through insert_before, and a new .rdb starts at 72 KiB.
* seaweed-volume: test which redb files are still at the old floor
The gate is missing, so the test does not compile yet.
* seaweed-volume: decide when a reused redb is still at the old floor
Compact only a file above 72 KiB and at most 1 MiB plus 8 KiB, and only
when floor_compact has not been recorded.
* seaweed-volume: test one-shot compact of an old-floor redb
Reuse, shrink, and storage-error recovery are specified. The helpers
they call are not implemented, so the tests do not compile yet.
* seaweed-volume: compact a reused redb that is still at the old floor
One compact runs when the file is above 72 KiB and at most 1 MiB plus
8 KiB. A storage error drops the handle and opens the same path again
so the volume does not keep a PreviousIo latch.
* seaweed-volume: publish a redb replay before compacting the old floor
compact() is what would make a Durability::None tail durable, and a
storage error then drops that tail on reopen. An in-band file is
committed first. The floor_compact flag is read only inside the band,
so a meta error cannot rebuild a larger index.
* seaweed-volume: drop the redb experimental cursor CI step
redb 4.6 has no redb-experimental-cursor feature. The needle-map tests
that used it now run in the normal cargo test step.
* seaweed-volume: drop the experimental-api-5 notes on redb reads
redb's experimental-api-5 can no longer be enabled, so these reads always
use the inherent ReadOnlyTable::get.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* seaweed-volume: drop the always-false flag from the old-floor band check
Both callers pass false and read floor_compact on their own, so the band
check only needs the file length.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* master: unregister a volume server whose heartbeats stop
A volume server sends a heartbeat every 5 s. When its host hangs or its
network drops packets, its SendHeartbeat stream stays open, and the
master unregisters it only once gRPC keepalive closes the connection,
60 s plus 20 s after the last frame. Until then the master keeps
assigning writes to volumes with a copy on it, and those writes hang.
SendHeartbeat now ends the stream when no heartbeat arrives for three
pulses (15 s), which unregisters the server through the existing
deferred path and tells clients its locations are gone. The server
reconnects and registers again once it can reach the master.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* master: test that clients learn a silent server's volumes are gone
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* master: fail the silent-stream receive test instead of hanging
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* pb: fall back to TCP when the local gRPC socket cannot be dialed
A temp cleaner can delete a local gRPC socket file while its server keeps
running. Every later dial to that server then failed with "no such file or
directory", so the master could no longer reach its own volume server and
volume growth stopped. Dial the server's TCP address when the socket dial
fails, as the S3 gateway already does for the filer's HTTP socket.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* pb: recreate a local gRPC socket whose file was removed
Once its socket file was deleted, a server kept accepting on an
unreachable listener until restart, so same-host RPCs stayed on the TCP
fallback. Check the path every minute and, when the file is gone, close
the old listener and bind the socket again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* pb: retry a failed local socket rebind on the next check
A failed rebind ended the watcher, so the socket stayed missing after the
cause cleared. Bind the replacement before closing the old listener: a
failed bind keeps the old listener serving and is retried on the next
check, and the old Serve still reports server shutdown. The old listener
no longer unlinks the path on close, since the replacement now owns it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* pb: set the local socket unlink policy before serving the listener
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* server: add -grpc.localSocketDir for the local gRPC sockets
`weed server` and `weed mini` hard-coded each local gRPC Unix socket
under /tmp. systemd-tmpfiles ages /tmp after 10 days and macOS after 3,
so a long-running server loses its socket, and RegisterLocalGrpcSocket
keeps routing local dials to the missing path: the master can no longer
reach its volume server.
Add -grpc.localSocketDir to both commands, defaulting to /tmp so an
existing setup is unchanged, and build every socket path from it with
filepath.Join. A folder that does not exist or is not a directory is
refused at startup rather than at the first local RPC. A folder whose
socket paths exceed the platform's sockaddr_un limit is refused too,
because every bind then fails with EINVAL while the server keeps running
and each local RPC dials a socket that does not exist.
Refs #12692
* server: refuse a -grpc.localSocketDir the server cannot bind in
An existing folder the server's user cannot write to passed the startup
check, and then every socket bind failed: ListenOnLocalSocket only logs
the error while GrpcDial keeps routing local dials to a socket that was
never created. After the path-length check, create and remove a probe
Unix socket in the folder, and refuse startup with the bind error if
that fails.
* server: give the -grpc.localSocketDir probe a random name
A probe named only by the process id could be precreated by another
user in a shared /tmp, or left by a crashed process whose pid was
reused, and the server cannot remove such a file, so startup failed
although the real socket paths were free. Name the probe with 8 random
bytes, retry a name that is taken, and rely on the listener's close to
unlink it.
* server: keep the -grpc.localSocketDir probe name within the service socket lengths
The probe was 5 bytes longer than the master and volume socket names, so a
folder whose service sockets fit the sockaddr_un limit could still be refused.
A 23-byte probe name is shorter than any service socket name, and a process
with no local sockets skips the check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* server: trim the -grpc.localSocketDir comments and drop issue references
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Brent Pease <179639673+brentDSL@users.noreply.github.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* webhook: share the default target settings
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* webhook: managed webhook targets with a drainable queue
Targets kept as JSON (name, endpoint, token, filters, retry and worker
settings) build their own queue; Close waits for queued and in-flight
deliveries before stopping it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: run webhook targets stored in /etc/seaweedfs when notification.webhook.managed is set
The targets in /etc/seaweedfs/notification_webhooks.json start with the
filer and are rebuilt from the store whenever the file changes on any
filer, alongside notification.toml. The previous queue drains before it
stops. Events for the file itself, which holds bearer tokens, are not
sent to notification queues.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: manage filer webhook targets
A Webhooks page under Management lists, adds, edits and deletes the
targets kept in /etc/seaweedfs/notification_webhooks.json. Bearer
tokens are write-only: the API reports whether one is set, and an empty
token on edit keeps the stored one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep the webhook queue when the stored targets did not change
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep a replaced webhook queue open until its senders hand over
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: read chunk-backed webhook targets before editing them
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* shell: keep the stored webhook targets out of fs.meta.notify
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* webhook: reject negative managed target settings
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* webhook: no signal handler on queues that reloads replace
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: swap the webhook queue without waiting behind blocked senders
The read lock held across SendMessage made a reload wait for any sender
blocked on a saturated target, and the waiting writer stalled every
other filer write with it, which is when an operator disables that
target. Close now refuses new sends and waits for the senders already
inside SendMessage, and a send that hits the closing queue retries on
its replacement.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* webhook: release blocked test handlers before the server shuts down
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: always run the webhook targets managed in the admin UI
Drop the notification.webhook.managed switch: every filer loads and live
reloads the stored targets. Without stored targets no queue is created.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* scaffold: place the admin-managed webhook note above enabled
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* scaffold: separate the admin-managed webhook note
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* scaffold: note that admin-managed webhooks follow the notification queue
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: retry loading webhook targets after a failed read
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: retire the admin-managed webhook queue on shutdown
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* ci: run the Python 3.9 jobs on 3.10
ubuntu-latest now resolves to Ubuntu 26.04, which has no Python 3.9 build
for actions/setup-python, so the Ceph S3 tests and the PyArrow Parquet
3.9 job fail during setup. 3.10 is the oldest version built for 26.04.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: list the Python versions the parquet CI runs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* admin: apply the saved theme inline at the top of the page head
The theme script was an external file, so a reload had to fetch or
revalidate it before the root got its theme, and the page could paint
with the light default in the meantime.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: set color-scheme on the root together with the theme
Until the stylesheets load, the browser paints the page canvas from the
root's color-scheme, which only the stylesheets set, so a dark theme
showed a white canvas for the duration of every reload.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* ec: mount shards against the index .vif when the local one has no EC config
A worker encode can send shards to a disk that still holds the source
volume's .vif while the encode's .vif lands with the index on a sibling
disk. The shard disk mounted through the source's config-free .vif, so
it reported encode time 0 and fell back to the sidecar layout, and reads
carrying the encode time were rejected as a different encode run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): mount shards against the index .vif when the local one has no EC config
Mirrors the Go mount: a data-dir .vif that records no EC config yields
to the idx dir's when that one records it, and load_vif_info_across_dirs
reports the directory the .vif actually came from.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: do not mirror EC sidecars onto a disk whose .vif has no EC config
Startup mirroring copied .ecx/.ecj next to a source volume's leftover
config-free .vif and kept that .vif, so after a restart the shard disk
mounted self-contained with encode time 0. Leave such a disk on the
cross-disk mount, which reads the owner's .vif.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): do not mirror EC sidecars onto a disk whose .vif has no EC config
Mirrors the Go startup mirror: a shard disk holding a source volume's
config-free .vif stays on the cross-disk mount, which reads the owner's
.vif, instead of mounting self-contained with encode time 0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ec: take the encode .vif from a sibling data dir when the index dir is shared
With a separate -dir.idx the .ecx is shared by every disk, but the encode's
.vif lands in the data dir of the disk that received it. A disk still holding
a source volume's config-free .vif mounted through it at generation 0.
NewEcVolume now accepts the server's data dirs and takes a sibling's EC .vif
when the index is not local and every sibling EC .vif names the same run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: give EC mounts the data dir of every disk on the server
NewStore records every data dir on each DiskLocation before loading, so the
startup scan, cross-disk reconcile and MountEcShards all pass them to
NewEcVolume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): take the encode .vif from a sibling data dir when the index dir is shared
Mirrors the Go mount: EcVolume::new_with_vif_dirs takes a sibling's EC .vif
when this disk's own records no EC config, the index is not local, and every
sibling EC .vif names the same run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): give EC mounts the data dir of every disk on the server
main sets Store.store_dirs before the first add_location, so a disk loaded
before its siblings still sees them; each DiskLocation passes them to
EcVolume::new_with_vif_dirs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: size startup EC validation by the sibling encode .vif
With a shared -dir.idx, a disk that still holds the source .dat and its
config-free .vif read the default data-shard count, judged custom-ratio
shards an interrupted encode, and removed them along with the shared .ecx
before the mount could take the sibling's .vif. The startup lookup now
falls back to the same sibling .vif the mount uses.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): size startup EC validation by the sibling encode .vif
Mirrors the Go change: validate_ec_volume falls back to the sibling data
dir's encode .vif before judging shards beside a source .dat.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: keep EC shards when sibling .vif files disagree on the encode
SiblingEcConfigVif reports when a sibling .vif cannot be read or the
siblings name different encode runs. The startup data-shard lookup then
returns 0 instead of the default ratio, and validateEcVolume keeps the
files rather than sizing custom-ratio shards by a ratio they do not use.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): keep EC shards when sibling .vif files disagree on the encode
Mirrors the Go change: sibling_ec_config_vif returns Err for an unreadable
sibling .vif or disagreeing runs, ec_data_shards_from_vif returns 0 then,
and validate_ec_volume keeps the files.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* storage: release the opened EC shard when its volume cannot be built
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* volume: keep reads over the download limit local when readMode is local
With -readMode=local the server never sends a read for a volume it does
not hold elsewhere, but a read over -concurrentDownloadLimitMB on a
replicated volume was still redirected to another replica. Skip the
replica fallback in local mode, so the read waits for a download slot
and answers 429 when the wait times out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): keep reads over the download limit local when readMode is local
Mirror the Go volume server: with readMode local, a read over the
download limit waits for a slot instead of being redirected to a
replica. proxy_or_redirect_to_target no longer needs the local-mode
redirect switch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume: check download capacity under the wait lock
waitForDownloadSlot read the in-flight size outside the cond lock and
the read handler broadcast without it, so a download finishing between
the check and the wait was missed and the read waited out the timeout
for a 429. Check capacity with util.WaitUntil under the lock and
broadcast under it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* volume(rs): register for the download notification before checking capacity
The wait loop created its Notified future only after the capacity
check, so a body dropped in between had its notify_waiters() lost and
the read waited out the deadline for a 429. Create the future first,
then check, as Go now checks under the cond lock.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* admin: fix cluster submenu toggle
* admin: update embedded JavaScript
* admin: drop the object store submenu handlers
The sidebar no longer renders an object store submenu, so its expand,
link and toggle handlers match nothing; the toggle handler repeated the
manual collapse that fought Bootstrap on the cluster submenu.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: ivan <i.stepanov@navigine.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
sudo switches its real uid to root while it starts, so kill -0 from the
invoking user fails with EPERM even though the mount process is alive,
and the wait loop reported "weed mount exited early" a few milliseconds
after starting it.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* filer: serve caught-up aggregated subscribers from memory, not a held disk pass
An aggregated SubscribeMetadata stream that does not take metadata chunks
(filer.sync, filer.backup, filer.meta.backup, filer.meta.tail, the
filer.remote.* syncs, the S3 gateway's subscriptions, and mounts that
predate chunk support) re-ran the persisted-log pass whenever its cursor
moved: after every memory hold at the delivery watermark and on every
2 s re-probe. The pass holds at the peers' flush low-watermark. Peers
flush on their own one-minute schedules, so on a cluster that keeps
writing some peer has always flushed past a caught-up cursor while the
slowest has not: the pass held at its first entry, the loop came back
to it, and memory was never read. The stream got each change only once
the slowest peer's flush covered it, in bursts up to a flush interval
late, and every pass listed and re-read the newest log files.
When the aggregated ring was already filling at the cursor and evicted
nothing after it, memory holds everything the persisted logs could add,
since every peer's log reaches the ring through the aggregator. Skip the
pass and read memory, held at the delivery watermark as before. The
skipped pass proves nothing past the cursor, and the next-day scan for
an empty pass does not apply. An empty ring, a ring that starts past the
cursor, and a cursor memory just refused still take the pass. Chunk
subscribers already skip it for a caught-up cursor: their ref listing
stops below the flush hold.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: keep a new peer's pre-start history on the disk pass
The ring only receives a peer's events from the start of its subscription.
A peer followed for the first time after this filer started (a filer added
to the cluster, a restarted pod with a new address, or the late-arriving
peers bootstrap) starts at its notice time, so what it logged before then
is only in the persisted logs. A cursor below that start passed the ring
check and skipped the disk pass, losing those events for subscribers that
do not take metadata chunks.
Record the newest start of a peer subscription that had no resume point and
send cursors below it through the disk pass as before. Peers that rejoin with
a resume point (a restart under the same address) do not move it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
* helm: pin the 4.53 tag in the vector metrics rejection test
The 4.54 release made 4.54 the chart's default image, and that image
serves weed-vector metrics, so rendering vector.metricsPort with the
default tag no longer fails. Pin image.tag=4.53 for the rejection case
and check that the default image renders the metrics port.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* helm: describe vector metrics support from 4.54 on in the chart README
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* helm: say the vector metrics render guard skips image overrides
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* helm: drop the 4.53 vector metrics render guard
The chart now defaults to 4.54, whose weed-vector serves --metrics-port, so
the check keyed on one old tag only blocked valid installs. The test asserts
the default image renders the metrics flag and HTTP probes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* helm: describe vector metrics without the render guard in the chart README
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* log_buffer: let a subscriber skip wake-ups for unwanted partition keys
Every append woke every registered subscriber. SetSubscriberWakeFilter lets
a reader sleep through appends whose partition key it would filter out; it
still reads them on its next poll. Flushes and keyless appends wake everyone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer_pb: decide subscription matches from an event's directories
MetadataDirectoryMayMatchSubscription rules out events whose directory no
child path of can match the subscription, and ScanMetadataEventDirectories
reads an event's directory and new parent path without allocating.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: wake subscribers of a move's destination directory
Appends are keyed by the source directory, so a filtered subscriber of the
destination would otherwise only see the move on its next poll.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: wake metadata subscribers only for directories they can match
Every metadata event woke and was scanned by every subscriber, so filer CPU
grew with the number of subscribers watching other paths. Readers now
register a directory wake filter, and the per-entry prefilter rules entries
out from their directories before the skeleton scan.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* filer: test that moves into a subscribed prefix pass the prefilter
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* docs: explain the 3-filer recommendation in the production setup notes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs: note that a filer load balancer must forward the gRPC port
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: create a multipart upload's directory on the object's owner filer
CreateMultipartUpload wrote .uploads/<id> to the gateway's own filer while
the upload's completion commits on the object's write owner. With
independent filer stores, a part or completion reaching another gateway
before peer metadata replication caught up could not see the upload.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: look up a multipart upload on the object's owner filer
UploadPart, UploadPartCopy, ListParts, CompleteMultipartUpload,
AbortMultipartUpload and the bucket policy SSE lookup read .uploads/<id>
from the gateway's own filer, so a request on another gateway shortly
after CreateMultipartUpload answered NoSuchUpload until replication
caught up. Read it preferring the object's write owner, like object reads.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: write multipart parts to the upload's owner filer
UploadPart and UploadPartCopy stored part entries on the gateway's own
filer, so ListParts and CompleteMultipartUpload on another gateway could
miss a part that replication had not delivered yet. Store them next to the
upload directory on the object's write owner.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: list and clean up a multipart upload on its owner filer
ListParts, CompleteMultipartUpload and AbortMultipartUpload listed and
removed part entries on the gateway's own filer. Do it where the upload
and its parts now live, so completion sees every part and cleanup does
not miss entries replication has not delivered yet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: test a multipart upload against a lagging gateway filer
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: check the upload's owner before freeing a failed part's chunks
A part write that the owner stored but answered with an error went to
recovery with no object, so the owner was never among the filers checked.
When the owner is outside the gateway's filer list, the others' not-found
answers freed chunks the stored part still references.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: list an upload's parts on the prior owner after a ring change
The upload record lookup already falls back to the key's prior owner while
a ring change is in its cooling-off window, but the part listing read only
the new owner. ListParts then reported no parts for an open upload. Fall
back the same way when the new owner has nothing yet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: find the upload record on the prior owner past a bare directory
A part routed to a new owner that has not received the upload yet makes
that filer create .uploads/<id> without the upload's key. The post-write
check then read it as an aborted upload and removed the part. While the
ring change is in its cooling-off window, a record on the prior owner
now wins over such a directory.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: merge the prior owner's parts into an upload listing
During a ring change's cooling-off window the new owner may have received
only some of an upload's parts. Listing returned the new owner's parts
alone once it had any, so ListParts dropped the rest and a completion
naming them failed with InvalidPart. Both owners' pages are now merged,
the owner's entry winning a shared name, and cut to the page limit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: fail an upload listing the prior owner could not answer
When the new owner has none of an upload's parts yet and the prior
owner's listing fails, the parts may all be on the prior owner. That
listing read as empty, so CompleteMultipartUpload answered NoSuchUpload
for an upload that still exists; it now returns the error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: fail an upload lookup the prior owner could not answer
During a ring change's cooling-off window an upload the new owner has
not received yet, or holds only as a bare directory, read as NoSuchUpload
when the prior owner's lookup failed. That failure is now returned, so
the client sees a retryable error instead of an upload that is gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* admin: support [maintenance.s3_lifecycle] in admin.toml
The admin.toml overlay covers vacuum, volume_balance and erasure_coding but
not s3_lifecycle, so the bucket lifecycle job's settings can only be changed
from the web UI and are lost whenever the admin data directory does not
persist. That is the worst combination for this job type: its
meta_log_retention_days knob decides whether bucket rules ever apply to
objects written before the job was enabled, and silently reverting it to the
default makes the rules no-op without any error.
Wire the four admin-side knobs into the existing overlay:
meta_log_retention_days retention window the meta-log replay can reach
walker_interval_minutes minimum gap between full bucket walks
cluster_deletes_per_second cluster-wide delete budget
cluster_deletes_burst token-bucket burst for that budget
All four are admin config values, not worker values: the engine partition is
computed on the admin side and the delete budget is divided across
execute-capable workers at dispatch time. enabled/retry_limit/
retry_backoff_seconds come for free from the shared section handling.
Tested with TestApplyPluginConfigFromTomlS3Lifecycle, which also pins the
retention=0 case: 0 means unbounded and must survive as an explicit 0 rather
than being treated as unset.
* admin: fix meta_log_retention_days guidance in admin.toml scaffold
Both reviewers caught a real error. `0` is not "unbounded": runShard does
retentionWindow := cfg.RetentionWindow
if retentionWindow <= 0 {
retentionWindow = maxTTL
}
so zero falls back to the longest rule TTL, which keeps every replay rule in
replay and promotes nothing to the walk set. Recommending 0 to force full
scans was wrong, and so was the claim that pre-existing objects are only
reachable through the walk set -- the cold-start recovery walk covers them
regardless of the retention value.
Describe zero as "no retention info supplied" and tell operators to set the
window the filer meta-log actually retains. The code change is unaffected:
it only wires the four keys into the existing overlay.
* admin: tie s3_lifecycle walk-set scans to walker_interval_minutes in admin.toml
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: show the s3_lifecycle retry defaults in admin.toml
The s3_lifecycle descriptor sets no retry limit or backoff, so a failed
run is not retried and the scheduler's 5 s backoff applies; the scaffold
listed the vacuum values instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: shorten the s3_lifecycle toml section comment
The retention and walker knobs are read by the worker from the admin
values, not computed on the admin side.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: cover cluster_deletes_burst in the s3_lifecycle toml test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* admin: check the s3_lifecycle retention zero is a stored int64
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3 test: evaluate mutation conditions and serve DeleteEntry in the fake filer
The fake ObjectTransaction now checks each mutation's own condition before
applying it, as the filer does, and reports the failed mutation. ETag clauses
read the stored ETag attribute first, like the filer. DeleteEntry removes the
entry so unrouted delete paths can run against the fake.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: write the suspended expiration marker before deleting the null version
A suspended-versioning expiration deleted the null version first and then
wrote the delete marker. When the pointer read or the marker write failed in
between, the retry found no null version, resolved as NOT_FOUND or
VERSION_NOT_LATEST, and never wrote the marker, so an older version became
the latest.
The marker now goes first. The latest pointer outranks the null object, so
the key reads as deleted once the marker lands, and a null delete that fails
after it leaves a noncurrent null version rather than exposing an older one.
The null delete is pinned to the entry read before the marker: on the owner
it carries IF_ENTRY_EQUAL on that read, and off the ring the entry is re-read
and compared by identity first. A null object written after the read is a
newer write and is no longer deleted. When the null version is the one that
passed the expiration checks, a missing or changed entry at that read
resolves the request as STALE_IDENTITY before anything is written.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: retry a failed routed null delete instead of deleting on the default filer
A routed null delete that failed fell through to the unrouted path, which
reads and deletes on the default filer. That filer may not have the owner's
newer null object yet, so the fallback could delete it without the owner-side
IF_ENTRY_EQUAL guard. The failure now returns RETRY_LATER; the marker is
already written, so the key keeps reading as deleted.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: recheck and delete an unrouted null version under the object write lock
Without a ring owner the identity recheck and the null delete were separate
calls, so a suspended PUT landing between them was deleted. Off the ring
writers take the object write lock, so the recheck and the delete now run
under it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 test: strip quotes from the stored ETag in the fake filer
The filer normalizes both sides of an ETag comparison; the fake now strips
quotes from the stored ETag attribute as well as from the candidate.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: retry the null delete when the object lock lookup fails on a routed key
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: check the suspended marker against the validated version
A suspended expiration that validated a named version wrote its marker
without comparing the pointer, so a null PUT landing after the checks was
hidden, and deleted too when it landed before the null read. The marker now
compares the latest the way the enabled path does and resolves the request
as VERSION_NOT_LATEST.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 test: count the marker's object write lock in the unrouted null delete
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: recheck the attempt deadline after reading the null version
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3: accept the governance bypass header case-insensitively
botocore and the AWS CLI send x-amz-bypass-governance-retention: True,
so the exact "true" match ignored the bypass and governance-locked
deletes and retention changes failed with AccessDenied.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: test governance bypass with SDK-style header values
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: normalize a nil policy value to no values
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: evaluate each policy condition against its own values
The process-wide normalized value cache keyed entries by fmt.Sprint of the
value, so ["a", "b"] and ["a b"] (or [] and [""]) shared one entry and a
condition in one policy could be compared against another policy's values.
Normalizing is cheaper than building that key, so drop the cache.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3api: test that look-alike condition values stay distinct
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: bound each LifecycleDelete attempt with its own deadline
Replay and walker deletes used the job context with no request
deadline, so one stalled unary RPC could hold a shard for the whole
job. Each attempt now runs under DeleteTimeout (default 1m), set after
the limiter wait. A timeout while the job is still live is retried like
a transport error and then halts the shard or walk without advancing;
parent cancellation still stops both the attempt and the backoff.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: admin setting for the delete RPC timeout
Adds delete_timeout_seconds to the S3 Lifecycle admin form and passes
it to both the replay drain and the walker. 0 keeps the 60s default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: describe replay and walker timeouts separately in the help text
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: fail the pass when a replay delete exhausts its attempts
A transport error or attempt timeout that outlived the retries halted
the shard with a nil error, so the job reported success. processMatches
now returns the error (the cursor still holds at the event), and
runShard treats a drain error as a clean stop only when its own context
ended, since an attempt timeout also wraps DeadlineExceeded.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: test that a replayed LifecycleDelete resolves after a lost reply
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: skip the expiration write once the attempt deadline passed
A worker retries a LifecycleDelete whose attempt timed out, while the
first attempt can still be running on the S3 server. An attempt that
stalled before its marker write would then stack a second delete marker
after the retry wrote one. The gRPC deadline reaches the handler context,
so check it right before the expiration writes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: recheck the attempt deadline after the suspended null delete
The null-version delete can block on the owner filer past the attempt
deadline; the worker may have retried and written a marker by then.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: finish the suspended marker once the null version is deleted
Skipping the marker after a successful null delete left an older version
as the latest, and the retry then resolved as a no-op without hiding it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3: let a routed delete marker commit only while its latest guard holds
createDeleteMarkerIf passes an optional condition, evaluated on the
.versions directory entry under the object's lock on the owner filer,
and reports a refused commit as errLatestVersionChanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: write the expiration marker as a compare-and-set on the latest pointer
A timed-out attempt can still be running on the S3 server while the
worker's retry writes the marker. The marker commit is now conditioned
on the .versions pointer as read just before it and skipped when the
latest is already a delete marker, so whichever attempt commits second
writes nothing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: resolve the marker as stale when another version became latest
The marker's compare-and-set only covered changes after its own pointer
read, so a version promoted after the expiration checks passed could be
hidden by the marker. The enabled path now passes the validated version
and a conflict retry that finds a different named latest resolves the
request as VERSION_NOT_LATEST.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: resolve a null expiration as stale once a version takes the pointer
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: read the marker's latest version the way getLatestObjectVersion does
A pointer names a version only with its file name; an id alone falls back
to the null object, and the null-is-latest signal makes the null version
current. An expiration that validated a named version no longer hides a
null written by a suspended PUT, and a current null under an id-only pointer
now expires instead of resolving as stale.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: hold the object write lock for an unrouted expiration marker
Off the ring createDeleteMarkerIf cannot carry the pointer guard, so a PUT
committing between the pointer read and the marker write was hidden. The
read and the write now run under the object write lock that unrouted
writers take.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: share transient-error retries between walker and replay deletes (#12649)
* s3 lifecycle: retry only transient LifecycleDelete failures
dispatchWithRetry retried every RPC error except parent cancellation, so
an authentication, permission or argument error spent the whole retry
budget before surfacing. Retry only attempt timeouts and the failures
util.IsTransientError recognizes (Unavailable, ResourceExhausted, network
resets); everything else returns on the first attempt. A nil response
is now an error instead of a nil dereference.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: take a delete-rate token for every LifecycleDelete attempt
processMatches waited on the shared limiter once per match, so the
retries behind it ran outside the cluster-wide deletes/sec budget. The
retry loop now waits on the limiter before each attempt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: give walker deletes the replay retry policy
WalkerDispatcher sent each LifecycleDelete once, so one dropped
connection aborted the bucket's daily walk while the same failure on the
replay path was retried. The walker now goes through deleteWithRetry and
shares its transient-error retries, per-attempt limiter wait and nil
response handling.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: retry a DeadlineExceeded the server sends back
A server or proxy can end the RPC with DeadlineExceeded while the
attempt's own deadline is still running. util.IsTransientError rejects
that status, so the delete halted with retries left. It is a timed-out
attempt like the client-side one, so retry it the same way.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: say walker deletes get 3 attempts in the timeout help
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* security: refuse to start when per-target server allowlists are not applied
A component that dials every server with one option ignored
<target>_allowed_server_* keys, so a config that only set those
accepted any CA-signed server.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* scaffold: say which components scope server allowlists per target
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* security: also catch per-target server allowlists set through WEED_ env vars
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* security: optionally check the dialed host against gRPC server certificates
verify_server_host under [grpc] or a [grpc.<component>] section switches
the client to certificate-and-host verification.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* scaffold: document verify_server_host
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: add a LifecycleDelete client that fails over between S3 fronts
When the current front returns Unavailable, the client closes it, marks it
failed for the rest of the pass, picks the next front that passes
checkLifecycleReady and resends the same request there. Callers cut off by
that switch closing their connection resend on the new front. When no front
is left, every later call returns one error naming the fronts tried.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: serve the pass through the failover client
Execute hands the replay drain and the walker one failover client built on
the selected front, reports each switch as job progress, and closes the
current connection when the pass ends.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: keep failing over until a front serves the resent delete
The resend after a switch went straight to the new front, so a second
lost front ended the call even with a healthy third one, and the walker
has no retry of its own. Resend through the failover loop instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: do not recheck fronts skipped when the pass started
The failover client started with no failed fronts, so losing the selected
front checked the fronts selectS3Front had already skipped again, holding
every delete for another readiness timeout per front.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: walk checkpoints take each entry's resume position
Versions of one object share a Path, so a checkpoint set from Path after
the first version made a resume skip the rest. The ListFunc now gives
each entry the start value that continues after it, and leaves it empty
on all but an object's last version.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: resume a bucket listing where the walk stopped
The filer listing skipped entries with key <= start, but its order is
not key order: each directory emits its .versions groups before its
files, and a directory's children come before a sibling like dir.txt.
Positions are now one (pass, name) frame per directory level, so a
resume seeds each listing and skips exactly what was finished. A version
group is one unit, and a skipped group still keeps its bare null
version out of the second pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: content hash of a walk view
Hashes every non-disabled action of a view and the versioning of their
buckets, so a saved walk position can be tied to the walk it came from:
another rule set, another walk mode, or a bucket that turned versioned
gives another hash.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: persist daily walk progress and resume it
A walk that failed or was cut short started over on the next pass,
listing again every bucket it had already finished. WalkBuckets now
keeps the finished buckets and each unfinished bucket's position in a
checkpoint file next to the shard cursors, one per shard set, and the
next walk of the same view and shards resumes from it. The record is
saved every 30s and when the walk stops, and cleared when a walk
completes, so the next walk is full again and sees keys added behind
the position; a clear that fails fails the walk rather than leave a
record that would skip buckets.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: a stuck resumed walk starts over
A bucket that fails at the same place on every pass kept the walk from
completing, so the buckets it had finished were never walked again and
their due objects waited forever. A resumed walk that fails again
without finishing anything clears its checkpoint, and the next walk is
full. A canceled walk keeps it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: do not resume a walk checkpoint left for a week
A checkpoint is cleared only by a later walk of the same shard set, so a
set that stopped walking, such as a one-off per-shard walk, left its
record behind, and a walk of that set much later would skip buckets
finished long before. Records now carry their save time and are not
resumed after seven days; a walk that keeps retrying saves on every
attempt and stays fresh.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: a failed walk without progress leaves its checkpoint alone
A pass canceled while it read the checkpoint failed the read, then
saved its own empty progress over the record it never loaded, so the
next pass started every bucket again. A failed walk that finished
nothing has nothing new to record and no longer writes; the stuck
resume reset still clears.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: space out walk checkpoint saves after a failed one
The save time advanced only on success, so once the filer refused a
periodic save every following entry tried again and logged another
warning. The interval now counts from the last attempt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: a walk checkpoint save that errors may still be on disk
A save whose reply was lost left onDisk false, so a walk that then
completed skipped the clear and the next walk resumed from the stale
record instead of walking everything.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: keep a stalled walk checkpoint for a day
A resumed walk that failed again without progress dropped its record
right away, so an outage spanning two attempts restarted the whole
walk. Treat the walk as stuck only once its record has not advanced
for a day.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: a resumed walk counts its earlier buckets as walked
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: replay a resumed recovery walk from the walk that began it
A recovery or cold-start pass rewinds replay to runNow - maxTTL. When the
walk resumed a checkpoint, its finished buckets were listed in an earlier
attempt, so an object there that was not yet due then and whose write is
now older than maxTTL was neither expired by the walk nor replayed.
The checkpoint now keeps the start of the walk that began it, WalkBuckets
returns that time (its own start for a fresh walk), and runShard floors
the recovery rewind and the cold-start replay at it. A record without a
start is not resumed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: a cold start that resumed a walk replays on the next pass
The pass's shared subscription starts at runNow - maxTTL for a shard
without a cursor, before its walk reports an earlier start, so flooring
the cold-start drain at the walk start could not deliver the older
events. Such a shard now saves its cursor at the walk start minus maxTTL
and returns, like the recovery branch, and the next pass replays the
window from that cursor.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: test that a cursor below the floor opens the next subscription
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* s3 lifecycle: test the cold-start replay across two Run passes
A cold start whose walk resumed an earlier attempt sees an older event
only on the next pass. The test runs Run twice against a filer that
serves events past the requested floor, with a later in-window event
that would otherwise move the cursor past the older one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* mount: fail the write when the swap file chunk cannot be created
#7957 added a nil check after NewSwapFileChunk so a failed swap file
creation returns an error instead of panicking. The result was assigned
to pageChunk, a PageChunk interface, before the check, and an interface
holding a nil *SwapFileChunk is not nil, so the check never fired:
SaveDataAt stored the nil chunk and panicked in WriteDataAt.
Check the *SwapFileChunk before converting it. The new test points the
swap directory below a regular file; on master it panics in
SwapFileChunk.WriteDataAt.
Signed-off-by: anant <170962632+antcybersec@users.noreply.github.com>
* mount: grow the file only after its write is buffered
Write set the new size, times, pending append offset and uncommitted
bytes before AddPage. When AddPage failed (now that a swap file chunk
that cannot be created returns an error), the write was reported as
failed but the larger size stayed on the handle's entry, so the next
flush published it with a hole where the data should be.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: report a partly buffered write as a short write
PageWriter.AddPage fills one chunk at a time, so when a later chunk
cannot be created the earlier chunks already hold their bytes. Return
how much was buffered, and let Write grow the size and times over that
prefix and report it, instead of failing the whole write while the
prefix still reaches the next flush.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: report the bytes a failed copy_file_range already buffered
A streaming copy whose page fails partway returned an error even though
earlier pages, or the start of the failing one, were already buffered and
would reach the next flush with the destination size left short. Count
the buffered bytes, grow the destination over them, and return them as a
short copy.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: free the copy test's destination pages
The buffered memory chunk counts toward the process-wide memory chunk
ceiling, so repeated runs of the test pushed later ones onto the
unusable swap directory.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: count only the bytes a swap chunk stored
A swap chunk whose file write fails stores a prefix or nothing, but
SaveDataAt returned no error and AddPage counted the whole span as
buffered. SaveDataAt now reports the short write, and AddPage passes the
stored count up so a write is never acknowledged past it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* mount: fail a partly buffered writeback write
Kernel writeback ignores the count in a WRITE reply, so a short write
there drops the unbuffered rest without an error. A write flagged as
page-cache writeback now keeps its buffered prefix but returns the
error, which the kernel reports on fsync.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Signed-off-by: anant <170962632+antcybersec@users.noreply.github.com>
Co-authored-by: anant <170962632+antcybersec@users.noreply.github.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* install.sh: offer the vector engine on linux only
Releases build weed-vector for linux amd64/arm64 only, so --component vector
on darwin or windows downloaded a missing asset.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* install.sh: add --enterprise
Installs from seaweedfs/artifactory: weed-enterprise-<os>_<arch>[_large_disk],
weed-volume-enterprise[_large_disk], weed-worker-enterprise and
weed-vector-enterprise. The latest tag skips vfs-* releases, and the Rust
volume server is linux-only there, so --component all skips it elsewhere.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* Revert "install.sh: offer the vector engine on linux only"
Releases after 4.53 publish weed-vector for darwin and windows too
(rust-vector-platforms.yml).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* install.sh: Enterprise vector engine is linux-only
Enterprise releases publish weed-vector-enterprise for linux amd64/arm64;
open-source releases keep their darwin and windows engines.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* test: installer --enterprise asset names, platforms and latest tag
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* install.sh: Enterprise latest is the newest plain version tag
artifactory also releases previews and a dev build, and a prerelease such
as kvcache-filer-native-v0.1.0-preview.1 sits in the release list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* README: show passing --enterprise through bash -s --
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011UpvafvK8JpagF94MHWqwK
* install.sh: the open-source weed for windows is a .zip too
Releases publish windows_amd64[_large_disk].zip, so asking for a .tar.gz
404s on every Windows host.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* install.sh: install the windows weed as weed.exe
weed-volume and weed-vector keep their .exe on Windows; weed lost it, so
cmd and PowerShell could not run the installed binary.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* install.sh: suggest weed-volume only when it was installed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-14 13:50:18 -08:00
497 changed files with 41477 additions and 4168 deletions
With `rules` left empty the route sends all traffic to the component's own Service and port. A rule may set `matches`, `filters`, `timeouts` and `backendRefs`, and a rule without `backendRefs` still routes to that Service. In all-in-one mode the master, volume, filer and s3 routes target the all-in-one Service. When S3 runs only on the filer (`filer.s3.enabled` without `s3.enabled`), the s3 route uses `filer.s3.port`.
Outside all-in-one mode, the volume Ingress and the default volume route target the `client-volume` Service, which lists only Ready volume pods. The `volume` Service also publishes pods that are not Ready yet, so their DNS records can exist before readiness. An explicit `backendRefs` entry that names the `volume` Service can therefore reach a volume server before it is Ready. Name the `client-volume` Service instead, with `volume.port`, and copy its `metadata.name` from `helm template` because long release names are truncated.
## Network Policies
In a namespace with a default-deny policy the install hangs: the components cannot resolve each other, and the post-install bucket hook waits on the master and filer until it gives up. `networkPolicy.enabled` renders one `NetworkPolicy` per component, selecting its pods by the standard `app.kubernetes.io/{name,instance,component}` labels and admitting traffic from the other pods of the release on the ports that component listens on.
@@ -610,6 +612,17 @@ Two things worth knowing before you turn this on:
The DNS selectors default to CoreDNS as kubeadm, kind and the managed offerings from AWS, Google and Azure install it. On OpenShift, override `egress.dnsNamespaceSelector` and `egress.dnsPodSelector` to match `openshift-dns`; see the comment in `values.yaml`.
## Volume server HTTPS
With `global.seaweedfs.enableSecurity`, gRPC between components uses mutual TLS, but the volume servers' HTTP port, which carries the file data, stays plaintext. Set `global.seaweedfs.volumeHttps.enabled: true` to serve it over TLS:
- `[https.volume]` points at the volume certificate, which then also names every volume group's service (`*.<fullname>-volume.<namespace>`), since volume servers register as `<pod>.<fullname>-volume.<namespace>`. With `certificates.externalCertificates`, the provided `<fullname>-volume-cert` needs those names.
- `[https.client]` is enabled with the client certificate and the chart CA, so every chart pod that talks to the volume servers does it over HTTPS.
- The volume probes use HTTPS.
- Every pod that reads `security.toml` gets a `checksum/volume-https` annotation, so switching the option on or off restarts them together.
The volume servers do not require client certificates, because kubelet probes cannot present one; enable JWT signing (`securityConfig.jwtSigning`) to authorize volume reads and writes. `[https.client]` also sends the admin UI's HTTP lookups on masters and S3 over HTTPS, which their plain listeners refuse, so the UI can miss volume public URLs and refuse SSE-S3 vector buckets. A volume Ingress or HTTPRoute needs its controller's HTTPS-backend setting. `weed mount`, the CSI driver and other clients outside the chart need their own `[https.client]` with the chart CA. The option is not supported with `allInOne`, whose volume server registers by pod IP.
## Common labels
`commonLabels` adds labels to the metadata of every object the chart creates. It may be a map or a template string rendering to one. The chart's own labels cannot be overridden, and pods (see `podLabels`) and `volumeClaimTemplates` are left unchanged.
@@ -718,7 +731,7 @@ The bundled engine images support Linux amd64 and arm64. Use `vector.imageOverri
`global.seaweedfs.enableSecurity` provisions and mounts the vector certificate and shared security configuration. With external certificates, provide the `<fullname>-vector-cert` secret (`my-seaweedfs-vector-cert` for release `my`). `fullname` follows `seaweedfs.fullname`, including `fullnameOverride`, `nameOverride`, and DNS-name truncation. Provide this secret alongside the existing CA and client secrets.
The default `vector.metricsPort: 0` and TCP probes support existing engine images. The default 4.53 image does not accept metrics flags; enabling metrics with it is rejected at render time. For engine builds with `/metrics`, `/health`, and `/ready`, set `vector.imageOverride` to that compatible image and `vector.metricsPort: 9329`; readiness then checks master registration. Enabling `global.seaweedfs.monitoring.enabled` also creates the vector ServiceMonitor. NetworkPolicy includes the configured gRPC and metrics ports.
The default `vector.metricsPort: 0` keeps TCP probes. Set `vector.metricsPort: 9329` to serve `/metrics`, `/health`, and `/ready` from the engine; readiness then checks master registration. Images older than 4.54 do not accept the metrics flag, so leave metrics off when pinning `image.tag` or `vector.imageOverride` to one. Enabling `global.seaweedfs.monitoring.enabled` also creates the vector ServiceMonitor. NetworkPolicy includes the configured gRPC and metrics ports.
To provision vector buckets during installation and upgrades, set:
{{- fail "global.seaweedfs.volumeHttps is not supported with allInOne: its volume server registers by pod IP, which the volume certificate cannot name" }}
{{- $preStopSeconds := .Values.s3.preStopSeconds | int }}
{{- $minGracePeriod := add $preStopSeconds 15 }}
{{- if and (gt $preStopSeconds 0) (lt (.Values.s3.terminationGracePeriodSeconds | int) $minGracePeriod) }}
{{- fail (printf "s3.terminationGracePeriodSeconds (%v) must be at least %d: the gateway keeps serving for s3.preStopSeconds (%d) after SIGTERM, then gives in-flight requests up to 15s to finish; add the time any s3.lifecycle.preStop hook takes" .Values.s3.terminationGracePeriodSeconds $minGracePeriod $preStopSeconds) -}}
{{- end }}
apiVersion:apps/v1
kind:Deployment
metadata:
@@ -49,6 +54,7 @@ spec:
{{- end }}
annotations:
{{- toYaml $podAnnotations | nindent 8 }}
{{- with include "seaweedfs.volumeHttpsAnnotation" $ }}{{ . | nindent 8 }}{{ end }}
{{- if and .Values.vector.metricsPort (not .Values.vector.imageOverride) (eq (toString (.Values.image.tag | default .Chart.AppVersion)) "4.53") }}
{{- fail "vector.metricsPort requires vector.imageOverride selecting an engine with metrics support; the default 4.53 image does not support metrics" }}
{{- end }}
apiVersion:apps/v1
kind:Deployment
metadata:
@@ -28,6 +25,7 @@ spec:
annotations:
{{- with .Values.podAnnotations }}{{ toYaml . | nindent 8 }}{{ end }}
{{- with .Values.vector.podAnnotations }}{{ toYaml . | nindent 8 }}{{ end }}
{{- with include "seaweedfs.volumeHttpsAnnotation" $ }}{{ . | nindent 8 }}{{ end }}
spec:
{{- include "seaweedfs.imagePullSecrets" . | nindent 6 }}
{{- if and $volume.enabled (eq (include "seaweedfs.componentName" (list $ $volumeName)) $name) }}
{{- fail (printf "The volume Ingress/HTTPRoute Service %q has the same name as the %s Service after truncation. Shorten fullnameOverride or the release name." $name $volumeName) }}
@@ -45,6 +45,8 @@ Rule of thumb: start with 3 masters, then grow volume servers with data.
- Metadata store options: PostgreSQL, MySQL, Redis, Cassandra, TiKV, etc.
- Run **3 filers** for HA
- Filers are stateless relative to each other — state lives in the DB
- No quorum among filers: 2 already survive one failure; the third keeps a spare while one is down for upgrades
- Give clients every filer address (e.g. `-filer=f1:8888,f2:8888,f3:8888`) or a load balancer that forwards both the HTTP and gRPC ports (8888 and 18888)
**S3 Servers**
@@ -77,7 +79,7 @@ Keeps housekeeping off the hot path.
"description":"Disks holding more than one writable volume of a collection, and the most writable volumes of a collection on one disk.",
"type":"timeseries",
"id":262,
"gridPos":{
"h":8,
"w":12,
"x":12,
"y":69
},
"fieldConfig":{
"defaults":{
"color":{
"mode":"palette-classic"
},
"custom":{
"axisBorderShow":false,
"axisCenteredZero":false,
"axisColorMode":"text",
"axisLabel":"",
"axisPlacement":"auto",
"barAlignment":0,
"drawStyle":"line",
"fillOpacity":10,
"gradientMode":"none",
"hideFrom":{
"legend":false,
"tooltip":false,
"viz":false
},
"insertNulls":false,
"lineInterpolation":"linear",
"lineWidth":1,
"pointSize":4,
"scaleDistribution":{
"type":"linear"
},
"showPoints":"never",
"spanNulls":false,
"stacking":{
"group":"A",
"mode":"none"
},
"thresholdsStyle":{
"mode":"off"
}
},
"mappings":[],
"unit":"short",
"thresholds":{
"mode":"absolute",
"steps":[
{
"color":"green",
"value":null
}
]
}
},
"overrides":[]
},
"options":{
"legend":{
"calcs":[
"lastNotNull",
"max"
],
"displayMode":"table",
"placement":"bottom",
"showLegend":true
},
"tooltip":{
"mode":"multi",
"sort":"desc"
}
},
"targets":[
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"count by (collection) (sum by (cluster, collection, data_center, rack, node, disk_id) (SeaweedFS_master_writable_volumes_per_disk{cluster=~\"$cluster\", state=\"writable\"}) > 1)",
"range":true,
"refId":"A",
"legendFormat":"{{collection}} disks with 2+"
},
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"max by (collection) (sum by (cluster, collection, data_center, rack, node, disk_id) (SeaweedFS_master_writable_volumes_per_disk{cluster=~\"$cluster\", state=\"writable\"}))",
"range":true,
"refId":"B",
"legendFormat":"{{collection}} max on one disk"
}
],
"pluginVersion":"10.3.1"
}
]
},
@@ -3335,6 +3442,102 @@
],
"pluginVersion":"10.3.1"
},
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"title":"Vacuum Dropped Needles",
"description":"Live needles vacuum dropped because their data could not be read back intact (CRC mismatch, malformed or short record), counted since the volume server started. Any non-zero value means a lost replica copy; the volume server log has each dropped key.",
"type":"timeseries",
"id":267,
"gridPos":{
"h":8,
"w":8,
"x":16,
"y":54
},
"fieldConfig":{
"defaults":{
"color":{
"mode":"palette-classic"
},
"custom":{
"axisBorderShow":false,
"axisCenteredZero":false,
"axisColorMode":"text",
"axisLabel":"",
"axisPlacement":"auto",
"barAlignment":0,
"drawStyle":"line",
"fillOpacity":10,
"gradientMode":"none",
"hideFrom":{
"legend":false,
"tooltip":false,
"viz":false
},
"insertNulls":false,
"lineInterpolation":"linear",
"lineWidth":1,
"pointSize":4,
"scaleDistribution":{
"type":"linear"
},
"showPoints":"never",
"spanNulls":false,
"stacking":{
"group":"A",
"mode":"none"
},
"thresholdsStyle":{
"mode":"off"
}
},
"mappings":[],
"unit":"short",
"thresholds":{
"mode":"absolute",
"steps":[
{
"color":"green",
"value":null
}
]
}
},
"overrides":[]
},
"options":{
"legend":{
"calcs":[
"lastNotNull",
"max"
],
"displayMode":"table",
"placement":"bottom",
"showLegend":true
},
"tooltip":{
"mode":"multi",
"sort":"desc"
}
},
"targets":[
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"sum by (instance, collection) (SeaweedFS_volumeServer_vacuuming_dropped_needles{cluster=~\"$cluster\"})",
"range":true,
"refId":"A",
"legendFormat":"{{instance}} {{collection}}"
}
],
"pluginVersion":"10.3.1"
},
{
"datasource":{
"type":"prometheus",
@@ -6629,6 +6832,423 @@
],
"pluginVersion":"10.3.1"
},
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"title":"Metadata Subscribe Delivery Lag",
"description":"Seconds from a metadata event's mutation until the filer sends it to a subscriber, by stream scope",
"type":"timeseries",
"id":263,
"gridPos":{
"h":8,
"w":12,
"x":0,
"y":71
},
"fieldConfig":{
"defaults":{
"color":{
"mode":"palette-classic"
},
"custom":{
"axisBorderShow":false,
"axisCenteredZero":false,
"axisColorMode":"text",
"axisLabel":"",
"axisPlacement":"auto",
"barAlignment":0,
"drawStyle":"line",
"fillOpacity":10,
"gradientMode":"none",
"hideFrom":{
"legend":false,
"tooltip":false,
"viz":false
},
"insertNulls":false,
"lineInterpolation":"linear",
"lineWidth":1,
"pointSize":4,
"scaleDistribution":{
"type":"linear"
},
"showPoints":"never",
"spanNulls":false,
"stacking":{
"group":"A",
"mode":"none"
},
"thresholdsStyle":{
"mode":"off"
}
},
"mappings":[],
"unit":"s",
"thresholds":{
"mode":"absolute",
"steps":[
{
"color":"green",
"value":null
}
]
}
},
"overrides":[]
},
"options":{
"legend":{
"calcs":[
"lastNotNull",
"max"
],
"displayMode":"table",
"placement":"bottom",
"showLegend":true
},
"tooltip":{
"mode":"multi",
"sort":"desc"
}
},
"targets":[
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"histogram_quantile(0.99, sum by (le, scope) (rate(SeaweedFS_filer_subscribe_delivery_lag_seconds_bucket{cluster=~\"$cluster\"}[$__rate_interval])))",
"range":true,
"refId":"A",
"legendFormat":"p99 {{scope}}"
},
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"histogram_quantile(0.5, sum by (le, scope) (rate(SeaweedFS_filer_subscribe_delivery_lag_seconds_bucket{cluster=~\"$cluster\"}[$__rate_interval])))",
"range":true,
"refId":"B",
"legendFormat":"p50 {{scope}}"
}
],
"pluginVersion":"10.3.1"
},
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"title":"Metadata Watermark Hold Duration",
"description":"How long an aggregated read stayed held at one entry until the peers' watermark released it (memory: delivery watermark, disk: flush watermark)",
"type":"timeseries",
"id":264,
"gridPos":{
"h":8,
"w":12,
"x":12,
"y":71
},
"fieldConfig":{
"defaults":{
"color":{
"mode":"palette-classic"
},
"custom":{
"axisBorderShow":false,
"axisCenteredZero":false,
"axisColorMode":"text",
"axisLabel":"",
"axisPlacement":"auto",
"barAlignment":0,
"drawStyle":"line",
"fillOpacity":10,
"gradientMode":"none",
"hideFrom":{
"legend":false,
"tooltip":false,
"viz":false
},
"insertNulls":false,
"lineInterpolation":"linear",
"lineWidth":1,
"pointSize":4,
"scaleDistribution":{
"type":"linear"
},
"showPoints":"never",
"spanNulls":false,
"stacking":{
"group":"A",
"mode":"none"
},
"thresholdsStyle":{
"mode":"off"
}
},
"mappings":[],
"unit":"s",
"thresholds":{
"mode":"absolute",
"steps":[
{
"color":"green",
"value":null
}
]
}
},
"overrides":[]
},
"options":{
"legend":{
"calcs":[
"lastNotNull",
"max"
],
"displayMode":"table",
"placement":"bottom",
"showLegend":true
},
"tooltip":{
"mode":"multi",
"sort":"desc"
}
},
"targets":[
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"histogram_quantile(0.99, sum by (le, scope) (rate(SeaweedFS_filer_subscribe_hold_seconds_bucket{cluster=~\"$cluster\"}[$__rate_interval])))",
"range":true,
"refId":"A",
"legendFormat":"p99 {{scope}}"
},
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"histogram_quantile(0.5, sum by (le, scope) (rate(SeaweedFS_filer_subscribe_hold_seconds_bucket{cluster=~\"$cluster\"}[$__rate_interval])))",
"description":"Seconds the filer's delivery claim and the peers' delivery and flush low-watermarks trail the clock; -1 while a tracked peer has not signalled",
"type":"timeseries",
"id":265,
"gridPos":{
"h":8,
"w":12,
"x":0,
"y":79
},
"fieldConfig":{
"defaults":{
"color":{
"mode":"palette-classic"
},
"custom":{
"axisBorderShow":false,
"axisCenteredZero":false,
"axisColorMode":"text",
"axisLabel":"",
"axisPlacement":"auto",
"barAlignment":0,
"drawStyle":"line",
"fillOpacity":10,
"gradientMode":"none",
"hideFrom":{
"legend":false,
"tooltip":false,
"viz":false
},
"insertNulls":false,
"lineInterpolation":"linear",
"lineWidth":1,
"pointSize":4,
"scaleDistribution":{
"type":"linear"
},
"showPoints":"never",
"spanNulls":false,
"stacking":{
"group":"A",
"mode":"none"
},
"thresholdsStyle":{
"mode":"off"
}
},
"mappings":[],
"unit":"s",
"thresholds":{
"mode":"absolute",
"steps":[
{
"color":"green",
"value":null
}
]
}
},
"overrides":[]
},
"options":{
"legend":{
"calcs":[
"lastNotNull",
"max"
],
"displayMode":"table",
"placement":"bottom",
"showLegend":true
},
"tooltip":{
"mode":"multi",
"sort":"desc"
}
},
"targets":[
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"max by (instance) (SeaweedFS_filer_meta_delivery_claim_age_seconds{cluster=~\"$cluster\"})",
"range":true,
"refId":"A",
"legendFormat":"claim {{instance}}"
},
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"max by (instance, kind) (SeaweedFS_filer_meta_peer_low_watermark_age_seconds{cluster=~\"$cluster\"})",
"range":true,
"refId":"B",
"legendFormat":"peer low {{kind}} {{instance}}"
}
],
"pluginVersion":"10.3.1"
},
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"title":"Metadata Subscribers Resumed from Disk",
"description":"Times a metadata subscriber fell off the in-memory ring and resumed from the persisted log",
"type":"timeseries",
"id":266,
"gridPos":{
"h":8,
"w":12,
"x":12,
"y":79
},
"fieldConfig":{
"defaults":{
"color":{
"mode":"palette-classic"
},
"custom":{
"axisBorderShow":false,
"axisCenteredZero":false,
"axisColorMode":"text",
"axisLabel":"",
"axisPlacement":"auto",
"barAlignment":0,
"drawStyle":"line",
"fillOpacity":10,
"gradientMode":"none",
"hideFrom":{
"legend":false,
"tooltip":false,
"viz":false
},
"insertNulls":false,
"lineInterpolation":"linear",
"lineWidth":1,
"pointSize":4,
"scaleDistribution":{
"type":"linear"
},
"showPoints":"never",
"spanNulls":false,
"stacking":{
"group":"A",
"mode":"none"
},
"thresholdsStyle":{
"mode":"off"
}
},
"mappings":[],
"unit":"ops",
"thresholds":{
"mode":"absolute",
"steps":[
{
"color":"green",
"value":null
}
]
}
},
"overrides":[]
},
"options":{
"legend":{
"calcs":[
"lastNotNull",
"max"
],
"displayMode":"table",
"placement":"bottom",
"showLegend":true
},
"tooltip":{
"mode":"multi",
"sort":"desc"
}
},
"targets":[
{
"datasource":{
"type":"prometheus",
"uid":"${DS_PROMETHEUS}"
},
"editorMode":"code",
"expr":"sum by (instance, scope) (rate(SeaweedFS_filer_subscribe_resume_from_disk{cluster=~\"$cluster\"}[$__rate_interval]))",
r#"json_extract(`metadata`, '$["k"]') = '"v"' AND json_exists(`metadata`, '$["k"]') AND json_get_string(`metadata`, 'k') = 'v' AND json_array_contains(`metadata`, '$["k"]', '"v"') AND NOT json_array_contains(`metadata`, '$["k"]', key)"#,
"{} AND TRY_CAST(json_extract(`metadata`, '$[\"n\"]') AS DOUBLE) > 3 AND NOT json_exists(`metadata`, '$[\"a.b\\\"c\"]') AND COALESCE(json_extract(`metadata`, '$[\"f\"]') = 'true', false)",
"(COALESCE(json_extract(`metadata`, '$[\"author\"]') in ('\"alice\"', '\"bob\"', '\"x\"'), false) OR COALESCE(json_array_contains(`metadata`, '$[\"author\"]', '\"alice\"'), false) OR COALESCE(json_array_contains(`metadata`, '$[\"author\"]', '\"bob\"'), false) OR COALESCE(json_array_contains(`metadata`, '$[\"author\"]', '\"x\"'), false))",
Path::Ivf,
),
(
"{\"author\":{\"$in\":[\"alice\",7]}}",
"(COALESCE(json_extract(`metadata`, '$[\"author\"]') in ('\"alice\"'), false) OR COALESCE(TRY_CAST(json_extract(`metadata`, '$[\"author\"]') AS DOUBLE) in (7), false) OR COALESCE(json_array_contains(`metadata`, '$[\"author\"]', '\"alice\"'), false) OR COALESCE(json_array_contains(`metadata`, '$[\"author\"]', '7'), false))",
// Unpatched, every event from here on arrives 2 x LogFlushInterval late.
// The dead peer may hold reads for its unreachable bound plus the removal
// grace (2 x LogFlushInterval each); after that delivery must be prompt.
fori:=0;;i++{
name:=fmt.Sprintf("probe-%d",i)
createPeerEntry(t,filer1Address,name)
ifwaitArrival(name,10*time.Second){
t.Logf("%s delivered promptly %v after the peer died",name,time.Since(diedAt).Round(time.Second))
return
}
iftime.Since(diedAt)>6*time.Minute{
t.Fatalf("aggregated delivery still held %v after the peer died unnoticed",time.Since(diedAt).Round(time.Second))
}
}
}
Loaded 100 of 497 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.