Files
Warp/server/internal/roomserver/directory.go
T
tajniak81andClaude Opus 5 d187ad0d17
CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Phase 4: sync
Implements PLAN.md Phase 4: the read model. /sync, /messages and /context,
the filters that narrow them, and the streams a response carries that are
not room events — typing, receipts, presence and to-device messages. With
this a client can be used against Warp, which is milestone M1.

The one architectural choice is that the syncapi has no copy of the rooms:
it reads them through the roomserver. Dendrite gives its syncapi its own
tables and feeds them from the output stream, which is right for a design
where the two can be separate processes, and Dendrite's could be. Warp is
one process by decision, and there the copy buys nothing and costs the
hardest class of bug a homeserver has — a read model that disagrees with
the room, where a client is shown a message that was rejected and the only
way to find out is to compare two tables. So the roomserver grew a read
model (stream.go, roomsync.go, visibility.go) rather than exporting its
store: reading an event means parsing it under its room's version, and a
second copy of the version registry, the parser and the client projection
would be a second place for them to disagree.

syncapi: stream tokens naming a position in each of five independent
streams, so a client that has seen receipt 7 but only event 4 can say so in
one opaque string. A token with fewer positions than this build writes is
accepted and the rest read as zero, which is what lets a token stored
before a stream existed go on working. The PDU position comes from
MAX(stream_ordering) and not from the counter row the other four use: the
counter is advanced inside the writing transaction, so a token taken from
it would name a position whose event no reader can see yet, and the event
would be skipped for good once that transaction committed.

Long polling goes through a notifier that wakes by room and by user rather
than globally — an event wakes the listeners of its room, a membership
event also wakes the user it names, so an invite reaches a client that is
not in the room yet. A wake-up is only ever a hint: the listener re-reads
the streams and decides for itself what changed, which is what makes it
safe for the notifier to hold no state about what each client has seen. The
listener registers before the read, so an event landing in between leaves
the channel signalled and the sync reads again rather than blocking on a
change it just missed. EventPersisted must not block, because it is called
with the room's write lock still held.

"Something happened" is not "a token moved". A stream can move without this
user being concerned by it, and returning on every such move would turn a
long poll back into a busy loop. The same trap caught presence twice over:
a client says it is still online by syncing, so ?set_presence= makes every
sync a presence write, and a stream that moved each time would wake every
peer, which would sync, which would move it again. SetPresence therefore
reports whether anything a peer would notice actually changed, and a write
that only refreshes the last-active timestamp leaves the stream alone.

Timeline windows are named by their two ends and a direction, Low exclusive
and High inclusive in both directions, rather than by "from" and "to" as
the wire format spells them. Each of those would otherwise be the low bound
in one direction and the high bound in the other, which is exactly the
off-by-one every pagination bug is made of; the handlers translate once and
nothing below them thinks about it again. A sync's timeline is read
backwards and reported forwards, because a client wants the newest events
of the window it missed — a forward read with a limit hands it the oldest
and then calls the rest a gap.

visibility: history visibility is now a span rather than a yes or no, which
is what Phase 3 deferred here. A user who has left a room is served the
room as it was when they left — their state reads, their members and their
timeline — instead of being refused, and is bounded above at their own
membership event so a kicked client cannot go on streaming. Their span is
found from their own member events, so a user who joined, left and rejoined
sees their latest span. ?at= on /members is honoured for the same reason.
What is left is that the span is computed from the room's current
history_visibility where the spec judges each event by the one in force
when it was sent; that is a state read per event and belongs with open
question 1.

Typing is held in memory and nowhere else: notifications expire in seconds,
are worthless across a restart, and arrive one per keystroke-burst per
room, so persisting them would be the busiest table in the database holding
the least valuable data in it. Receipts only ever advance, compared on the
position of the event acknowledged rather than on arrival, because two of a
user's clients read at different speeds and the slower one must not drag
the marker backwards. To-device queues are per device and drained by the
next sync rather than by the one that delivered them, so a client that
crashes in between gets the batch again — the right way round, since a lost
key share leaves a message permanently undecryptable and a duplicate is
ignored. A wildcard addressee is expanded when sent, not stored, because
"every device" means the ones that existed then.

Presence is off by default, which answers PLAN.md open question 3. It is
the noisiest thing in Matrix and the one genuinely fan-out notification
here; a private homeserver gains little from it. With it off the endpoints
refuse rather than disappearing, because a client that gets a 404 from
/presence concludes the server is too old to have it and stops asking.

storage: one migration per driver adding the receipt, to-device, presence
and filter tables with a counter row each, and a stream position on the
existing account data table rather than a parallel one — there is exactly
one current value per (user, room, type), and a second table would be a
second thing to keep in step. Account data is reported in an event list but
is not an event, so it gets its own response type: a room event with an
empty sender and no timestamp would make a client decide what that meant.

Deliberately missing, each named in docs/sync.md: notification counts (they
need push rules, Phase 8), device lists (the keyserver, Phase 7), anything
remote (Phase 5), threads (Phase 10). device_lists is sent as two empty
lists because a client reads a missing one as malformed; the notification
counts are left out entirely, because a zero there is a claim and an absent
field is not.

Tested through HTTP rather than against the builder, because what is worth
pinning down is the response a client sees — which section a room lands in,
whether a token handed back can be handed in again, whether paging
terminates and loses nothing. The storage tests run against both SQL
drivers; the notifier has its own tests for the concurrent case. A live
server was driven end to end, which is what caught the two bugs the unit
tests had missed: a backwards /messages page must be in reverse
chronological order, and `start` must name where the page began rather than
position zero when ?from= was omitted.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-10-16 11:55:27 +02:00

392 lines
13 KiB
Go

package roomserver
import (
"context"
"fmt"
"strconv"
"strings"
"github.com/dariuszjaniak/warp/server/internal/matrix/event"
"github.com/dariuszjaniak/warp/server/internal/matrix/id"
"github.com/dariuszjaniak/warp/server/internal/storage"
)
// MaxAliasLength is the spec's cap on a room alias, sigil and server name
// included.
const MaxAliasLength = id.MaxLength
// aliasFor builds a full local alias from the localpart a client supplied,
// and checks it.
func (r *API) aliasFor(localpart string) (string, error) {
alias := "#" + localpart + ":" + r.serverName
if err := r.validateLocalAlias(alias); err != nil {
return "", err
}
return alias, nil
}
// validateLocalAlias checks an alias and insists it belongs to this server.
//
// The grammar is deliberately the loose one the spec gives for an alias —
// anything but a colon, and no control characters — rather than the
// localpart rules an account is held to. An alias is a label a room's
// members chose, and the spec puts no character restrictions on it beyond
// what parsing needs.
func (r *API) validateLocalAlias(alias string) error {
if err := validateAliasGrammar(alias); err != nil {
return err
}
_, serverName, _ := strings.Cut(alias[1:], ":")
if serverName != r.serverName {
return fmt.Errorf("%w: %s is not an alias of this server", ErrForbidden, alias)
}
return nil
}
// validateAliasGrammar checks an alias of any server.
func validateAliasGrammar(alias string) error {
switch {
case alias == "":
return fmt.Errorf("%w: a room alias must not be empty", ErrInvalidContent)
case alias[0] != '#':
return fmt.Errorf("%w: a room alias must start with '#'", ErrInvalidContent)
case len(alias) > MaxAliasLength:
return fmt.Errorf("%w: a room alias may be at most %d bytes", ErrInvalidContent, MaxAliasLength)
}
localpart, serverName, found := strings.Cut(alias[1:], ":")
switch {
case !found:
return fmt.Errorf("%w: %s has no server name; expected #alias:server", ErrInvalidContent, alias)
case localpart == "":
return fmt.Errorf("%w: %s has an empty localpart", ErrInvalidContent, alias)
case serverName == "":
return fmt.Errorf("%w: %s has an empty server name", ErrInvalidContent, alias)
}
// A control character in an alias would be invisible in every client
// that shows it, which is exactly what makes it worth refusing.
if strings.ContainsFunc(alias, func(c rune) bool { return c < 0x20 || c == 0x7f }) {
return fmt.Errorf("%w: %s contains a control character", ErrInvalidContent, alias)
}
return nil
}
// isLocalAlias reports whether an alias belongs to this server.
func (r *API) isLocalAlias(alias string) bool {
if validateAliasGrammar(alias) != nil {
return false
}
_, serverName, _ := strings.Cut(alias[1:], ":")
return serverName == r.serverName
}
// CreateAlias points a local alias at a room.
//
// The caller has to be in the room. The spec leaves the permission to the
// server, and "a member of the room may give it a name" is the rule that
// matches what an alias is for while keeping a stranger from squatting
// names against rooms they cannot see.
func (r *API) CreateAlias(ctx context.Context, alias, roomID, userID string) error {
if err := r.validateLocalAlias(alias); err != nil {
return err
}
if err := id.ValidateRoomID(roomID); err != nil {
return fmt.Errorf("%w: %v", ErrInvalidContent, err)
}
if _, err := r.store.Room(ctx, roomID); err != nil {
return err
}
if err := r.requireJoined(ctx, roomID, userID); err != nil {
return err
}
return r.store.CreateAlias(ctx, storage.RoomAlias{
Alias: alias,
RoomID: roomID,
Creator: userID,
CreatedAtMS: r.nowMS(),
})
}
// DeleteAlias removes a local alias.
//
// Either the user who created it, or a user who could set the room's
// canonical alias, may delete it — the first because it is theirs, the
// second because the room's moderators have to be able to clean up after a
// member who has left.
func (r *API) DeleteAlias(ctx context.Context, alias, userID string, isAdmin bool) error {
if err := r.validateLocalAlias(alias); err != nil {
return err
}
stored, err := r.store.Alias(ctx, alias)
if err != nil {
return err
}
if !isAdmin && stored.Creator != userID {
canSet, err := r.CanSendStateEvent(ctx, stored.RoomID, userID, TypeCanonicalAlias)
if err != nil {
return err
}
if !canSet {
return fmt.Errorf("%w: %s may not delete the alias %s", ErrForbidden, userID, alias)
}
}
return r.store.DeleteAlias(ctx, alias)
}
// ResolvedAlias is what a directory lookup returns.
type ResolvedAlias struct {
RoomID string
// Servers are the servers known to be in the room, which a client
// passes back as ?server_name= when it joins. With federation off the
// only one is this server.
Servers []string
}
// ResolveAlias turns a room alias into a room ID.
//
// A remote alias has to be asked of the server that owns it, which needs
// federation; with it off the client is told that rather than being told
// the alias does not exist, because the two call for quite different
// reactions.
func (r *API) ResolveAlias(ctx context.Context, alias string) (ResolvedAlias, error) {
if err := validateAliasGrammar(alias); err != nil {
return ResolvedAlias{}, err
}
if !r.isLocalAlias(alias) {
if !r.federationEnabled() {
return ResolvedAlias{}, fmt.Errorf(
"%w: %s belongs to another server, and resolving a remote alias",
ErrFederationDisabled, alias)
}
return ResolvedAlias{}, fmt.Errorf(
"%w: resolving an alias of another server is not implemented yet", ErrFederationDisabled)
}
stored, err := r.store.Alias(ctx, alias)
if err != nil {
return ResolvedAlias{}, err
}
return ResolvedAlias{RoomID: stored.RoomID, Servers: []string{r.serverName}}, nil
}
// RoomAliases lists the local aliases of a room, for a user who may see it.
func (r *API) RoomAliases(ctx context.Context, roomID, userID string) ([]string, error) {
if _, err := r.requireReadable(ctx, roomID, userID); err != nil {
return nil, err
}
aliases, err := r.store.AliasesForRoom(ctx, roomID)
if err != nil {
return nil, err
}
if aliases == nil {
aliases = []string{}
}
return aliases, nil
}
// RoomVisibility reports whether a room is in this server's public
// directory.
func (r *API) RoomVisibility(ctx context.Context, roomID string) (string, error) {
room, err := r.store.Room(ctx, roomID)
if err != nil {
return "", err
}
if room.Published {
return VisibilityPublic, nil
}
return VisibilityPrivate, nil
}
// SetRoomVisibility publishes a room in this server's directory, or
// withdraws it.
//
// The permission is the one the spec hints at and Synapse settled on: a
// user who could set the room's canonical alias, or a server admin. An
// unpublished room that nobody can find is recoverable; a room published by
// a passer-by is not.
func (r *API) SetRoomVisibility(ctx context.Context, roomID, userID, visibility string, isAdmin bool) error {
switch visibility {
case VisibilityPublic, VisibilityPrivate:
default:
return fmt.Errorf("%w: visibility must be %q or %q", ErrInvalidContent,
VisibilityPublic, VisibilityPrivate)
}
if _, err := r.store.Room(ctx, roomID); err != nil {
return err
}
if !isAdmin {
canSet, err := r.CanSendStateEvent(ctx, roomID, userID, TypeCanonicalAlias)
if err != nil {
return err
}
if !canSet {
return fmt.Errorf("%w: %s may not change whether %s is published",
ErrForbidden, userID, roomID)
}
}
return r.store.SetPublished(ctx, roomID, visibility == VisibilityPublic)
}
// PublicRoomsRequest pages and filters the public room directory.
type PublicRoomsRequest struct {
// Limit is how many rooms to return; 0 lets the store decide.
Limit int
// Since is the pagination token from a previous response.
Since string
// Search is the generic search term from the filter.
Search string
// Server is the ?server= parameter: another server's directory, which
// needs federation.
Server string
}
// PublicRoom is one entry in the public room directory.
type PublicRoom struct {
RoomID string `json:"room_id"`
Name string `json:"name,omitempty"`
Topic string `json:"topic,omitempty"`
CanonicalAlias string `json:"canonical_alias,omitempty"`
AvatarURL string `json:"avatar_url,omitempty"`
NumJoinedMembers int `json:"num_joined_members"`
WorldReadable bool `json:"world_readable"`
GuestCanJoin bool `json:"guest_can_join"`
JoinRule string `json:"join_rule,omitempty"`
RoomType string `json:"room_type,omitempty"`
Aliases []string `json:"aliases,omitempty"`
}
// PublicRoomsResponse is the directory page.
type PublicRoomsResponse struct {
Chunk []PublicRoom `json:"chunk"`
// NextBatch and PrevBatch are the tokens for the pages either side,
// and are absent at the ends.
NextBatch string `json:"next_batch,omitempty"`
PrevBatch string `json:"prev_batch,omitempty"`
TotalRoomCountEstimate int `json:"total_room_count_estimate"`
}
// PublicRooms returns a page of this server's public room directory.
//
// The pagination token is the offset, written out as a decimal. That is
// enough for a directory ordered by member count and is honest about what
// it is: a token that encoded a cursor would imply a stability the ordering
// does not have, since a room gaining a member moves between pages whatever
// the token says.
func (r *API) PublicRooms(ctx context.Context, req PublicRoomsRequest) (PublicRoomsResponse, error) {
if req.Server != "" && req.Server != r.serverName {
if !r.federationEnabled() {
return PublicRoomsResponse{}, fmt.Errorf(
"%w: reading the room directory of %s", ErrFederationDisabled, req.Server)
}
return PublicRoomsResponse{}, fmt.Errorf(
"%w: reading another server's room directory is not implemented yet", ErrFederationDisabled)
}
offset, err := parseDirectoryToken(req.Since)
if err != nil {
return PublicRoomsResponse{}, err
}
summaries, total, err := r.store.PublishedRooms(ctx, storage.RoomFilter{
Search: req.Search,
Limit: req.Limit,
Offset: offset,
})
if err != nil {
return PublicRoomsResponse{}, err
}
resp := PublicRoomsResponse{
Chunk: make([]PublicRoom, 0, len(summaries)),
TotalRoomCountEstimate: total,
}
for _, summary := range summaries {
aliases, err := r.store.AliasesForRoom(ctx, summary.ID)
if err != nil {
return PublicRoomsResponse{}, err
}
resp.Chunk = append(resp.Chunk, publicRoomOf(summary, aliases))
}
if offset > 0 {
resp.PrevBatch = directoryToken(max(offset-len(summaries), 0))
}
if offset+len(summaries) < total {
resp.NextBatch = directoryToken(offset + len(summaries))
}
return resp, nil
}
// publicRoomOf projects a stored room onto a directory entry.
func publicRoomOf(summary storage.RoomSummary, aliases []string) PublicRoom {
return PublicRoom{
RoomID: summary.ID,
Name: summary.Name,
Topic: summary.Topic,
CanonicalAlias: summary.CanonicalAlias,
AvatarURL: summary.AvatarURL,
NumJoinedMembers: summary.JoinedMembers,
WorldReadable: summary.HistoryVisibility == HistoryVisibilityWorldReadable,
GuestCanJoin: summary.GuestAccess == GuestAccessCanJoin,
JoinRule: summary.JoinRule,
RoomType: summary.RoomType,
Aliases: aliases,
}
}
// containsString reports whether needle is in haystack.
func containsString(haystack []string, needle string) bool {
for _, s := range haystack {
if s == needle {
return true
}
}
return false
}
// membershipFilterValues are the memberships a client may filter a member
// list by.
var membershipFilterValues = []string{
event.MembershipJoin, event.MembershipLeave,
event.MembershipInvite, event.MembershipBan, event.MembershipKnock,
}
// ValidateMembershipFilter checks a ?membership= or ?not_membership= value.
func ValidateMembershipFilter(value string) error {
if value == "" || containsString(membershipFilterValues, value) {
return nil
}
return fmt.Errorf("%w: %q is not a membership", ErrInvalidContent, value)
}
// maxDirectoryOffset bounds how far into the directory a pagination token
// may point. The token comes back from a client, so it is input: without a
// bound, "since=99999999999999" is an invitation to make the database count
// past the end of a table.
const maxDirectoryOffset = 1 << 20
// directoryToken renders a directory offset as a pagination token.
func directoryToken(offset int) string {
return strconv.Itoa(offset)
}
// parseDirectoryToken reads a pagination token back.
func parseDirectoryToken(token string) (int, error) {
if token == "" {
return 0, nil
}
offset, err := strconv.Atoi(token)
if err != nil || offset < 0 || offset > maxDirectoryOffset {
return 0, fmt.Errorf("%w: %q is not a pagination token from this server", ErrInvalidContent, token)
}
return offset, nil
}