CI / Test (ubuntu-latest) (push) Canceled after 0s
CI / Test (windows-latest) (push) Canceled after 0s
CI / Storage tests on PostgreSQL (push) Canceled after 0s
CI / Complement (federation off) (push) Canceled after 0s
CI / golangci-lint (push) Canceled after 0s
CI / Smoke test the binary (push) Canceled after 0s
Implements PLAN.md Phase 4: the read model. /sync, /messages and /context, the filters that narrow them, and the streams a response carries that are not room events — typing, receipts, presence and to-device messages. With this a client can be used against Warp, which is milestone M1. The one architectural choice is that the syncapi has no copy of the rooms: it reads them through the roomserver. Dendrite gives its syncapi its own tables and feeds them from the output stream, which is right for a design where the two can be separate processes, and Dendrite's could be. Warp is one process by decision, and there the copy buys nothing and costs the hardest class of bug a homeserver has — a read model that disagrees with the room, where a client is shown a message that was rejected and the only way to find out is to compare two tables. So the roomserver grew a read model (stream.go, roomsync.go, visibility.go) rather than exporting its store: reading an event means parsing it under its room's version, and a second copy of the version registry, the parser and the client projection would be a second place for them to disagree. syncapi: stream tokens naming a position in each of five independent streams, so a client that has seen receipt 7 but only event 4 can say so in one opaque string. A token with fewer positions than this build writes is accepted and the rest read as zero, which is what lets a token stored before a stream existed go on working. The PDU position comes from MAX(stream_ordering) and not from the counter row the other four use: the counter is advanced inside the writing transaction, so a token taken from it would name a position whose event no reader can see yet, and the event would be skipped for good once that transaction committed. Long polling goes through a notifier that wakes by room and by user rather than globally — an event wakes the listeners of its room, a membership event also wakes the user it names, so an invite reaches a client that is not in the room yet. A wake-up is only ever a hint: the listener re-reads the streams and decides for itself what changed, which is what makes it safe for the notifier to hold no state about what each client has seen. The listener registers before the read, so an event landing in between leaves the channel signalled and the sync reads again rather than blocking on a change it just missed. EventPersisted must not block, because it is called with the room's write lock still held. "Something happened" is not "a token moved". A stream can move without this user being concerned by it, and returning on every such move would turn a long poll back into a busy loop. The same trap caught presence twice over: a client says it is still online by syncing, so ?set_presence= makes every sync a presence write, and a stream that moved each time would wake every peer, which would sync, which would move it again. SetPresence therefore reports whether anything a peer would notice actually changed, and a write that only refreshes the last-active timestamp leaves the stream alone. Timeline windows are named by their two ends and a direction, Low exclusive and High inclusive in both directions, rather than by "from" and "to" as the wire format spells them. Each of those would otherwise be the low bound in one direction and the high bound in the other, which is exactly the off-by-one every pagination bug is made of; the handlers translate once and nothing below them thinks about it again. A sync's timeline is read backwards and reported forwards, because a client wants the newest events of the window it missed — a forward read with a limit hands it the oldest and then calls the rest a gap. visibility: history visibility is now a span rather than a yes or no, which is what Phase 3 deferred here. A user who has left a room is served the room as it was when they left — their state reads, their members and their timeline — instead of being refused, and is bounded above at their own membership event so a kicked client cannot go on streaming. Their span is found from their own member events, so a user who joined, left and rejoined sees their latest span. ?at= on /members is honoured for the same reason. What is left is that the span is computed from the room's current history_visibility where the spec judges each event by the one in force when it was sent; that is a state read per event and belongs with open question 1. Typing is held in memory and nowhere else: notifications expire in seconds, are worthless across a restart, and arrive one per keystroke-burst per room, so persisting them would be the busiest table in the database holding the least valuable data in it. Receipts only ever advance, compared on the position of the event acknowledged rather than on arrival, because two of a user's clients read at different speeds and the slower one must not drag the marker backwards. To-device queues are per device and drained by the next sync rather than by the one that delivered them, so a client that crashes in between gets the batch again — the right way round, since a lost key share leaves a message permanently undecryptable and a duplicate is ignored. A wildcard addressee is expanded when sent, not stored, because "every device" means the ones that existed then. Presence is off by default, which answers PLAN.md open question 3. It is the noisiest thing in Matrix and the one genuinely fan-out notification here; a private homeserver gains little from it. With it off the endpoints refuse rather than disappearing, because a client that gets a 404 from /presence concludes the server is too old to have it and stops asking. storage: one migration per driver adding the receipt, to-device, presence and filter tables with a counter row each, and a stream position on the existing account data table rather than a parallel one — there is exactly one current value per (user, room, type), and a second table would be a second thing to keep in step. Account data is reported in an event list but is not an event, so it gets its own response type: a room event with an empty sender and no timestamp would make a client decide what that meant. Deliberately missing, each named in docs/sync.md: notification counts (they need push rules, Phase 8), device lists (the keyserver, Phase 7), anything remote (Phase 5), threads (Phase 10). device_lists is sent as two empty lists because a client reads a missing one as malformed; the notification counts are left out entirely, because a zero there is a claim and an absent field is not. Tested through HTTP rather than against the builder, because what is worth pinning down is the response a client sees — which section a room lands in, whether a token handed back can be handed in again, whether paging terminates and loses nothing. The storage tests run against both SQL drivers; the notifier has its own tests for the concurrent case. A live server was driven end to end, which is what caught the two bugs the unit tests had missed: a backwards /messages page must be in reverse chronological order, and `start` must name where the page began rather than position zero when ?from= was omitted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
235 lines
8.4 KiB
Go
235 lines
8.4 KiB
Go
package roomserver
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/dariuszjaniak/warp/server/internal/matrix/event"
|
|
"github.com/dariuszjaniak/warp/server/internal/matrix/roomversion"
|
|
)
|
|
|
|
// VisibleRange is the span of a room's event stream a user may read.
|
|
//
|
|
// It is a range rather than a yes or no because membership is not a yes or
|
|
// no either. A user who has left a room keeps what they saw while they were
|
|
// in it and sees nothing after their leave; a user who joined a room whose
|
|
// history visibility is `joined` sees nothing from before their join. Both
|
|
// are the same question — where does this user's window start and end — and
|
|
// answering it once per room is what lets a timeline read be a single
|
|
// bounded query rather than a filter applied to every event in it.
|
|
type VisibleRange struct {
|
|
// Allowed is false when the user may see nothing of the room at all.
|
|
Allowed bool
|
|
|
|
// From is the first position the user may see, exclusive. Zero means
|
|
// the start of the room.
|
|
From int64
|
|
|
|
// To is the last position the user may see, inclusive. Zero means the
|
|
// top of the stream, and goes on meaning that as the stream grows.
|
|
To int64
|
|
|
|
// Membership is the user's current membership, empty for a user who was
|
|
// never in the room.
|
|
Membership string
|
|
|
|
// HistoryVisibility is the room's current history visibility, which the
|
|
// bounds above were derived from.
|
|
HistoryVisibility string
|
|
}
|
|
|
|
// Contains reports whether a position is inside the range.
|
|
func (v VisibleRange) Contains(pos int64) bool {
|
|
switch {
|
|
case !v.Allowed:
|
|
return false
|
|
case pos <= v.From:
|
|
return false
|
|
case v.To != 0 && pos > v.To:
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
// Clamp narrows a caller's window to what the range allows, reporting
|
|
// whether anything is left of it.
|
|
//
|
|
// The bounds are exclusive at the bottom and inclusive at the top, the same
|
|
// as a storage.TimelineRequest, so the result can be handed straight to
|
|
// one.
|
|
func (v VisibleRange) Clamp(from, to int64) (int64, int64, bool) {
|
|
if !v.Allowed {
|
|
return 0, 0, false
|
|
}
|
|
from = max(from, v.From)
|
|
if v.To != 0 && (to == 0 || to > v.To) {
|
|
to = v.To
|
|
}
|
|
if to != 0 && from >= to {
|
|
return 0, 0, false
|
|
}
|
|
return from, to, true
|
|
}
|
|
|
|
// VisibleRange works out what a user may read of a room.
|
|
//
|
|
// The rules are the spec's history visibility:
|
|
//
|
|
// - world_readable: everything, to anybody, member or not.
|
|
// - shared: everything, to anybody who is or has been a member.
|
|
// - invited: from the user's invite onwards.
|
|
// - joined: from the user's join onwards.
|
|
//
|
|
// A user who has left or was banned is bounded at their own membership
|
|
// event in every case, which is what stops a kicked user's client from
|
|
// going on streaming the room. An invitee is told enough to decide — the
|
|
// stripped state that travels with the invite — and no timeline.
|
|
//
|
|
// The approximation here is the room's *current* history visibility. The
|
|
// spec judges each event by the visibility in force when it was sent, so a
|
|
// room that was once world_readable and is now `joined` hides history here
|
|
// that the spec would show, and the reverse shows history it would hide.
|
|
// Doing it exactly means resolving the history visibility at every event in
|
|
// the window — a state read per event — and belongs with the state storage
|
|
// work of PLAN.md open question 1. Until then this follows the setting the
|
|
// room's members last agreed on, which is the one they would expect to
|
|
// apply.
|
|
func (r *API) VisibleRange(ctx context.Context, roomID, userID string) (VisibleRange, error) {
|
|
room, rules, err := r.roomAndRules(ctx, roomID)
|
|
if err != nil {
|
|
return VisibleRange{}, err
|
|
}
|
|
summary, err := r.store.RoomSummary(ctx, room.ID)
|
|
if err != nil {
|
|
return VisibleRange{}, err
|
|
}
|
|
return r.visibleRange(ctx, roomID, rules, userID, summary.HistoryVisibility)
|
|
}
|
|
|
|
// visibleRange is VisibleRange with the room's history visibility already
|
|
// in hand, for the callers — a sync over many rooms — that have it.
|
|
func (r *API) visibleRange(ctx context.Context, roomID string, rules roomversion.Rules, userID, historyVisibility string) (VisibleRange, error) {
|
|
out := VisibleRange{HistoryVisibility: historyVisibility}
|
|
|
|
changes, err := r.membershipHistory(ctx, roomID, rules, userID)
|
|
if err != nil {
|
|
return VisibleRange{}, err
|
|
}
|
|
if len(changes) > 0 {
|
|
out.Membership = changes[len(changes)-1].membership
|
|
}
|
|
|
|
worldReadable := historyVisibility == HistoryVisibilityWorldReadable
|
|
switch out.Membership {
|
|
case event.MembershipJoin:
|
|
out.Allowed = true
|
|
case event.MembershipLeave, event.MembershipBan:
|
|
out.Allowed = true
|
|
// Bounded at their own membership event: what they saw stays
|
|
// theirs, what happened afterwards does not.
|
|
out.To = changes[len(changes)-1].position
|
|
default:
|
|
// Invited, knocking, or never a member. Only a world-readable room
|
|
// has anything to show them.
|
|
out.Allowed = worldReadable
|
|
}
|
|
|
|
// World-readable removes the floor — they could read the room as a
|
|
// stranger, so there is nothing to gain by hiding it from them as a
|
|
// member — but not the ceiling: a leaver's *membership* view still ends
|
|
// where they left, and the stranger's view is what /messages on a
|
|
// world-readable room gives them anyway.
|
|
if !worldReadable && out.Allowed {
|
|
switch historyVisibility {
|
|
case HistoryVisibilityInvited, HistoryVisibilityJoined:
|
|
out.From = spanStart(changes, historyVisibility)
|
|
}
|
|
}
|
|
return out, nil
|
|
}
|
|
|
|
// membershipChange is one of a user's membership events in a room.
|
|
type membershipChange struct {
|
|
membership string
|
|
position int64
|
|
}
|
|
|
|
// membershipHistory reads a user's membership events in a room, oldest
|
|
// first.
|
|
func (r *API) membershipHistory(ctx context.Context, roomID string, rules roomversion.Rules, userID string) ([]membershipChange, error) {
|
|
stored, err := r.store.UserMembershipEvents(ctx, roomID, userID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
out := make([]membershipChange, 0, len(stored))
|
|
for _, s := range stored {
|
|
e, err := parseEvent(s, rules)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
membership, err := e.Membership()
|
|
if err != nil {
|
|
// A member event with no membership could not have been
|
|
// accepted into the room, so this is a corrupted row rather
|
|
// than something a client sent. Skipping it would widen the
|
|
// window silently.
|
|
return nil, fmt.Errorf("member event %s of %s has no membership: %w", s.EventID, roomID, err)
|
|
}
|
|
out = append(out, membershipChange{membership: membership, position: s.StreamOrdering})
|
|
}
|
|
return out, nil
|
|
}
|
|
|
|
// spanStart is the floor of the user's current membership span, exclusive.
|
|
//
|
|
// For `joined` visibility that is the join that began the span they are in
|
|
// — or, for a user who has left, the one that began the span they left
|
|
// from. For `invited` it is the invite that preceded that join, because an
|
|
// invitee is entitled to the room from the moment they were asked.
|
|
//
|
|
// A user who joined, left and rejoined therefore sees their latest span and
|
|
// not the earlier ones, which is what the spec's per-event rule works out
|
|
// to for everything after their last join.
|
|
func spanStart(changes []membershipChange, historyVisibility string) int64 {
|
|
// Walk back to the membership event that opened the current span.
|
|
start := len(changes) - 1
|
|
for start > 0 && changes[start].membership != event.MembershipJoin {
|
|
start--
|
|
}
|
|
for start > 0 && changes[start-1].membership == event.MembershipJoin {
|
|
// Consecutive joins are profile changes, not rejoins; the span
|
|
// began at the first of them.
|
|
start--
|
|
}
|
|
if historyVisibility == HistoryVisibilityInvited &&
|
|
start > 0 && changes[start-1].membership == event.MembershipInvite {
|
|
start--
|
|
}
|
|
// Exclusive, so one below the event itself: the membership event is the
|
|
// first thing the user sees, which is how a client renders "you joined".
|
|
return changes[start].position - 1
|
|
}
|
|
|
|
// requireReadable refuses a caller who may see nothing of a room, and
|
|
// returns the range for one who may.
|
|
func (r *API) requireReadable(ctx context.Context, roomID, userID string) (VisibleRange, error) {
|
|
visible, err := r.VisibleRange(ctx, roomID, userID)
|
|
if err != nil {
|
|
return VisibleRange{}, err
|
|
}
|
|
return visible, visible.refusal(roomID, userID)
|
|
}
|
|
|
|
// refusal turns a range that allows nothing into the error a client is
|
|
// given for it.
|
|
func (v VisibleRange) refusal(roomID, userID string) error {
|
|
if v.Allowed {
|
|
return nil
|
|
}
|
|
if v.Membership == event.MembershipInvite {
|
|
return fmt.Errorf("%w: %s has been invited to %s but has not joined it",
|
|
ErrForbidden, userID, roomID)
|
|
}
|
|
return fmt.Errorf("%w: %s is not in %s", ErrForbidden, userID, roomID)
|
|
}
|